Am 25.01.2018 um 00:19 schrieb Brian Paul:
> All but two cases of the switch did the same n += InstSize[n[0].opcode]
> instruction. Just move it after the switch.
>
> Add some sanity check assertions.
> ---
> src/mesa/main/dlist.c | 39 +++
> 1 file changed, 1
Am 25.01.2018 um 00:19 schrieb Brian Paul:
> The newest version of WSI Fusion makes several glDrawPixels calls
> per frame. By caching more than one image, we get better performance
> when panning/zomming the map.
zooming
> ---
> src/mesa/state_tracker/st_cb_drawpixels.c | 192
> +++
Reviewed-by: Roland Scheidegger
Am 25.01.2018 um 00:19 schrieb Brian Paul:
> To aid in debugging gallium surface format selection issues.
> ---
> src/mesa/state_tracker/st_format.c | 23 ++-
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/state_t
From: Roland Scheidegger
We are not allowed to modify the incoming coords values, or things may
crash (as we may be inside a llvm conditional and the values may be used
in another branch).
I recently broke this when fixing an issue with NaNs and seamless cube
map filtering, and it causes crashes
---
include/vulkan/vulkan.h| 54 ---
src/vulkan/registry/vk.xml | 91 +-
2 files changed, 130 insertions(+), 15 deletions(-)
diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h
index ec67abe..d3e2e24 100644
--- a/i
Jason Ekstrand writes:
> I'm a bit concerned about how complex things are getting. I've been
> looking at this for the past hour or so and I don't have anything yet.
> I'll keep thinking.
Hmm, ya the patch is a bit repetitive. Right now the loop iteration is
over tiled address bits is like:
v4
On Wednesday, January 24, 2018 4:33:56 PM PST Rafael Antognolli wrote:
> These packets were causing GPU hangs when the context was restored,
> possibly because they were pointing to BO's that were already
> unreferenced. So we tell the hardware to ignore such packets after the
> batch buffer ends,
On Wednesday, January 24, 2018 12:37:21 PM PST Jason Ekstrand wrote:
> The only purpose of this function is to disable aux on texture surfaces
> when the corresponding renderbuffer has aux disabled. However, the act
> of disabling aux on the renderbuffer will cause it to be resolved and
> intel_mi
On Wed, Jan 24, 2018 at 05:00:47PM -0800, Jason Ekstrand wrote:
> On Wed, Jan 24, 2018 at 4:39 PM, Nanley Chery wrote:
>
> > On Wed, Jan 24, 2018 at 04:15:33PM -0800, Jason Ekstrand wrote:
> > > On Wed, Jan 24, 2018 at 4:04 PM, Nanley Chery
> > wrote:
> > >
> > > > On Fri, Jan 19, 2018 at 03:47:
On Wed, Jan 24, 2018 at 4:33 PM, Rafael Antognolli <
rafael.antogno...@intel.com> wrote:
> Similar to the GL driver, ignore 3DSTATE_CONSTANT_* packets when doing a
> context restore.
>
> Signed-off-by: Rafael Antognolli
> Cc: Jason Ekstrand
> Cc: "18.0"
> ---
> src/intel/vulkan/anv_private.h
On Wed, Jan 24, 2018 at 4:39 PM, Nanley Chery wrote:
> On Wed, Jan 24, 2018 at 04:15:33PM -0800, Jason Ekstrand wrote:
> > On Wed, Jan 24, 2018 at 4:04 PM, Nanley Chery
> wrote:
> >
> > > On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote:
> > > > The current strategy we use for mana
On Mon, Jan 22, 2018 at 05:14:05PM -0800, Jason Ekstrand wrote:
> On Mon, Jan 22, 2018 at 2:24 AM, Pohjolainen, Topi <
> topi.pohjolai...@gmail.com> wrote:
>
> > On Fri, Jan 19, 2018 at 03:47:36PM -0800, Jason Ekstrand wrote:
> > > ---
> > > src/intel/vulkan/genX_cmd_buffer.c | 34 +++
I'm a bit concerned about how complex things are getting. I've been
looking at this for the past hour or so and I don't have anything yet.
I'll keep thinking.
On Tue, Jan 23, 2018 at 6:42 AM, Scott D Phillips <
scott.d.phill...@intel.com> wrote:
> TileY's low 6 address bits are: v1 v0 u3 u2 u1 u
On Fri, Jan 19, 2018 at 03:47:32PM -0800, Jason Ekstrand wrote:
> Now that this isn't a multi-case if and it's just the one case, it's a
> bit clearer if the condition is just part of the if instead of being
> pulled out into a boolean variable.
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 13
On Fri, Jan 19, 2018 at 03:47:35PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_image.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> ind
From: Dave Airlie
This uses a different shader than radeonsi, as we can't address non-256
aligned ssbos, which the radeonsi code does. This passes some extra
offsets into the shader.
It also contains a set of u64 instruction implementation that may
or may not be complete (at least the u64div is
This passes the arb_query_buffer-object-qbo test in piglit,
the coherent test is a bit less successful but some of that is
lacking support for indirect compute anyways.
I'm not going to enable GL4.5, as we haven't got CTS coverage
yet, but this is one of the last bits towards GL4.5 on cayman.
Dav
From: Dave Airlie
This just makes it a bit simpler for cayman vs eg
---
src/gallium/drivers/r600/r600_shader.c | 370 +++--
1 file changed, 116 insertions(+), 254 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_shader.c
b/src/gallium/drivers/r600/r600_shader
From: Dave Airlie
If the images/buffer bindings had a gap, this produced the wrong values,
this should fix that to generate the correct rat mask for mixes of
images/buffers/cbs.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/evergreen_compute.c | 2 +-
src/gallium/drivers/r600/evergr
From: Dave Airlie
---
docs/features.txt | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/features.txt b/docs/features.txt
index 4b2bf2c..2e110d9 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -188,12 +188,12 @@ GL 4.3, GLSL 4.30 -- all DONE: i965
On Wed, Jan 24, 2018 at 04:15:33PM -0800, Jason Ekstrand wrote:
> On Wed, Jan 24, 2018 at 4:04 PM, Nanley Chery wrote:
>
> > On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote:
> > > The current strategy we use for managing resolves has an issues where we
> > > track clear colors and
These packets were causing GPU hangs when the context was restored,
possibly because they were pointing to BO's that were already
unreferenced. So we tell the hardware to ignore such packets after the
batch buffer ends, since we know those BO's are not around anymore.
This change fixes GPU hangs o
The GPU hang caused by push constants is apparently fixed, so let's
enable them again.
Signed-off-by: Rafael Antognolli
Cc: "18.0"
---
src/intel/compiler/brw_fs.cpp | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index fa
Similar to the GL driver, ignore 3DSTATE_CONSTANT_* packets when doing a
context restore.
Signed-off-by: Rafael Antognolli
Cc: Jason Ekstrand
Cc: "18.0"
---
src/intel/vulkan/anv_private.h | 1 +
src/intel/vulkan/genX_cmd_buffer.c | 47 ++
2 files change
I've gone ahead and added my rb to the remaining meson patches, added the
relevant Fixes tags, and pushed them to master (except the one that I don't
think is necessary now).
Thanks for working on this.
Dylan
Quoting Greg V (2018-01-24 10:02:38)
> meson: updated with suggestions from review.
>
On Wed, Jan 24, 2018 at 4:04 PM, Nanley Chery wrote:
> On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote:
> > The current strategy we use for managing resolves has an issues where we
> > track clear colors and the need for resolves per-LOD but we still allow
> > resolves of only a su
https://bugs.freedesktop.org/show_bug.cgi?id=104777
Matteo Bruni changed:
What|Removed |Added
CC||jasua...@igalia.com,
|
On Fri, Jan 19, 2018 at 03:47:30PM -0800, Jason Ekstrand wrote:
> The current strategy we use for managing resolves has an issues where we
> track clear colors and the need for resolves per-LOD but we still allow
> resolves of only a subset of the slices in any given LOD and doing so
> sets the "ne
Cc: Chad Versace
---
src/intel/isl/isl.h | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index e3acb0e..cf53b5a 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel/isl/isl.h
@@ -1565,10 +1565,25 @@ isl_drm_modifi
This function is used to determine when we need to re-allocate a
miptree. Since we do nothing different in miptree allocation for
sRGB vs. linear, loosening this should be safe and may lead to less
copying and reallocating in some odd cases.
Reviewed-by: Kenneth Graunke
Reviewed-by: Chad Versace
The old code made a new miptree that referenced the same BO as the
renderbuffer and just trusted in the memory aliasing to work. There are
only two ways in which the new miptree is liable to differ from the one
in the renderbuffer and neither of them matter:
1) It may have a different target. T
This patch series provides fixes for the texture_from_pixmap path when
modifiers are used. All but the first and last patches are reviewed. I
haven't pushed to land anything yet because ee57b15ec764736e disabled CCS
for miptrees with sRGB formats and that caused TFP to always get a resolve
which
Reviewed-by: Kenneth Graunke
Reviewed-by: Chad Versace
Cc: "17.3"
---
src/mesa/drivers/dri/i965/intel_tex_image.c | 34 -
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c
b/src/mesa/drivers/dri/i965/intel_te
We're about to start letting the intel_obj->_Format be the "real"
texture format. For depth/stencil textures, this may be a combined
depth stencil format. For ETC2 on gen7 and earlier, this will be the
actual ETC2 format. This makes a bit more GL sense but means we have to
be careful in state up
The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT
which has tighter restrictions than just "it's shared". In particular,
it says that any rendering to the image while it is bound causes the
contents to become undefined.
The GLX_EXT_texture_from_pixmap extension provides us w
https://bugs.freedesktop.org/show_bug.cgi?id=104777
--- Comment #1 from Matteo Bruni ---
Looking for the testcase mentioned in the regression commit I stumbled upon bug
104668. It sounds like it's the same issue.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You ar
From: Dave Airlie
This seems to be broken, at least the cts tests fail.
This fixes:
dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_4
dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_8
2 samples seems to pass fine, amdvlk doesn't appear to enable T
---
src/mesa/vbo/vbo_noop.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/vbo/vbo_noop.h b/src/mesa/vbo/vbo_noop.h
index f61cd51..8aa17ce 100644
--- a/src/mesa/vbo/vbo_noop.h
+++ b/src/mesa/vbo/vbo_noop.h
@@ -23,8 +23,8 @@
* OTHER DEALINGS IN THE SOFTWARE.
The arrays specified by ctx->Array._DrawArrays are used for all
vertex drawing via vbo_context::draw_prims(). Different arrays are
used for immediate mode, vertex arrays, display lists, etc. Changing
from one to another requires updating derived/driver array state.
Before, we indirectly specifid
Instead of looping over 32 attributes, just scan the enabled attrib bits.
This involves manipulating the 'enabled' attributes variable depending
on whether we're using legacy GL or a vertex shader.
We can remove the varying_inputs variable since it's the same as
the new 'enabled' bitfield.
---
sr
Do more of the vertex array setup at display list compilation time
via the compile_vertex_list() function.
Then, at draw time, just do final vertex array setup dependent on
whether we're using fixed function or a vertex shader.
This can help apps which use a lot of short display list drawing.
---
These will be used in a later patch.
---
src/mesa/vbo/vbo_attrib.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/vbo/vbo_attrib.h b/src/mesa/vbo/vbo_attrib.h
index ba36ab7..fb178e1 100644
--- a/src/mesa/vbo/vbo_attrib.h
+++ b/src/mesa/vbo/vbo_attrib.h
@@ -32,6 +32,7
---
src/mesa/vbo/vbo_exec_array.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c
index b11da09..43362db 100644
--- a/src/mesa/vbo/vbo_exec_array.c
+++ b/src/mesa/vbo/vbo_exec_array.c
@@ -369,11 +369,11 @@ reca
Instead of NONE/ARB use FF/SHADER. Move the enum declaration to
vbo_private.h where it's used.
---
src/mesa/vbo/vbo_exec.h | 7 ---
src/mesa/vbo/vbo_exec_array.c | 6 +++---
src/mesa/vbo/vbo_exec_draw.c | 7 ---
src/mesa/vbo/vbo_private.h| 22 --
src/mesa
I think 'cl' used to mean client array.
---
src/mesa/vbo/vbo_context.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
index dbeb687..f516c67 100644
--- a/src/mesa/vbo/vbo_context.c
+++ b/s
To match the VERT_ATTRIB_COLOR_INDEX name.
Give a name to the previously anonymous enum of VBO_ATTRIB_x values.
Update the comment on the enum.
---
src/mesa/vbo/vbo_attrib.h | 21 +++--
src/mesa/vbo/vbo_attrib_tmp.h | 4 ++--
2 files changed, 13 insertions(+), 12 deletions(-)
---
src/mesa/vbo/vbo_exec.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h
index 5f28e70..dc18889 100644
--- a/src/mesa/vbo/vbo_exec.h
+++ b/src/mesa/vbo/vbo_exec.h
@@ -31,14 +31,15 @@ USE OR OTHER DEALINGS IN THE S
---
src/mesa/vbo/vbo_exec.h | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h
index f02f459..5f28e70 100644
--- a/src/mesa/vbo/vbo_exec.h
+++ b/src/mesa/vbo/vbo_exec.h
@@ -136,28 +136,31 @@ stru
All but two cases of the switch did the same n += InstSize[n[0].opcode]
instruction. Just move it after the switch.
Add some sanity check assertions.
---
src/mesa/main/dlist.c | 39 +++
1 file changed, 11 insertions(+), 28 deletions(-)
diff --git a/src/mesa/m
The newest version of WSI Fusion makes several glDrawPixels calls
per frame. By caching more than one image, we get better performance
when panning/zomming the map.
---
src/mesa/state_tracker/st_cb_drawpixels.c | 192 +-
src/mesa/state_tracker/st_context.c | 4
To aid in debugging gallium surface format selection issues.
---
src/mesa/state_tracker/st_format.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/src/mesa/state_tracker/st_format.c
b/src/mesa/state_tracker/st_format.c
index 3f7e55e..cc72ba4 100644
--
Reviewed-by: Dylan Baker
Quoting Greg V (2018-01-24 10:02:42)
> get_pkgconfig_variable('cflags') always returns an empty list, it's a
> function for getting *custom* variables.
>
> Meson does not yet support asking for cflags, so explicitly invoke
> pkg-config for now.
> ---
> meson.build | 10
I think this patch is no longer necessary, since libglsl has idep_nir, which
includes a dependency on nir_opcodes_h. Although I did notice it still has
inc_nir, which it doesn't need...
Quoting Greg V (2018-01-24 10:02:41)
> ---
> src/compiler/glsl/meson.build | 2 +-
> 1 file changed, 1 insertio
Reviewed-by: Dylan Baker
Quoting Greg V (2018-01-24 10:02:39)
> Reviewed-by: Emil Velikov
> ---
> src/gallium/drivers/radeonsi/meson.build | 2 +-
> src/mesa/meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi
https://bugs.freedesktop.org/show_bug.cgi?id=103543
--- Comment #9 from Dylan Baker ---
Can you try building with git tip again? A patch just landed that fixes the way
the meson build calculates the LLVM version string for the pre-processor. I'm
not sure if that will fix it, but it's worth trying
On Wed, Jan 24, 2018 at 02:32:02PM -0800, Jason Ekstrand wrote:
> On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote:
>
> > On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote:
> > > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand
> > > wrote:
> > >
> > > > On Mon, Jan 22, 2018 at 11
https://bugs.freedesktop.org/show_bug.cgi?id=104777
Bug ID: 104777
Summary: Attaching multiple shader objects for the same stage
to a GLSL program triggers a linker error
Product: Mesa
Version: git
Hardware: All
On Wed, Jan 24, 2018 at 1:59 PM, Nanley Chery wrote:
> On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote:
> > On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand
> > wrote:
> >
> > > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery
> > > wrote:
> > >
> > >> On Fri, Jan 19, 2018 at 03:47:
ping
Quoting Dylan Baker (2018-01-12 11:57:34)
> Here's a few things I've caught as I've started trying to add the meson
> build to our CI system.
>
> Dylan Baker (2):
> meson: set proper pkg-config version for libdrm_freedreno
> meson: set the minimum version correctly
>
> freedreno/meson.
This attribute is similar to the definition of restrict in
C99 and it might help LLVM.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 66203fa4ba..f9ce4f
UBOs are constants buffers.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 1a52367602..07089349e2 100644
--- a/src/amd/common/ac_
For descriptors.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 07089349e2..3d64dcf26d 100644
--- a/src/amd/common/ac_nir_to_llvm
Greg V writes:
> The error was: no matching constructor for initialization of
> 'std::vector'
> ---
> src/gallium/state_trackers/clover/llvm/metadata.hpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/llvm/metadata.hpp
> b/src/gallium
Push constants are constant buffers.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index f9ce4feb61..1a52367602 100644
--- a/src/amd/co
Someone else merged a similar patch to the first one already, but I've pushed
this patch to master.
Thanks!
Quoting Marc Dietrich (2018-01-24 13:03:51)
> LLVM patch level is not included in HAVE_LLVM.
>
> Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware")
> Cc: Dylan B
On Mon, Jan 22, 2018 at 06:39:52PM -0800, Jason Ekstrand wrote:
> On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand
> wrote:
>
> > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery
> > wrote:
> >
> >> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote:
> >> > This moves it to being based
Quoting Marc Dietrich (2018-01-24 13:02:42)
> Hi,
>
> Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom:
> > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote:
> > > Second hunk of fixes found by manual comparison with autotools generated
> > > compiler flags.
> > >
> >
The correct define is USE_SSE4.1 as in autotools.
Fixes: 84486f64626a ("meson: Enable SSE4.1 optimizations")
Cc: Dylan Baker
Reviewed-by: Eric Engestrom
Signed-off-by: Marc Dietrich
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
in
Quoting Jon Turney (2018-01-24 12:26:47)
> On 24/01/2018 19:35, Dylan Baker wrote:
> > v2: - Also fix drirc install path
> >
> > Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")
> > Reported-by: Marc Dietrich
> > Signed-off-by: Dylan Baker
> > Reviewed-by: Eric Engestrom (v1)
Hi,
Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom:
> On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote:
> > Second hunk of fixes found by manual comparison with autotools generated
> > compiler flags.
> >
> > Signed-off-by: Marc Dietrich
> > ---
> >
> > - Why do
LLVM patch level is not included in HAVE_LLVM.
Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware")
Cc: Dylan Baker
Reviewed-by: Eric Engestrom
Signed-off-by: Marc Dietrich
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build
Modify DumpToFile to only dump the function, not the entire module.
Reduces file sizes and speeds up the dumping.
---
src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.
LLVM 3.9 was not taken into account in initial check-in.
Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.")
cc: mesa-sta...@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104749
Acked-by: Emil Velikov
---
src/gallium/drivers/swr/rasterizer/jitter/Ji
Instead of keeping an array of booleans, we now hang onto an array of
isl_aux_usage enums. This means that the thing we are passing from
brw_draw.c to surface state setup is the thing that surface state setup
actually needs instead of an input to compute what it needs.
Cc: mesa-sta...@lists.freed
Previously, we were handling self-dependencies by marking the render
buffer and then passing disable_aux=true to prepare_texture so that it
would do a resolve. This works but ends us up doing to much resolving
in some cases. Specifically, if we're doing something such as mipmap
generation, this w
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104411
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104383
Fixes: ea0d2e98ecb369ab84e78c84709c0930ea8c293a
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Topi Pohjolainen
Reviewed-by: Kenneth Graunke
---
src/mesa/drivers/dri/i9
The only purpose of this function is to disable aux on texture surfaces
when the corresponding renderbuffer has aux disabled. However, the act
of disabling aux on the renderbuffer will cause it to be resolved and
intel_miptree_texture_aux_usage will already check the resolved status
of a texture a
Both callers of intel_miptree_prepare/finish_render have to call
intel_miptree_render_aux_usage anyway for other reasons. They may as
well pass the result in instead of us calling it again.
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Iago Toral Quiroga
Reviewed-by: Kenneth Graunke
---
s
This is a v2 of the series I sent out last night. The primary change in
this series is the addition of patches 3 and 6. Ken was rightly concerned
about the affect that 4 would have on compute. However, it turns out that
the function in question was just pointless and can just be removed. The
fi
Only one of the callers of intel_miptree_render_aux_usage actually took
brw->draw_aux_buffer_disabled into account. This was causing us to
ignore draw_aux_buffer_disabled for the intel_miptree_prepare_render.
This isn't a problem because the draw_aux_buffer_disabled entry was set
during texture pr
On Wed, Jan 24, 2018 at 6:15 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Jan 19, 2018 at 03:47:31PM -0800, Jason Ekstrand wrote:
> > This pass performs an "ambiguate" operation on a CCS-compressed surface
> > by manually writing zeros into the CCS. On gen8+, ISL gives us
On 24/01/2018 19:35, Dylan Baker wrote:
v2: - Also fix drirc install path
Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
Reviewed-by: Eric Engestrom (v1)
---
src/util/meson.build | 9 ++---
1 file changed, 6 inse
CC:
Signed-of-by: Chuck Atkins
---
configure.ac | 12
1 file changed, 12 insertions(+)
diff --git a/configure.ac b/configure.ac
index 7c1fbe0ed1..e1be7b78e4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2780,6 +2780,18 @@ if test "x$enable_llvm" = xyes; then
fi
On Wed, Jan 24, 2018 at 4:04 AM, Tomasz Figa wrote:
> Hi Robert,
>
> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss
> wrote:
>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm,
>> since at least 4 implementations exist, and share a lot of contents.
>> The idea is to keep the com
v2: - Also fix drirc install path
Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
Reviewed-by: Eric Engestrom (v1)
---
src/util/meson.build | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/
Before we were adding -DHAVE_SSE41 which isn't what the code is
looking for, so some uses of the sse4.1 code were always being
skipped.
v2: Don't add any compile check for the quite old -msse4.1 option (Dylan)
Fixes: 84486f6462 ("meson: Enable SSE4.1 optimizations")
Reviewed-by: Dylan Baker
---
On Wednesday, January 24, 2018 8:38:43 AM PST Juan A. Suarez Romero wrote:
> This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5.
> ---
> src/mesa/main/fbobject.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index d23916d1ad
On Wed, Jan 24, 2018 at 11:13 AM, Kenneth Graunke
wrote:
> On Wednesday, January 24, 2018 2:03:41 AM PST Jason Ekstrand wrote:
> > Instead of keeping an array of booleans, we now hang onto an array of
> > isl_aux_usage enums. This means that the thing we are passing from
> > brw_draw.c to surfac
Quoting Scott D Phillips (2018-01-24 11:13:14)
> Dylan Baker writes:
>
> > Matt and I talked about whether we needed the compile check, he didn't
> > think we
> > did because we required a GCC that has msse4.1 support, but the HAVE vs USE
> > is
> > a real bug (someone else noticed that too).
>
On Wednesday, January 24, 2018 2:03:38 AM PST Jason Ekstrand wrote:
> Yeah, right...
>
> However, this little series does fix at least three of them and probably a
> lot more. The thing which we recently discovered is that you really need
> to flush the render cache between switching aux_usage on
Dylan Baker writes:
> Matt and I talked about whether we needed the compile check, he didn't think
> we
> did because we required a GCC that has msse4.1 support, but the HAVE vs USE is
> a real bug (someone else noticed that too).
>
> CC'ing Matt in case I'm miss-remembering something.
Ah right
On Wednesday, January 24, 2018 2:03:41 AM PST Jason Ekstrand wrote:
> Instead of keeping an array of booleans, we now hang onto an array of
> isl_aux_usage enums. This means that the thing we are passing from
> brw_draw.c to surface state setup is the thing that surface state setup
> actually need
Quoting Emil Velikov (2018-01-24 11:00:04)
> On 24 January 2018 at 18:19, Dylan Baker wrote:
> > Quoting Emil Velikov (2018-01-24 03:53:35)
> >> On 24 January 2018 at 10:39, Marc Dietrich wrote:
> >> > Hi Dylan,
> >> >
> >> > Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker:
> >> >>
On 24 January 2018 at 18:19, Dylan Baker wrote:
> Quoting Emil Velikov (2018-01-24 03:53:35)
>> On 24 January 2018 at 10:39, Marc Dietrich wrote:
>> > Hi Dylan,
>> >
>> > Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker:
>> >> Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulka
Matt and I talked about whether we needed the compile check, he didn't think we
did because we required a GCC that has msse4.1 support, but the HAVE vs USE is
a real bug (someone else noticed that too).
CC'ing Matt in case I'm miss-remembering something.
Quoting Scott D Phillips (2018-01-24 10:28
Quoting Jon Turney (2018-01-24 10:29:03)
> On 24/01/2018 18:19, Dylan Baker wrote:
> > Quoting Emil Velikov (2018-01-24 03:53:35)
> >> On 24 January 2018 at 10:39, Marc Dietrich wrote:
> >>> Hi Dylan,
> >>>
> >>> Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker:
> Fixes: d199225
On 24.01.2018 18:02, Juan A. Suarez Romero wrote:
On Mon, 2018-01-22 at 08:41 +0200, Tapani Pälli wrote:
On 01/19/2018 12:44 PM, Juan A. Suarez Romero wrote:
Anyone could take a look at this patch?
Can you pinpoint where the mentioned tests are located, which suite?
Yes. It's in the Ope
On Jan 24, 2018, at 11:43 AM, Emil Velikov
mailto:emil.l.veli...@gmail.com>> wrote:
On 24 January 2018 at 15:30, George Kyriazis
mailto:george.kyria...@intel.com>> wrote:
LLVM 3.9 was not taken into in initial check-in.
Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.")
cc: me
On 24/01/2018 18:19, Dylan Baker wrote:
Quoting Emil Velikov (2018-01-24 03:53:35)
On 24 January 2018 at 10:39, Marc Dietrich wrote:
Hi Dylan,
Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker:
Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")
Reported-by: Marc
Before we were adding -DHAVE_SSE41 which isn't what the code is
looking for, so some uses of the sse4.1 code were always being
skipped.
Fixes: 84486f6462 ("meson: Enable SSE4.1 optimizations")
---
meson.build | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git
1 - 100 of 201 matches
Mail list logo
