2017-08-11 20:06 GMT+02:00 Mauro Rossi :
> 2017-08-11 17:25 GMT+02:00 Rob Herring :
>> On Fri, Aug 11, 2017 at 10:10 AM, Mauro Rossi wrote:
>>> 2017-08-11 16:23 GMT+02:00 Rob Herring :
On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote:
> Current generation rules rely on LOCAL_PATH varia
This series resolves
https://bugs.freedesktop.org/show_bug.cgi?id=101985, currently blocking
17.2 release.
Tested-by: Mark Janes
Samuel Iglesias Gonsálvez writes:
> v2:
> - Use nibctrl and the number of written/read owords to detect
> each case of a 1-OWord Block Read/Write (Curro)
>
> Signed-
On Fri, Aug 11, 2017 at 10:40 PM, Emil Velikov wrote:
> Hi Nicolai,
>
> It seems that the first two patches [1] in this series landed with the
> stable tag.
> While this patch alongside the remaining three [2] did not.
>
> Do we want the latter in stable as well or shall we leave them out?
We can
Hi Nicolai,
It seems that the first two patches [1] in this series landed with the
stable tag.
While this patch alongside the remaining three [2] did not.
Do we want the latter in stable as well or shall we leave them out?
Thanks
Emil
[1]
873789002f5 radeonsi/gfx9: fix vertex idx in ES with mul
On 1 August 2017 at 08:35, Timothy Arceri wrote:
> When generation the storage offset for struct members we need
> to skip opaque types as they no longer have backing storage.
>
> Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless
> opaque types")
> Bugzilla: https://bugs.
On Fri, Aug 11, 2017 at 6:00 PM, Nicolai Hähnle wrote:
> On 10.08.2017 21:57, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeon/r600_pipe_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/radeon/r600_pipe_c
On Fri, Aug 11, 2017 at 3:09 AM, Timothy Arceri wrote:
> On 11/08/17 05:57, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeon/r600_pipe_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/radeon/r600_pipe_com
On Fri, Aug 11, 2017 at 6:35 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes the SteamVR menus, which were broken by this feature.
That's impossible. RADEON_SURF_SHAREABLE is already checked by
ac_surface.c. This patch is a no-op change.
Marek
>
> Signed-off-by: Dave Airlie
> ---
>
On 11 August 2017 at 13:54, Christian König wrote:
> Am 11.08.2017 um 14:32 schrieb Emil Velikov:
>>
>> Hi Gurkirpal,
>>
>> Thanks for working on this. I believe Christian has some good points.
>> There's only one small question + suggestion from me.
>>
>> On 11 August 2017 at 05:31, Gurkirpal Sin
On Wed, Aug 9, 2017 at 10:34 PM, Rob Herring wrote:
> On Wed, Aug 9, 2017 at 3:19 PM, Marek Olšák wrote:
>> You already know I can't accept the amdgpu part.
>
> You don't agree with my explanation in the other patch?
OK. This patch is:
Reviewed-by: Marek Olšák
Marek
__
Reviewed-by: Marek Olšák
Marek
On Wed, Aug 9, 2017 at 3:47 PM, Samuel Pitoiset
wrote:
> Only resident bindless descriptors are currently updated and
> re-uploaded, this makes sure that the non-resident ones are
> also updated.
>
> Signed-off-by: Samuel Pitoiset
> Cc: "17.2"
> ---
> src/galli
Eric Anholt writes:
> Tapani Pälli writes:
>
>> On 06/22/2017 02:08 AM, Eric Anholt wrote:
>>> Tapani Pälli writes:
>>>
On 06/14/2017 01:12 AM, Eric Anholt wrote:
> Tapani Pälli writes:
>
>> On 06/12/2017 09:52 AM, Tapani Pälli wrote:
>>>
>>> On 05/18/2017 09:39 PM, E
Jason Ekstrand writes:
> oof... Have you run this through Jenkins? It should be ok, but
> it will be a functional change. It's a good change, but it is a
> change.
I ran the patch through jenkins, where the only problem it
reported was a gpu hang on skl gt2 in:
ES2-CTS.functional.state_query
On Fri, Aug 11, 2017 at 10:55 AM, Samuel Pitoiset
wrote:
> Will be used for allocating bindless descriptor slots for
> RadeonSI.
>
> v2 - change the interface (remove lock/unlock)
>- make a non-inline implementation
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/auxiliary/Makefile.so
On Thursday, August 10, 2017 11:50:30 PM PDT Tapani Pälli wrote:
> I do wonder what the target machine is (I haven't seen one that would
> not have ARCH_X86_HAVE_SSE4_1 true, both 32bit and 64bit) but falling
> back to memcpy makes perfect sense without USE_SSE4_1;
>
> Reviewed-by: Tapani Pälli
On Fri, Aug 11, 2017 at 6:53 PM, Marek Olšák wrote:
> On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset
> wrote:
>> Using VRAM address as bindless handles is not a good idea because
>> we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize
>> because it has no information about the pointe
On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset
wrote:
> Using VRAM address as bindless handles is not a good idea because
> we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize
> because it has no information about the pointer.
>
> Instead, use slots indexes like the existing descript
Patches 1 & 2:
Reviewed-by: Nicolai Hähnle
On 10.08.2017 21:57, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/gallium/
On 10.08.2017 22:33, Marek Olšák wrote:
From: Marek Olšák
This fixes corrupted shadows in Unigine Valley.
The corruption disappeared when I stopped setting IMG_DATA_FORMAT_24_8
for depth.
Cc: 17.2
Reviewed-by: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +
On Fri, Aug 11, 2017 at 10:10 AM, Mauro Rossi wrote:
> 2017-08-11 16:23 GMT+02:00 Rob Herring :
>> On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote:
>>> Current generation rules rely on LOCAL_PATH variable,
>>> which may be undefined when dependencies are expanded;
>>> move to using MESA_TOP va
Reviewed-by: Marek Olšák
Marek
On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset
wrote:
> To share common code between rw buffers and bindless descriptors.
>
> v3: - rename to si_emit_global_shader_pointers()
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/drivers/radeonsi/si_descriptors
2017-08-11 16:23 GMT+02:00 Rob Herring :
> On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote:
>> Current generation rules rely on LOCAL_PATH variable,
>> which may be undefined when dependencies are expanded;
>> move to using MESA_TOP variable to define sid_tables.py script path
>
> I count rough
On Thu, Aug 10, 2017 at 2:02 PM, wrote:
> From: Boyuan Zhang
>
> Signed-off-by: Boyuan Zhang
Acked-by: Alex Deucher
> ---
> tests/amdgpu/Makefile.am | 1 +
> tests/amdgpu/amdgpu_test.c | 6 +
> tests/amdgpu/amdgpu_test.h | 15 ++
> tests/amdgpu/frame.h | 2 +-
> tests
Add support for the exchange swap method. Since we're now forcing a fake front
buffer and we exchange the back and fake front on swaps, we don't need to add
much code.
Signed-off-by: Thomas Hellstrom
---
src/loader/loader_dri3_helper.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-
With GLX_SWAP_COPY_OML and GLX_SWAP_EXCHANGE_OML it may happen in situations
when glXSwapBuffers() is immediately followed by for example another
glXSwapBuffers() or glXCopyBuffers() or back buffer age querying, that we
haven't yet allocated and initialized a new back buffer because there was
no GL
EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() to indicate
that it wants to preserve back buffer contents across a buffer swap.
While the loader then turns off server-side page-flipping there's nothing to
guarantee that a new backbuffer isn't chosen when EGL starts to render a
Eliminate the back-to-fake-front copy by exchanging the previous back buffer
and the fake front buffer. This is a gain except when we need to preserve
the back buffer content but in that case we still typically gain by replacing
a server-side blit by a client side non-flushing blit.
Signed-off-by:
Support the GLX_SWAP_COPY_OML method. When this method is requested, we use
the same swapbuffer code path as EGL_BUFFER_PRESERVED.
Signed-off-by: Thomas Hellstrom
---
src/loader/loader_dri3_helper.c | 9 -
src/loader/loader_dri3_helper.h | 1 +
2 files changed, 9 insertions(+), 1 deletio
It's not used anywhere and now that we're about to exchange back- and
fake fronts it doesn't serve a purpose.
Signed-off-by: Thomas Hellstrom
---
src/loader/loader_dri3_helper.c | 2 --
src/loader/loader_dri3_helper.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/src/loader/loader_dri3_h
On Fri, Aug 11, 2017 at 9:02 AM, Mauro Rossi wrote:
> Current generation rules rely on LOCAL_PATH variable,
> which may be undefined when dependencies are expanded;
> move to using MESA_TOP variable to define sid_tables.py script path
I count roughly 67 occurrences of pointing to python scripts u
This gives the dri3 loader a chance to clean up the blit context cache.
Signed-off-by: Thomas Hellstrom
---
src/glx/dri3_glx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c
index dc94740..b79fec7 100644
--- a/src/glx/dri3_glx.c
+++ b/src/glx/dri3_glx
Implement back-to-fake-front flips,
Fix EGL_BUFFER_PRESERVED path.
Implement dri3 support for GLX_SWAP_EXCHANGE_OML and GLX_SWAP_COPY_OML.
The back-to-fake-front flips will save a full buffer copy in the case of a
fake front being enabled and GLX_SWAP_UNDEFINED_OML.
Support for EGL_BUFFER_PRESERV
The code was relying on us always having a current context for client local
image blit operations. Otherwise the blit would be skipped. However,
glxSwapBuffers, for example, doesn't require a current context and that was a
common problem in the dri1 era. It seems the problem has resurfaced with dri
This gives the dri3 loader a chance to clean up the blit context cache.
Signed-off-by: Thomas Hellstrom
---
src/egl/drivers/dri2/egl_dri2.c | 5 -
src/egl/drivers/dri2/egl_dri2.h | 2 ++
src/egl/drivers/dri2/platform_x11_dri3.c | 9 +
3 files changed, 15 insertions(
Current generation rules rely on LOCAL_PATH variable,
which may be undefined when dependencies are expanded;
move to using MESA_TOP variable to define sid_tables.py script path
Fixes the following building error:
external/mesa/src/gallium/drivers/radeonsi/si_debug.c:30:10: fatal error:
'sid_tabl
Am 11.08.2017 um 14:32 schrieb Emil Velikov:
Hi Gurkirpal,
Thanks for working on this. I believe Christian has some good points.
There's only one small question + suggestion from me.
On 11 August 2017 at 05:31, Gurkirpal Singh wrote:
+PKG_CHECK_MODULES([OMX_TIZONIA], [libtizonia >=
$LIB
On 11 August 2017 at 05:31, Gurkirpal Singh wrote:
> --- /dev/null
> +++ b/src/gallium/state_trackers/omx_tizonia/entrypoint.c
> @@ -0,0 +1,152 @@
> +/**
> + *
> + * Permission is hereby granted, free of charge, to any person
Hi Gurkirpal,
Thanks for working on this. I believe Christian has some good points.
There's only one small question + suggestion from me.
On 11 August 2017 at 05:31, Gurkirpal Singh wrote:
> +PKG_CHECK_MODULES([OMX_TIZONIA], [libtizonia >=
> $LIBOMXIL_TIZONIA_REQUIRED])
> +PKG_CHECK_MO
On 11 August 2017 at 12:31, Tapani Pälli wrote:
> On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote:
>>
>> On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke
>> wrote:
>>>
>>> This should hopefully fix build issues on 32-bit Android-x86.
>>>
>>> Cc: Mauro Rossi
>>> Cc: Tapani Pälli
>>> Bugzilla: ht
On 08/11/2017 02:23 PM, Grazvydas Ignotas wrote:
On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote:
This should hopefully fix build issues on 32-bit Android-x86.
Cc: Mauro Rossi
Cc: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050
---
src/mesa/drivers/dri/i
Oops, sorry about that!
Reviewed-by: Iago Toral Quiroga
On Thu, 2017-08-10 at 18:02 -0400, Matt Turner wrote:
> ---
> src/intel/compiler/brw_vec4_reg_allocate.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/compiler/brw_vec4_reg_allocate.cpp
> b/src/intel
Reviewed-by: Iago Toral Quiroga
On Thu, 2017-08-10 at 22:52 -0700, Kenneth Graunke wrote:
> Passing screen lets us get the kernel features, devinfo, and bufmgr,
> without needing container_of.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102062
> Cc: Mauro Rossi
> Cc: Tapani Pälli
On 08/11/2017 01:18 PM, Tapani Pälli wrote:
On 08/11/2017 01:02 PM, Timothy Arceri wrote:
On 11/08/17 17:45, Tapani Pälli wrote:
This makes development/changes to program resource code more safe.
Patch also makes helper functions static.
Signed-off-by: Tapani Pälli
---
src/mesa/main/s
On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote:
> This should hopefully fix build issues on 32-bit Android-x86.
>
> Cc: Mauro Rossi
> Cc: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050
> ---
> src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++
> 1 fil
https://bugs.freedesktop.org/show_bug.cgi?id=102148
Bug ID: 102148
Summary: Crash when running qopenglwidget example on mesa
llvmpipe win32
Product: Mesa
Version: git
Hardware: x86 (IA32)
OS: Windows (All)
https://bugs.freedesktop.org/show_bug.cgi?id=101851
--- Comment #5 from Mike Lothian ---
I'm seeing this with 17.2-rc2 even when passing -fuse-ld=bfd
libtool: link: ( cd ".libs" && rm -f "libEGL_common.la" && ln -s
"../libEGL_common.la" "libEGL_common.la" )
/bin/sh ../../libtool --tag=CC --mo
On 11 August 2017 at 06:52, Kenneth Graunke wrote:
> Passing screen lets us get the kernel features, devinfo, and bufmgr,
> without needing container_of.
>
Hmm it seems to be crashing since sample (aka brw) cannot be NULL.
Which seems to be the case here.
Reviewed-by: Emil Velikov
One could fix
On 08/11/2017 01:02 PM, Timothy Arceri wrote:
On 11/08/17 17:45, Tapani Pälli wrote:
This makes development/changes to program resource code more safe.
Patch also makes helper functions static.
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 3 ++-
1 file changed, 2 ins
On 31 July 2017 at 15:15, Daniel Stone wrote:
> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.
Anyone?
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-d
https://bugs.freedesktop.org/show_bug.cgi?id=101982
--- Comment #9 from Daniel Stone ---
(In reply to Link Mauve from comment #8)
> When not using the opengl-hq profile of mpv, I get a much better error, I’m
> still not sure why it doesn’t crash the compositor in this case, and it does
> in the o
On 11/08/17 17:45, Tapani Pälli wrote:
This makes development/changes to program resource code more safe.
Patch also makes helper functions static.
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/
Quoting Kenneth Graunke (2017-08-11 06:52:47)
> This should hopefully fix build issues on 32-bit Android-x86.
>
> Cc: Mauro Rossi
> Cc: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050
> ---
> src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++
> 1 file changed,
Hi,
On 11 August 2017 at 08:39, Philipp Zabel wrote:
> Nice, this makes sure that all planes up to the last modifier have fds
> present. And since all fds are guaranteed to be present, the modifier
> equality check in dri2_check_dma_buf_attribs also makes sure that there
> are no missing modifier
Will be used for allocating bindless descriptor slots for
RadeonSI.
v2 - change the interface (remove lock/unlock)
- make a non-inline implementation
Signed-off-by: Samuel Pitoiset
---
src/gallium/auxiliary/Makefile.sources | 2 +
src/gallium/auxiliary/util/u_idalloc.c | 94
Am 11.08.2017 um 06:31 schrieb Gurkirpal Singh:
Coexist with --enable-omx so they can be built independently
Detect tizonia package config file
Generate libomxtiz_mesa.so and install it to libtizcore.pc::pluginsdir
Only compile empty source (target.c) for now.
Really nice piece of work. Just a
This makes development/changes to program resource code more safe.
Patch also makes helper functions static.
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_
Signed-off-by: Tapani Pälli
---
src/compiler/glsl/linker.cpp | 32 ++--
src/mesa/main/mtypes.h | 1 +
2 files changed, 23 insertions(+), 10 deletions(-)
(Alternatively, we could make add_program_resource a template function
so we would not need to modify all th
On Wed, 2017-08-09 at 11:53 +0100, Daniel Stone wrote:
> When using dmabuf import, make sure that the modifier is actually
> allowed to add planes to the base format, as implied by the comment.
>
> Signed-off-by: Daniel Stone
---
> src/egl/drivers/dri2/egl_dri2.c | 38 +++
On 08/09/2017 06:41 PM, Nicolai Hähnle wrote:
On 08.08.2017 18:57, Samuel Pitoiset wrote:
Will be used for allocating bindless descriptor slots for
RadeonSI.
Signed-off-by: Samuel Pitoiset
---
src/gallium/auxiliary/Makefile.sources | 1 +
src/gallium/auxiliary/util/u_idalloc.h | 103
++
On 08/10/2017 11:17 PM, Marek Olšák wrote:
On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset
wrote:
A new pair of user SGPR is needed for loading the bindless
descriptors from shaders. Because the descriptors are global for
all stages, there is no need to add separate indices for GFX9.
v3: - f
LGTM, now existence of fd is checked foreach plane_n;
Reviewed-by: Tapani Pälli
On 08/09/2017 01:53 PM, Daniel Stone wrote:
When using dmabuf import, make sure that the modifier is actually
allowed to add planes to the base format, as implied by the comment.
Signed-off-by: Daniel Stone
---
61 matches
Mail list logo
