On Fri, Aug 11, 2017 at 6:53 PM, Marek Olšák <[email protected]> wrote: > On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset > <[email protected]> wrote: >> Using VRAM address as bindless handles is not a good idea because >> we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize >> because it has no information about the pointer. >> >> Instead, use slots indexes like the existing descriptors. Note >> that we use fixed 16-dword slots for both samplers and images. >> This doesn't really matter because no real apps use image handles. >> >> This improves performance with DOW3 by +7%. >> >> v3: - fix si_emit_global_shader_pointers() for merged GFX9 shaders >> - always re-upload the array of descriptors at creation time >> v2: - inline si_release_bindless_descriptors() > > I meant that you inline the function manually. Anyway:
I see patch 6 where the function is no longer a one-liner. There is no need to inline. > > Reviewed-by: Marek Olšák <[email protected]> > > Marek _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
