This patch results into an infinite, but interruptible, hang when trying to use
OpenCL. Not even the piglit quick_cl tests are working. It works fine after
revert.
System info:
Gentoo AMD64 Unstable
RX 470 8GB (Polaris 10)
LLVM, Clang, Mesa incl. dependencies on Git Master.
P.S.:
OpenCL on Ola
Fixes: fe56c745b8cb ("Convert sed(1) syntax to be compatible with FreeBSD and
OpenBSD")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100236
Suggested-by: Jan Beich
Suggested-by: Michel Dänzer
Signed-off-by: Vinson Lee
---
configure.ac | 16
1 file changed, 8 insertio
This little series adds 48-bit address support to the Vulkan driver. This
allows us to advertise heap sizes over 4 GiB on Broadwell hardware and above.
On my laptop with 8 GiB of RAM, we now report a heap size of 6 GiB.
This series has only been tested lightly because I didn't want to send it
to
This commit adds support for using the full 48-bit address space on
Broadwell and newer hardware. Thanks to certain limitations, not all
objects can be placed above the 32-bit boundary. In particular, general
and state base address need to live within 32 bits. (See also
Wa32bitGeneralStateOffset
Instead of just advertising the aperture size, we do something more
intelligent. On systems with a full 48-bit PPGTT, we can address 100%
of the available system RAM from the GPU. In order to keep clients from
burning 100% of your available RAM for graphics resources, we have a
nice little heuris
Pushed, Thanks!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=99789
Timothy Arceri changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hi gregory,
Am 2017-03-17 10:25, schrieb Gregory Hainaut:
diff --git a/src/mesa/main/marshal.c b/src/mesa/main/marshal.c
index f8cad30..43a70d4 100644
--- a/src/mesa/main/marshal.c
+++ b/src/mesa/main/marshal.c
@@ -214,6 +218,12 @@ track_vbo_binding(struct gl_context *ctx, GLenum
target, GLuint
https://bugs.freedesktop.org/show_bug.cgi?id=100266
Michel Dänzer changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=79858
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
I intend to need to get to the devinfo structure, and storing the screen
is an easy way to do that.
It seems to be the consensus that you cannot share an image between
multiple screens.
Scape-goat: Rob Clark
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
s
This doesn't really "do" anything because the default tiling for the
winsys buffer is X tiled. We do however want the X tiled modifier to
work correctly from the API perspective, which would imply that if you
set this modifier, and later do a get_modifier, you get back at least X
tiled.
v2: priori
At image creation create a path for dealing with the linear modifier.
This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR
was specified.
During development of this patch series, it was decided that a lack of
modifier was an insufficient way to express the required modifiers. A
This patch begins introducing how we'll actually handle the potentially
many modifiers coming in from the API, how we'll store them, and the
structure in the code to support it.
Prior to this patch, the Y-tiled modifier would be entirely ignored. It
shouldn't actually be used until this point beca
This was the third chunk of the Renderbuffer Decompression series (aka GBM
modifiers). Splitting this up to make merging easier. These patches are plumbing
through the existing modifiers (up to the new CCS ones).
After this series we should support Y-tiled modifiers properly, thus allowing
the mod
New to the patch series after reordering things for landing smaller
chunks.
This will essentially enable modifiers from clients that were just
enabled in previous patches. A client could use the modifiers by
setting all of them at create, but had no way to actually query them
after creating the su
Fix build with Python < 2.7.
File "src/compiler/nir/nir_builder_opcodes_h.py", line 46, in
from nir_opcodes import opcodes
File "src/compiler/nir/nir_opcodes.py", line 178, in
unop_convert("{}2{}{}".format(src_t[0], dst_t[0], bit_size),
ValueError: zero length field name in format
F
On Fri, Mar 17, 2017 at 09:13:39AM -0700, Matt Turner wrote:
> On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand wrote:
> > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote:
> >>
> >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand
> >> wrote:
> >> > Older versions of GCC don't like compound lit
On Fri, Mar 17, 2017 at 3:15 PM, Ville Syrjälä wrote:
> On Fri, Mar 17, 2017 at 09:13:39AM -0700, Matt Turner wrote:
> > On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand
> wrote:
> > > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner
> wrote:
> > >>
> > >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekst
On Fri, Mar 17, 2017 at 8:05 PM, Alan Swanson wrote:
> Since switching to LRU eviction the only user of these predicate
> functions now resolves directory entry stats itself so pass them
> directly saving calling fstat and strlen twice (and the
> expensive strlen is skipped entirely if access time
Fixes build without vulkan.h installed in system header locations:
CC vulkan/vulkan_libvulkan_intel_la-anv_gem.lo
In file included from vulkan/anv_private.h:66:0,
from vulkan/anv_gem.c:31:
/opt/xorg/include/vulkan/vulkan_intel.h:27:20: fatal error: vulkan.h:
No such file or
https://bugs.freedesktop.org/show_bug.cgi?id=100266
Bug ID: 100266
Summary: Glitches in blender
Product: Mesa
Version: 17.0
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
On Fri, Mar 17, 2017 at 5:15 AM, Dylan Baker wrote:
> Quoting Marek Olšák (2017-03-16 18:53:59)
>> On Fri, Mar 17, 2017 at 12:11 AM, Dylan Baker wrote:
>> > Quoting Marek Olšák (2017-03-16 15:36:26)
>> >> Is there a way not to use ninja with meson, because ninja redirects
>> >> all stderr output
https://bugs.freedesktop.org/show_bug.cgi?id=100259
--- Comment #6 from Christoph Haag ---
My workaround was to revert
https://cgit.freedesktop.org/mesa/mesa/commit/?id=191ff914a2c77d7d982048ef21422a209e1e7e06,
then make install works.
Subsequent builds of git master will then link correctly to
On Fri, Mar 17, 2017 at 11:07 AM, Emil Velikov
wrote:
> Hello list,
>
> The candidate for the Mesa 17.0.2 is now available. Currently we have:
> - 42 queued
> - 3 nominated (outstanding)
> - and 1 rejected patch(es)
>
>
> Current queue consists predominantly of ANV and RADV fixes. The i965,
>
On Fri, Mar 17, 2017 at 12:28 PM, Emil Velikov
wrote:
> On 17 March 2017 at 19:05, Jason Ekstrand wrote:
> > On Fri, Mar 17, 2017 at 10:10 AM, Emil Velikov >
> > wrote:
> >>
> >> On 17 March 2017 at 16:55, Emil Velikov
> wrote:
> >> > From: Emil Velikov
> >> >
> >> > The enum aub_state_struct
https://bugs.freedesktop.org/show_bug.cgi?id=100262
ch...@circlecvi.com changed:
What|Removed |Added
CC||ch...@circlecvi.com
--
You are re
https://bugs.freedesktop.org/show_bug.cgi?id=100262
Bug ID: 100262
Summary: libswrAVX2.so Causes hang with QOpenGLWidget
Product: Mesa
Version: 13.0
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Sev
On 17 March 2017 at 19:05, Jason Ekstrand wrote:
> On Fri, Mar 17, 2017 at 10:10 AM, Emil Velikov
> wrote:
>>
>> On 17 March 2017 at 16:55, Emil Velikov wrote:
>> > From: Emil Velikov
>> >
>> > The enum aub_state_struct_type type is a seeming left over from the
>> > i965 days. Since we don't us
On Fri, Mar 17, 2017 at 10:10 AM, Emil Velikov
wrote:
> On 17 March 2017 at 16:55, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > The enum aub_state_struct_type type is a seeming left over from the
> > i965 days. Since we don't use we can safely drop it.
> >
> > As a nice side-effect the on
I have a similar patch locally on my machine.
s/list/set in the very last comment in the patch and it is:
Reviewed-by: Thomas Helland
There are also similar situations in other areas where we can
do the same trick. Constant propagation I believe?
Afk, so can't check what other passes I looked at
https://bugs.freedesktop.org/show_bug.cgi?id=100257
--- Comment #3 from Eero Tamminen ---
Yeah, Windows driver is still stuck on GL 4.4 and product material is pretty
Windows centric.
(Windows driver supports some additional extensions that Mesa doesn't support
yet.)
--
You are receiving this
On Friday, March 17, 2017 6:19:26 AM PDT Emil Velikov wrote:
> Hi all
>
> A few weeks ago I've notice that the glsl tests have not been executed
> for 2+years and attempted to resolve that. Namely:
>
> - make distcheck - generates and executes 0 (yes zero) tests
> - out of tree make check is
From: Emil Velikov
Things should just work (tm) with the default options. Plus the one we
pass is already the default, so just drop it.
Signed-off-by: Emil Velikov
---
docs/releasing.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/releasing.html b/docs/releasing.h
Hello list,
The candidate for the Mesa 17.0.2 is now available. Currently we have:
- 42 queued
- 3 nominated (outstanding)
- and 1 rejected patch(es)
Current queue consists predominantly of ANV and RADV fixes. The i965, nouveau
(nvc0) and radeons has also seen some Improvements. To top it up
Since switching to LRU eviction the only user of these predicate
functions now resolves directory entry stats itself so pass them
directly saving calling fstat and strlen twice (and the
expensive strlen is skipped entirely if access time is newer).
v2: Update for empty cache dir detection changes
On Fri, 17 Mar 2017 13:11:31 +0100
Markus Wick wrote:
> Hi gregory,
>
> Am 2017-03-17 10:25, schrieb Gregory Hainaut:
> > diff --git a/src/mesa/main/marshal.c b/src/mesa/main/marshal.c
> > index f8cad30..43a70d4 100644
> > --- a/src/mesa/main/marshal.c
> > +++ b/src/mesa/main/marshal.c
> > @@ -2
Reviewed-by: Marek Olšák
Marek
On Fri, Mar 17, 2017 at 4:17 PM, Alex Deucher wrote:
> Cc: 17.0
> Signed-off-by: Alex Deucher
> ---
> include/pci_ids/radeonsi_pci_ids.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/pci_ids/radeonsi_pci_ids.h
> b/include/pci_ids/radeonsi_pc
Reviewed-by: Marek Olšák
Marek
On Fri, Mar 17, 2017 at 1:02 AM, Timothy Arceri wrote:
> Fixes a bunch of piglit crashes that hit an assert() when trying
> to delete the framebuffer. The assert() was triggered because
> WinSysDrawBuffer was set to NULL before glDeleteFramebuffers()
> was called.
https://bugs.freedesktop.org/show_bug.cgi?id=100259
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 17 March 2017 at 16:55, Emil Velikov wrote:
> From: Emil Velikov
>
> The enum aub_state_struct_type type is a seeming left over from the
> i965 days. Since we don't use we can safely drop it.
>
> As a nice side-effect the only libdrm_intel requirement in src/intel
> [outside of tools/aubinator
https://bugs.freedesktop.org/show_bug.cgi?id=100257
--- Comment #2 from Francis Herne ---
FWIW, if the Khronos list is up-to-date, the Windows driver really doesn't
support 4.5 yet.
https://www.khronos.org/conformance/adopters/conformant-products#opengl
--
You are receiving this mail because:
From: Emil Velikov
The enum aub_state_struct_type type is a seeming left over from the
i965 days. Since we don't use we can safely drop it.
As a nice side-effect the only libdrm_intel requirement in src/intel
[outside of tools/aubinator] - include intel_aub.h can now be removed.
And with next co
From: Emil Velikov
Only tools/aubinator requires it [for intel_aub.h].
Signed-off-by: Emil Velikov
---
src/intel/Makefile.am | 1 -
src/intel/Makefile.tools.am | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/Makefile.am b/src/intel/Makefile.am
index 63bfd45f
From: Emil Velikov
The only part which requires libdrm_intel tools/aubinator is not built
on Android.
Signed-off-by: Emil Velikov
---
src/intel/Android.blorp.mk| 2 --
src/intel/Android.compiler.mk | 3 ---
src/intel/Android.vulkan.mk | 13 ++---
3 files changed, 6 insertions(+
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:34, Jason Ekstrand wrote:
It all just works since it's just a hardware register so we might as
well turn it on.
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/
Looks good to me :
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:34, Jason Ekstrand wrote:
From: Ilia Mirkin
In the end, pipeline statistics queries look a lot like occlusion
queries only with between 1 and 11 begin/end pairs being generated
instead of just the one.
Reviewed-By: Lionel Land
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:34, Jason Ekstrand wrote:
In order to get accurate statistics, we need to disable statistics for
blits, clears, and the surface state memcpy at the top of each secondary
command buffer. There are two possible approaches to this:
1) Disable befor
https://bugs.freedesktop.org/show_bug.cgi?id=100257
Jason Ekstrand changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=100259
--- Comment #4 from bellamort...@gmail.com ---
Came here to file the exact same bug.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
me
On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand wrote:
> On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote:
>>
>> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand
>> wrote:
>> > Older versions of GCC don't like compound literals in static const
>> > variable declarations because they don't think
https://bugs.freedesktop.org/show_bug.cgi?id=100259
LoneVVolf changed:
What|Removed |Added
Version|unspecified |git
--
You are receiving this mail because
https://bugs.freedesktop.org/show_bug.cgi?id=100259
--- Comment #3 from LoneVVolf ---
libtool: install: (cd
/home/panoramix/Documents/WIP/pkgbuilds/lib32-mesa-git/src/mesa/src/egl;
/bin/sh
"/home/panoramix/Documents/WIP/pkgbuilds/lib32-mesa-git/src/mesa/libtool"
--silent --tag CC --mode=relink g
https://bugs.freedesktop.org/show_bug.cgi?id=100259
--- Comment #2 from LoneVVolf ---
Created attachment 130292
--> https://bugs.freedesktop.org/attachment.cgi?id=130292&action=edit
make install phase
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Con
https://bugs.freedesktop.org/show_bug.cgi?id=100259
--- Comment #1 from LoneVVolf ---
Created attachment 130291
--> https://bugs.freedesktop.org/attachment.cgi?id=130291&action=edit
log of build() phase
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the as
On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand
wrote:
> On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote:
>
>> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand
>> wrote:
>> > Older versions of GCC don't like compound literals in static const
>> > variable declarations because they don't think
Reviewed-by: Jason Ekstrand
On Fri, Mar 17, 2017 at 9:03 AM, Robert Bragg wrote:
> I've just pushed an old patch (was already reviewed, but I never followed
> up on
> it) that added a timebase_scale to gen_device_info so we can use that
> instead
> here instead.
>
> --- >8 ---
>
> Now that ther
On Fri, Mar 17, 2017 at 9:04 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Nah ignore me, we don't have any bit field for that in vulkan.h...
> Might be nice to rename me like CLIP though ;)
>
You want 3DSTATE_STREAMOUT statistics renamed? I ca do that easily enough
as a follow
https://bugs.freedesktop.org/show_bug.cgi?id=100259
Bug ID: 100259
Summary: [EGL] [GBM] lib32 undefined reference to
`gbm_bo_create_with_modifiers'
Product: Mesa
Version: unspecified
Hardware: x86-64 (AMD64)
On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote:
> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand
> wrote:
> > Older versions of GCC don't like compound literals in static const
> > variable declarations because they don't think it's an actual constant
> > value.
>
> Probably because the typ
Nah ignore me, we don't have any bit field for that in vulkan.h...
Might be nice to rename me like CLIP though ;)
On 17/03/17 16:03, Lionel Landwerlin wrote:
Do we want to enable statistics on 3DSTATE_STREAMOUT as well?
On 16/03/17 21:34, Jason Ekstrand wrote:
---
src/intel/vulkan/genX_pipel
I've just pushed an old patch (was already reviewed, but I never followed up on
it) that added a timebase_scale to gen_device_info so we can use that instead
here instead.
--- >8 ---
Now that there's a timebase_scale in gen_device_info which is
effectively the 'period' this switches anv_GetPhysic
Do we want to enable statistics on 3DSTATE_STREAMOUT as well?
On 16/03/17 21:34, Jason Ekstrand wrote:
---
src/intel/vulkan/genX_pipeline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index a6ec3b6..bb3e203 100644
---
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:34, Jason Ekstrand wrote:
---
src/intel/vulkan/genX_pipeline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index a6ec3b6..bb3e203 100644
--- a/src/intel/vulkan/genX_pipel
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:34, Jason Ekstrand wrote:
It's in 3DSTATE_CLIP, so it doesn't really need the extra detail. This
matches what we do for VS, FS, etc.
---
src/intel/genxml/gen6.xml | 2 +-
src/intel/genxml/gen7.xml | 2 +-
src/intel/genxml/gen75.xml | 2 +-
s
On Fri, Jan 6, 2017 at 9:28 PM, Kenneth Graunke wrote:
> On Friday, January 6, 2017 1:17:39 PM PST Kenneth Graunke wrote:
>> From: Robert Bragg
>>
>> v2: (Ken) Update timebase_scale for platforms past Skylake/Broxton too.
>
> Hi Robert!
>
> Your patch had merge conflicts in gen_device_info.c at t
On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand wrote:
> Older versions of GCC don't like compound literals in static const
> variable declarations because they don't think it's an actual constant
> value.
Probably because the type it was cast to was explicitly non-const.
https://bugs.freedesktop.org/show_bug.cgi?id=100257
Bug ID: 100257
Summary: Mesa 17.0.1 says OpenGL Core 4.5 even though my Intel
HD 520 Graphics Card supports only 4.4
Product: Mesa
Version: 17.0
Hardware: x86-64 (AMD64)
Reviewed-by: Lionel Landwerlin
On 16/03/17 21:09, Jason Ekstrand wrote:
Older versions of GCC don't like compound literals in static const
variable declarations because they don't think it's an actual constant
value.
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1
Cc: 17.0
Signed-off-by: Alex Deucher
---
include/pci_ids/radeonsi_pci_ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/pci_ids/radeonsi_pci_ids.h
b/include/pci_ids/radeonsi_pci_ids.h
index fca47b0..b14291d 100644
--- a/include/pci_ids/radeonsi_pci_ids.h
+++ b/include/pci_ids/ra
I thought I remembered patches with those numbers in gen_device_info
somewhere...
Anyway :
Reviewed-by: Lionel Landwerlin
On 17/03/17 14:41, Robert Bragg wrote:
Broxton's reference clock for timestamps runs at 19.2MHz and gives us
a period of 52.083 nanoseconds.
Signed-off-by: Robert Bragg
Broxton's reference clock for timestamps runs at 19.2MHz and gives us
a period of 52.083 nanoseconds.
Signed-off-by: Robert Bragg
---
src/intel/vulkan/anv_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/ir_optimization.h | 1 +
src/compiler/glsl/lower_instructions.cpp | 14 ++
2 files changed, 15 insertions(+)
diff --git a/src/compiler/glsl/ir_optimization.h
b/src/compiler/glsl/ir_optimization.h
index 67a7514c7d..b103687973
It relies on the force_glsl_abs_sqrt driconf option.
Signed-off-by: Samuel Pitoiset
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 7b917ebe47..42cdc5
Previously each time we saw a variable we just created a duplicate
entry in the list. This is particularly bad for loops were we add
everything twice, and then throw nested loops into the mix and the
list was growing expoentially.
This stops the glsl-vs-unroll-explosion test which has 16 nested
lo
From: Emil Velikov
The relative/absolute path brings little to no benefit in being printed
as testname. Trim it out.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/optimiza
From: Emil Velikov
We don't want to lie ourselves that 'everything is fine' when no tests
were found/ran.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/tests/optimization-test.sh
b/src/co
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/compiler/glsl/glcpp/tests/glcpp-test.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/glcpp/tests/glcpp-test.sh
b/src/compiler/glsl/glcpp/tests/glcpp-test.sh
index 474e8ef5307..d98c408f739 100755
--- a/src/comp
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh
b/src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh
index f0043adba10..c1e39290d39 100
From: Emil Velikov
The current "let's print any folder which exists" is simply confusing.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/optimization-test.sh
b/src/compile
From: Emil Velikov
Now that we have srcdir we can use it to correctly manage/point to the
script. Effectively fixing OOT invokation of `make check'.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/compiler/glsl/glcpp/tests/glcpp-test.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/glcpp/tests/glcpp-test.sh
b/src/compiler/glsl/glcpp/tests/glcpp-test.sh
index 3546a3e0168..474e8ef5307 100755
From: Emil Velikov
Otherwise manual invokation of the script from elsewhere than
`dirname $0` will fail.
With these all the artefacts should be created in the correct location,
and thus we can remove the old (and slighly strange) clean-local line.
Signed-off-by: Emil Velikov
---
src/compiler/
From: Emil Velikov
Rather than hardcoding glcpp/other use `basename "$0"` which expands
appropriatelly.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh | 2 +-
src/compiler/glsl/glcpp/tests/glcpp-test.sh | 2 +-
2 files changed, 2 insertions(+), 2 deleti
From: Emil Velikov
Rather than hardcoding the binary location (which ends up wrong in a
number of occasions) in the python script, pass it as argument.
This allows us to remove a couple of dirname/basename workarounds that
aimed to keep this working, and succeeded in the odd occasion.
Signed-of
From: Emil Velikov
v2: use -eq over a string comparison (Eric)
Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
src/compiler/glsl/tests/optimization-test.sh | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/optimization-test.s
From: Emil Velikov
Current definitions work fine for the manual invokation of the script,
although the whole script does not consider that one can run it OOT.
The latter will be handled with latter patches, although it will be
extensively using the two variables.
Signed-off-by: Emil Velikov
--
From: Emil Velikov
At the moment we look for generator script(s) in builddir while they
are in srcdir, and we proceed to generate the tests and expected output
in srcdir, which is not allowed.
To untangle:
- look for the generator script in the correct place
- generate the files in builddir, b
From: Emil Velikov
Otherwise we'll fail when invoking the script outside of "make check"
v2: use -ne over a string comparison (Eric)
Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
src/compiler/glsl/tests/optimization-test.sh | 10 ++
1 file changed, 10 insertions(+)
dif
From: Emil Velikov
Spamming the log with the (in some cases extremely long) test location
is of limited use.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/warnings-test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/warnings-test.sh
b/
From: Emil Velikov
Bail out early if the script is not where we expect it to be.
v2: use -f instead of -e. latter returns true on folder(s)
Signed-off-by: Emil Velikov
---
Eric, -r does not distinguish between files and folders so I've changed
to -f and removed your r-b. I think as-is it addre
From: Emil Velikov
There is no robust way to detect either one, so simply hope for the best
and warn just in case.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/compiler/glsl/tests/optimizatio
From: Emil Velikov
There is no robust way to detect either one, so simply hope for the best
and warn just in case.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/warnings-test.sh | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/test
From: Emil Velikov
With later commits we'll fix the generators to produce the files in the
correct location. That in itself will cause an issue since the files
will be left dangling and make distcheck will fail.
Cc: Matt Turner
Signed-off-by: Emil Velikov
---
Matt, do you think we should pick
Hi all
A few weeks ago I've notice that the glsl tests have not been executed
for 2+years and attempted to resolve that. Namely:
- make distcheck - generates and executes 0 (yes zero) tests
- out of tree make check is broken - either generates or executes 0
tests, or fails since the glsl_com
From: Emil Velikov
... or non-executable, in particular.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/warnings-test.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/tests/warnings-test.sh
b/src/compiler/glsl/tests/warnings-test.sh
index 6a52d4064f8..50d
From: Emil Velikov
We don't want to lie ourselves that 'everything is fine' when no tests
were found/ran.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/warnings-test.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/tests/warnings-test.sh
b/src/compiler/g
Before this commit, we would effectively fail to run any of the test in
a OOT builds.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/warnings-test.sh | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl/tests/warnings-test.sh
b/src/compiler
From: Emil Velikov
We're going to use them with the next commits to determine where to put
the generated tests and/or built binaries.
Signed-off-by: Emil Velikov
---
src/compiler/Makefile.glsl.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/Makefile.glsl.am b/src/compiler/M
On 17 March 2017 at 06:10, Jonathan Gray wrote:
> Using $< in non-suffix make rules is a GNU extension. Explicitly use
> the name of the python script to fix the build on OpenBSD.
>
Thanks Jonathan. R-b and pushed to master.
-Emil
___
mesa-dev mailing
1 - 100 of 117 matches
Mail list logo
