[Mesa-dev] [PATCH 9/9] i965: Use num_shared from nir_shader for shared variables size

2016-03-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.c b/src/mesa/drivers/dri/i965/brw_cs.c index 0ab9ebd..9345ce8 100644 --- a/src/mesa/drivers/dri/i965/brw_cs.c +++ b/src/m

[Mesa-dev] [PATCH 4/9] nir: Add atomic operations on variables

2016-03-14 Thread Jordan Justen
This allows us to first generate atomic operations for shared variables using these opcodes, and then later we can lower those to the shared atomics intrinsics with nir_lower_io. Signed-off-by: Jordan Justen --- src/compiler/nir/nir_intrinsics.h | 27 +++ 1 file changed,

[Mesa-dev] [PATCH 3/9] squash: Increase nir_variable_data::mode to 5 bits

2016-03-14 Thread Jordan Justen
Prevents: ../../../../../src/compiler/nir/nir.h:176:30: warning: 'nir_variable::nir_variable_data::mode' is too small to hold all values of 'enum nir_variable_mode' nir_variable_mode mode:4; Signed-off-by: Jordan Justen --- src/compiler/nir/nir.h | 2 +- 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH 0/9] nir shared variable support

2016-03-14 Thread Jordan Justen
This patchset allows nir to support shared variable. It works well with our SPIR-V support in the Intel Vulkan driver. I've also tried to get GLSL to delay shared variable lowering to allow it to be handled later in nir, but I got caught up in various places within the GLSL compiler. Oh well... gi

[Mesa-dev] [PATCH 2/9] nir: Add compute shader shared variable storage class

2016-03-14 Thread Jordan Justen
Previously we were receiving shared variable accesses via a lowered intrinsic function from glsl. This change allows us to send in variables instead. For example, when converting from SPIR-V. Signed-off-by: Jordan Justen --- src/compiler/nir/nir.c | 6 ++ src/compiler/nir/nir.h

[Mesa-dev] [PATCH 8/9] nir/glsl_to_nir: Initialize num_shared

2016-03-14 Thread Jordan Justen
If the glsl compiler option LowerShaderSharedVariables is set, then this will be a non-zero value, and nir should not need to lower shared variables. If LowerShaderSharedVariables is not set, then nir will need to lower the shared variables. Signed-off-by: Jordan Justen --- src/compiler/nir/glsl

[Mesa-dev] [PATCH 5/9] nir: Add support for lowering load/stores of shared variables

2016-03-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/nir/nir.c | 1 + src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_clone.c| 1 + src/compiler/nir/nir_lower_io.c | 35 --- src/compiler/nir/nir_print.c| 1 + 5 files changed, 32 insertion

[Mesa-dev] [PATCH 6/9] nir: Lower shared var atomics during nir_lower_io

2016-03-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/nir/nir_lower_io.c | 86 - 1 file changed, 84 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index f844947..a869eb2 100644 --- a/src/compiler/nir/ni

[Mesa-dev] [PATCH 1/9] nir/print: Add space after shader_storage var mode

2016-03-14 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/nir/nir_print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index bdfbd26..231a4f5 100644 --- a/src/compiler/nir/nir_print.c +++ b/src/compiler/nir/nir_print.c @@ -312

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-14 Thread Iago Toral
On Mon, 2016-03-14 at 11:15 -0700, Mark Janes wrote: > Iago Toral writes: > > > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: > >> On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > >> > Hello, > >> > > >> > There is only one patch from this series that ha

[Mesa-dev] [PATCH] llvmpipe: fix lp_rast_plane alignment on 32bit

2016-03-14 Thread sroland
From: Roland Scheidegger Some rasterization code relies (for sse) on the first and third planes (but not the second for now) being 128bit aligned, and we didn't get that on 32bit - I mistakenly thought the 64bit number in the struct would get the thing aligned to 64bit even on 32bit archs. Stepha

Re: [Mesa-dev] [PATCH] spirv: Fix structure splitting with per-vertex interface arrays.

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 14, 2016 at 9:13 PM, Kenneth Graunke wrote: > On Monday, March 14, 2016 5:23:44 PM PDT Jason Ekstrand wrote: > > On Sun, Mar 13, 2016 at 6:08 PM, Kenneth Graunke > > wrote: > > > > > We want to use interface_type, not vtn_var->type. They're normally > > > equivalent, but for geometr

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Kenneth Graunke
On Monday, March 14, 2016 5:25:58 PM PDT Matt Turner wrote: > On Mon, Mar 14, 2016 at 5:22 PM, Matt Turner wrote: > > On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez wrote: > >> Matt Turner writes: > >> > >>> Missing this causes an assertion failure in the scheduler with the next > >>> patch.

Re: [Mesa-dev] [PATCH] spirv: Fix structure splitting with per-vertex interface arrays.

2016-03-14 Thread Kenneth Graunke
On Monday, March 14, 2016 5:23:44 PM PDT Jason Ekstrand wrote: > On Sun, Mar 13, 2016 at 6:08 PM, Kenneth Graunke > wrote: > > > We want to use interface_type, not vtn_var->type. They're normally > > equivalent, but for geometry/tessellation per-vertex interface arrays, > > we need to unwrap a l

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: use vector loads for (optimized) tri raster funcs

2016-03-14 Thread Roland Scheidegger
Am 15.03.2016 um 02:37 schrieb Stéphane Marchesin: > On Mon, Feb 1, 2016 at 8:14 AM, Brian Paul wrote: >> On 01/31/2016 06:00 PM, srol...@vmware.com wrote: >>> >>> From: Roland Scheidegger >>> >>> When we switched to 64bit rasterization, we could no longer use straight >>> aligned loads for loadi

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #6 from Stephane Marchesin --- It is an alignment problem in the code. I fixed it with: https://chromium-review.googlesource.com/#/c/332681/2/media-libs/mesa/files/10.5-lp_rast-Remove-alignment-constraints.patch Feel free to try loc

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-14 Thread Michel Dänzer
On 15.03.2016 01:04, Daniel Stone wrote: > On 9 March 2016 at 02:57, Michel Dänzer wrote: >> On 08.03.2016 20:36, Daniel Stone wrote: >>> Taking the approach I suggested would allow us to solve multi-GPU >>> with the same approach, whereas with the wrapper driver ... who >>> volunteers to write th

Re: [Mesa-dev] [PATCH 3/4] docs: Renormalize some extensions.

2016-03-14 Thread Ilia Mirkin
"In progress" would seem to imply someone is working on it, which, AFAIK, is not the case. On Mar 14, 2016 7:35 PM, "Romain Failliot" wrote: > This fixes some exceptions I have to deal with in mesamatrix.net. > The extensions GL_ARB_texture_buffer_object had a comment between "DONE" > and the bra

[Mesa-dev] [PATCH 4/4] docs: Renormalize older extensions.

2016-03-14 Thread Romain Failliot
For older extensions, there is an explanation first and the extension name in brackets, like that: Clamping controls (GL_ARB_color_buffer_float) I inverted that so we have the extension first and then the explanation in brackets, like that: GL_ARB_color_buffer_float (Clamping controls) It

[Mesa-dev] [PATCH 3/4] docs: Renormalize some extensions.

2016-03-14 Thread Romain Failliot
This fixes some exceptions I have to deal with in mesamatrix.net. The extensions GL_ARB_texture_buffer_object had a comment between "DONE" and the brackets. And the extension GL_KHR_robustness (in GL 4.5 and GLES 3.1) was using "90% done" instead of "in progress". The "90% done" is still here thoug

[Mesa-dev] [PATCH 2/4] docs: Realign the "Status" column.

2016-03-14 Thread Romain Failliot
The "Status" column was misaligned in some GL sections. This is a lot of diffs, but it's only spaces in the end. --- docs/GL3.txt | 278 +-- 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 1

[Mesa-dev] [PATCH 1/4] docs: howto to read and edit GL3.txt

2016-03-14 Thread Romain Failliot
Added a small guide on how to read and edit GL3.txt. I think this would help as much the devs as the users reading this file. --- docs/GL3.txt | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index ee7faca..1ed5c1a 100644 --

[Mesa-dev] [PATCH 0/4] Small changes in GL3.txt (v2)

2016-03-14 Thread Romain Failliot
Hi! With the recent commits, I'm having some trouble parsing the GL3.txt text file for mesamatrix.net. With these set of 4 patches, I'm proposing to rationalize this file a little bit. Rest assure, the content is still exactly the same. Cheers! Romain Failliot (4): docs: howto to read and edi

[Mesa-dev] [Bug 94549] [swrast] piglit glsl-arb-fragment-coord-conventions regression

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94549 Bug ID: 94549 Summary: [swrast] piglit glsl-arb-fragment-coord-conventions regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #5 from comicfans44 --- > This is with Weston's DRM-backend, right? I think so . I'm using GMA500 driver and didn't launch X11, just run weston from terminal. > When does this happen btw.? > > Is it on Weston startup, or later, or

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: use vector loads for (optimized) tri raster funcs

2016-03-14 Thread Stéphane Marchesin
On Mon, Feb 1, 2016 at 8:14 AM, Brian Paul wrote: > On 01/31/2016 06:00 PM, srol...@vmware.com wrote: >> >> From: Roland Scheidegger >> >> When we switched to 64bit rasterization, we could no longer use straight >> aligned loads for loading the plane data. However, what the code actually >> does

Re: [Mesa-dev] Small changes in GL3.txt

2016-03-14 Thread Romain Failliot
Thanks for the explanations, I'll resend these patch the right way. 2016-03-14 10:01 GMT-04:00 Nicolai Hähnle : > Hi Romain, > > On 13.03.2016 16:50, Romain Failliot wrote: >> >> Hi! >> >> With the recent commits, I'm having some trouble parsing the GL3.txt >> text file for mesamatrix.net. >> >> W

Re: [Mesa-dev] [PATCH] st/mesa: honour sized internal formats in st_choose_format

2016-03-14 Thread Nicolai Hähnle
On 14.03.2016 16:23, Marek Olšák wrote: Reviewed-by: Marek Olšák Thanks. Do we need to fix GL_SRGB8_ALPHA8 as well? Not sure about ARB_texture_view. For ARB_shader_image_load_store, the spec has a table with an exhaustive list of supported formats, and none of them are SRGB. Do we nee

[Mesa-dev] [PATCH v2 05/10] i965/vec4/tcs: Set conditional mod on TCS_OPCODE_SRC0_010_IS_ZERO.

2016-03-14 Thread Matt Turner
Missing this causes an assertion failure in the scheduler with the next patch. --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 1 - src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_ge

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Matt Turner
On Mon, Mar 14, 2016 at 5:35 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> Missing this causes an assertion failure in the scheduler with the next patch. --- src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Francisco Jerez
Matt Turner writes: > On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> Missing this causes an assertion failure in the scheduler with the next >>> patch. >>> --- >>> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 00/14] nir: add bit-size information in data types

2016-03-14 Thread Jason Ekstrand
I had a few comments, but by-and-large it looks fine. If you think you need to do a respin, that's fine. Otherwise, with the comments addressed, Reviewed-by: Jason Ekstrand On Mon, Mar 7, 2016 at 12:45 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Hello, > > Iago and I are wo

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > When we replace an expresion we have to compute bitsize information for the > replacement. We do this in two passes to validate that bitsize information > is consistent and correct:

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Matt Turner
On Mon, Mar 14, 2016 at 5:22 PM, Matt Turner wrote: > On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> Missing this causes an assertion failure in the scheduler with the next >>> patch. >>> --- >>> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 3 ++- >>> 1 fi

Re: [Mesa-dev] [PATCH] spirv: Fix structure splitting with per-vertex interface arrays.

2016-03-14 Thread Jason Ekstrand
On Sun, Mar 13, 2016 at 6:08 PM, Kenneth Graunke wrote: > We want to use interface_type, not vtn_var->type. They're normally > equivalent, but for geometry/tessellation per-vertex interface arrays, > we need to unwrap a level. > > Otherwise, we tried to iterate a structure members but instead us

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Matt Turner
On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez wrote: > Matt Turner writes: > >> Missing this causes an assertion failure in the scheduler with the next >> patch. >> --- >> src/mesa/drivers/dri/i965/brw_ir_vec4.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

2016-03-14 Thread Francisco Jerez
Matt Turner writes: > Missing this causes an assertion failure in the scheduler with the next > patch. > --- > src/mesa/drivers/dri/i965/brw_ir_vec4.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_ir_vec4.h > b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

2016-03-14 Thread Connor Abbott
On Mon, Mar 14, 2016 at 7:48 PM, Jason Ekstrand wrote: > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > wrote: >> >> From: Connor Abbott >> >> v2: Use the bit-size information from the opcode information if defined >> (Iago) >> >> Signed-off-by: Iago Toral Quiroga >> >> FIXME:

Re: [Mesa-dev] [PATCH 06/10] i965: Relax restriction on scheduling last instruction.

2016-03-14 Thread Francisco Jerez
Matt Turner writes: > I think when this code was written, basic blocks were always ended by a > control flow instruction or an end-of-thread message. That's no longer > the case, and removing this restriction actually helps things: > >instructions in affected programs: 7267 -> 7244 (-0.32%) >

Re: [Mesa-dev] [PATCH 07/10] i965: Assert that an instruction is not inserted around itself.

2016-03-14 Thread Francisco Jerez
Matt Turner writes: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/src/mesa/drivers/dri/i965/brw_shader.cpp > index dfe6afc..d007ed0 100644 > --- a/src/mesa/drivers/dri/i965/brw_shader.cp

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > v2: Use the bit-size information from the opcode information if defined > (Iago) > > Signed-off-by: Iago Toral Quiroga > > FIXME: This should be squashed into the previous commit s

[Mesa-dev] [PATCH] gallium/swr: Cleaned up some context-resource management

2016-03-14 Thread George Kyriazis
Removed bound_to_context. We now pick up the context from the screen instead of the resource itself. The resource could be out-of-date and point to a pipe that is already freed. Fixes manywin mesa xdemo. --- src/gallium/drivers/swr/swr_context.cpp | 16 +++- src/gallium/drivers/swr/

Re: [Mesa-dev] [PATCH] i965: Fix gl_TessLevelOuter[] for isolines.

2016-03-14 Thread Kenneth Graunke
On Monday, March 14, 2016 3:00:06 PM PDT Kenneth Graunke wrote: > Thanks to James Legg for finding this! > > From the ARB_tessellation_shader spec: > "The number of isolines generated is derived from the first outer > tessellation level; the number of segments in each isoline is > derived from t

[Mesa-dev] [PATCH] i965: Fix gl_TessLevelOuter[] for isolines.

2016-03-14 Thread Kenneth Graunke
Thanks to James Legg for finding this! From the ARB_tessellation_shader spec: "The number of isolines generated is derived from the first outer tessellation level; the number of segments in each isoline is derived from the second outer tessellation level." According to the PRM, "TF.LineDensity

Re: [Mesa-dev] [PATCH 21/30] i965/fs: Add live interval validation pass.

2016-03-14 Thread Francisco Jerez
Matt Turner writes: > On Sun, Mar 13, 2016 at 8:47 PM, Francisco Jerez > wrote: >> This could be improved somewhat with additional validation of the >> calculated live in/out sets and by checking that the calculated live >> intervals are minimal (which isn't strictly necessary to guarantee the

[Mesa-dev] Build completed: mesa 636

2016-03-14 Thread AppVeyor
Build mesa 636 completed Commit 4d02e91e49 by Hans de Goede on 3/14/2016 2:01 PM: clover: Fix pipe_grid_info.indirect not being initialized.\n\nAfter pipe_grid_info.indirect was introduced, clover was not modified\nto set it causing it to pass uninitialized mem

Re: [Mesa-dev] [PATCH] st/mesa: honour sized internal formats in st_choose_format

2016-03-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Do we need to fix GL_SRGB8_ALPHA8 as well? Do we need to update st_extensions.c to check that all formats with the RGBA order are supported before enabling ARB_texture_view or ARB_shader_image_load_store? Marek On Mon, Mar 14, 2016 at 9:42 PM, Nicolai Hähnle wrote: >

[Mesa-dev] Build failed: mesa 635

2016-03-14 Thread AppVeyor
Build mesa 635 failed Commit af06190760 by Sarah Sharp on 10/29/2015 11:11 PM: mesa: docs: Intel i965 hardware limits.\n\nThis should help the next person working on hardware enabling figure out\nwhere in the Intel PRMs to find the magic platform hardware value

Re: [Mesa-dev] [PATCH v2 2/2] mesa: docs: Intel i965 hardware limits.

2016-03-14 Thread Sarah Sharp
I waited a little less than a week for review, but got no responses, so I've pushed these two trivial docs patches to master. Sarah Sharp On Tue, Mar 08, 2016 at 11:42:44AM -0800, Sarah Sharp wrote: > v2: > - use \name doxygen format instead of @defgroup, which creates >a separate module - a

Re: [Mesa-dev] [Nouveau] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 09:49 PM, Francisco Jerez wrote: Samuel Pitoiset writes: On 03/14/2016 02:29 PM, Samuel Pitoiset wrote: On 03/14/2016 02:26 PM, Hans de Goede wrote: Hi, On 14-03-16 14:01, Samuel Pitoiset wrote: On 03/14/2016 01:50 PM, Hans de Goede wrote: After pipe_grid_info.indirect

Re: [Mesa-dev] [PATCH 04/14] nir: add double constant types

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index d493186..d2fd23d 100644 > --- a/sr

Re: [Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 08:50 PM, Hans de Goede wrote: Hi, On 14-03-16 16:41, Samuel Pitoiset wrote: On 03/14/2016 04:28 PM, Hans de Goede wrote: Hi, On 14-03-16 16:05, Ilia Mirkin wrote: There's a less hacky and more hacky way forward. The more hacky solution is to set file index to -1 or somethi

Re: [Mesa-dev] [Nouveau] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Francisco Jerez
Samuel Pitoiset writes: > On 03/14/2016 02:29 PM, Samuel Pitoiset wrote: >> >> >> On 03/14/2016 02:26 PM, Hans de Goede wrote: >>> Hi, >>> >>> On 14-03-16 14:01, Samuel Pitoiset wrote: On 03/14/2016 01:50 PM, Hans de Goede wrote: > After pipe_grid_info.indirect was introduced,

[Mesa-dev] [PATCH] st/mesa: honour sized internal formats in st_choose_format

2016-03-14 Thread Nicolai Hähnle
From: Nicolai Hähnle The bitcasting which is possible with shader images (and texture views?) requires that when the user specifies a sized internal format for a texture, we really allocate that format. To this end: (1) find_exact_format should ignore sized internal formats and (2) some of the

Re: [Mesa-dev] [PATCH 11/14] nir: add nir_dest_bit_size() helper

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 39aad02..c7e4dcc 100644 > ---

Re: [Mesa-dev] [PATCH 10/14] nir: add nir_src_bit_size() helper

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index d2fd23d..39aad02 100644 > ---

Re: [Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Hans de Goede
Hi, On 14-03-16 16:41, Samuel Pitoiset wrote: On 03/14/2016 04:28 PM, Hans de Goede wrote: Hi, On 14-03-16 16:05, Ilia Mirkin wrote: There's a less hacky and more hacky way forward. The more hacky solution is to set file index to -1 or something and then not do the lowering when you see tha

Re: [Mesa-dev] [PATCH] swrast: Move assert for 'slice' in to check_map_teximage

2016-03-14 Thread Alejandro Piñeiro
On 14/03/16 18:44, Anuj Phogat wrote: > Cc: Alejandro Piñeiro > Signed-off-by: Anuj Phogat > --- > src/mesa/swrast/s_texture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c > index 9ccd0e3..25918e3 100644 > --

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-14 Thread Martin Peres
On 14/03/16 19:59, Kyle Brenneman wrote: On 03/14/2016 11:43 AM, Martin Peres wrote: On 14/03/16 19:16, Kyle Brenneman wrote: On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, M

Re: [Mesa-dev] [PATCH 00/10] gallium: more preparation for shader images support

2016-03-14 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Sun, Mar 13, 2016 at 3:29 PM, Nicolai Hähnle wrote: > Hi, > > this is probably my last batch of hardware-independent patches that need > to be pushed before the series that finally adds ARB_shader_image_load_store > for radeonsi. > > Patches 1

Re: [Mesa-dev] [PATCH 05/14] nir: update opcode definitions for different bit sizes

2016-03-14 Thread Connor Abbott
On Mon, Mar 14, 2016 at 2:10 PM, Jason Ekstrand wrote: > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > wrote: >> >> From: Connor Abbott >> >> Some opcodes need explicit bitsizes, and sometimes we need to use the >> double version when constant folding. >> >> v2: fix output typ

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-14 Thread Mark Janes
Iago Toral writes: > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: >> On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: >> > Hello, >> > >> > There is only one patch from this series that has been reviewed (patch >> > 1). >> > >> > Our plans is to start se

Re: [Mesa-dev] [PATCH 05/14] nir: update opcode definitions for different bit sizes

2016-03-14 Thread Jason Ekstrand
On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > Some opcodes need explicit bitsizes, and sometimes we need to use the > double version when constant folding. > > v2: fix output type for u2f (Iago) > > v3: do not change vecN opcod

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-14 Thread Kyle Brenneman
On 03/14/2016 11:43 AM, Martin Peres wrote: On 14/03/16 19:16, Kyle Brenneman wrote: On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could be a hack

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-14 Thread Martin Peres
On 14/03/16 19:16, Kyle Brenneman wrote: On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could be a hacky way of handling the case where multiple 3D

[Mesa-dev] [PATCH] swrast: Move assert for 'slice' in to check_map_teximage

2016-03-14 Thread Anuj Phogat
Cc: Alejandro Piñeiro Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c index 9ccd0e3..25918e3 100644 --- a/src/mesa/swrast/s_texture.c +++ b/src/mesa/swrast/s_t

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #4 from Roland Scheidegger --- So, it crashed in the jit fragment shader code. Could you tell what the fb size was (the values from scene->fb in lp_rast_shade_tile, possibly the ones from the (first) color and zbuffer themselves)? I w

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-14 Thread Kyle Brenneman
On 03/11/2016 05:25 PM, Martin Peres wrote: On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could be a hacky way of handling the case where multiple 3D drivers could be used to drive the same GP

Re: [Mesa-dev] [PATCH] swrast: Delete the unused 'slice' parameter

2016-03-14 Thread Anuj Phogat
On Sat, Mar 12, 2016 at 1:42 AM, Alejandro Piñeiro wrote: > On 12/03/16 00:16, Anuj Phogat wrote: > > Signed-off-by: Anuj Phogat > > Any reason to not just move the slice assert at line 243 as part of the > checks of check_map_teximage? > Didn't notice it. I'll take your suggestion and send out

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 Daniel Stone changed: What|Removed |Added Assignee|wayland-bugs@lists.freedesk |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] compiler/glsl: Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0

2016-03-14 Thread Lars Hamre
Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert This mirrors the logic from process_initializer() which performs the same check for cons

Re: [Mesa-dev] LLVMInitializeAMDGPU* undefined?

2016-03-14 Thread Jan Vesely
On Mon, 2016-03-14 at 10:19 +0800, Chih-Wei Huang wrote: > 2016-03-11 11:50 GMT+08:00 Jan Vesely : > > > > On Fri, 2016-03-11 at 10:09 +0800, Chih-Wei Huang wrote: > > > > > > cc1: some warnings being treated as errors > > > > > > > > > But I'm still not sure whether if it should be fixed on th

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-14 Thread Daniel Stone
Hi, On 9 March 2016 at 02:57, Michel Dänzer wrote: > On 08.03.2016 20:36, Daniel Stone wrote: >> Taking the approach I suggested would allow us to solve multi-GPU >> with the same approach, whereas with the wrapper driver ... who >> volunteers to write the Radeon+Intel combination driver? > > Why

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-14 Thread Daniel Stone
Hey Emil, On 8 March 2016 at 17:04, Emil Velikov wrote: > Summarising and stating some unsaid assumptions. > > Assumptions: > - The proposed solution is a replacement of the wrapped drivers > approach. No, it's meant to introduce an API mostly gears towards > DRI_PRIME setups. > - Wrapped drive

Re: [Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 04:28 PM, Hans de Goede wrote: Hi, On 14-03-16 16:05, Ilia Mirkin wrote: There's a less hacky and more hacky way forward. The more hacky solution is to set file index to -1 or something and then not do the lowering when you see that. The less hacky solution is the one you propo

Re: [Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Hans de Goede
Hi, On 14-03-16 16:05, Ilia Mirkin wrote: There's a less hacky and more hacky way forward. The more hacky solution is to set file index to -1 or something and then not do the lowering when you see that. The less hacky solution is the one you proposed as #1 - introduce a new file for "buffer" me

Re: [Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Ilia Mirkin
There's a less hacky and more hacky way forward. The more hacky solution is to set file index to -1 or something and then not do the lowering when you see that. The less hacky solution is the one you proposed as #1 - introduce a new file for "buffer" memory and lower it to the global file by addin

Re: [Mesa-dev] [PATCH mesa v2] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Samuel Pitoiset
Thanks Hans! Reviewed-by: Samuel Pitoiset On 03/14/2016 03:01 PM, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info st

Re: [Mesa-dev] Small changes in GL3.txt

2016-03-14 Thread Nicolai Hähnle
Hi Romain, On 13.03.2016 16:50, Romain Failliot wrote: Hi! With the recent commits, I'm having some trouble parsing the GL3.txt text file for mesamatrix.net. With these set of 4 patches, I'm proposing to rationalize a little bit this file. The content is exactly the same. (Note: I'm not really

[Mesa-dev] [PATCH mesa v2] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Hans de Goede
After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info struct when declaring it, to avoid similar problems popping-up in the future. Cc: "11.2" Sig

Re: [Mesa-dev] [RFC mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Hans de Goede
Messed up the subject prefix, sorry. Resending with proper prefix. On 14-03-16 15:00, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire

[Mesa-dev] [RFC mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Hans de Goede
After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info struct when declaring it, to avoid similar problems popping-up in the future. Cc: "11.2" Sig

Re: [Mesa-dev] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 02:29 PM, Samuel Pitoiset wrote: On 03/14/2016 02:26 PM, Hans de Goede wrote: Hi, On 14-03-16 14:01, Samuel Pitoiset wrote: On 03/14/2016 01:50 PM, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass unini

Re: [Mesa-dev] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 02:26 PM, Hans de Goede wrote: Hi, On 14-03-16 14:01, Samuel Pitoiset wrote: On 03/14/2016 01:50 PM, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commi

Re: [Mesa-dev] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Hans de Goede
Hi, On 14-03-16 14:01, Samuel Pitoiset wrote: On 03/14/2016 01:50 PM, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_in

[Mesa-dev] [RFC mesa] nouveau: Add support for OpenCL global memory buffers

2016-03-14 Thread Hans de Goede
This little "hack" fixes the use of OpenCL global memory buffers with nouveau, but clearly the #if 0 is not a solution as it breaks buffers with GLSL. The reason I'm posting this as an RFC patch is to discuss how to solve this properly, 2 solutions come to mind: 1) Use separate nv50_ir::FILE_MEMO

Re: [Mesa-dev] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Samuel Pitoiset
On 03/14/2016 01:50 PM, Hans de Goede wrote: After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info struct when declaring it, to avoid similar pr

[Mesa-dev] [PATCH mesa] clover: Fix pipe_grid_info.indirect not being initialized

2016-03-14 Thread Hans de Goede
After pipe_grid_info.indirect was introduced, clover was not modified to set it causing it to pass uninitialized memory for it to launch_grid. This commit fixes this by zero-ing the entire pipe_grid_info struct when declaring it, to avoid similar problems popping-up in the future. Signed-off-by:

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-14 Thread Iago Toral
On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: > On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > > Hello, > > > > There is only one patch from this series that has been reviewed (patch > > 1). > > > > Our plans is to start sending patches for adding fp64

[Mesa-dev] [Bug 94522] weston eglSwapBuffers crash in kms_swrast_dri.so on GMA500

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #3 from Pekka Paalanen --- When does this happen btw.? Is it on Weston startup, or later, or perhaps when you try to run any application using OpenGL under Weston? -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 94522] weston eglSwapBuffers crash in kms_swrast_dri.so on GMA500

2016-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #2 from Pekka Paalanen --- This is with Weston's DRM-backend, right? I'll just point out that this has nothing to do with Wayland. even if it was a Weston bug which I doubt. Any application that runs on KMS and uses kms_swrast_dri.so