Re: [Mesa-dev] [PATCH] mesa/shader: return correct attribute location for double matrix arrays

2015-12-10 Thread Dave Airlie
On 10 December 2015 at 16:43, Tapani Pälli wrote: > > On 12/10/2015 05:41 AM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> If we have a dmat2[4], then dmat2[0] is at 17, dmat2[1] at 19, >> dmat2[2] at 21 etc. The old code was returning 17,18,19. >> >> I think this code is also wrong for float

Re: [Mesa-dev] [PATCH] mesa/shader: return correct attribute location for double matrix arrays

2015-12-10 Thread Dave Airlie
On 10 December 2015 at 14:42, Timothy Arceri wrote: > On Thu, 2015-12-10 at 13:41 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> If we have a dmat2[4], then dmat2[0] is at 17, dmat2[1] at 19, >> dmat2[2] at 21 etc. The old code was returning 17,18,19. >> >> I think this code is also wrong f

[Mesa-dev] [PATCH 1/4] nv50/ir: add short imad support

2015-12-10 Thread Ilia Mirkin
Support emission of the short imad, but also include it in the various logic that tries to make it possible to emit. Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 55 ++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 ++- src/gal

[Mesa-dev] [PATCH 3/4] nv50/ir: fix imul emission in the presence of an immediate

2015-12-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp index 00b

[Mesa-dev] [PATCH 2/4] nv50/ir: teach post-ra immediate folding into mad about integers

2015-12-10 Thread Ilia Mirkin
There will usually be a split before the mad op, peer through that and pick out the right word of the immediate. Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 34 -- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 4/4] nv50/ir: manually optimize multiplication expansion logic

2015-12-10 Thread Ilia Mirkin
The conversion of 32-bit integer multiplies into 16-bit ones happens after the regular optimization loop. However it's fairly common to multiply by a small integer, rendering some of the expansion pointless. Firstly, propagate immediates when possible into mul ops, secondly just remove the ops whe

Re: [Mesa-dev] [PATCH 2/2] draw: remove clip from vertex header

2015-12-10 Thread Roland Scheidegger
FWIW I'm unconvinced this is really worth doing, though it makes it a bit more explicit which variable is really used. And it appears to work... Though there's something I'm wondering about, albeit it's unchanged from before, if the shader writes clipVertex (and position), for the ordinary xyz clip

[Mesa-dev] [PATCH 1/2] draw: don't assume fixed offset for data in struct vertex_info

2015-12-10 Thread sroland
From: Roland Scheidegger Otherwise, if struct vertex_info is changed, you're in for some surprises... --- src/gallium/auxiliary/draw/draw_pt_fetch.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pt_fetch.c b/src/gallium/auxiliary/dra

[Mesa-dev] [PATCH 2/2] draw: remove clip from vertex header

2015-12-10 Thread sroland
From: Roland Scheidegger vertex header had both clip and pre_clip_pos. There was some confusion what these were really used for, so just remove one. We need one in any case (pre_clip_pos) because the draw llvm shader would overwrite the position output from the vs with the viewport transformed. H

[Mesa-dev] [Bug 93261] GL/DRI3 over ssh broken

2015-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93261 --- Comment #2 from Michel Dänzer --- This can be solved in xserver with these two patches: https://patchwork.freedesktop.org/patch/67759/ https://patchwork.freedesktop.org/patch/67337/ -- You are receiving this mail because: You are the QA Co

[Mesa-dev] [PATCH 1/2] r600: fix viewport clipping magic.

2015-12-10 Thread Dave Airlie
From: Dave Airlie This fixes the CTS ARB_viewport_array tests and the arb_viewport_array-render-viewport-2 test I sent to the piglit list. I'm not sure what this register does, or if we should ever not be setting it, but lets just set it always for now. Signed-off-by: Dave Airlie --- src/gall

[Mesa-dev] [PATCH 2/2] radeonsi: fix viewport clipping magic.

2015-12-10 Thread Dave Airlie
From: Dave Airlie This fixes the CTS ARB_viewport_array tests and the arb_viewport_array-render-viewport-2 test I sent to the piglit list. I'm not sure what this register does, or if we should ever not be setting it, but lets just set it always for now. Signed-off-by: Dave Airlie --- src/gall

Re: [Mesa-dev] [PATCH] nir: silence uninitialized warning

2015-12-10 Thread Rob Clark
On Thu, Dec 10, 2015 at 7:08 PM, Timothy Arceri wrote: > Reviewed-by: Rob Clark > --- > src/glsl/nir/nir_lower_clip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir_lower_clip.c b/src/glsl/nir/nir_lower_clip.c > index e2a2bb6..36cc578 100644 > --- a/s

Re: [Mesa-dev] [PATCH] svga: avoid emitting redundant SetSamplers() commands

2015-12-10 Thread Charmaine Lee
>From: Brian Paul >Sent: Thursday, December 10, 2015 2:05 PM >To: mesa-dev@lists.freedesktop.org >Cc: Jose Fonseca; Charmaine Lee >Subject: [PATCH] svga: avoid emitting redundant SetSamplers() commands >This greatly reduces the number of SetSamplers() commands for some >applications. >--- > src/

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Roland Scheidegger
Am 10.12.2015 um 17:06 schrieb Jose Fonseca: > On 10/12/15 15:53, Roland Scheidegger wrote: >> Am 10.12.2015 um 15:44 schrieb Jose Fonseca: >>> On 10/12/15 08:09, Dave Airlie wrote: On 10 December 2015 at 14:31, wrote: > From: Roland Scheidegger > > Discovered this when working

[Mesa-dev] [PATCH] gk104/ir: simplify and fool-proof texbar algorithm

2015-12-10 Thread Ilia Mirkin
With the current algorithm, we only look at tex uses. However there's a write-after-write hazard where we might decide to, on some path, not use a texture's output at all, but instead to write a different value to that register. However without the barrier, the texture might complete later and over

Re: [Mesa-dev] [PATCH] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Brian Paul
On 12/10/2015 03:56 PM, Marek Olšák wrote: On Thu, Dec 10, 2015 at 10:14 PM, Brian Paul wrote: Previously, we were tracking sampler views for fragment shaders and suppressing redundant state changes, but not for other types of shaders. Now sampler views for all shader types are handled the same

[Mesa-dev] [PATCH] nir: silence uninitialized warning

2015-12-10 Thread Timothy Arceri
--- src/glsl/nir/nir_lower_clip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_lower_clip.c b/src/glsl/nir/nir_lower_clip.c index e2a2bb6..36cc578 100644 --- a/src/glsl/nir/nir_lower_clip.c +++ b/src/glsl/nir/nir_lower_clip.c @@ -217,7 +217,7 @@ nir_lower_cl

Re: [Mesa-dev] [PATCH] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Marek Olšák
On Thu, Dec 10, 2015 at 10:14 PM, Brian Paul wrote: > Previously, we were tracking sampler views for fragment shaders and > suppressing redundant state changes, but not for other types of shaders. > Now sampler views for all shader types are handled the same way. > > v2: s/PIPE_MAX_SAMPLERS/PIPE_M

Re: [Mesa-dev] [PATCH 1/5] gallium/radeon: fix Hyper-Z hangs by programming PA_SC_MODE_CNTL_1 correctly

2015-12-10 Thread Alex Deucher
On Thu, Dec 10, 2015 at 8:10 AM, Marek Olšák wrote: > From: Marek Olšák > > This is the recommended setting according to hw people and it makes Hyper-Z > stable. Just the two magic states. > > This fixes Evergreen, Cayman, SI, CI, VI (using the Cayman code). > > Cc: 11.0 11.1 For the series: Re

Re: [Mesa-dev] [PATCH] svga: avoid emitting redundant SetIndexBuffer commands

2015-12-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, December 10, 2015 1:09 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca Subject: [PATCH] svga: avoid emitting redundant SetIndexBuffer commands --- src/gallium/drivers/svga/

[Mesa-dev] [PATCH] svga: avoid emitting redundant SetSamplers() commands

2015-12-10 Thread Brian Paul
This greatly reduces the number of SetSamplers() commands for some applications. --- src/gallium/drivers/svga/svga_context.h | 3 +++ src/gallium/drivers/svga/svga_state_sampler.c | 22 +++--- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH v3] nv50, nvc0: optimize coherent buffer checking at draw time

2015-12-10 Thread Samuel Pitoiset
Instead of iterating over all the buffer resources looking for coherent buffers, we keep track of a context-wide count. This will save some iterations (and CPU cycles) in 99.99% case because usually coherent buffers are not so used. Changes from v3: - check if views[i] and views[i]->texture are n

[Mesa-dev] [PATCH] nv50/ir: combine sequences of conversions

2015-12-10 Thread Ilia Mirkin
In some cases shaders want non-default rounding when converting float to integer. This can be done in one go, so merge the two ops. This comes up in the packUnorm4x8 & co functions, as well as a few random shaders. Overall shader-db impact is minimal, helping a handful of witcher2 and other misc sh

[Mesa-dev] [PATCH] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Brian Paul
Previously, we were tracking sampler views for fragment shaders and suppressing redundant state changes, but not for other types of shaders. Now sampler views for all shader types are handled the same way. v2: s/PIPE_MAX_SAMPLERS/PIPE_MAX_SHADER_SAMPLER_VIEWS/, per Ilia. --- src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 1/3] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Brian Paul
On 12/10/2015 02:10 PM, Ilia Mirkin wrote: On Thu, Dec 10, 2015 at 4:08 PM, Brian Paul wrote: diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index 6b29b20..5db3d20 100644 --- a/src/gallium/auxiliary/cso_cache/cso_context.c +++ b/src/g

Re: [Mesa-dev] [PATCH 1/3] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Ilia Mirkin
On Thu, Dec 10, 2015 at 4:08 PM, Brian Paul wrote: > diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c > b/src/gallium/auxiliary/cso_cache/cso_context.c > index 6b29b20..5db3d20 100644 > --- a/src/gallium/auxiliary/cso_cache/cso_context.c > +++ b/src/gallium/auxiliary/cso_cache/cso_conte

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-10 Thread Nanley Chery
On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > If EGL_KHR_surfaceless_context is used then glViewport can be called > with NULL for the draw and read surfaces. This was previously causing > a crash because the i965 driver tries to use this point to invalidate > the surfaces and it

[Mesa-dev] [PATCH] svga: avoid emitting redundant SetIndexBuffer commands

2015-12-10 Thread Brian Paul
--- src/gallium/drivers/svga/svga_context.h | 4 src/gallium/drivers/svga/svga_draw.c| 17 - 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium/drivers/svga/svga_context.h index c4284cc..db9491b 100644 --

[Mesa-dev] [PATCH 2/3] cso: don't send redundant sampler state changes to drivers

2015-12-10 Thread Brian Paul
One of the purposes of the CSO module is to filter out redundant state changes from reaching the driver. This was done for things like blend state, depth/stencil state, shaders, etc, but not texture samplers. This eliminates a lot of redundant driver calls in some apps. --- src/gallium/auxiliary

[Mesa-dev] [PATCH 3/3] cso: remove / add some comments

2015-12-10 Thread Brian Paul
--- src/gallium/auxiliary/cso_cache/cso_context.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index 06089ad..afcf27d 100644 --- a/src/gallium/auxiliary/cso_cache/cso_co

[Mesa-dev] [PATCH 1/3] cso: handle sampler view changes the same way for all shader types

2015-12-10 Thread Brian Paul
Previously, we were tracking sampler views for fragment shaders and suppressing redundant state changes, but not for other types of shaders. Now sampler views for all shader types are handled the same way. --- src/gallium/auxiliary/cso_cache/cso_context.c | 88 --- 1 file c

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

2015-12-10 Thread Jason Ekstrand
On Dec 10, 2015 12:40 PM, "Matt Turner" wrote: > > On Thu, Dec 10, 2015 at 11:11 AM, Jason Ekstrand wrote: > > > > On Dec 10, 2015 6:58 AM, "Francisco Jerez" wrote: > >> > >> Jason Ekstrand writes: > >> > >> > We aren't using it anymore. > >> > >> It seems useful to me to be able to represent i

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

2015-12-10 Thread Matt Turner
On Thu, Dec 10, 2015 at 11:11 AM, Jason Ekstrand wrote: > > On Dec 10, 2015 6:58 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > We aren't using it anymore. >> >> It seems useful to me to be able to represent indirect access as part of >> any instruction source or destination r

Re: [Mesa-dev] [PATCH] glsl: Relax requirement on Centroid matching between shader stages

2015-12-10 Thread Ian Romanick
On 12/10/2015 01:18 AM, Lofstedt, Marta wrote: > > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On >> Behalf Of Ian Romanick >> Sent: Friday, November 6, 2015 6:47 PM >> To: Marta Lofstedt; mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-12-10 Thread Kristian Høgsberg
On Fri, Dec 4, 2015 at 6:24 AM, Michel Thierry wrote: > On 11/18/2015 10:53 PM, Kristian Høgsberg wrote: >> >> On Wed, Oct 14, 2015 at 5:11 AM, Michel Thierry >> wrote: >>> >>> On 10/14/2015 8:19 AM, Daniel Vetter wrote: On Tue, Oct 13, 2015 at 02:51:36PM -0700, Kristian Høgsberg w

Re: [Mesa-dev] [PATCH 08/15] i965/vec4: Use MOV_INDIRECT instead of reladdr for indirect push constants

2015-12-10 Thread Jason Ekstrand
On Thu, Dec 10, 2015 at 1:25 AM, Michael Schellenberger Costa wrote: > Hi Jason, Hi! Please remember to reply-all so it goes to the list. :-) > Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: >> This commit moves us to an instruction based model rather than a >> register-based model for indirect

Re: [Mesa-dev] [PATCH 03/15] i965/fs: Use MOV_INDIRECT for all indirect uniform loads

2015-12-10 Thread Jason Ekstrand
On Wed, Dec 9, 2015 at 8:33 PM, Matt Turner wrote: > On Wed, Dec 9, 2015 at 8:23 PM, Jason Ekstrand wrote: >> Instead of using reladdr, this commit changes the FS backend to emit a >> MOV_INDIRECT whenever we need an indirect uniform load. We also have to >> rework some of the other bits of the

Re: [Mesa-dev] [PATCH 05/15] i965/fs: Stop relying on param_size in assign_constant_locations

2015-12-10 Thread Jason Ekstrand
On Thu, Dec 10, 2015 at 1:12 AM, Michael Schellenberger Costa wrote: > Hi, > > Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: >> Now that we have MOV_INDIRECT opcodes, we have all of the size information >> we need directly in the opcode. With a little restructuring of the >> algorithm used in as

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

2015-12-10 Thread Jason Ekstrand
On Dec 10, 2015 6:58 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > We aren't using it anymore. > > It seems useful to me to be able to represent indirect access as part of > any instruction source or destination register. > > The following: > > | mov_indirect g0, g1, a0 > | foo g2

Re: [Mesa-dev] [PATCH] util/u_helpers: return correct number of bound buffers

2015-12-10 Thread Ilia Mirkin
On Thu, Dec 10, 2015 at 1:50 PM, Patrick Rudolph wrote: > In case a state tracker unbinds every slot by a seperate > pipe->set_vertex_buffers() call, starting from slot zero, the number > of bound buffers would not reach zero at all. > The current algorithm does not account for pre-existing holes

[Mesa-dev] [PATCH] util/u_helpers: return correct number of bound buffers

2015-12-10 Thread Patrick Rudolph
In case a state tracker unbinds every slot by a seperate pipe->set_vertex_buffers() call, starting from slot zero, the number of bound buffers would not reach zero at all. The current algorithm does not account for pre-existing holes in the buffer list. Unbinding all buffers at once or starting at

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-10 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 2:15 PM, Ilia Mirkin wrote: > On Wed, Dec 9, 2015 at 11:23 AM, Ilia Mirkin wrote: >> On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: >>> This patch indeed seems to not have a sense. I just added it to the bug >>> report as a suggestion that it works for me after this modifica

Re: [Mesa-dev] [PATCH 05/15] i965/fs: Stop relying on param_size in assign_constant_locations

2015-12-10 Thread Jason Ekstrand
On Dec 10, 2015 9:06 AM, "Francisco Jerez" wrote: > > Michael Schellenberger Costa > writes: > > > Hi, > > > > Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: > >> Now that we have MOV_INDIRECT opcodes, we have all of the size information > >> we need directly in the opcode. With a little restruc

Re: [Mesa-dev] [PATCH v4] mesa: Update _mesa_has_geometry_shaders

2015-12-10 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 1/1] i965: Do not overwrite optimizer dumps

2015-12-10 Thread Matt Turner
On Thu, Dec 10, 2015 at 8:44 AM, Juan A. Suarez Romero wrote: > On Mon, 2015-11-30 at 12:26 +0100, Juan A. Suarez Romero wrote: >> When using INTEL_DEBUG=optimizer, each optimizing step is dump to >> disk, >> in a separate file. > > > Any news on this? Can be considered as reviewed? Thanks in adva

Re: [Mesa-dev] [PATCH 1/3] tgsi/scan: add flag colors_written

2015-12-10 Thread Alex Deucher
On Thu, Dec 10, 2015 at 8:09 AM, Marek Olšák wrote: > From: Marek Olšák > > This is a prerequisite for the following r600g fix. > > Cc: 11.0 11.1 For the series: Reviewed-by: Alex Deucher > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ > src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + >

Re: [Mesa-dev] [PATCH] radeonsi: implement RB+ for Stoney (v2)

2015-12-10 Thread Alex Deucher
On Wed, Dec 9, 2015 at 5:35 PM, Marek Olšák wrote: > From: Marek Olšák > > v2: fix dual source blending Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 1 + > src/gallium/drivers/radeon/r600_pipe_common.h | 3 + > src/gallium/drivers/radeon/r600_texture.c

Re: [Mesa-dev] [PATCH 05/15] i965/fs: Stop relying on param_size in assign_constant_locations

2015-12-10 Thread Francisco Jerez
Michael Schellenberger Costa writes: > Hi, > > Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: >> Now that we have MOV_INDIRECT opcodes, we have all of the size information >> we need directly in the opcode. With a little restructuring of the >> algorithm used in assign_constant_locations we don'

Re: [Mesa-dev] [PATCH v3 00/12] nir: Get rid of the *_indirect variants of

2015-12-10 Thread Rob Clark
On Tue, Dec 8, 2015 at 4:46 PM, Jason Ekstrand wrote: > This is my third sending of this series. I think this version is close to > working on all of the relevant drivers (it works on i965). Hopefully, we > can actually push it this time. > > As mentioned before, all but the first two patches wi

Re: [Mesa-dev] [PATCH 05/15] i965/fs: Stop relying on param_size in assign_constant_locations

2015-12-10 Thread Michael Schellenberger Costa
Hi, Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: > Now that we have MOV_INDIRECT opcodes, we have all of the size information > we need directly in the opcode. With a little restructuring of the > algorithm used in assign_constant_locations we don't need param_size > anymore. The big thing to

Re: [Mesa-dev] [PATCH v4 1/1] i965: Do not overwrite optimizer dumps

2015-12-10 Thread Juan A. Suarez Romero
On Mon, 2015-11-30 at 12:26 +0100, Juan A. Suarez Romero wrote: > When using INTEL_DEBUG=optimizer, each optimizing step is dump to > disk, > in a separate file. Any news on this? Can be considered as reviewed? Thanks in advance J.A. ___ mes

[Mesa-dev] [PATCH v4] mesa: Update _mesa_has_geometry_shaders

2015-12-10 Thread Marta Lofstedt
From: Marta Lofstedt Updates the _mesa_has_geometry_shaders function to also look for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. --- src/mesa/main/context.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h i

[Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

2015-12-10 Thread Marta Lofstedt
From: Marta Lofstedt Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 70 ++-- src/mesa/main/get_hash_params.py | 53 +- 2 files changed, 92 insertions(+),

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Jose Fonseca
On 10/12/15 15:53, Roland Scheidegger wrote: Am 10.12.2015 um 15:44 schrieb Jose Fonseca: On 10/12/15 08:09, Dave Airlie wrote: On 10 December 2015 at 14:31, wrote: From: Roland Scheidegger Discovered this when working on other clip code, apparently didn't work correctly - the combination

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Roland Scheidegger
Am 10.12.2015 um 15:44 schrieb Jose Fonseca: > On 10/12/15 08:09, Dave Airlie wrote: >> On 10 December 2015 at 14:31, wrote: >>> From: Roland Scheidegger >>> >>> Discovered this when working on other clip code, apparently didn't work >>> correctly - the combination of linear interpolated values

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Brian Paul
On 12/10/2015 07:44 AM, Jose Fonseca wrote: On 10/12/15 08:09, Dave Airlie wrote: On 10 December 2015 at 14:31, wrote: From: Roland Scheidegger Discovered this when working on other clip code, apparently didn't work correctly - the combination of linear interpolated values and using gl_Clip

[Mesa-dev] [PATCH demos] configure.ac: Fix default behavior of AC_ARG_WITH(glut) if glut isn't available

2015-12-10 Thread Andreas Boll
Fixes a regression introduced in 406248811eb0dfabf75ae9495b54529ec59cce66 It wrongly sets glut_enabled=yes if glut isn't available and neither option --with-glut nor --without-glut was given. The default behavior in that case should be if glut is available then enable glut else it should disable

[Mesa-dev] [Bug 93278] Configure should not have hardcoded list of {dri, gallium} drivers

2015-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93278 --- Comment #4 from Marek Olšák --- I would close this as not a bug. People are supposed to read error messages and either install missing dependencies or adjust configure parameters accordingly. -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

2015-12-10 Thread Francisco Jerez
Jason Ekstrand writes: > We aren't using it anymore. It seems useful to me to be able to represent indirect access as part of any instruction source or destination register. The following: | mov_indirect g0, g1, a0 | foo g2, g0 and the converse case with indirect destination offset (which you

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Jose Fonseca
On 10/12/15 08:09, Dave Airlie wrote: On 10 December 2015 at 14:31, wrote: From: Roland Scheidegger Discovered this when working on other clip code, apparently didn't work correctly - the combination of linear interpolated values and using gl_ClipVertex produced wrong values (failing all suc

[Mesa-dev] [Bug 93261] GL/DRI3 over ssh broken

2015-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93261 Martin Peres changed: What|Removed |Added Blocks||93185 -- You are receiving this mail bec

Re: [Mesa-dev] [PATCH v2] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
I noticed that I've typed gl_gentable.c instead of glapi_gentable.c in the commit message. Fixed that locally. 2015-12-10 14:35 GMT+01:00 Andreas Boll : > Removes the public symbol _glapi_create_table_from_handle from > libGL.so.1 on all platforms except Darwin. > > Since the symbol is not used on

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
I think it we should keep it in src/mapi/glapi/gen since there are all other generated glapi files. There's also glapi_x86.S, glapi_x86-64.S and glapi_sparc.S which are conditionally built too. Could you take a look at v2? It would be nice if you could test it on Darwin. Thanks, Andreas 2015-12-

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
2015-12-09 18:07 GMT+01:00 Emil Velikov : > On 9 December 2015 at 14:11, Andreas Boll wrote: >> Removes the public symbol _glapi_create_table_from_handle from >> libGL.so.1 on all plattforms except Darwin. >> > typo -> platforms > fixed in v2 >> Since the symbol is not used on other plattforms i

[Mesa-dev] [PATCH v2] glapi: Build gl_gentable.c only on Darwin

2015-12-10 Thread Andreas Boll
Removes the public symbol _glapi_create_table_from_handle from libGL.so.1 on all platforms except Darwin. Since the symbol is not used on other platforms it makes sense to build gl_gentable.c only on Darwin. A little bit of history: _glapi_create_table_from_handle was introduced in commit 85937

[Mesa-dev] [PATCH 2/5] r600g: re-enable Hyper-Z for stencil on Evergreen & Cayman

2015-12-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index 78fe87e..0f628ee 100644 --- a/src/gallium/drivers/r600/evergreen

[Mesa-dev] [PATCH 3/5] r600g: remove a Hyper-Z workaround that's likely not needed anymore

2015-12-10 Thread Marek Olšák
From: Marek Olšák FORCE_OFF == 0, no need to set that --- src/gallium/drivers/r600/evergreen_state.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index 0f62

[Mesa-dev] [PATCH 5/5] radeonsi: implement fast stencil clear

2015-12-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/drivers/radeonsi/si_blit.c| 46 --- src/gallium/drivers/radeonsi/si_pipe.h| 2 ++ src/gallium/drivers/radeonsi/si_state.c | 26 --- 4 files changed,

[Mesa-dev] [PATCH 4/5] radeonsi: re-enable Hyper-Z for stencil

2015-12-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 4245452..9038704 100644 --- a/src/gallium/drivers/radeonsi/si_st

[Mesa-dev] [PATCH 1/5] gallium/radeon: fix Hyper-Z hangs by programming PA_SC_MODE_CNTL_1 correctly

2015-12-10 Thread Marek Olšák
From: Marek Olšák This is the recommended setting according to hw people and it makes Hyper-Z stable. Just the two magic states. This fixes Evergreen, Cayman, SI, CI, VI (using the Cayman code). Cc: 11.0 11.1 --- src/gallium/drivers/r600/evergreen_state.c | 9 +++-- src/gallium/drivers/r

[Mesa-dev] [PATCH 2/3] r600g: write all MRTs only if there is exactly one output (fixes a hang)

2015-12-10 Thread Marek Olšák
From: Marek Olšák This fixes a hang in piglit/arb_blend_func_extended-fbo-extended-blend-pattern_gles2 on REDWOOD. Cc: 11.0 11.1 --- src/gallium/drivers/r600/r600_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/galliu

[Mesa-dev] [PATCH 1/3] tgsi/scan: add flag colors_written

2015-12-10 Thread Marek Olšák
From: Marek Olšák This is a prerequisite for the following r600g fix. Cc: 11.0 11.1 --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/t

[Mesa-dev] [PATCH 3/3] radeonsi: use tgsi_shader_info::colors_written

2015-12-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 1 - src/gallium/drivers/radeonsi/si_state.c | 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 9 - 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shade

Re: [Mesa-dev] [PATCH] radeonsi: also print hexadecimal values for register fields in the IB parser

2015-12-10 Thread eocallaghan
On 2015-12-10 09:54, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index cce665e..034acf5 100644

Re: [Mesa-dev] [PATCH] radeonsi: don't call of u_prims_for_vertices for patches and rectangles

2015-12-10 Thread eocallaghan
On 2015-12-10 22:15, Marek Olšák wrote: On Thu, Dec 10, 2015 at 4:01 AM, Michel Dänzer wrote: On 10.12.2015 06:58, Marek Olšák wrote: From: Marek Olšák Both caused a crash due to a division by zero in that function. This is an alternative fix. Cc: 11.0 11.1 --- src/gallium/drivers/radeons

[Mesa-dev] Spec bug in GL/GLSL/ARB_enhanced_layouts specs?

2015-12-10 Thread Timothy Arceri
Hi guys, Just wanted to run this past you all before taking the time to report it as a bug. There seems to be conflicting text in the OpenGL and GLSL specs in regards to the component layout qualifier. In Section 11.1.1 (Vertex Attributes) from the OpenGL 4.5 spec: "When an attribute variable d

Re: [Mesa-dev] [PATCH] radeonsi: don't call of u_prims_for_vertices for patches and rectangles

2015-12-10 Thread Marek Olšák
On Thu, Dec 10, 2015 at 4:01 AM, Michel Dänzer wrote: > On 10.12.2015 06:58, Marek Olšák wrote: >> From: Marek Olšák >> >> Both caused a crash due to a division by zero in that function. >> This is an alternative fix. >> >> Cc: 11.0 11.1 >> --- >> src/gallium/drivers/radeonsi/si_state_draw.c |

Re: [Mesa-dev] [PATCH] glsl: Relax requirement on Centroid matching between shader stages

2015-12-10 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Friday, November 6, 2015 6:47 PM > To: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] glsl: Relax requirement on Centroid > matching

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-10 Thread Oded Gabbay
On Wed, Dec 9, 2015 at 8:30 PM, Matt Turner wrote: > On Tue, Dec 8, 2015 at 9:37 PM, Jonathan Gray wrote: >> Change the __m128i variables to be volatile so gcc 4.9 won't optimise >> all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd calls >> still get optimised out but now there is a

Re: [Mesa-dev] [RFC PATCH 1/5] i965/eu: set correct execution size in brw_NOP

2015-12-10 Thread Iago Toral
On Wed, 2015-12-09 at 10:38 -0800, Matt Turner wrote: > On Wed, Dec 9, 2015 at 4:15 AM, Iago Toral Quiroga wrote: > > --- > > src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c > > b/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] draw: fix clipping with linear interpolated values and gl_ClipVertex

2015-12-10 Thread Dave Airlie
On 10 December 2015 at 14:31, wrote: > From: Roland Scheidegger > > Discovered this when working on other clip code, apparently didn't work > correctly - the combination of linear interpolated values and using > gl_ClipVertex produced wrong values (failing all such combinations > in piglits glsl

Re: [Mesa-dev] [RFC PATCH 5/5] i965: Skip execution size adjustment for instructions of width 4

2015-12-10 Thread Iago Toral
On Wed, 2015-12-09 at 23:51 -0800, Jason Ekstrand wrote: > > On Dec 9, 2015 11:47 PM, "Iago Toral" wrote: > > > > On Wed, 2015-12-09 at 08:10 -0800, Jason Ekstrand wrote: > > > > > > On Dec 9, 2015 4:16 AM, "Iago Toral Quiroga" > > > wrote: > > > > > > > > This code in brw_set_dest adjusts the e