I think it we should keep it in src/mapi/glapi/gen since there are all other generated glapi files. There's also glapi_x86.S, glapi_x86-64.S and glapi_sparc.S which are conditionally built too.
Could you take a look at v2? It would be nice if you could test it on Darwin. Thanks, Andreas 2015-12-09 18:17 GMT+01:00 Jeremy Huddleston Sequoia <[email protected]>: > The general concept of this change seems fine to me. > > Given the desire to keep glapi as similar as possible across platforms, would > it be better to just move this into glx/apple rather than leaving it in glapi? > >> On Dec 9, 2015, at 09:07, Emil Velikov <[email protected]> wrote: >> >> On 9 December 2015 at 14:11, Andreas Boll <[email protected]> wrote: >>> Removes the public symbol _glapi_create_table_from_handle from >>> libGL.so.1 on all plattforms except Darwin. >>> >> typo -> platforms >> >>> Since the symbol is not used on other plattforms it makes sense to >> ditto >> >>> build gl_gentable.c only on Darwin. >>> >> Ideally we'll keep the dispatch as close to identical across all >> platforms (i.e. we'll nuke this), although for now this will do. >> >> Out of curiosity is there any noticeable difference in the build times? >> >> ... >>> XXX If we still want to distribute gl_gentable.c in the release tarball >>> we could drop the changes in src/mapi/glapi/gen/Makefile.am >>> >> Yes please. We want to ship all the generated sources, regardless of >> the platform they're used. >> >> ... >>> index 2da8f7d..25ea44a 100644 >>> --- a/src/mapi/glapi/gen/Makefile.am >>> +++ b/src/mapi/glapi/gen/Makefile.am >>> @@ -27,8 +27,11 @@ MESA_GLAPI_OUTPUTS = \ >>> $(MESA_GLAPI_DIR)/glapi_mapi_tmp.h \ >>> $(MESA_GLAPI_DIR)/glprocs.h \ >>> $(MESA_GLAPI_DIR)/glapitemp.h \ >>> - $(MESA_GLAPI_DIR)/glapitable.h \ >>> - $(MESA_GLAPI_DIR)/glapi_gentable.c >>> + $(MESA_GLAPI_DIR)/glapitable.h >>> + >>> +if HAVE_APPLEDRI >>> +MESA_GLAPI_OUTPUTS += $(MESA_GLAPI_DIR)/glapi_gentable.c >>> +endif >>> >>> MESA_GLAPI_ASM_OUTPUTS = >>> if HAVE_X86_ASM >>> @@ -88,8 +91,11 @@ XORG_GLAPI_DIR = $(XORG_BASE)/glx >>> XORG_GLAPI_OUTPUTS = \ >>> $(XORG_GLAPI_DIR)/glprocs.h \ >>> $(XORG_GLAPI_DIR)/glapitable.h \ >>> - $(XORG_GLAPI_DIR)/dispatch.h \ >>> + $(XORG_GLAPI_DIR)/dispatch.h >>> + >>> +if HAVE_APPLEDRI >>> $(XORG_GLAPI_DIR)/glapi_gentable.c >> Erm missing XORG_GLAPI_OUTPUTS += ? >> >> Afaict even with the above makefile changes the file should still be >> in the in the tarball. Am I missing something ? >> >> Would be great if Jeremy (or someone else) has the chance to test >> this, in case we've missing something. >> >> -Emil > _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
