[Mesa-dev] [PATCH 2/2] android: fix a building error of libmesa_program

Add libmesa_glsl to LOCAL_STATIC_LIBRARIES to get its exported include path (for nir_opcodes.h). Signed-off-by: Chih-Wei Huang --- src/mesa/program/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/program/Android.mk b/src/mesa/program/Android.mk index 374fcbf..af16e77 1006

[Mesa-dev] [PATCH 1/2] android: export the path of the generated nir_opcodes.h

The modules including nir_opcodes.h can just add libmesa_glsl to their LOCAL_STATIC_LIBRARIES. Signed-off-by: Chih-Wei Huang --- src/glsl/Android.gen.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/Android.gen.mk b/src/glsl/Android.gen.mk index 82f2bf1..35d79f2 100644 --- a/src

[Mesa-dev] [PATCH 0/2] More Android patches

First, thanks to Emil who submitted a series of patches to fix Android building issues for the master branch. However, there are still some errors in my test. These patches try to fix them. The patches are based on Emil's 'submit/android-fixes#1' branch. With them I'm able to build the i915 and i9

Re: [Mesa-dev] [PATCH 8/9] nir: Implement a nir_sweep() pass.

On Wednesday, April 01, 2015 05:54:29 PM Jason Ekstrand wrote: > On Sat, Mar 28, 2015 at 2:28 PM, Kenneth Graunke > wrote: > > This pass performs a mark and sweep pass over a nir_shader's associated > > memory - anything still connected to the program will be kept, and any > > dead memory we drop

Re: [Mesa-dev] [PATCH 14/16] android: add inital NIR build

2015-03-29 4:54 GMT+08:00 Emil Velikov : > From: Mauro Rossi > > Required by the i965 driver. > > Cc: "10.5" > [Emil Velikov: Split from a larger commit] > Signed-off-by: Emil Velikov > --- > src/glsl/Android.gen.mk | 62 > +++-- > src/glsl/Android.m

[Mesa-dev] [PATCH 5/5] nir: Remove fsin_reduced/fcos_reduced.

--- src/glsl/nir/nir_opcodes.py | 2 -- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index 062cd62..87f06d1 100644 --- a/src/glsl/nir/nir_opcodes.py +++ b/src/glsl/nir/nir_opcod

[Mesa-dev] [PATCH 3/5] program: Remove unused emit_scs().

Was only used by the sin_reduced/cos_reduced cases, which themselves were impossible to reach. --- I've left this as a separate patch from 1/5, but I guess it should probably be squashed with it. src/mesa/program/ir_to_mesa.cpp | 98 - 1 file changed, 98 de

[Mesa-dev] [PATCH 1/5] glsl: Remove never used sin_reduced/cos_reduced.

These were added in commit f2616e56, presumably in preparation for translating ARB vp/fp into GLSL IR. That never happened, and neither did a lowering pass that actually generated these instructions. --- src/glsl/ir.cpp | 4 src/glsl/ir.h

[Mesa-dev] [PATCH 4/5] st/mesa: Remove unused emit_scs().

Was only used by the sin_reduced/cos_reduced cases, which themselves were impossible to reach. --- I've left this as a separate patch from 1/5, but I guess it should probably be squashed with it. src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 98 -- 1 file changed, 98 de

[Mesa-dev] [PATCH 2/5] i965/vec4: Remove emit_scs() prototype.

This has never existed. --- src/mesa/drivers/dri/i965/brw_vec4.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 6ec00d5..700ca69 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.h +++ b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 03/13] i965/register_coalesce: Do register size checks before is_copy_payload

This allows us to get rid of the visitor argument in is_copy_payload --- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp b/src/mesa/drivers/dri/i965/brw_fs_

[Mesa-dev] [PATCH 05/13] i965/fs: Make emit_single_fb_write take an explicit exec_size

--- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 16 +--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 278a8ee..4ea579d 100644 --- a

[Mesa-dev] [PATCH 06/13] i965/fs: Make LOAD_PAYLOAD take a header size

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 20 +++- 4 files changed, 20 insertions(+), 12 deletions(-) di

[Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

This allows us to combine code in CSE and register coalesce --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 18 +- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 14 +- sr

[Mesa-dev] [PATCH 08/13] SQUASH: i965/fs: Make destinations of load_payload have the appropreate width

--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index f8c2a14..b7eeb47 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_vis

[Mesa-dev] [PATCH 00/13] i965: Make LOAD_PAYLOAD sane again

This patch series comes with two apologies. First, is for the fact that most of it has to be squashed into a single super-commit. Unfortunately, this is one of those things that can't really be done incrementally. Second, is for the absolute disaster that I left LOAD_PAYLOAD in at the end of my s

[Mesa-dev] [PATCH 12/13] SQUASH: i965/fs: Set up fb-write payloads directly

Previously, we had a big helper function for setting up the color sources of the LOAD_PAYLOAD instruction. Now that lower_load_payload is much more sane, all that complexity isn't needed anymore. We can just stash sources directly in the LOAD_PAYLOAD and trust lower_load_payload to do the right t

[Mesa-dev] [PATCH 10/13] SQUASH: i965/fs_cse: Support the new-style LOAD_PAYLOAD

--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index 403674d..d86e99f 100644 --- a/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 11/13] SQUASH: i965/fs_inst::is_copy_payload: Support the new-style LOAD_PAYLOAD

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index bc45a38..fac507e 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 13/13] i965/fs_inst: Get rid of the effective_width field

The effective_width field was an ill-concieved hack to get around issues in the LOAD_PAYLOAD instruction. Now that the LOAD_PAYLOAD instruction is far more sane, this field can die. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 25 -- .../drivers/dri/i965/brw_fs_cop

[Mesa-dev] [PATCH 01/13] i965/fs_cse: Factor out code to create copy instructions

--- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 75 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index f2c4098..dd199fa 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 07/13] i965/fs: Rework fs_visitor::LOAD_PAYLOAD

We rework LOAD_PAYLOAD to verify that all of the sources that count as headers are, indeed, exactly one register and that all of the non-header sources match the destination width. We then take the exec_size for LOAD_PAYLOAD directly from the destination width. --- src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 02/13] i965: Change header_present to header_size in backend_instruction

--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 +++ src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 20 src/mesa/drivers/dri/i965/brw_fs_visitor.

[Mesa-dev] [PATCH 09/13] SQUASH: i965/fs: Rework fs_visitor::lower_load_payload

Instead of the complicated and broken-by-design pile of heuristics we had before, we now have a straightforward lowering: 1) All header sources are copied directly using force_writemask_all and, since they are guaranteed to be a single register, there are no force_sechalf issues. 2) All

Re: [Mesa-dev] [PATCH] nir: add support for structured COME FROM

On Wed, Apr 1, 2015 at 8:34 PM, Jason Ekstrand wrote: > On Wed, Apr 1, 2015 at 9:59 AM, Francisco Jerez wrote: >> Connor Abbott writes: >> >>> Unfortunately, we can't support unstructured COME FROM yet, since we >>> can't structurize arbitrary control flow graphs. Also TODO is adding >>> support

Re: [Mesa-dev] [PATCH 8/9] nir: Implement a nir_sweep() pass.

On Sat, Mar 28, 2015 at 2:28 PM, Kenneth Graunke wrote: > This pass performs a mark and sweep pass over a nir_shader's associated > memory - anything still connected to the program will be kept, and any > dead memory we dropped on the floor will be freed. > > The expectation is that this will be c

Re: [Mesa-dev] [PATCH] nir: add support for structured COME FROM

On Wed, Apr 1, 2015 at 9:59 AM, Francisco Jerez wrote: > Connor Abbott writes: > >> Unfortunately, we can't support unstructured COME FROM yet, since we >> can't structurize arbitrary control flow graphs. Also TODO is adding >> support for threading by having multiple come_from's point to the sam

Re: [Mesa-dev] [PATCH] i965/generator: Get rid of the ! in the unreachable statement

Reviewed-by: Mark Janes Jason Ekstrand writes: > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > index f88c041..4f3

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

On Wed, Apr 1, 2015 at 4:26 PM, Ilia Mirkin wrote: > On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: >> On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >>> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: > From: Rob Clar

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

On Wed, Apr 1, 2015 at 4:26 PM, Ilia Mirkin wrote: > On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: >> On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >>> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: > From: Rob Clar

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

On Wed, Apr 1, 2015 at 7:14 PM, Connor Abbott wrote: > On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: >> On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: >>> On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark --- src/

Re: [Mesa-dev] [PATCH] nir/print: Correctly print swizzles for explicitly sized alu sources

Reviewed-by: Connor Abbott On Wed, Apr 1, 2015 at 7:17 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_print.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c > index 53fada8..fb8c934 1006

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

On Wed, Apr 1, 2015 at 4:20 PM, Rob Clark wrote: > On Wed, Apr 1, 2015 at 6:56 PM, Jason Ekstrand wrote: >> On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Freedreno and vc4 want this behavior for the time being (until we have >>> real flow control). Even after th

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

I think it might be better here if we had a callback that backends can fill in that tells you when an instruction can be pulled out by the sel peephole. As Jason noted, you won't be able to do this for everything (notably, output writes and variable writes) and we'll probably need special handling

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

On Wed, Apr 1, 2015 at 6:56 PM, Jason Ekstrand wrote: > On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Freedreno and vc4 want this behavior for the time being (until we have >> real flow control). Even after that, we probably want to turn this into >> some sort of dr

[Mesa-dev] [PATCH] i965/generator: Get rid of the ! in the unreachable statement

--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index f88c041..4f39f73 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp

[Mesa-dev] [PATCH] nir/print: Correctly print swizzles for explicitly sized alu sources

--- src/glsl/nir/nir_print.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index 53fada8..fb8c934 100644 --- a/src/glsl/nir/nir_print.c +++ b/src/glsl/nir/nir_print.c @@ -137,21 +137,21 @@ print_de

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

On Wed, Apr 1, 2015 at 6:49 PM, Jason Ekstrand wrote: > On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: >> On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Signed-off-by: Rob Clark >>> --- >>> src/glsl/nir/nir_opcodes.py | 4 ++-- >>> 1 file changed, 2 inserti

Re: [Mesa-dev] Mesa (master): nir/print: Don't print extra swizzzle components

On Wed, Apr 1, 2015 at 1:52 PM, Connor Abbott wrote: > On Wed, Apr 1, 2015 at 4:44 PM, Eric Anholt wrote: >> Jason Ekstrand writes: >> >>> Module: Mesa >>> Branch: master >>> Commit: 793a94d6b5fc589ca8d7475347def4e222cd3d7c >>> URL: >>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=793a94

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: > From: Rob Clark > > Freedreno and vc4 want this behavior for the time being (until we have > real flow control). Even after that, we probably want to turn this into > some sort of driver tunable threshold, since for at least some hardware, > re

Re: [Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

On Tue, Mar 31, 2015 at 4:10 PM, Ilia Mirkin wrote: > On Tue, Mar 31, 2015 at 6:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/nir/nir_opcodes.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/glsl/nir/nir_opcod

[Mesa-dev] [PATCH 2/4] nir: Add an interface to turn a nir_src into a nir_ssa_def.

We use nir_ssa_defs for nir_builder args, so this takes a nir_src and makes one so it can be passed in. --- src/glsl/nir/nir_builder.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h index ecbdbe3..587d014 100644 ---

[Mesa-dev] [PATCH 4/4] i965: Use the tex projector lowering pass instead of hand-rolling it.

This only impacts the ARB_fp path. We can't quite disable the GLSL-level lowering pass, because it needs to apply before brw_do_lower_unnormalized_offset(). --- Note: I haven't fully piglited this. It sounds like there are nice automated systems for regression testing now. src/mesa/drivers/dri/

[Mesa-dev] [PATCH 1/4] nir: Add an interface for the builder to insert instructions before.

So far we'd only used nir_builder to build brand new programs. But if we're doing modifications to instructions (like in a lowering pass), then we want to generate new stuff before the instruction we're modifying. --- src/glsl/nir/nir_builder.h | 27 +++ 1 file changed, 23

[Mesa-dev] [PATCH 3/4] nir: Add a lowering pass for texture projectors.

Not much hardware wants them these days, and it might give us a chance to do CSE or algebraic at the NIR level. --- I wrote this originally for vc4, but I'm not sure I'm going to turn it on -- I'm using a non-Newton-Raphson RCP in my TXP handling right now, and if I do this pass then I get the N-R

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #12 from Tom Stellard --- (In reply to Tom Stellard from comment #11) > Are these these same patches you sent to the mailing list? Do you have any interest in fixing up these patches? If not, I may give it a try. -- You are receiv

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

Rob Clark writes: > From: Rob Clark > > Freedreno and vc4 want this behavior for the time being (until we have > real flow control). Even after that, we probably want to turn this into > some sort of driver tunable threshold, since for at least some hardware, > reasonably large if/else is best

Re: [Mesa-dev] Mesa (master): nir/print: Don't print extra swizzzle components

On Wed, Apr 1, 2015 at 4:44 PM, Eric Anholt wrote: > Jason Ekstrand writes: > >> Module: Mesa >> Branch: master >> Commit: 793a94d6b5fc589ca8d7475347def4e222cd3d7c >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=793a94d6b5fc589ca8d7475347def4e222cd3d7c >> >> Author: Jason Ekstrand

Re: [Mesa-dev] Mesa (master): nir/print: Don't print extra swizzzle components

Jason Ekstrand writes: > Module: Mesa > Branch: master > Commit: 793a94d6b5fc589ca8d7475347def4e222cd3d7c > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=793a94d6b5fc589ca8d7475347def4e222cd3d7c > > Author: Jason Ekstrand > Date: Mon Mar 23 18:20:21 2015 -0700 > > nir/print: Don'

[Mesa-dev] [PATCH] glsl: check for forced_language_version in is_version()

This is a follow-on fix from the earlier "glsl: allow ForceGLSLVersion to override #version directives" change. Since we're not changing the language_version field, we have to check forced_language_version here. --- src/glsl/glsl_parser_extras.h | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH] mesa: add ARB_depth_buffer_float to ES3.0 required extension list

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: add ARB_depth_buffer_float to ES3.0 required extension list

Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 8e0c3ef..7c6d994 100644 --- a/src/mesa/main/version.c +++ b/src/mesa/main/version.c @@ -382,6 +382,7 @@ compute_version_es2(const stru

Re: [Mesa-dev] [PATCH 1/2] i965: Create a has_side_effects for fs_inst

On Wed, Apr 1, 2015 at 10:39 AM, Ben Widawsky wrote: > When an instruction has a side effect, it impacts the available options when > reordering an instruction. As the EOT flag is an implied write to the render > target in the FS, it can be considered a side effect. > > This patch shouldn't actual

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Combine tex/fb_write operations (opt)

On Wednesday, April 01, 2015 10:39:17 AM Ben Widawsky wrote: > Certain platforms support the ability to sample from a texture, and write it > out > to the file RT - thus saving a costly send instructions (note that this is a > potnential win if one wanted to backport to a tag that didn't have the

Re: [Mesa-dev] [PATCH 1/2] i965: Create a has_side_effects for fs_inst

On Wednesday, April 01, 2015 10:39:16 AM Ben Widawsky wrote: > When an instruction has a side effect, it impacts the available options when > reordering an instruction. As the EOT flag is an implied write to the render > target in the FS, it can be considered a side effect. > > This patch shouldn'

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On 01/04/15 20:25, Brian Paul wrote: On 04/01/2015 01:15 PM, Jose Fonseca wrote: On 01/04/15 19:49, Brian Paul wrote: On 04/01/2015 12:02 PM, Eric Anholt wrote: Module: Mesa Branch: master Commit: 783ad697d25e754ab719ab6c715969c35dbe867b URL: https://urldefense.proofpoint.com/v2/url?u=http-3A_

Re: [Mesa-dev] [PATCH] gallium: sihp tgsi_to_nir.h in the tarball

On 01/04/15 19:21, Matt Turner wrote: > Feel free to just push changes like this. > > Acked-by: Matt Turner > Will do. Thanks. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] configure: nuke --with-max-{width,height}

On 04/01/2015 12:21 PM, Emil Velikov wrote: On 01/04/15 15:07, Brian Paul wrote: On 04/01/2015 08:51 AM, Emil Velikov wrote: Unused as of commit 630ab0d27ba(mesa: remove last of MAX_WIDTH, MAX_HEIGHT). Update all the remaining references to the defines. XXX: Does the updated comments in xlib-l

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On 04/01/2015 01:15 PM, Jose Fonseca wrote: On 01/04/15 19:49, Brian Paul wrote: On 04/01/2015 12:02 PM, Eric Anholt wrote: Module: Mesa Branch: master Commit: 783ad697d25e754ab719ab6c715969c35dbe867b URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

Am 01.04.2015 um 20:11 schrieb Matt Turner: > On Tue, Mar 31, 2015 at 6:44 PM, Rob Clark wrote: >> On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger >> wrote: >>> So if this is not enough precision, maybe should state how large the >>> error can be? >>> >> >> tbh, if I knew what the error for

Re: [Mesa-dev] [PATCH] gallium: sihp tgsi_to_nir.h in the tarball

Feel free to just push changes like this. Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] configure.ac: error out if python/mako is not found when required

On Wed, Apr 1, 2015 at 12:04 PM, Emil Velikov wrote: > In case of using a distribution tarball (or a dirty git tree) one can > have the generated sources locally. Make configure.ac error out > otherwise, to alert that about the unmet requirement(s) of python/mako. > > v2: Check only for a single f

Re: [Mesa-dev] [PATCH v2] i965/skl: Fix the order of the arguments for the LD sampler message

On Monday, March 09, 2015 05:17:56 PM Neil Roberts wrote: > In Skylake the order of the arguments for sample messages with the LD > type are u, v, lod, r whereas previously they were u, lod, v, r. > > This fixes 144 Piglit tests including ones that directly use > texelFetch and also some using the

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On 01/04/15 19:49, Brian Paul wrote: On 04/01/2015 12:02 PM, Eric Anholt wrote: Module: Mesa Branch: master Commit: 783ad697d25e754ab719ab6c715969c35dbe867b URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D783ad697d25e754ab719ab6c715969c35dbe

[Mesa-dev] [PATCH] gallium: sihp tgsi_to_nir.h in the tarball

Signed-off-by: Emil Velikov --- src/gallium/auxiliary/Makefile.sources | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/Makefile.sources b/src/gallium/auxiliary/Makefile.sources index bd8e949..ec7547c 100644 --- a/src/gallium/auxiliary/Makefile.sources

[Mesa-dev] [PATCH v2] configure.ac: error out if python/mako is not found when required

In case of using a distribution tarball (or a dirty git tree) one can have the generated sources locally. Make configure.ac error out otherwise, to alert that about the unmet requirement(s) of python/mako. v2: Check only for a single file for each dependency. Cc: Matt Turner Suggested-by: Matt T

Re: [Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

Hmm, I don't trust myself with gotos yet because I still don't have much experience writing them. So maybe I'll use them for a different patch later. On Wed, Apr 1, 2015 at 11:56 AM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > An alternative, btw, is to do a goto to the existing unlock.

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On Wed, Apr 1, 2015 at 2:53 PM, Brian Paul wrote: > On 04/01/2015 12:49 PM, Brian Paul wrote: >> >> On 04/01/2015 12:02 PM, Eric Anholt wrote: >>> >>> Module: Mesa >>> Branch: master >>> Commit: 783ad697d25e754ab719ab6c715969c35dbe867b >>> URL: >>> >>> https://urldefense.proofpoint.com/v2/url?u=ht

Re: [Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

Reviewed-by: Ilia Mirkin An alternative, btw, is to do a goto to the existing unlock. This would have the advantage of keeping a single unlock, and a single return path in the function. Your call, you get the R-b either way. -ilia On Wed, Apr 1, 2015 at 2:23 PM, Laura Ekstrand wrote: > Ilia

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On 04/01/2015 12:49 PM, Brian Paul wrote: On 04/01/2015 12:02 PM, Eric Anholt wrote: Module: Mesa Branch: master Commit: 783ad697d25e754ab719ab6c715969c35dbe867b URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D783ad697d25e754ab719ab6c715969c

Re: [Mesa-dev] [PATCH 4/9] nir: Move the compare-with-zero optimizations to the late section

On Tue, Mar 31, 2015 at 11:04 AM, Matt Turner wrote: > On Mon, Mar 23, 2015 at 8:43 PM, Jason Ekstrand wrote: >> On Mon, Mar 23, 2015 at 8:34 PM, Matt Turner wrote: >>> On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand >>> wrote: total instructions in shared programs: 4422307 -> 4422363 (0.

Re: [Mesa-dev] Mesa (master): gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

On 04/01/2015 12:02 PM, Eric Anholt wrote: Module: Mesa Branch: master Commit: 783ad697d25e754ab719ab6c715969c35dbe867b URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D783ad697d25e754ab719ab6c715969c35dbe867b&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67L

Re: [Mesa-dev] [PATCH 2/2] configure.ac: error out if python/mako is not found when required

On 01/04/15 17:44, Matt Turner wrote: > On Mon, Mar 23, 2015 at 10:49 AM, Emil Velikov > wrote: >> In case of using a distribution tarball (or a dirty git tree) one can >> have the generated sources locally. Make configure.ac error out >> otherwise, to alert that about the unmet requirement(s) of

[Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

Ilia Mirkin found that I had forgotten to free the mutex in the error case. --- src/mesa/main/bufferobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b67e1c4..c7ef90b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/buff

Re: [Mesa-dev] [PATCH] configure: nuke --with-max-{width,height}

On 01/04/15 15:07, Brian Paul wrote: > On 04/01/2015 08:51 AM, Emil Velikov wrote: >> Unused as of commit 630ab0d27ba(mesa: remove last of MAX_WIDTH, >> MAX_HEIGHT). Update all the remaining references to the defines. >> >> XXX: Does the updated comments in xlib-libGL make sense, or should one >> c

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

On Tue, Mar 31, 2015 at 6:44 PM, Rob Clark wrote: > On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger > wrote: >> So if this is not enough precision, maybe should state how large the >> error can be? >> > > tbh, if I knew what the error for this approach was, I would have > included it. I'm n

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

On Wed, Apr 1, 2015 at 11:39 AM, Roland Scheidegger wrote: > Am 01.04.2015 um 15:50 schrieb Ilia Mirkin: >> On Wed, Apr 1, 2015 at 7:09 AM, Roland Scheidegger >> wrote: >>> Am 01.04.2015 um 03:44 schrieb Rob Clark: On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger wrote: > Am 0

Re: [Mesa-dev] [PATCH 1/5] mesa: remove unused macros from colormac.h

Thanks. BTW, there's more #includes of colormac.h in the DRI drivers that could probably be removed, but I don't have time to do that and test them right now. -Brian On 04/01/2015 11:51 AM, Mark Janes wrote: Series Reviewed-by: Mark Janes Brian Paul writes: --- src/mesa/main/colormac.

Re: [Mesa-dev] [PATCH 1/5] mesa: remove unused macros from colormac.h

Series Reviewed-by: Mark Janes Brian Paul writes: > --- > src/mesa/main/colormac.h | 45 - > 1 file changed, 45 deletions(-) > > diff --git a/src/mesa/main/colormac.h b/src/mesa/main/colormac.h > index bc69f46..33ca5af 100644 > --- a/src/mesa/main/co

Re: [Mesa-dev] [PATCH] configure: nuke --with-max-{width,height}

Note that gl_constants can be calculated without gl_context. It's how the GL versions are calculated for GLX_MESA_query_renderer. There's also pipe_screen that can be used to get the equivalent of MaxRenderbufferSize. Marek On Wed, Apr 1, 2015 at 5:07 PM, Brian Paul wrote: > On 04/01/2015 08:51

Re: [Mesa-dev] [PATCH 2/2] configure.ac: error out if python/mako is not found when required

On Mon, Mar 23, 2015 at 10:49 AM, Emil Velikov wrote: > In case of using a distribution tarball (or a dirty git tree) one can > have the generated sources locally. Make configure.ac error out > otherwise, to alert that about the unmet requirement(s) of python/mako. > > Cc: Matt Turner > Suggested

[Mesa-dev] [PATCH 1/2] i965: Create a has_side_effects for fs_inst

When an instruction has a side effect, it impacts the available options when reordering an instruction. As the EOT flag is an implied write to the render target in the FS, it can be considered a side effect. This patch shouldn't actually have any impact on the current code since the EOT flag impli

[Mesa-dev] [PATCH 2/2] i965/fs: Combine tex/fb_write operations (opt)

Certain platforms support the ability to sample from a texture, and write it out to the file RT - thus saving a costly send instructions (note that this is a potnential win if one wanted to backport to a tag that didn't have the patch from Topi which removed excess MOVs from LOAD_PAYLOAD - 97caf5fa

Re: [Mesa-dev] [PATCH 1/5] mesa: remove unused macros from colormac.h

Feels silly giving R-b, so the series is (which I think is probably sufficient for you to push) Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/23] main: Add entry point for CreateBuffers.

Yes, you are right. Thanks for the catch. I will send a fix patch to the mailing list. Laura On Mon, Mar 30, 2015 at 7:10 PM, Ilia Mirkin wrote: > On Wed, Feb 11, 2015 at 9:05 PM, Laura Ekstrand > wrote: > > for (i = 0; i < n; i++) { > > - _mesa_HashInsert(ctx->Shared->BufferObjects

Re: [Mesa-dev] [PATCH] nir: add support for structured COME FROM

Connor Abbott writes: > Unfortunately, we can't support unstructured COME FROM yet, since we > can't structurize arbitrary control flow graphs. Also TODO is adding > support for threading by having multiple come_from's point to the same > unconditional branch, as well as various other INTERCAL fe

Re: [Mesa-dev] [PATCH 3/3] glsl: Reassociate multiplication of mat*mat*vec.

On Mon, Mar 30, 2015 at 11:54 AM, Matt Turner wrote: > On Sat, Mar 28, 2015 at 11:03 AM, Jason Ekstrand wrote: >> On Fri, Mar 27, 2015 at 9:22 PM, Matt Turner wrote: >>> The typical case of mat4*mat4*vec4 is 80 scalar multiplications, but >>> mat4*(mat4*vec4) is only 32. >>> >>> On HSW (with vec

[Mesa-dev] [PATCH] configure.ac: remove deprecated --with-libclc-path

The option was deprecated with commit 959e83d6507(clover: Adapt libclc's INCLUDEDIR and LIBEXECDIR to make use of the new introduced libclc.pc.) back in 2012 with mesa 9.2. Cc: Tom Stellard Signed-off-by: Emil Velikov --- configure.ac | 13 - 1 file changed, 13 deletions(-) diff --

[Mesa-dev] [PATCH 1/5] mesa: remove unused macros from colormac.h

--- src/mesa/main/colormac.h | 45 - 1 file changed, 45 deletions(-) diff --git a/src/mesa/main/colormac.h b/src/mesa/main/colormac.h index bc69f46..33ca5af 100644 --- a/src/mesa/main/colormac.h +++ b/src/mesa/main/colormac.h @@ -52,70 +52,25 @@ _mesa_u

[Mesa-dev] [PATCH 5/5] mesa: don't include colormac.h in format code

--- src/mesa/main/format_pack.py | 1 - src/mesa/main/format_unpack.h | 2 ++ src/mesa/main/format_unpack.py | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/format_pack.py b/src/mesa/main/format_pack.py index f141da8..2f43a30 100644 --- a/src/mesa/main/format

[Mesa-dev] [PATCH 4/5] mesa: remove unneeded #include of colormac.h

--- src/mesa/main/attrib.c | 1 - src/mesa/main/debug.c| 2 +- src/mesa/main/pixel.c| 1 - src/mesa/main/pixeltransfer.c| 2 +- src/mesa/main/samplerobj.h | 3 +++ src/mesa/main/texcompress.c | 1 - src/mesa/main/texcompress_fxt1.c | 1 - src/mesa/m

[Mesa-dev] [PATCH 2/5] swrast: remove unneeded #include of colormac.h

--- src/mesa/swrast/s_aatriangle.c | 1 - src/mesa/swrast/s_alpha.c | 1 - src/mesa/swrast/s_atifragshader.c | 1 - src/mesa/swrast/s_context.c | 1 - src/mesa/swrast/s_copypix.c | 1 - src/mesa/swrast/s_feedback.c| 1 - src/mesa/swrast/s_fog.c

[Mesa-dev] [PATCH 3/5] tnl: remove unneeded #include of colormac.h

--- src/mesa/tnl/t_rasterpos.c | 1 - src/mesa/tnl/t_vb_fog.c | 1 - src/mesa/tnl/t_vb_light.c | 1 - src/mesa/tnl/t_vb_normals.c | 1 - src/mesa/tnl/t_vb_program.c | 1 - src/mesa/tnl/t_vb_texgen.c | 1 - src/mesa/tnl/t_vb_texmat.c | 1 - src/mesa/tnl/t_vb_ver

[Mesa-dev] [PATCH] nir: add support for structured COME FROM

Unfortunately, we can't support unstructured COME FROM yet, since we can't structurize arbitrary control flow graphs. Also TODO is adding support for threading by having multiple come_from's point to the same unconditional branch, as well as various other INTERCAL features. Signed-off-by: Connor A

[Mesa-dev] [PATCH] nir: add support for structured COME FROM

Unfortunately, we can't support unstructured COME FROM yet, since we can't structurize arbitrary control flow graphs. Also TODO is adding support for threading by having multiple come_from's point to the same unconditional branch, as well as various other INTERCAL features. Signed-off-by: Connor A

Re: [Mesa-dev] [PATCH] i965: Give the FS and VEC4 visitors more descriptive names.

On 2015-04-01 02:43:38, Francisco Jerez wrote: > It has always struck me as odd that these objects are both called > visitors even though visiting only makes for a tiny fraction of their > job. Other no less important tasks seem misrepresented, like > optimizing, analyzing, emitting and pretty-pri

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

Am 01.04.2015 um 15:50 schrieb Ilia Mirkin: > On Wed, Apr 1, 2015 at 7:09 AM, Roland Scheidegger wrote: >> Am 01.04.2015 um 03:44 schrieb Rob Clark: >>> On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger >>> wrote: Am 01.04.2015 um 00:57 schrieb Rob Clark: > From: Rob Clark >

Re: [Mesa-dev] [PATCH] configure: nuke --with-max-{width,height}

On 04/01/2015 08:51 AM, Emil Velikov wrote: Unused as of commit 630ab0d27ba(mesa: remove last of MAX_WIDTH, MAX_HEIGHT). Update all the remaining references to the defines. XXX: Does the updated comments in xlib-libGL make sense, or should one consider SWRAST_MAX_WIDTH ? Cc: Brian Paul Signed-

[Mesa-dev] [PATCH] configure: nuke --with-max-{width,height}

Unused as of commit 630ab0d27ba(mesa: remove last of MAX_WIDTH, MAX_HEIGHT). Update all the remaining references to the defines. XXX: Does the updated comments in xlib-libGL make sense, or should one consider SWRAST_MAX_WIDTH ? Cc: Brian Paul Signed-off-by: Emil Velikov --- configure.ac

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.4

Hi On Mon, Mar 30, 2015 at 8:12 AM, Dave Airlie wrote: > From: Dave Airlie > > At the moment to get an EGL image to a dma-buf file descriptor, > you have to use EGL_MESA_drm_image, and then use libdrm to > convert this to a file descriptor. > > This extension just provides an API modelled on EG

  1   2   >