[Mesa-dev] [PATCH] i965: Split Gen4-5 BlitFramebuffer code; prefer BLT over Meta.

A while back I switched intel_blit_framebuffer to prefer Meta over the BLT. This meant that Gen8 platforms would start using the 3D engine for blits, just like we do on Gen6-7.5. However, I hadn't considered Gen4-5 when making that change. The BLT engine appears to be substantially faster on 965

Re: [Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

On Wed, Mar 4, 2015 at 8:18 PM, Matt Turner wrote: > Patches 1-2 are > > Reviewed-by: Matt Turner As are patches 3-7. Thanks Brian! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

On Wed, Mar 4, 2015 at 6:19 PM, Brian Paul wrote: > So it matches the preprocessor check around the u_current_init_tsd() code. > --- > src/mapi/u_current.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mapi/u_current.c b/src/mapi/u_current.c > index afa887e..eb77cc7

Re: [Mesa-dev] [PATCH 01/12] mesa: include c11/threads.h in mtypes.h

On Wed, Mar 4, 2015 at 6:18 PM, Brian Paul wrote: > Let's directly include c11/threads.h instead of relying on glapi.h > to provide it. > --- This one is Reviewed-by: Matt Turner The rest are Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

On Wed, Mar 4, 2015 at 3:00 AM, Emil Velikov wrote: > On 27 February 2015 at 23:28, Sedat Dilek wrote: >> On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov >> wrote: >>> On 07/02/15 21:44, Sedat Dilek wrote: Hi, I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2. M

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 79098, which changed state. Bug 79098 Summary: x86/common_x86.c:51:19: error: cpuid.h: No such file or directory https://bugs.freedesktop.org/show_bug.cgi?id=79098 What|Removed |Added -

[Mesa-dev] [Bug 79098] x86/common_x86.c:51:19: error: cpuid.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=79098 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] State of Geometry shader instancing on radeonsi

Then you can count me as working on ARB_viewport_array. Alexandre Demers On 2015-02-25 14:25, Marek Olšák wrote: Nobody is working on ARB_gpu_shader5 for radeonsi. Marek On Wed, Feb 25, 2015 at 6:41 PM, Ilia Mirkin wrote: On Wed, Feb 25, 2015 at 11:24 AM, Alexandre Demers wrote: Hi ever

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

https://bugs.freedesktop.org/show_bug.cgi?id=89433 --- Comment #1 from Jonathan Gray --- Created attachment 114016 --> https://bugs.freedesktop.org/attachment.cgi?id=114016&action=edit make -Wvla conditional How about the attached patch to make it conditional on the GCC version? -- You are r

[Mesa-dev] [PATCH 12/12] osmesa: include stdio.h

--- src/mesa/drivers/osmesa/osmesa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 9f1a5a8..022523e 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/osmesa.c @@ -33,6 +33,7 @@ */ +#incl

[Mesa-dev] [PATCH 5/7] mapi: THREADS was always defined, remove it

THREADS was defined if HAVE_PTHREADS or _WIN32 was defined. That's always the case. The build would die in c11/threads.h otherwise. --- src/mapi/glapi/gen/gl_x86-64_asm.py | 6 +- src/mapi/glapi/gen/gl_x86_asm.py| 14 ++ src/mapi/glapi/glapi.h | 13 ++---

[Mesa-dev] [PATCH 1/7] mapi: remove u_macros.h

Only U_STRINGIFY() is used in entry.c --- src/mapi/Makefile.sources | 1 - src/mapi/entry.c| 4 +++- src/mapi/entry_x86-64_tls.h | 1 - src/mapi/entry_x86_tls.h| 1 - src/mapi/entry_x86_tsd.h| 1 - src/mapi/u_macros.h | 12 6 files changed, 3 inserti

[Mesa-dev] [PATCH 08/12] st/xlib: include stdio.h

--- src/gallium/state_trackers/glx/xlib/glx_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c b/src/gallium/state_trackers/glx/xlib/glx_api.c index f59b0ba..d1bd760 100644 --- a/src/gallium/state_trackers/glx/xlib/glx_api.c +++ b/src/gallium/s

[Mesa-dev] [PATCH 06/12] swrast: include stdio.h where needed

--- src/mesa/drivers/dri/swrast/swrast.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/swrast/swrast.c b/src/mesa/drivers/dri/swrast/swrast.c index b801476..fb29078 100644 --- a/src/mesa/drivers/dri/swrast/swrast.c +++ b/src/mesa/drivers/dri/swrast/swrast.c @@ -32,6 +32

[Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

So it matches the preprocessor check around the u_current_init_tsd() code. --- src/mapi/u_current.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/u_current.c b/src/mapi/u_current.c index afa887e..eb77cc7 100644 --- a/src/mapi/u_current.c +++ b/src/mapi/u_current.c @@

[Mesa-dev] [PATCH 7/7] mapi: remove u_thread.h

Just use c11 threads directly. --- src/mapi/Makefile.sources | 3 +-- src/mapi/glapi/glapi.h| 1 - src/mapi/mapi.c | 1 - src/mapi/stub.c | 14 +++--- src/mapi/u_current.c | 28 ++-- src/mapi/u_execmem.c | 2 +- 6 files changed,

[Mesa-dev] [PATCH 3/7] mapi: rewrite u_current_init() function without u_thread_self()

Remove u_thread_self() since u_thread.h is going away soon. Create a simple thread ID abstraction which wraps WIN32 or c11 threads. This also gets rid of the questionable casting of thrd_t to an unsigned long. --- src/mapi/u_current.c | 43 --- src/mapi/u_th

[Mesa-dev] [PATCH 11/12] xlib: include stdio.h

--- src/mesa/drivers/x11/fakeglx.c | 2 +- src/mesa/drivers/x11/xfonts.c | 1 + src/mesa/drivers/x11/xm_api.c | 1 + src/mesa/drivers/x11/xm_tri.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index 00c583f..

[Mesa-dev] [PATCH 6/7] mapi: use c11 call_once() instead of pthread_once()

--- src/mapi/glapi/glapi_entrypoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/glapi_entrypoint.c b/src/mapi/glapi/glapi_entrypoint.c index 53104ce..7facd8a 100644 --- a/src/mapi/glapi/glapi_entrypoint.c +++ b/src/mapi/glapi/glapi_entrypoint.c @@ -29

[Mesa-dev] [PATCH 4/7] mesa: remove THREADS check, printf calls in debug.c

THREADS is going away in the next commit. --- src/mesa/main/debug.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/debug.c b/src/mesa/main/debug.c index eda4937..b50d79e 100644 --- a/src/mesa/main/debug.c +++ b/src/mesa/main/debug.c @@ -118,11 +118,6 @@ void _mesa_print_info

[Mesa-dev] [PATCH 10/12] st/osmesa: include stdio.h

--- src/gallium/state_trackers/osmesa/osmesa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/osmesa/osmesa.c b/src/gallium/state_trackers/osmesa/osmesa.c index 4e2b2e0..2d5d096 100644 --- a/src/gallium/state_trackers/osmesa/osmesa.c +++ b/src/gallium/state_tracker

[Mesa-dev] [PATCH 09/12] st/xlib: include stdio.h

--- src/gallium/state_trackers/glx/xlib/glx_usefont.c | 1 + src/gallium/state_trackers/glx/xlib/xm_api.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/glx/xlib/glx_usefont.c b/src/gallium/state_trackers/glx/xlib/glx_usefont.c index f7ee68b..b3e9c79 100644

[Mesa-dev] [PATCH 07/12] st/mesa: include stdio.h where needed

--- src/mesa/state_tracker/st_atom.c | 1 + src/mesa/state_tracker/st_cb_texture.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index 8cc6af2..f0fe11f 100644 --- a/src/mesa/state_tracker/st_atom.c +++ b/src/mesa/sta

[Mesa-dev] [PATCH 03/12] glsl: include stdio.h where needed

--- src/glsl/s_expression.cpp | 1 + src/glsl/standalone_scaffolding.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glsl/s_expression.cpp b/src/glsl/s_expression.cpp index 2928a4d..7eaa491 100644 --- a/src/glsl/s_expression.cpp +++ b/src/glsl/s_expression.cpp @@ -24,6 +24,

[Mesa-dev] [PATCH 04/12] dri/common: include stdio.h where needed

--- src/mesa/drivers/dri/common/utils.c | 1 + src/mesa/drivers/dri/common/xmlconfig.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index ccdc971..bb22107 100644 --- a/src/mesa/drivers/dri/common/utils.c +++ b/

[Mesa-dev] [PATCH 01/12] mesa: include c11/threads.h in mtypes.h

Let's directly include c11/threads.h instead of relying on glapi.h to provide it. --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6e99773..efeee8b 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @

[Mesa-dev] [PATCH 02/12] mesa: include stdio.h where needed

Instead of relying on glapi.h or some other header to provide it. --- src/mesa/main/blit.c | 1 + src/mesa/main/debug.c | 1 + src/mesa/main/dlist.h | 2 +- src/mesa/main/errors.c| 1 + src/mesa/main/execmem.c | 1 + src/mesa/main/framebuf

[Mesa-dev] [PATCH 05/12] nouveau: include stdio.h where needed

--- src/mesa/drivers/dri/nouveau/nouveau_context.c | 1 + src/mesa/drivers/dri/nouveau/nouveau_driver.c | 1 + src/mesa/drivers/dri/nouveau/nouveau_screen.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c b/src/mesa/drivers/dri/nouveau/nouvea

Re: [Mesa-dev] [PATCH] i965: Reserve more batch space to accomodate Gen6 perfmonitors.

On Wed, Mar 4, 2015 at 3:46 PM, Kenneth Graunke wrote: > Ben noticed that I said each PIPE_CONTROL was 4 DWords, but it's > actually 5 DWords on Gen6-7. We've been reserving insufficient space > for performance monitoring on Sandybridge, which means it would likely > break if you used that functi

Re: [Mesa-dev] New stable-branch 10.4 candidate pushed

On Wed, Mar 4, 2015 at 4:53 AM, Emil Velikov wrote: > Trivial merge conflicts > --- > Here are the commits where I manually merged conflicts, so these might > merit additional review: > > commit a598a9bdfe9f5d0ed35ca89a55cf74a2b678e8e1 > Author: Matt Turner > > mesa: Corre

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

On Wed, Mar 4, 2015 at 5:28 PM, Matt Turner wrote: > On Wed, Mar 4, 2015 at 5:07 PM, Jason Ekstrand > wrote: > > On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner wrote: > >> @@ -357,16 +394,22 @@ linear_to_xtiled_faster(uint32_t x0, uint32_t x1, > >> uint32_t x2, uint32_t x3, > >>if (mem_cop

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

On Wed, Mar 4, 2015 at 5:07 PM, Jason Ekstrand wrote: > On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner wrote: >> @@ -357,16 +394,22 @@ linear_to_xtiled_faster(uint32_t x0, uint32_t x1, >> uint32_t x2, uint32_t x3, >>if (mem_copy == memcpy) >> return linear_to_xtiled(0, 0, xtile_wid

Re: [Mesa-dev] [PATCH 1/3] Revert "common: Fix PBOs for 1D_ARRAY."

Series is Reviewed-by: Jason Ekstrand On Wed, Mar 4, 2015 at 3:15 PM, Emil Velikov wrote: > On 4 March 2015 at 17:22, Neil Roberts wrote: > > This reverts commit 546aba143d13ba3f993ead4cc30b2404abfc0202. > > > > I think the changes to the calls to glBlitFramebuffer from this patch > > are no d

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner wrote: > The SSSE3 swizzling code was written for fast uploads to the GPU and > assumed the destination was always 16-byte aligned. When we began using > this code for fast downloads as well we didn't do anything to account > for the fact that the desti

[Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact that the destination pointer given by glReadPixels() or glGetTexImage() is

Re: [Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

On Wed, 2015-03-04 at 09:55 -0800, Ian Romanick wrote: > From: Ian Romanick > > Both the AMD and Intel APIs provide a dataSize parameter, and this > function would merrily ignore it. Neither API specifies what to do when > the buffer isn't big enough. I take the easy route of writing all the >

[Mesa-dev] [PATCH 0/7] v2 of Tex[ture]Buffer[Range] functions

This divides a major rework of Tex[ture]Buffer[Range] into multiple patches as recommended by Anuj Phogat. Laura Ekstrand (7): main: Add utility function _mesa_lookup_bufferobj_err. main: Use _mesa_lookup_bufferobj_err to simplify Tex[ture]Buffer[Range]. main: Refactor _mesa_texture_buff

[Mesa-dev] [PATCH 7/7] main: Add entry point for TextureBufferRange.

v2: Review by Martin Peres - Get rid of difficult-to-follow code copied and pasted from the original TexBufferRange --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 + src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 46

[Mesa-dev] [PATCH 5/7] main: Add check_texture_buffer_range.

Creates a shared function that TexBufferRange and TextureBufferRange can use to check the buffer range. This cleans up TexBufferRange considerably. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 73 ++-

[Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

Adds a useful comment and some whitespace. Fixes an error message. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/texima

[Mesa-dev] [PATCH 6/7] main: Add check_texture_buffer_target.

Creates a shared function to ensure that texture buffer target is GL_TEXTURE_BUFFER. Helps to clean up the Tex[ture]Buffer[Range] functions. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 39 --- 1 file ch

[Mesa-dev] [PATCH 3/7] main: Refactor _mesa_texture_buffer_range.

Changes how the caller is identified in error messages, moves a check for ARB_texture_buffer_object from the entry points to the shared code in _mesa_texture_buffer_range, and removes an unused argument (GLenum target). v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- s

[Mesa-dev] [PATCH 2/7] main: Use _mesa_lookup_bufferobj_err to simplify Tex[ture]Buffer[Range].

v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] - Closing curly brace on the same line as else --- src/mesa/main/teximage.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c i

[Mesa-dev] [PATCH 1/7] main: Add utility function _mesa_lookup_bufferobj_err.

This function is exposed to mesa driver internals so that texture buffer objects and array objects can use it. --- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/buff

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

Assuming my patch to fix 'extern "C"' issues is pushed before this one, Reviewed-by: Mark Janes Jose Fonseca writes: > From: José Fonseca > > This is just to help repro and fixing these issues with any C++ compiler -- > > commiting this will of course wait until all issues are addressed. > >

[Mesa-dev] [PATCH] Fix invalid extern "C" around header inclusion.

System headers may contain C++ declarations, which cannot be given C linkage. For this reason, include statements should never occur inside extern "C". This patch moves the C linkage statements to enclose only the declarations within a single header. --- src/gallium/auxiliary/util/u_math.h

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

On Wed, Mar 4, 2015 at 4:19 PM, Matt Turner wrote: > The SSSE3 swizzling code was written for fast uploads to the GPU and > assumed the destination was always 16-byte aligned. When we began using > this code for fast downloads as well we didn't do anything to account > for the fact that the desti

[Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact that the destination pointer given by glReadPixels() or glGetTexImage() is

Re: [Mesa-dev] [PATCH 2/3] meta: Allow GL_UN/PACK_IMAGE_HEIGHT in _mesa_meta_pbo_Get/TexSubImage

I have a new texturing/getteximage-targets test on the Piglit ML that cleans up the test considerably and causes it to hit these Meta PBO paths. It just hasn't been given R-B's yet. http://patchwork.freedesktop.org/patch/42864/ On Wed, Mar 4, 2015 at 9:22 AM, Neil Roberts wrote: > Now that a la

[Mesa-dev] [PATCH] i965: Reserve more batch space to accomodate Gen6 perfmonitors.

Ben noticed that I said each PIPE_CONTROL was 4 DWords, but it's actually 5 DWords on Gen6-7. We've been reserving insufficient space for performance monitoring on Sandybridge, which means it would likely break if you used that functionality. (Thankfully, no one does...) Signed-off-by: Kenneth G

[Mesa-dev] [PATCH 4/6] main: assert(texImage) in ARB_DSA texture cube map functions.

ARB_direct_state_access functions that deal with texture cube maps need to make sure that texture images are not NULL before operating on them. In the following cases, the error check functions already throw an error if texImage == NULL, so an assert can be raised instead. v2: Review from Anuj Pho

[Mesa-dev] [PATCH 3/6] main: Remove redundant copy of cube map block comment in GetTextureImage.

The comment describing why ARB_direct_state_access texture cube map functions use _mesa_cube_level_complete is very long. To save room in the files, readers are now referred to one central comment on texturesubimage in teximage.c. v2: Review from Anuj Phogat - Remove redundant copies of the cu

[Mesa-dev] [PATCH 5/6] main: Add TEXTURE_CUBE_MAP support for glCompressedTextureSubImage3D.

v2: Review from Anuj Phogat - Remove redundant copies of the cube map block comment - Replace redundant "if (!texImage) return;" statements with assert(texImage) --- src/mesa/main/teximage.c | 158 +++ src/mesa/main/teximage.h | 3 +- 2 file

[Mesa-dev] [PATCH 1/6] main: _mesa_cube_level_complete checks NumLayers.

_mesa_cube_level_complete now verifies that a cube map texture object actually has six texture images before proceeding. --- src/mesa/main/texobj.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index d5aa620..0b200a1 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 6/6] main: Checking for cube completeness in GetCompressedTextureImage.

v2: Review from Anuj Phogat - Remove redundant copies of the cube map block comment - Replace redundant "if (!texImage) return;" statements with assert(texImage) --- src/mesa/main/texgetimage.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH 0/6] v2 of Compressed Textures Cube Map Support

This cleans up ARB_direct_state_access texture cube map functions (mostly in response to reviews from Anuj Phogat). Laura Ekstrand (6): main: _mesa_cube_level_complete checks NumLayers. main: Remove redundant NumLayers checks. main: Remove redundant copy of cube map block comment in GetT

[Mesa-dev] [PATCH 2/6] main: Remove redundant NumLayers checks.

ARB_direct_state_access texture functions that operate on cube maps no longer need to verify that cube map texture objects contain six texture images because _mesa_cube_level_complete now does that for them. --- src/mesa/main/texgetimage.c | 13 - src/mesa/main/teximage.c| 14 -

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=89364 Vinson Lee changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [PATCH] i965/hsw: Implement end of batch workaround

This patch can cause an infinite recursion if the previous patch titled, "i965: Track finished batch state" isn't present (backporters take notice). v2: Sent out the wrong patch originally. This patches switches the order of flushes, doing the generic flush before the CC_STATE, and the required wo

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

https://bugs.freedesktop.org/show_bug.cgi?id=89433 Bug ID: 89433 Summary: GCC 4.2 does not support -Wvla Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: regression

Re: [Mesa-dev] [PATCH 1/3] Revert "common: Fix PBOs for 1D_ARRAY."

On 4 March 2015 at 17:22, Neil Roberts wrote: > This reverts commit 546aba143d13ba3f993ead4cc30b2404abfc0202. > > I think the changes to the calls to glBlitFramebuffer from this patch > are no different to what it was doing previously because it used to > set height to 1 before doing the blits. Ho

[Mesa-dev] [PATCH] mesa/st: remove unused TexData

this isn't hooked up to anything at all from what I can see. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_cb_texture.c | 21 - src/mesa/state_tracker/st_texture.h| 6 -- 2 files changed, 27 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 89292, which changed state. Bug 89292 Summary: [regression,bisected] incomplete screenshots in some cases https://bugs.freedesktop.org/show_bug.cgi?id=89292 What|Removed |Added -

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

Jose Fonseca writes: > From: José Fonseca > > This is just to help repro and fixing these issues with any C++ compiler -- > > commiting this will of course wait until all issues are addressed. Hi Jose, I have a patch which trivially fixes extern "C" in the 14 files identified by no_extern_c.h

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Break down SIMD16 3-source instructions when required.

On Wed, Mar 4, 2015 at 12:53 PM, Kenneth Graunke wrote: > Several steppings of Skylake fail when using SIMD16 with 3-source > instructions (such as MAD). > > This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit > tests. > > Based on a patch by Neil Roberts. > > Signed-off-by: Kenneth G

Re: [Mesa-dev] [PATCH] clover: Enable cl_khr_fp64 for devices that support doubles v4

On Wed, Mar 4, 2015 at 7:47 AM, Tom Stellard wrote: > v2: > - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE > and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. > - Only define cl_khr_fp64 if the extension is supported. > - Remove trailing space from extension string. > - Re

Re: [Mesa-dev] [PATCH 1/2] i965: Refactor SIMD16-to-2xSIMD8 checks.

On Wed, Mar 4, 2015 at 12:53 PM, Kenneth Graunke wrote: > Gathering all the checks into a single place makes it easier to add new > workarounds. > > Signed-off-by: Kenneth Graunke > Cc: Neil Roberts > Cc: Matt Turner > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 28 +-- >

[Mesa-dev] [PATCH 2/2] i965/skl: Break down SIMD16 3-source instructions when required.

Several steppings of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. Based on a patch by Neil Roberts. Signed-off-by: Kenneth Graunke Cc: Neil Roberts Cc: Matt Turner --- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 1/2] i965: Refactor SIMD16-to-2xSIMD8 checks.

Gathering all the checks into a single place makes it easier to add new workarounds. Signed-off-by: Kenneth Graunke Cc: Neil Roberts Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 28 +-- src/mesa/drivers/dri/i965/brw_shader.cpp | 48

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Silence unused parameter warning

On Wed, Mar 4, 2015 at 8:45 AM, Ian Romanick wrote: > On 03/01/2015 05:19 PM, Jason Ekstrand wrote: > > Not sure why you Cc'd me, but whatever. Seems obvious enough. > > Because b18fd23 was your commit. Sometimes left over, unused parameters > are the result of a mistake. I just wanted to be s

Re: [Mesa-dev] [PATCH 5/6] main: Refactor Tex[ture]Buffer[Range].

On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > Uses _mesa_lookup_bufferobj_err to clean up buffer object retrieval. Moves > error checking statements into separate functions to allow code sharing > between traditional and ARB_direct_state_access entry points. It's little difficult to fo

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Disable SIMD16 when 3-source instructions are used

On Wed, Mar 4, 2015 at 6:33 AM, Neil Roberts wrote: > Stepping C0 of Skylake fails when using SIMD16 with 3-source > instructions (such as MAD). This patch just makes it disable SIMD16 in > that case. > > This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit > tests. > --- We already h

Re: [Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

On Tue, Mar 3, 2015 at 5:39 PM, Laura Ekstrand wrote: > I also need it in teximage.c for Texture Buffer objects. > Right. That's just one file in this series. Mention it in the commit message If you're aware of future use of this function in multiple files. > On Tue, Mar 3, 2015 at 5:24 PM, Fredr

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On Wed, Mar 04, 2015 at 10:28:16AM -0800, Chad Versace wrote: > On 03/04/2015 09:52 AM, Chris Wilson wrote: > > The manpage for glFlush says > > > > "glFlush can return at any time. It does not wait until the execution of > > *all* > > previously issued GL commands is complete." > > > > Emphasi

Re: [Mesa-dev] [PATCH] mapi: fix build after 8aa9191878a5608fc6e4e8c72bea1d25cd821dec

Reviewed-by: Jose Fonseca On 04/03/15 17:49, Mark Janes wrote: Due to recent #include changes, `make check` fails on glx-test. The target requires a standard include path to find util/macros.h. --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/M

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On 03/04/2015 09:52 AM, Chris Wilson wrote: > On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: >> On 02/26/2015 05:24 AM, Chris Wilson wrote: >>> When rendering to an fbo, even though it may be acting as a winsys >>> frontbuffer or just generally, we never throttle. However, when rende

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

Am 04.03.2015 um 12:38 schrieb Jose Fonseca: > On 04/03/15 02:00, Emil Velikov wrote: >> On 27 February 2015 at 23:28, Sedat Dilek wrote: >>> On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov >>> wrote: On 07/02/15 21:44, Sedat Dilek wrote: > Hi, > > I was building mesa v10.4.4 with m

Re: [Mesa-dev] [PATCH] mapi: fix build after 8aa9191878a5608fc6e4e8c72bea1d25cd821dec

Brian also sent this patch, and I sent his a R-b because I saw it first. :) On 03/04/2015 09:49 AM, Mark Janes wrote: > Due to recent #include changes, `make check` fails on glx-test. The > target requires a standard include path to find util/macros.h. > --- > src/glx/tests/Makefile.am | 1 + >

Re: [Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

Right. -Brian On 03/04/2015 10:56 AM, Ian Romanick wrote: Due to 0339e7db, right? If so, Reviewed-by: Ian Romanick On 03/04/2015 09:03 AM, Brian Paul wrote: --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefi

Re: [Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

Due to 0339e7db, right? If so, Reviewed-by: Ian Romanick On 03/04/2015 09:03 AM, Brian Paul wrote: > --- > src/glx/tests/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am > index dd82449..b02a9e3 100644 > --- a/src/glx/t

[Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

From: Ian Romanick Both the AMD and Intel APIs provide a dataSize parameter, and this function would merrily ignore it. Neither API specifies what to do when the buffer isn't big enough. I take the easy route of writing all the complete bits of data that will fit. With more complete specs, we

Re: [Mesa-dev] [PATCH v2] i965/skl: Disable SIMD16 when 3-source instructions are used

On Wed, Mar 4, 2015 at 9:20 AM, Neil Roberts wrote: > Steppings C0 and D0 of Skylake fail when using SIMD16 with 3-source > instructions (such as MAD). This patch just makes it disable SIMD16 in > those cases. > > This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit > tests. > > v2: Al

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: > On 02/26/2015 05:24 AM, Chris Wilson wrote: > > When rendering to an fbo, even though it may be acting as a winsys > > frontbuffer or just generally, we never throttle. However, when rendering > > to an fbo, there is no natural frame b

[Mesa-dev] [PATCH] mapi: fix build after 8aa9191878a5608fc6e4e8c72bea1d25cd821dec

Due to recent #include changes, `make check` fails on glx-test. The target requires a standard include path to find util/macros.h. --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am index dd82449..4db01c0 100644

Re: [Mesa-dev] [PATCH 1/2] i965: Store the GPU revision number in brw_context

On Wed, Mar 4, 2015 at 6:32 AM, Neil Roberts wrote: > brwContextInit now queries the GPU revision number via a new parameter > for DRM_I915_GETPARAM. This new parameter requires a kernel patch and > a patch to libdrm. If the kernel doesn't support it then it will > continue but set the revision nu

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On 02/26/2015 05:24 AM, Chris Wilson wrote: > When rendering to an fbo, even though it may be acting as a winsys > frontbuffer or just generally, we never throttle. However, when rendering > to an fbo, there is no natural frame boundary. Conventionally we use > SwapBuffers and glFinish, but potenti

[Mesa-dev] [PATCH 1/3] Revert "common: Fix PBOs for 1D_ARRAY."

This reverts commit 546aba143d13ba3f993ead4cc30b2404abfc0202. I think the changes to the calls to glBlitFramebuffer from this patch are no different to what it was doing previously because it used to set height to 1 before doing the blits. However it was introducing some problems with the blit for

[Mesa-dev] [PATCH 2/3] meta: Allow GL_UN/PACK_IMAGE_HEIGHT in _mesa_meta_pbo_Get/TexSubImage

Now that a layered source PBO is interpreted as a single tall 2D image it's quite easy to accept the image height packing option by just creating an image that is tall enough to include the image padding. I'm not sure whether the image height property should affect 1D_ARRAY textures. My intuition

[Mesa-dev] [PATCH 3/3] meta: Fix the y offset for 1D_ARRAY in _mesa_meta_pbo_TexSubImage

The yoffset needs to be interpreted as a slice offset for 1D array textures. This patch implements that by moving the yoffset into zoffset similar to how it moves the height into depth. --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 8 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH v2] i965/skl: Disable SIMD16 when 3-source instructions are used

Steppings C0 and D0 of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This patch just makes it disable SIMD16 in those cases. This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. v2: Also apply on stepping D0 --- Damien Lespiau pointed out that the wo

Re: [Mesa-dev] [PATCH 2/2] common: Correct PBO 2D_ARRAY handling.

The Meta PBO upload path does not exist in 10.4, so we don't need to worry about a backport. On Tue, Mar 3, 2015 at 6:01 PM, Emil Velikov wrote: > On 24 February 2015 at 23:20, Laura Ekstrand wrote: > > Changes PBO uploads and downloads to use a tall (height * depth) 2D > texture > > for blitti

[Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

--- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am index dd82449..b02a9e3 100644 --- a/src/glx/tests/Makefile.am +++ b/src/glx/tests/Makefile.am @@ -2,6 +2,7 @@ if HAVE_SHARED_GLAPI AM_CFLAGS = $(PTHREAD_CFLAGS)

Re: [Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

Hi Brian, Did you try to `make check` in mesa with these patches? I get errors compiling glx-test: src/glx/glxclient.h:59:25: fatal error: util/macros.h: No such file or directory -Mark Brian Paul writes: > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- > 1 file changed, 1 inse

[Mesa-dev] [PATCH] clover: Enable cl_khr_fp64 for devices that support doubles v4

v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to has_doubles(

Re: [Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

On 02/28/2015 10:33 AM, Ilia Mirkin wrote: > On Sat, Feb 28, 2015 at 1:26 PM, Carl Worth wrote: >> On Fri, Feb 27 2015, Ian Romanick wrote: >>> All dd functions take a gl_context as the first parameter. Instead of >>> removing it, just silence the warning. >> >> For code using gcc, I really prefe

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Silence unused parameter warning

On 03/01/2015 05:19 PM, Jason Ekstrand wrote: > Not sure why you Cc'd me, but whatever. Seems obvious enough. Because b18fd23 was your commit. Sometimes left over, unused parameters are the result of a mistake. I just wanted to be sure. > Reviewed-by: Jason Ekstrand > On 02/27/2015 06:50 PM,

Re: [Mesa-dev] [PATCH 1/4] scons: Use -Werror MSVC compatibility flags per-directory.

Series LGTM. Reviewed-by: Brian Paul On 03/04/2015 07:27 AM, Jose Fonseca wrote: Matching what we already do with autotools builds. --- scons/gallium.py| 27 --- src/egl/main/SConscript | 2 ++ src/gallium/auxiliary/SConscrip

Re: [Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

On 03/04/2015 07:08 AM, Jose Fonseca wrote: On 04/03/15 12:58, Jose Fonseca wrote: On 04/03/15 04:20, Matt Turner wrote: On Tue, Mar 3, 2015 at 8:07 PM, Brian Paul wrote: --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Disable SIMD16 when 3-source instructions are used

Ilia Mirkin writes: > On Wed, Mar 4, 2015 at 9:33 AM, Neil Roberts wrote: >> Stepping C0 of Skylake fails when using SIMD16 with 3-source >> instructions (such as MAD). This patch just makes it disable SIMD16 in >> that case. >> >> This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit

Re: [Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

On Wed, 2015-03-04 at 15:35 +0100, Kai Wasserbäch wrote: > Samuel Iglesias Gonsálvez wrote on 04.03.2015 07:54: > > On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote: > >> Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56: > >>> This output variables gives more flexibility for future change

  1   2   >