Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Tapani Pälli
Hi; On 06/02/2014 08:44 PM, Benjamin Bellec wrote: > Hello, > > This patch set prevents me from launching Steam. > I'm on r600g (Radeon HD5850 Evergreen). Thanks for testing the patches! What I forgot to state in the mail was that I've only been able to test this with Intel i965 driver, things mi

Re: [Mesa-dev] [PATCH 5/5] r600g, radeonsi: don't use hardware MSAA resolve if dst is fast-cleared

2014-06-02 Thread Michel Dänzer
The radeonsi related changes in this series are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list

[Mesa-dev] [PATCH:mesa] Use -z defs instead of --no-undefined on Solaris

2014-06-02 Thread Alan Coopersmith
While recent versions of the Solaris linker support --no-undefined, older ones do not, and even current ones get confused if the Makefile passes one form and libtool sneaks in the other. Signed-off-by: Alan Coopersmith --- configure.ac |2 ++ 1 file changed, 2 insertions(+) diff --git a/con

Re: [Mesa-dev] [PATCH 05/19] i965/fs: Loop from 0 to inst->sources, not 0 to 3.

2014-06-02 Thread Kenneth Graunke
On Monday, June 02, 2014 03:48:23 PM Ian Romanick wrote: > On 05/31/2014 10:11 PM, Kenneth Graunke wrote: > > On Tuesday, May 27, 2014 06:47:36 PM Matt Turner wrote: > > [snip] > >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > > b/src/mesa/drivers/dri/i965/brw_fs_copy_propa

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-02 Thread Bruno Jimenez
On Mon, 2014-06-02 at 16:16 -0400, Alex Deucher wrote: > On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez wrote: > > On Fri, 2014-05-30 at 19:33 -0400, Alex Deucher wrote: > >> On Fri, May 30, 2014 at 11:31 AM, Bruno Jiménez > >> wrote: > >> > The data has been extracted from: > >> > AMD Accelerat

Re: [Mesa-dev] ARB_sso layout() + other qualifiers

2014-06-02 Thread Chris Forbes
On Tue, Jun 3, 2014 at 11:17 AM, Ian Romanick wrote: > Do you mean supported or enabled (in the shader)? > ARB_shading_language_420pack is supported by every driver that supports > GLSL 1.30. I mean enabled in the shader, sorry. ___ mesa-dev mailing lis

Re: [Mesa-dev] ARB_sso layout() + other qualifiers

2014-06-02 Thread Ian Romanick
On 05/19/2014 10:06 PM, Chris Forbes wrote: > Hi Ian, > > When I was writing the `precise` support I found some error cases in > the GLSL parser where we reject combinations of layout() with > invariant / interpolation / etc qualifiers. > > This seems to be consistent with the GLSL 1.50 grammar (

Re: [Mesa-dev] [PATCH 05/19] i965/fs: Loop from 0 to inst->sources, not 0 to 3.

2014-06-02 Thread Ian Romanick
On 05/31/2014 10:11 PM, Kenneth Graunke wrote: > On Tuesday, May 27, 2014 06:47:36 PM Matt Turner wrote: > [snip] >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp >> index 069b60f..a1aff21 100644 >> --- a/src/mesa/drive

Re: [Mesa-dev] [RFC PATCH 00/11] Add support for ARB_compressed_texture_pixel_storage

2014-06-02 Thread Ian Romanick
On 06/01/2014 11:29 PM, Chris Forbes wrote: > This series adds support for ARB_compressed_texture_pixel_storage from GL4.2. > This > provides a convenient way to update a subrectangle of a compressed texture > from client memory or a pixel buffer object, without having to rearrange the > client

Re: [Mesa-dev] [PATCH 10/11] mesa: Add pixel storage support for GetCompressedTexImage

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/texgetimage.c | 73 > + > 1 file changed, 40 insertions(+), 33 deletions(-) > > diff --git a/src/mesa/main/texge

Re: [Mesa-dev] [PATCH] i965: Put '_default_' in the name of functions that set default state.

2014-06-02 Thread Ian Romanick
On 06/01/2014 12:16 AM, Kenneth Graunke wrote: > Eventually we're going to use functions to set bits on an instruction. > Putting 'default' in the name of functions that alter default state will > help distinguins them. ^^^ distinguish or pengiuns Reviewed-by: Ian Romanick > This

Re: [Mesa-dev] [PATCH 09/11] mesa: Compute proper strides for compressed texture pixel storage.

2014-06-02 Thread Ian Romanick
I really had to stare at this for a long time. Hopefully someone else can look at it too. Either way, this patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/texstore.c | 35 +++ >

Re: [Mesa-dev] [PATCH 08/11] mesa: Extract computation of compressed pixel store params

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > This logic is reusable across CompressedTex*Image* and > GetCompressedTexImage; the strides calculated will also be needed > in the PBO validation functions to ensure that the referenced range of > bytes is val

Re: [Mesa-dev] [PATCH 07/11] mesa: Emit errors for inconsistent compressed pixel store state

2014-06-02 Thread Ian Romanick
Other than the nit below, this patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/texgetimage.c | 10 +- > src/mesa/main/teximage.c| 45 > + > src/mesa/main/

Re: [Mesa-dev] [PATCH 06/11] mesa: Add new pixel pack/unpack state for ARB_compressed_texture_pixel_storage

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/get_hash_params.py | 10 +++ > src/mesa/main/mtypes.h | 4 +++ > src/mesa/main/pixelstore.c | 64 > +

Re: [Mesa-dev] [PATCH 04/11] glapi: Add XML infrastructure for ARB_compressed_texture_pixel_storage

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > .../gen/ARB_compressed_texture_pixel_storage.xml| 21 > + > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API

Re: [Mesa-dev] [PATCH 05/11] tests: Add new enum strings for ARB_compressed_texture_pixel_storage

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/tests/enum_strings.cpp | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/main/tests/enum_strings.cpp > b/src/mesa/main/tests/enum_st

Re: [Mesa-dev] [PATCH 03/11] mesa: Add extension enable for ARB_compressed_texture_pixel_storage

2014-06-02 Thread Ian Romanick
For bisects, this patch should go last. Otherwise, it is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/

Re: [Mesa-dev] [PATCH 01/11] mesa: Trim down PixelStorei implementation

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Move _mesa_error call for INVALID_VALUE to one place. > Remove checks for previous value matching -- this was important when we > were flushing vertices before the update, but that hasn't happened for a > long

Re: [Mesa-dev] [PATCH 02/11] mesa: Make CompressedTexSubImage errors more consistent

2014-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2014 11:29 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/main/teximage.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 845ba80

Re: [Mesa-dev] [PATCH] i965: Put '_default_' in the name of functions that set default state.

2014-06-02 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/5] glsl: Reorder ir_type_* enum for easier comparisons.

2014-06-02 Thread Ian Romanick
On 06/01/2014 12:58 PM, Matt Turner wrote: > Makes checking whether an object is an ir_dereference, an ir_rvalue, or > an ir_jump simpler. Since ir_dereference is a subclass or ir_rvalue, > list its subtypes first so that they can both generate nice code. This tickles a memory from back when we ad

Re: [Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-02 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick Cc: "10.1 10.2" On 06/01/2014 12:56 PM, jfons...@vmware.com wrote: > From: José Fonseca > > --- > src/mesa/main/get_hash_generator.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/get_hash_generator.py > b/src/mes

[Mesa-dev] [PATCH] glsl: Rebuild the symbol table without unreachable symbols

2014-06-02 Thread Ian Romanick
From: Ian Romanick Previously we had to keep unreachable global symbols in the symbol table because the symbol table is used during linking. Having the symbol table retain pointers to freed memory... what could possibly go wrong? At the same time, this meant that we kept live references to tons

[Mesa-dev] [Bug 75212] Mesa selects wrong DRI driver

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75212 --- Comment #9 from Bernd Kuhls --- (In reply to comment #8) > Why not file a bug with your distribution mentioning that Mesa now requires > libudev (but not udev) Hi, I found a way to include libudev in the distro, so you can disregard my com

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-02 Thread Alex Deucher
On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez wrote: > On Fri, 2014-05-30 at 19:33 -0400, Alex Deucher wrote: >> On Fri, May 30, 2014 at 11:31 AM, Bruno Jiménez wrote: >> > The data has been extracted from: >> > AMD Accelerated Parallel Processing OpenCL Programming Guide (rev 2.7) >> > Appendix

Re: [Mesa-dev] [PATCH] egl/main: Fix eglMakeCurrent when releasing context from current thread.

2014-06-02 Thread Chad Versace
Beren, I committed this to master. Thanks for the fix. On Thu, Mar 20, 2014 at 08:36:34AM +0100, Beren Minor wrote: > EGL 1.4 Specification says that > eglMakeCurrent(display, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT) > can be used to release the current thread's ownership on the surfaces >

Re: [Mesa-dev] [PATCH 2/2] mesa: Make glGetIntegerv(GL_*_ARRAY_SIZE) return GL_BGRA.

2014-06-02 Thread Matt Turner
Yes, please have a Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #13 from Marek Olšák --- FYI, I reverted the patch. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Kenneth Graunke
On Monday, June 02, 2014 07:44:15 PM Benjamin Bellec wrote: [snip] > The "canary error" on Google points to a previously closed bug from > glsl-compiler : > https://bugs.freedesktop.org/show_bug.cgi?id=58039 It's probably unrelated - failing the canary check basically just means you botched your

Re: [Mesa-dev] [PATCH 4/4] i965/gen8: Print number of instructions directly.

2014-06-02 Thread Kenneth Graunke
On Monday, June 02, 2014 11:06:05 AM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 6 ++ > src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp | 3 +++ > 2 files changed, 9 insertions(+) Series is: Reviewed-by: Kenneth Graunke signature.asc Description: This i

Re: [Mesa-dev] [PATCH 2/2] mesa: Make glGetIntegerv(GL_*_ARRAY_SIZE) return GL_BGRA.

2014-06-02 Thread Jose Fonseca
- Original Message - > > > - Original Message - > > On Sun, Jun 1, 2014 at 12:56 PM, wrote: > > > From: José Fonseca > > > > > > Same as b026b6bbfe3f15c8a7296ac107dc3d31f74e401e, but > > > COLOR_ARRAY_SIZE/SECONDARY_COLOR_ARRAY_SIZE. > > > > > > Ideally we wouldn't munge the

[Mesa-dev] [PATCH 2/4] i965: Move program header printing to end of generate_code().

2014-06-02 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 30 +++ src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 18 ++ src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 30 +++ src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp | 18 ++--

[Mesa-dev] [PATCH 4/4] i965/gen8: Print number of instructions directly.

2014-06-02 Thread Matt Turner
--- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 6 ++ src/mesa/drivers/dri/i965/gen8_vec4_generator.cpp | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp index 3703368..6d455a3 1006

[Mesa-dev] [PATCH 3/4] i965: Emit compaction stats without walking the assembly.

2014-06-02 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 19 --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 6 ++ 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 1/4] i965: Move annotation info into generate code.

2014-06-02 Thread Matt Turner
Suggested by Ken as a way to cut down lines of code. --- src/mesa/drivers/dri/i965/brw_fs.h| 6 +-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 52 ++- src/mesa/drivers/dri/i965/brw_vec4.h | 6 +-- src/mesa/drivers/dri/i965/brw_vec4_genera

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 10:29 AM, Pohjolainen, Topi wrote: > On Mon, Jun 02, 2014 at 09:44:16AM -0700, Jordan Justen wrote: >> On Mon, Jun 2, 2014 at 2:36 AM, Pohjolainen, Topi >> wrote: >> > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> >> Previously array spacing lod0 was onl

Re: [Mesa-dev] [RFC PATCH 15/16] i965/gen6: Force W tiling alignment with array_spacing_lod0

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 3:03 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:54PM -0700, Jordan Justen wrote: >> Signed-off-by: Jordan Justen >> --- >> src/mesa/drivers/dri/i965/brw_tex_layout.c | 16 +--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --g

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Benjamin Bellec
Hello, This patch set prevents me from launching Steam. I'm on r600g (Radeon HD5850 Evergreen). Here is the log : $ MESA_DEBUG=1 LIBGL_DEBUG=1 STEAM_RUNTIME=0 steam Running Steam on fedora 19 64-bit STEAM_RUNTIME is disabled by the user Installing breakpad exception handler for appid(steam)/versi

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Pohjolainen, Topi
On Mon, Jun 02, 2014 at 09:44:16AM -0700, Jordan Justen wrote: > On Mon, Jun 2, 2014 at 2:36 AM, Pohjolainen, Topi > wrote: > > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: > >> Previously array spacing lod0 was only used with a single mip level. > >> > >> It indicated that no mi

Re: [Mesa-dev] [PATCH v2 0/3] Software rasterizer in the DRM EGL platform

2014-06-02 Thread Adam Jackson
On Thu, 2014-05-15 at 01:58 +0100, Emil Velikov wrote: > On 05/05/14 17:07, Giovanni Campagna wrote: > > This is my second attempt to bring swrast to the DRM EGL platform. > > It includes both the legacy loader, which will work with any > > swrast driver, and the new gallium winsys which works with

[Mesa-dev] [Bug 77596] [r600g] random and reproducible crash in Left 4 Dead 2 (bisected)

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77596 Benjamin Bellec changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 77596, which changed state. Bug 77596 Summary: [r600g] random and reproducible crash in Left 4 Dead 2 (bisected) https://bugs.freedesktop.org/show_bug.cgi?id=77596 What|Removed |Added

Re: [Mesa-dev] [PATCH 1/5] glsl: Set ir_instruction::ir_type in the base class constructor

2014-06-02 Thread Matt Turner
On Mon, Jun 2, 2014 at 1:10 AM, Juha-Pekka Heikkilä wrote: > this set 1..5 are > > Reviewed-by: Juha-Pekka Heikkila Thanks Juha-Pekka! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 2:42 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> Previously array spacing lod0 was only used with a single mip level. >> >> It indicated that no mip level spacing should be used between array >> slices. >> >> gen6 stencil

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 2:36 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> Previously array spacing lod0 was only used with a single mip level. >> >> It indicated that no mip level spacing should be used between array >> slices. >> >> gen6 stencil

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #12 from ajax at nwnk dot net --- (In reply to comment #5) > The patch that changed RTLD_GLOBAL to RTLD_LOCAL was incorrect; see > http://lists.freedesktop.org/archives/mesa-dev/2014-May/060441.html > > dlopening libGL to bring symbo

[Mesa-dev] [PATCH 2/5] r300g: BlitFramebuffer should follow render condition

2014-06-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r300/r300_blit.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r300/r300_blit.c b/src/gallium/drivers/r300/r300_blit.c index 2b516d2..2320abb 100644 --- a/src/gallium/drivers/r300/r300_blit.c +++ b/src/ga

[Mesa-dev] [PATCH 3/5] r600g: BlitFramebuffer should follow render condition

2014-06-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_blit.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index 1a2a911..a2e7fa3 100644 --- a/src/gallium/drivers/r600/r600_blit.c +++ b/s

[Mesa-dev] [PATCH 5/5] r600g, radeonsi: don't use hardware MSAA resolve if dst is fast-cleared

2014-06-02 Thread Marek Olšák
From: Marek Olšák It doesn't work and our docs say so too. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/r600/r600_blit.c | 3 ++- src/gallium/drivers/radeonsi/si_blit.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.

[Mesa-dev] [PATCH 4/5] radeonsi: BlitFramebuffer should follow render condition

2014-06-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 6bc89ab..0a4a660 100644 --- a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 1/5] r600g, radeonsi: disable fast clear if render condition is on

2014-06-02 Thread Marek Olšák
From: Marek Olšák For some reason, CP DMA doesn't follow the predicate bit if I enable it, so this is the only option. This fixes piglit: spec/NV_conditional_render/clear Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeon/r600_texture.c | 3 +++ 1 file changed, 3 insertions(+

Re: [Mesa-dev] [PATCH 2/2] i965: in set_read_rb_tex_image() check _mesa_meta_bind_rb_as_tex_image() did succeed

2014-06-02 Thread Pohjolainen, Topi
On Fri, May 30, 2014 at 02:37:35PM +0300, Pohjolainen, Topi wrote: > On Fri, May 30, 2014 at 01:54:48PM +0300, Juha-Pekka Heikkila wrote: > > Check if _mesa_meta_bind_rb_as_tex_image() did give the texture. > > If no texture was given there is already either > > GL_INVALID_VALUE or GL_OUT_OF_MEMORY

[Mesa-dev] [RFC 19/20] mesa: take shader program cache in to use

2014-06-02 Thread Tapani Pälli
Patch initializes program cache on context creation, caches linked programs and skips linking if program is found from the cache. Signed-off-by: Tapani Pälli --- src/mesa/main/context.c | 4 src/mesa/program/ir_to_mesa.cpp | 7 +++ 2 files changed, 11 insertions(+) diff --git a

[Mesa-dev] [RFC 13/20] glsl: functions to deserialize gl_shader and gl_shader_program

2014-06-02 Thread Tapani Pälli
These utility functions for deserialization can be utilized by binary shader cache and ARB_get_program_binary extension. Signed-off-by: Tapani Pälli --- src/glsl/Makefile.sources | 1 + src/glsl/shader_cache.h | 12 ++ src/glsl/shader_deserialize.cpp | 403 ++

[Mesa-dev] [RFC 16/20] glsl: add method to deserialize binary program from given path

2014-06-02 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/glsl/shader_cache.h | 3 +++ src/glsl/shader_deserialize.cpp | 18 ++ 2 files changed, 21 insertions(+) diff --git a/src/glsl/shader_cache.h b/src/glsl/shader_cache.h index 23d1098..2262a49 100644 --- a/src/glsl/shader_cache.h +++ b/sr

[Mesa-dev] [RFC 20/20] mesa: binary cache size management

2014-06-02 Thread Tapani Pälli
Patch adds validation round whenever cache path is created/checked. Validation keeps the cache size at wanted level by deleting rarely accessed file entries. Signed-off-by: Tapani Pälli --- src/mesa/program/prog_diskcache.c | 97 +++ 1 file changed, 97 inserti

[Mesa-dev] [RFC 17/20] mesa: add helpers for the binary shader cache

2014-06-02 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/mtypes.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 688a3bd..ee12337 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -4252,6 +4252,12 @@ struct gl_context *

[Mesa-dev] [RFC 14/20] mesa: add _mesa_mkdir helper to imports.h

2014-06-02 Thread Tapani Pälli
Function provides platform agnostic way to create a directory. This will be used by the binary shader cache. Signed-off-by: Tapani Pälli --- src/mesa/main/imports.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index af7

[Mesa-dev] [RFC 18/20] mesa/program: add disk cache functionality

2014-06-02 Thread Tapani Pälli
Patch adds functions to cache linked shader programs to disk. Cache key is generated from shader sources of the program. Cache path is generated on initialization if does not exist yet. Signed-off-by: Tapani Pälli --- src/mesa/Makefile.sources | 1 + src/mesa/program/prog_diskcache.c |

[Mesa-dev] [RFC 11/20] glsl: functions to serialize gl_shader and gl_shader_program

2014-06-02 Thread Tapani Pälli
These utility functions for serialization can be utilized by binary shader cache and ARB_get_program_binary extension. Signed-off-by: Tapani Pälli --- src/glsl/Makefile.sources | 1 + src/glsl/shader_cache.h | 86 +++ src/glsl/shader_serialize.cpp | 240 +

[Mesa-dev] [RFC 10/20] mesa: iterate method for string_to_uint_map

2014-06-02 Thread Tapani Pälli
Shader binary cache requires this to be able to cache hash data from the gl_shader_program structure. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/mesa/program/hash_table.h | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/program/hash_table.h b/src/mesa/progra

[Mesa-dev] [RFC 12/20] mesa: add _Linked helper to gl_shader_program struct

2014-06-02 Thread Tapani Pälli
This boolean indicates if program has ever been linked succesfully, will be used by binary shader cache to detect relinking. Signed-off-by: Tapani Pälli --- src/mesa/main/mtypes.h | 1 + src/mesa/program/ir_to_mesa.cpp | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/mesa/main

[Mesa-dev] [RFC 15/20] glsl: add capability to read/map files to memory_map

2014-06-02 Thread Tapani Pälli
Patch provides mmap version and a simple/slow version if mmap is not available. This functionality will be used by the binary shader cache. Signed-off-by: Tapani Pälli --- src/glsl/memory_map.h | 70 +-- 1 file changed, 68 insertions(+), 2 deletion

[Mesa-dev] [RFC 06/20] glsl: export populate_symbol_table function

2014-06-02 Thread Tapani Pälli
Binary shader cache needs this to allocate and fill gl_shader symbol table. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/glsl/linker.cpp | 2 +- src/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp in

[Mesa-dev] [RFC 09/20] glsl: ir_deserializer class for the binary shader cache

2014-06-02 Thread Tapani Pälli
ir_deserializer fills existing gl_shader structure's ir exec_list from binary data, this will be used by shader binary cache implementation. Signed-off-by: Tapani Pälli --- src/glsl/Makefile.sources| 1 + src/glsl/ir_deserializer.cpp | 730 +++ src/g

[Mesa-dev] [RFC 07/20] glsl: add MAX_NUM_STATE_SLOTS and check against builtin uniforms

2014-06-02 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/glsl/builtin_variables.cpp | 3 +++ src/mesa/main/config.h | 4 2 files changed, 7 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 9b35850..60b0e38 100644 --- a/src/glsl/builtin_variables.cpp +++ b/

[Mesa-dev] [RFC 08/20] glsl: glsl_type deserialization

2014-06-02 Thread Tapani Pälli
Will be utilized by IR deserialization for binary shaders. Signed-off-by: Tapani Pälli --- src/glsl/glsl_types.cpp | 106 src/glsl/glsl_types.h | 19 + 2 files changed, 125 insertions(+) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/

[Mesa-dev] [RFC 01/20] glsl: memory_writer helper class for data serialization

2014-06-02 Thread Tapani Pälli
Class will be used by the shader binary cache implementation. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/glsl/memory_writer.h | 204 +++ 1 file changed, 204 insertions(+) create mode 100644 src/glsl/memory_writer.h diff --git a/src/

[Mesa-dev] [RFC 04/20] glsl: memory_map helper class for data deserialization

2014-06-02 Thread Tapani Pälli
Class will be used by the shader binary cache implementation. Signed-off-by: Tapani Pälli --- src/glsl/memory_map.h | 164 ++ 1 file changed, 164 insertions(+) create mode 100644 src/glsl/memory_map.h diff --git a/src/glsl/memory_map.h b/src/glsl

[Mesa-dev] [RFC 05/20] glsl: add MESA_SHADER_CACHE_MAGIC string for shader binary cache

2014-06-02 Thread Tapani Pälli
Patch adds a string that can be used by binary cache to identify that shader binaries were generated with exact same Mesa library. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/glsl/shader_cache_magic.h | 36 1 file changed, 36 insertions(+) c

[Mesa-dev] [RFC 02/20] glsl: glsl_type serialization

2014-06-02 Thread Tapani Pälli
Will be utilized by IR serialization to serialize user defined types. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry (v1) --- src/glsl/glsl_types.cpp | 58 + src/glsl/glsl_types.h | 6 + 2 files changed, 64 insertions(+) diff --git a/

[Mesa-dev] [RFC 03/20] glsl: serialize methods for IR instructions

2014-06-02 Thread Tapani Pälli
Patch adds a new virtual function for ir_instruction base class which has to be implemented by each instruction. This data will be used by the shader binary cache implementation. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/glsl/Makefile.sources | 1 + src/glsl/ir.h

[Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-02 Thread Tapani Pälli
Hello; This series provides a disk cache for the shader compiler and is used to 'skip glLinkProgram' like GL_ARB_get_program_binary does but under the hood without api for the client. Many of the patches are from my 'GL_ARB_get_program_binary' series and some were reviewed by Paul earlier. I'v

[Mesa-dev] [PATCH] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-02 Thread Emil Velikov
Originally all hardware drivers duplicate the driver_name string from an external source, while for the software rasterizer we set it to "swrast". Follow the example set by hw drivers this way we can free the string at dri2_terminate(). v2: Use strdup over strndup. Suggested by Ilia Mirkin. v3: Ha

Re: [Mesa-dev] [PATCH] egl/dri2: do not leak dri2_dpy->driver_name

2014-06-02 Thread Emil Velikov
On 02/06/14 07:31, Chia-I Wu wrote: > On Sun, Jun 1, 2014 at 11:53 PM, Emil Velikov > wrote: >> Originally all hardware drivers duplicate the driver_name string >> from an external source, while for the software rasterizer we set >> it to "swrast". Follow the example set by hw drivers this way >>

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #11 from Rui Salvaterra --- Also kills Compiz/Unity on my Ironlake, Haswell (Iris Pro 5200) and NV50 (NVAC) machines. This commit seems to bust everything out there. -- You are receiving this mail because: You are the assignee for t

[Mesa-dev] [PATCH 2/3] i965/gen7: Refactor array type resolving

2014-06-02 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h | 9 + src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 6 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw

[Mesa-dev] i965: Helpers for resolving properties of surfaces

2014-06-02 Thread Topi Pohjolainen
Jordan's gen6-layer work made me try if some of the duplicated switch cases could be shared. Not a big deal, but a little clearer I think. There is still one left in gen7_blorp_emit_depth_stencil_config() but there depth is resolved based on miptree alone instead of consulting a renderbuffer. I su

[Mesa-dev] [PATCH 3/3] i965/gen7: Refactor resolving of depth

2014-06-02 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h | 1 + src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 15 + src/mesa/drivers/dri/i965/gen7_misc_state.c | 26 ++- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 1

[Mesa-dev] [PATCH 1/3] i965/gen7: Refactor renderbuffer target override

2014-06-02 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h | 8 src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 17 + src/mesa/drivers/dri/i965/gen7_blorp.cpp | 4 +--- src/mesa/drivers/dri/i965/gen7_misc_state.c | 8 ++

Re: [Mesa-dev] [RFC PATCH 15/16] i965/gen6: Force W tiling alignment with array_spacing_lod0

2014-06-02 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:54PM -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c > b/src/mesa/dri

Re: [Mesa-dev] [RFC PATCH 14/16] i965/gen6: Stencil/hiz needs an offset for LOD > 0

2014-06-02 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:53PM -0700, Jordan Justen wrote: > Since gen6 stencil only supports LOD0, we need to program an offset to > the LOD when emitting the stencil/hiz. > > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/gen6_blorp.cpp | 10 - > src/mesa/driver

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: > Previously array spacing lod0 was only used with a single mip level. > > It indicated that no mip level spacing should be used between array > slices. > > gen6 stencil only support LOD0, so we need to allocate the miptree > similar

[Mesa-dev] [Bug 79469] Commit e3cc0d90e14e62a0a787b6c07a6df0f5c84039be breaks unigine heaven

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79469 --- Comment #10 from Keith Hammond --- (In reply to comment #6) > (In reply to comment #3) > > Confirmed on r600g. > +1 (Evergreen) +1 on cypress can't launch unity desktop -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Pohjolainen, Topi
On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: > Previously array spacing lod0 was only used with a single mip level. > > It indicated that no mip level spacing should be used between array > slices. > > gen6 stencil only support LOD0, so we need to allocate the miptree > similar

[Mesa-dev] [Bug 79230] After upgrade from 10.1.4 to 10.2-rc4 cross-compile fails

2014-06-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79230 --- Comment #7 from war...@o2.pl --- Emil, >> PKG_CONFIG_PATH="$(libdir)/pkgconfig" \ >Wrong. You should set the path to the location where the cross-build pc are >>available. I.e. the location where the above libdrm_radeon.pc is stored. A

Re: [Mesa-dev] [PATCH 1/5] glsl: Set ir_instruction::ir_type in the base class constructor

2014-06-02 Thread Juha-Pekka Heikkilä
this set 1..5 are Reviewed-by: Juha-Pekka Heikkila On Sun, Jun 1, 2014 at 10:58 PM, Matt Turner wrote: > From: Ian Romanick > > This has the added perk that if you forget to set ir_type in the > constructor of a new subclass (or a new constructor of an existing > subclass) the compiler will te

Re: [Mesa-dev] [PATCH V2 06/11] loader: Use drirc device_id parameter in complement to DRI_PRIME

2014-06-02 Thread Michel Dänzer
On 30.05.2014 20:20, Axel Davy wrote: > On 30/05/2014 06:05, Michel Dänzer wrote : >> On 30.05.2014 12:49, Axel Davy wrote: >>> On 29/05/2014 23:31, Michel Dänzer a wrote : >>> >>> I tried with your compile options (except for the opencl flags, didn't >>> have the required libs), and it worked. >>>

Re: [Mesa-dev] [PATCH 2/2] mesa: Make glGetIntegerv(GL_*_ARRAY_SIZE) return GL_BGRA.

2014-06-02 Thread Jose Fonseca
- Original Message - > On Sun, Jun 1, 2014 at 12:56 PM, wrote: > > From: José Fonseca > > > > Same as b026b6bbfe3f15c8a7296ac107dc3d31f74e401e, but > > COLOR_ARRAY_SIZE/SECONDARY_COLOR_ARRAY_SIZE. > > > > Ideally we wouldn't munge the incoming state, so that we wouldn't need to > > unm