Re: [Mesa-dev] [PATCH 07/10] i965/fs: Handle arrays of special regs more cleanly.

2014-03-26 Thread Kenneth Graunke
On 03/26/2014 02:23 PM, Eric Anholt wrote: > I need to extend the size of the outputs[] array, and this was going to > get ridiculous. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 36 > ++-- > 1 file changed, 22 insertions(+), 14 deletions(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH 06/10] i965/fs: Fix dump_instructions() on uniforms.

2014-03-26 Thread Kenneth Graunke
On 03/26/2014 02:23 PM, Eric Anholt wrote: > All of a vec4 uniform was being printed as "u0" > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > i

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 --- Comment #3 from cgerlac...@gmail.com --- I set LP_NUM_THREADS=1 to reduce the number of stracktraces and used Mesa 10.1 with llvm 3.4. If you need more information or something I should test, please feel free to ask. Thread 1: ntdll.dll!

[Mesa-dev] [Bug 76664] Metro: Last Light segfaults very often in level 10 (swamp) on loading last checkpoint

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76664 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@list

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-26 Thread Marek Olšák
On Wed, Mar 26, 2014 at 4:30 AM, Roland Scheidegger wrote: > Am 26.03.2014 03:29, schrieb Marek Olšák: >> My reasoning was that it would be better to specify a raw clear value >> and clear value size for buffers, which are always untyped, and >> pipe_color_union for textures, which are always type

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-26 Thread Marek Olšák
I'm going to add parameters: format, first_layer, last_layer. I'm going to drop: face. Marek On Thu, Mar 27, 2014 at 1:22 AM, Roland Scheidegger wrote: > Marek, > > what are your plans for this change? > > Roland > > Am 22.03.2014 20:03, schrieb Roland Scheidegger: >>> On Sat, Mar 22, 2014 at 4:

Re: [Mesa-dev] [PATCH 3/3] gallium/u_gen_mipmap: rewrite using pipe->blit

2014-03-26 Thread Roland Scheidegger
Marek, what are your plans for this change? Roland Am 22.03.2014 20:03, schrieb Roland Scheidegger: >> On Sat, Mar 22, 2014 at 4:54 PM, Roland Scheidegger >> wrote: >>> I think this is missing some parameters by not using a sampler view. In >>> particular can we please have a separate format he

[Mesa-dev] [PATCH 5/6] mapi_abi: Make ES1 and ES2 static_dispatch=false functions hidden

2014-03-26 Thread Ian Romanick
From: Ian Romanick This has been a long standing issue with the ES libraries. Functions marked in the XML with 'static_dispatch=false' were still incorrectly exported. ABI-check is supposed to detect this case, but we have to paper over failures every time a new extension is added. This change

[Mesa-dev] [PATCH 1/6] glapi: Remove some duplicate ignore="true" lines

2014-03-26 Thread Ian Romanick
From: Ian Romanick It looks like these were added accidentally by Paul in commit 1a1db174. >From the commit message and the look of the patch, I think this was just some sed-job left overs. Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/gl_API.xml | 32 1 f

[Mesa-dev] [PATCH 4/6] mapi: Hack around glGetInternalformativ not being hidden in GLES

2014-03-26 Thread Ian Romanick
From: Ian Romanick This is hella ugly. The same-named function in desktop OpenGL is hidden, but it needs to be exposed by libGLESv2 for OpenGL ES 3.0. There's no way to express in the XML that a function should be be hidden in one API but exposed in another. This won't affect any change now, bu

[Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-03-26 Thread Ian Romanick
Tomorrow or Friday I'm going to send out the last of the GL_ARB_separate_shader_objects patches. Shortly after that, I will send out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT is the GLES subset of the ARB extension. In preparing for this new extension, I noticed the old

[Mesa-dev] [PATCH 3/6] glapi/es1: Don't mark core functions as static_dispatch=false

2014-03-26 Thread Ian Romanick
From: Ian Romanick Functions that are part of OpenGL ES 1.0 or 1.1 should have static dispatch functions in libGLESv1_CM. This doesn't affect any change yet, but it will prevent later regressions. Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/gl_and_es_API.xml | 129 -

[Mesa-dev] [PATCH 6/6] mapi_abi: Remove ABI-check work arounds for functions that are no longer exported

2014-03-26 Thread Ian Romanick
From: Ian Romanick The previous commit stopped exporting 21 libGLESv2 and 88 libGLESv1_CM functions. This removes the work-arounds for those functions from ABI-check. Signed-off-by: Ian Romanick --- src/mapi/es1api/ABI-check | 93 +-- src/mapi/es2ap

[Mesa-dev] [PATCH 2/6] glapi: Mark all GL_ARB_separate_shader_objects functions with static_dispatch=false

2014-03-26 Thread Ian Romanick
From: Ian Romanick This prevents the entrypoints from being (incorrectly) advertised by libGL. Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/ARB_separate_shader_objects.xml | 122 ++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_

Re: [Mesa-dev] [PATCH 2/2] st/mesa: overhaul texture / sample swizzle code

2014-03-26 Thread Marek Olšák
The patch looks good to me. There is hardware which doesn't support swizzling, but it sure isn't radeon. Marek On Thu, Mar 27, 2014 at 12:17 AM, Brian Paul wrote: > > I haven't investigated fbo-blending-formats but if it's like > fbo-clear-formats, this fixes the piglit_draw_rect_tex() rendering

[Mesa-dev] [Bug 76664] New: Metro: Last Light segfaults very often in level 10 (swamp) on loading last checkpoint

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76664 Priority: medium Bug ID: 76664 Assignee: mesa-dev@lists.freedesktop.org Summary: Metro: Last Light segfaults very often in level 10 (swamp) on loading last checkpoint Severit

Re: [Mesa-dev] Questions regarding KHR_debug for OpenGL ES

2014-03-26 Thread Felipe Tonello
Hi Timothy, On Sun, Mar 23, 2014 at 2:11 PM, Timothy Arceri wrote: > On Mon, 2014-03-17 at 11:42 -0700, Felipe Tonello wrote: >> Hi all, >> >> I'm working on the KHR_debug for OpenGL ES junior job. I recently >> submitted patches to allow the piglit tests to be enabled in GLES >> contexts as well

Re: [Mesa-dev] [PATCH 2/2] st/mesa: overhaul texture / sample swizzle code

2014-03-26 Thread Brian Paul
I haven't investigated fbo-blending-formats but if it's like fbo-clear-formats, this fixes the piglit_draw_rect_tex() rendering which displays the texture on a test quad. -Brian On 03/26/2014 03:52 PM, Marek Olšák wrote: Is this just a workaround for the fbo-blending-formats test? It shoul

[Mesa-dev] [PATCH] mesa: fix glMultiDrawArrays inside a display list

2014-03-26 Thread Brian Paul
The underlying glDrawArrays() calls weren't getting compiled into the display list. We simply need to use the current dispatch table so the CALL_DrawArrays() is routed to the display list save function. This patch also fixes glMultiModeDrawArraysIBM and glMultiModeDrawElementsIBM. Fixes the new

Re: [Mesa-dev] [PATCH 2/2] st/mesa: overhaul texture / sample swizzle code

2014-03-26 Thread Marek Olšák
Is this just a workaround for the fbo-blending-formats test? It should test if GL_DST_ALPHA is equivalent to GL_ONE if the format is RGBX. I don't think the test has anything to do with texturing. Marek On Wed, Mar 26, 2014 at 8:58 PM, Brian Paul wrote: > Previously we only examined the GL_DEPTH

Re: [Mesa-dev] [PATCH 2/3] i965: Use _mesa_format_x_to_a to support more X -> A blits.

2014-03-26 Thread Eric Anholt
Kenneth Graunke writes: > There's really no reason to limit ourselves to a single format; the > technique works just as well for any format in this family. > > Signed-off-by: Kenneth Graunke > - if (src_mt->format == MESA_FORMAT_B8G8R8X8_UNORM && > - dst_mt->format == MESA_FORMAT_B8G8R

[Mesa-dev] [PATCH 05/10] i965/fs: Fix vgrf0 live interval when no interpolation was done.

2014-03-26 Thread Eric Anholt
When you've got a simple solid-color shader that doesn't generate pixel_x/y interpolation, we were deciding that the first vgrf was the same as both the undefined pixel_x and pixel_y, and extending its live interval to avoid the stride problem. That tricked optimization (such as compute_to_mrf) th

[Mesa-dev] [PATCH 07/10] i965/fs: Handle arrays of special regs more cleanly.

2014-03-26 Thread Eric Anholt
I need to extend the size of the outputs[] array, and this was going to get ridiculous. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 03/10] i965: Remove stale comment.

2014-03-26 Thread Eric Anholt
We stopped doing variable index lowering for uniforms in a64c1eb9b110f29b8abf803a8256306702629bdc, 5 months after the comment was added. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 09/10] i965/fs: Track output regs on a split virtual GRF basis.

2014-03-26 Thread Eric Anholt
Basically, replace the output_components[] array with per-channel tracking of the register storing that channel, or a BAD_FILE undefined reg. Right now var->data.location_frac is always 0, but I'm going to use that in vector_splitting next. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-

[Mesa-dev] [PATCH 02/10] glsl: Move tree grafting's debug output to stderr.

2014-03-26 Thread Eric Anholt
The rest of our compiler dumps are there, now. --- src/glsl/opt_tree_grafting.cpp | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/glsl/opt_tree_grafting.cpp b/src/glsl/opt_tree_grafting.cpp index f3bd580..d47613c 100644 --- a/src/glsl/opt_tr

[Mesa-dev] [PATCH 10/10] i965/fs: Allow brw_fs_vector_splitting on shader outputs.

2014-03-26 Thread Eric Anholt
Now, a single output vec4 can be referenced by multiple ir_variables (gl_Fragcolor_x, gl_FragColor_y, etc.). This gives a couple of chances for tree grafting to work. total instructions in shared programs: 1644020 -> 1643948 (-0.00%) instructions in affected programs: 7446 -> 7374 (-0.97%) GA

[Mesa-dev] [PATCH 08/10] i965/fs: Track whether we're doing dual source in a more obvious way.

2014-03-26 Thread Eric Anholt
I'm going to be turning dual_src_output into an array in a moment. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 01/10] glsl: Skip making a temporary for assignments when we don't need one.

2014-03-26 Thread Eric Anholt
While we wish our optimization passes could identify all the cases where we can coalesce our variables, we miss out on a lot of opportunities. total instructions in shared programs: 1673849 -> 1673166 (-0.04%) instructions in affected programs: 299521 -> 298838 (-0.23%) GAINED:

[Mesa-dev] i965: Vector splitting of outputs

2014-03-26 Thread Eric Anholt
Here's a little series I wrote yesterday while tracking down why some silly MOVs were generated in a microbenchmark. As usual with optimization, the thing I was trying to work on (not present in this series) ended up requiring a bunch of other work to prevent regressions. Well, the first patch is

[Mesa-dev] [PATCH 06/10] i965/fs: Fix dump_instructions() on uniforms.

2014-03-26 Thread Eric Anholt
All of a vec4 uniform was being printed as "u0" --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 713e477..b3f1dfd 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 04/10] i965: Drop pointless check for variable declarations in splitting.

2014-03-26 Thread Eric Anholt
We're walking the whole instruction stream, so we know the declaration will be found. --- src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp b/src/mesa/dri

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-26 Thread Ilia Mirkin
On Wed, Mar 26, 2014 at 4:32 PM, Marek Olšák wrote: > I'm afraid that relying on glxinfo will only make the lists > incomplete. I'm sure I won't run glxinfo for every Mesa release and > every GPU I have. I guess somebody else will have to maintain > extension lists for radeon if we want to have ra

[Mesa-dev] [Bug 76621] suffering curse of opensource while building mesa

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76621 --- Comment #2 from Daniel Stone --- Rohit, Please do not inform the humans of our plans to conquer earth via dependencies on packages providing two headers. The poor open source developers are obviously not intelligent enough to understand the

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-26 Thread Marek Olšák
I'm afraid that relying on glxinfo will only make the lists incomplete. I'm sure I won't run glxinfo for every Mesa release and every GPU I have. I guess somebody else will have to maintain extension lists for radeon if we want to have radeon there. What I like about GL3.txt that your solution lac

Re: [Mesa-dev] [PATCH 09/14] mesa: In emit_texenv() type mismatch was forced with typecast

2014-03-26 Thread Chris Forbes
On Thu, Mar 27, 2014 at 2:20 AM, Juha-Pekka Heikkila wrote: > Type mismatch caused random memory to be copied when casted > memory area was smaller than expected type. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/ff_fragment_shader.cpp | 19 +++ > 1 file changed,

[Mesa-dev] [PATCH 2/2] st/mesa: overhaul texture / sample swizzle code

2014-03-26 Thread Brian Paul
Previously we only examined the GL_DEPTH_MODE state to determine the sampler view swizzle for depth textures. Now we also consider the texture base format for color textures too. The basic idea is if we're sampling from a RGB texture we always want to get A=1, even if the actual hardware format m

[Mesa-dev] [PATCH 1/2] st/mesa: simplify apply_depthmode()

2014-03-26 Thread Brian Paul
In preparation for following changes. I used a temporary test harness to compare the old code to the new for all possible swizzle inputs. No change in results. --- src/mesa/state_tracker/st_atom_texture.c | 85 +- 1 file changed, 47 insertions(+), 38 deletions(-) d

[Mesa-dev] [PATCH V4 09/10] mesa: Add support to unpack depth-stencil texture in to FLOAT_32_UNSIGNED_INT_24_8_REV

2014-03-26 Thread Anuj Phogat
V2: Follow the new naming convention for unpack functions. Use double precision for converting Z24 to a float. V3: Unpack stencil value to most significant byte. Use 'struct z32f_x24s8' type. V4: Unpack stencil value to least significant byte. Add a comment to clarify stencil packing.

Re: [Mesa-dev] [PATCH 1/2] draw/gs: reduce the size of the gs output buffer

2014-03-26 Thread Roland Scheidegger
Am 26.03.2014 18:37, schrieb Zack Rusin: > We used to overallocate the output buffer sometimes running out > of memory with applications rendering large geometries. The actual > maximum number of vertices out is simply the maximum number of > primitives in (number of gs invocations) multiplied by t

Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-26 Thread Kenneth Graunke
On 03/26/2014 11:14 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 03/25/2014 11:27 AM, Eric Anholt wrote: >>> The implementation kept a page-sized area for uploading data, and >>> uploaded chunks from that to a 64kb-sized streamed buffer. This wasted >>> cache footprint (and extra sta

Re: [Mesa-dev] [PATCH 2/2] draw/llvm: improve debugging output a bit

2014-03-26 Thread Jose Fonseca
Series looks good to me. Jose - Original Message - > it's useful to know what the llvmbuildstore arguments are going to > be before executing it because it can crash and make sure to > print out the inputs only if we're not generating a gs because > it fetches inputs differently. > > Sig

Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-26 Thread Eric Anholt
Kenneth Graunke writes: > On 03/25/2014 11:27 AM, Eric Anholt wrote: >> The implementation kept a page-sized area for uploading data, and >> uploaded chunks from that to a 64kb-sized streamed buffer. This wasted >> cache footprint (and extra state tracking to do so) when we want to just >> write

[Mesa-dev] [PATCH mesa-demos] glxgears: Smooth animation with AIGLX

2014-03-26 Thread Jon TURNEY
Since commit 0b19fb0a5c6299baf28e26625e39773846f815b2 "improved animation rate" glxgears computes the amount to turn the gears each frame by multipling the angular velocity of the gears by the time since the last frame, rather than at a constant amount per frame. This gives a smooth animation with

[Mesa-dev] [PATCH 1/2] draw/gs: reduce the size of the gs output buffer

2014-03-26 Thread Zack Rusin
We used to overallocate the output buffer sometimes running out of memory with applications rendering large geometries. The actual maximum number of vertices out is simply the maximum number of primitives in (number of gs invocations) multiplied by the maximum number of output vertices per gs input

[Mesa-dev] [PATCH 2/2] draw/llvm: improve debugging output a bit

2014-03-26 Thread Zack Rusin
it's useful to know what the llvmbuildstore arguments are going to be before executing it because it can crash and make sure to print out the inputs only if we're not generating a gs because it fetches inputs differently. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_llvm.c

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-26 Thread Emil Velikov
On 26/03/14 14:24, Ilia Mirkin wrote: > Hello, > > As the outcome of a discussion yesterday on #dri-devel > (http://people.freedesktop.org/~cbrill/dri-log/index.php?channel=dri-devel&date=2014-03-25 > starting around 16:30), I've created a small page that lists all > extensions/limits supported by

Re: [Mesa-dev] [PATCH] configure.ac: fix typo in error message

2014-03-26 Thread Emil Velikov
I have some patches queued the first of which reverts the commit that caused this typo. -Emil On 26/03/14 15:24, Fabio Pedretti wrote: > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 1e5e496..b3d8a92 100644 > ---

Re: [Mesa-dev] [PATCH 0/7] Rename pack/unpack functions

2014-03-26 Thread Brian Paul
On 03/26/2014 09:38 AM, Roland Scheidegger wrote: Am 22.03.2014 19:15, schrieb Brian Paul: This is the first batch of function renaming in format_pack.c and format_unpack.c so the function names match the format names. No regressions with piglit runs with llvmpipe and swrast. The project isn't

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: Simplify vertex and geometry shaders.

2014-03-26 Thread Jose Fonseca
- Original Message - > > I see the crashes you're referring to. > > > > I don't quite understand why though: concerning the geometry shader, other > > than cosmetic changes, in theory I should just have replaced a > > null/non-null > > `tokens` pointer with a boolean `no_tokens`, though ob

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: Simplify vertex and geometry shaders.

2014-03-26 Thread Zack Rusin
> I see the crashes you're referring to. > > I don't quite understand why though: concerning the geometry shader, other > than cosmetic changes, in theory I should just have replaced a null/non-null > `tokens` pointer with a boolean `no_tokens`, though obviously I missed > something. Yea, you mis

Re: [Mesa-dev] [PATCH 3/3] svga: add work-around for Sauerbraten Z fighting issue

2014-03-26 Thread Jose Fonseca
- Original Message - > --- > src/gallium/drivers/svga/svga_context.c | 33 > ++ > src/gallium/drivers/svga/svga_context.h |5 > src/gallium/drivers/svga/svga_state_need_swtnl.c | 13 +++-- > 3 files changed, 49 insertions(+), 2 dele

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: Simplify vertex and geometry shaders.

2014-03-26 Thread Jose Fonseca
I see the crashes you're referring to. I don't quite understand why though: concerning the geometry shader, other than cosmetic changes, in theory I should just have replaced a null/non-null `tokens` pointer with a boolean `no_tokens`, though obviously I missed something. I should also had bro

Re: [Mesa-dev] [PATCH] st/mesa: add null pointer checking in query object functions

2014-03-26 Thread Roland Scheidegger
Am 25.03.2014 00:30, schrieb Brian Paul: > Don't pass null query object pointers into gallium functions. > This avoids segfaulting in the VMware driver (and others?) if the > pipe_context::create_query() call fails and returns NULL. > > Cc: "10.0" "10.1" > --- > src/mesa/state_tracker/st_cb_quer

Re: [Mesa-dev] [PATCH 2/2] mesa: fix unpack_Z32_FLOAT_X24S8() / unpack_Z32_FLOAT() mix-up

2014-03-26 Thread Roland Scheidegger
Am 22.03.2014 18:27, schrieb Brian Paul: > And use the z32f_x24s8 helper struct in unpack_Z32_FLOAT_X24S8(). > Cc: "10.0" "10.1" > --- > src/mesa/main/format_unpack.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main

Re: [Mesa-dev] [PATCH 0/7] Rename pack/unpack functions

2014-03-26 Thread Roland Scheidegger
Am 22.03.2014 19:15, schrieb Brian Paul: > This is the first batch of function renaming in format_pack.c and > format_unpack.c so the function names match the format names. > > No regressions with piglit runs with llvmpipe and swrast. > > The project isn't done, but this is most of it. > > -Bria

Re: [Mesa-dev] [PATCH] st/mesa: improve sampler view handling v2

2014-03-26 Thread Brian Paul
On 03/26/2014 09:18 AM, Christian König wrote: Am 26.03.2014 15:38, schrieb Brian Paul: Can you remove the "v2" from the subject line? I've did so and committed the result. But why actually should I do this? Just to follow the convention of other patches -Brian

[Mesa-dev] [PATCH] configure.ac: fix typo in error message

2014-03-26 Thread Fabio Pedretti
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1e5e496..b3d8a92 100644 --- a/configure.ac +++ b/configure.ac @@ -287,7 +287,7 @@ case "x$enable_static$enable_shared" in xnoyes ) ;; * ) -AC_MSG_WARN([Messa build supp

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: Simplify vertex and geometry shaders.

2014-03-26 Thread Zack Rusin
Actually Jose I think we'll need to revert this. That's because draw always assumed that if geometry shader is present it means that the geometry shader is present, but that is not true anymore. That's because d3d10 creates a null geometry shader to pass around the stream output. Before the patc

Re: [Mesa-dev] [PATCH] st/mesa: improve sampler view handling v2

2014-03-26 Thread Christian König
Am 26.03.2014 15:38, schrieb Brian Paul: Can you remove the "v2" from the subject line? I've did so and committed the result. But why actually should I do this? Reviewed-by: Brian Paul Thanks, Christian. On 03/26/2014 07:38 AM, Christian König wrote: From: Christian König Keep a dynam

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-26 Thread Brian Paul
On 03/26/2014 08:24 AM, Ilia Mirkin wrote: Hello, As the outcome of a discussion yesterday on #dri-devel (https://urldefense.proofpoint.com/v1/url?u=http://people.freedesktop.org/~cbrill/dri-log/index.php?channel%3Ddri-devel%26date%3D2014-03-25&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7

Re: [Mesa-dev] [PATCH] st/mesa: improve sampler view handling v2

2014-03-26 Thread Brian Paul
Can you remove the "v2" from the subject line? Reviewed-by: Brian Paul On 03/26/2014 07:38 AM, Christian König wrote: From: Christian König Keep a dynamically increasing array of all the views created for a texture instead of just the last one. v2: add comments, fix array size calculation,

[Mesa-dev] RFC: per-driver extension lists

2014-03-26 Thread Ilia Mirkin
Hello, As the outcome of a discussion yesterday on #dri-devel (http://people.freedesktop.org/~cbrill/dri-log/index.php?channel=dri-devel&date=2014-03-25 starting around 16:30), I've created a small page that lists all extensions/limits supported by core/compat profiles, per driver: http://people.

Re: [Mesa-dev] [PATCH 1/3] mesa: Add a new _mesa_format_x_to_a() function.

2014-03-26 Thread Brian Paul
On 03/25/2014 07:01 PM, Kenneth Graunke wrote: This translates RGBX formats to the equivalent RGBA format. Signed-off-by: Kenneth Graunke --- src/mesa/main/formats.c | 57 + src/mesa/main/formats.h | 3 +++ 2 files changed, 60 insertions(+)

Re: [Mesa-dev] [PATCH] mapi/glapi: Use ElementTree instead of libxml2.

2014-03-26 Thread Jose Fonseca
- Original Message - > On 03/25/2014 09:34 AM, jfons...@vmware.com wrote: > > From: José Fonseca > > > > It is quite hard to meet the dependency of the libxml2 python bindings > > out side Linux, and in particularly on MacOSX; whereas ElementTree is > > part of Python's standard library.

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 José Fonseca changed: What|Removed |Added CC||jfons...@vmware.com --- Comment #2 from J

[Mesa-dev] [PATCH] st/mesa: improve sampler view handling v2

2014-03-26 Thread Christian König
From: Christian König Keep a dynamically increasing array of all the views created for a texture instead of just the last one. v2: add comments, fix array size calculation, release only the first sampler view found Signed-off-by: Christian König --- src/mesa/state_tracker/st_atom_sampler.

[Mesa-dev] [PATCH 12/14] mesa: add missing null check in _mesa_NewHashTable()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/hash.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..21da652 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,10 +115,20 @@ _mesa_NewHashTable(void

[Mesa-dev] [PATCH 10/14] mesa: Add missing null checks into prog_hash_table.c

2014-03-26 Thread Juha-Pekka Heikkila
Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/program/prog_hash_table.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/program/prog_hash_table.c b/src/mesa/program/pr

[Mesa-dev] [PATCH 14/14] mesa: add null checks in symbol_table.c

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..9c3556a 100644 --- a/src/mesa/program/symb

[Mesa-dev] [PATCH 11/14] glsl: add missing null check in tfeedback_decl::init()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_varyings.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..d0a9d75 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -278,6 +278,12 @@

[Mesa-dev] [PATCH 09/14] mesa: In emit_texenv() type mismatch was forced with typecast

2014-03-26 Thread Juha-Pekka Heikkila
Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_s

[Mesa-dev] [PATCH 13/14] i965: check malloc return value in intel_resolve_map_set()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..a338c5e 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 07/14] mesa: add missing null checks in _tnl_register_fastpath()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5cdf743 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src/mesa

[Mesa-dev] [PATCH 02/14] glx: remove unused __glXClientInfo()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 4b17d7c..7984715 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1378,19 +1378,6 @@ glXQueryS

[Mesa-dev] [PATCH 00/14] Klocwork patches

2014-03-26 Thread Juha-Pekka Heikkila
This is same set as I posted yesterday. I had forgotten to add R-b comments to commit messages. My apologies Matt. :) I reworked Ian's patch because my set depend on it and Ian's patch seem to have vanished in the void. It needed a small update because it was breaking "make check". Matt, about "

[Mesa-dev] [PATCH 08/14] mesa: add extra null checks in vbo_rebase_prims()

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/vbo/vbo_rebase.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..7aa8d08 100644 --- a/src/mesa/vbo/vbo_reba

[Mesa-dev] [PATCH 03/14] glx: add extra null check in getFBConfigs

2014-03-26 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Brian Paul --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean psc->s

[Mesa-dev] [PATCH 05/14] mesa: Add missing null check in _mesa_parse_arb_program()

2014-03-26 Thread Juha-Pekka Heikkila
Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y ind

[Mesa-dev] [PATCH 01/14] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

2014-03-26 Thread Juha-Pekka Heikkila
From: Ian Romanick This can be called from locations that don't have a context pointer handy. This patch also adds enough infrastructure so that the unit tests for the GLSL compiler and the stand-alone compiler will build and function. This patch was originally signed off by Ian Romanick, now v

[Mesa-dev] [PATCH 06/14] mesa: remove redundant running of check_symbol_table()

2014-03-26 Thread Juha-Pekka Heikkila
Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 04/14] mesa: Prevent negative indexing on noise2, noise3 and noise4

2014-03-26 Thread Juha-Pekka Heikkila
% operator could return negative value which would cause indexing before perm table. Change %256 to &0xff Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) d

[Mesa-dev] [Bug 76621] suffering curse of opensource while building mesa

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76621 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 76621] New: suffering curse of opensource while building mesa

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76621 Priority: medium Bug ID: 76621 Assignee: mesa-dev@lists.freedesktop.org Summary: suffering curse of opensource while building mesa Severity: blocker Classification: Unclassified

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 --- Comment #1 from cgerlac...@gmail.com --- Some short test program that provokes the deadlock: #include int main (int, char **) { QLibrary library ("some path to llvmpipe opengl32.dll"); library.load (); printf ("loaded: %d\n", library