Re: [Mesa-dev] [PATCH 2/2] linker: Eliminate more dead code after demoting shader inputs and outputs

2011-10-23 Thread Yuanhan Liu
On Fri, Oct 21, 2011 at 11:49:44AM -0700, Ian Romanick wrote: > From: Ian Romanick > > Consider the following vertex shader and fragment shader: > > // vertex shader > varying vec4 v; > uniform vec4 u; > > void main() { gl_Position = vec4(0.0); v = u; } > > // fragment shader > void main() { g

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-23 Thread Yuanhan Liu
On Fri, Oct 21, 2011 at 11:49:43AM -0700, Ian Romanick wrote: > From: Ian Romanick > > Setting this flag prevents declarations of uniforms from being removed > from the IR. Since the IR is directly used by several API functions > that query uniforms in shaders, uniform declarations cannot be rem

Re: [Mesa-dev] [PATCH] glsl: Add gl_MaxVaryingComponents in GLSL 1.30.

2011-10-23 Thread Ian Romanick
On 10/23/2011 12:49 AM, Eric Anholt wrote: This is the new name for gl_MaxVaryingFloats now that non-float varyings exist. Fixes piglit glsl-1.30/execution/maximums/gl_MaxVaryingFloats Reviewed-by: Ian Romanick --- src/glsl/ir_variable.cpp |2 ++ 1 files changed, 2 insertions(+), 0 d

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-23 Thread James Cloos
I haven't restarted the X server yet, but everything I've tried works fine, both direct and over tcp from my compute node. -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freede

[Mesa-dev] [Bug 42128] Crash when visiting a site with Firefox

2011-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 --- Comment #2 from Kenneth Graunke 2011-10-23 14:01:50 PDT --- Not sure what driver you're using... I was not able to reproduce this on my Intel Sandybridge system, using either the latest Mesa 7.11 branch (from git, not the release) or Mesa m

Re: [Mesa-dev] [PATCH] glsl: Add gl_MaxVaryingComponents in GLSL 1.30.

2011-10-23 Thread Kenneth Graunke
On 10/23/2011 12:49 AM, Eric Anholt wrote: > This is the new name for gl_MaxVaryingFloats now that non-float > varyings exist. Fixes piglit > glsl-1.30/execution/maximums/gl_MaxVaryingFloats > --- > src/glsl/ir_variable.cpp |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH] TransformFeedback: Assign transform feedback varying slots in linker.

2011-10-23 Thread Marek Olšák
On Sat, Oct 22, 2011 at 2:14 AM, Dan McCabe wrote: > Modify the linker to assign additional slots for varying > variables used by transform feedback. This is done after other > varyings are already assigned slots. > > Since this is done after previous varying slot assignments, > the code needs to

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix multithreaded buffer object refcounting. v2

2011-10-23 Thread Mathias Fröhlich
Hi, On Sunday, October 23, 2011 17:55:52 Brian Paul wrote: > Reviewed-by: Brian Paul > > I think it would be really good to have even a simple, single-threaded > piglit test for this (glPush, glDeleteBufferObj, glPop). Could you > write one? Pushing this on top of the todo list :) Do I also

Re: [Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-23 Thread Mathias Fröhlich
Hi, On Sunday, October 23, 2011 17:53:53 Brian Paul wrote: > Looks good. Just minor things: > > In other places where we have a field like this it's called DeletePending. > > The comment you added in _mesa_DeleteBuffersARB() is a bit hard to > understand. If you need help, I could rewrite it

Re: [Mesa-dev] [PATCH] gallium/auxiliary/util: Solaris also has standard Unix sockets

2011-10-23 Thread Brian Paul
On 10/21/2011 05:19 PM, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith --- src/gallium/auxiliary/util/u_network.c |9 ++--- src/gallium/auxiliary/util/u_network.h |3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Brian Paul

[Mesa-dev] [PATCH] util: remove gotos in u_upload_mgr.c

2011-10-23 Thread Brian Paul
From: Brian Paul We can trivially remove the gotos in two places in this code and make it a bit more readable. --- src/gallium/auxiliary/util/u_upload_mgr.c | 24 1 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-23 Thread Brian Paul
On 10/21/2011 07:34 PM, Ian Romanick wrote: On 10/21/2011 12:53 PM, Brian Paul wrote: On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanick Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is di

[Mesa-dev] [Bug 42128] Crash when visiting a site with Firefox

2011-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 --- Comment #1 from Brian Paul 2011-10-23 08:59:01 PDT --- Could you possibly debug this to determine what the texture internalFormat is at the failure? Or try Mesa from git? I can improve the warning message for this problem for the future. --

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix multithreaded buffer object refcounting. v2

2011-10-23 Thread Brian Paul
On 10/22/2011 04:58 AM, Mathias Fröhlich wrote: Hi, Buffer objects may be shared across contexts. Rework the array attrib push/pop implementation to be thread safe. Make use of more library functions for this purpose. Please review. Reviewed-by: Brian Paul I think it would be really good t

Re: [Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-23 Thread Brian Paul
On 10/22/2011 04:57 AM, Mathias Fröhlich wrote: Hi, Make sure we do not run into the classic ABA problem on buffer object bind, reusing this name and may be never rebind since we get an new name that was just deleted and never rebound in between. The explicit rebinding to the debault object in

[Mesa-dev] [Bug 42128] New: Crash when visiting a site with Firefox

2011-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 Bug #: 42128 Summary: Crash when visiting a site with Firefox Classification: Unclassified Product: Mesa Version: 7.11 Platform: x86 (IA32) OS/Version: Linux (All) Sta

[Mesa-dev] [PATCH] glsl: Add gl_MaxVaryingComponents in GLSL 1.30.

2011-10-23 Thread Eric Anholt
This is the new name for gl_MaxVaryingFloats now that non-float varyings exist. Fixes piglit glsl-1.30/execution/maximums/gl_MaxVaryingFloats --- src/glsl/ir_variable.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_variable.cpp b/src/glsl/ir_variable.cpp