[llvm-branch-commits] [libcxx] [libc++] Fix AppleClang version number when checking for __builtin_verbose_trap support (PR #110263)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/110263 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [release/19.x] Cherry-picks to fix the zdump spurious failures in CI (PR #110259)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/110259 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Fix AppleClang version number when checking for __builtin_verbose_trap support (PR #110263)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/110263 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Fix AppleClang version number when checking for __builtin_verbose_trap support (PR #110263)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110263 We should have been checking against 1700, not 17000, which was a typo. (cherry picked from commit 1eba87904b0cbaaee82cfdb835528b85d99320ef) >From b1affedd7d2e4f2e13c3a2cbd8e3645fb5b9af0e Mon Sep 17 00:00:00 20

[llvm-branch-commits] [libcxx] [release/19.x] Cherry-picks to fix the zdump spurious failures in CI (PR #110259)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110259 None >From 3be5c6921fbc46a3a4a6957b7b58c2398c8a8ce8 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 15 Aug 2024 08:14:13 + Subject: [PATCH 1/2] [lldb][test] Mark sys_info zdump test unsupported on

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

ldionne wrote: > I guess > [6f6422f](https://github.com/llvm/llvm-project/commit/6f6422f4a2b8647a59936c131e50a79906d89510) > and > [cdd608b](https://github.com/llvm/llvm-project/commit/cdd608b8f0ce090b3568238387df368751bdbb5d) > should also be cherry-picked. @tru @ldionne This is now https:/

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Fix AppleClang version number when checking for __builtin_verbose_trap support (PR #110263)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/110263 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Disable the clang-tidy checks to get CI back (#109989) (PR #110162)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/110162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109324 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/109324 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

@@ -992,6 +992,7 @@ def add_version_header(tc): "name": "__cpp_lib_ranges", "values": { "c++20": 202207, +"c++23": 202211, # P2602R2 Poison Pills are Too Toxic ldionne wrote: Ack, we can fix that in a fo

[llvm-branch-commits] [libcxx] [libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/109324 This is a (very partial) cherry-pick of #101715 to fix this oversight in the LLVM 19 release. >From f94aed192c413fc174d353c9f8f27766497a8c56 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 19 Sep 2024 1

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109291 >From 9558a97c93be4fb957a82476f5fc1861aff1ed5d Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 10 Apr 2024 23:12:22 +0200 Subject: [PATCH 1/2] [libc++] Follow-up to "Poison Pills are Too Toxic" * U

[llvm-branch-commits] [libcxx] [libcxxabi] release/19.x: [libc++] Avoid re-exporting a few specific symbols from libc++abi (#109054) (PR #110677)

ldionne wrote: As I explained in the original PR, I think this is a fairly important fix since that was an unintentional change in LLVM 19, but this can also potentially break people who compiled with LLVM 19.1. Since we're making the fix on `main`, it will land in LLVM 20 anyway and I think i

[llvm-branch-commits] [libcxx] 8a25c60 - [libc++] Disable the clang-tidy checks to get CI back (#109989)

Author: Louis Dionne Date: 2024-09-26T16:00:43-04:00 New Revision: 8a25c601eb64bcdb7c6c74bee52655468dfdd91b URL: https://github.com/llvm/llvm-project/commit/8a25c601eb64bcdb7c6c74bee52655468dfdd91b DIFF: https://github.com/llvm/llvm-project/commit/8a25c601eb64bcdb7c6c74bee52655468dfdd91b.diff

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109324 >From 2978a0a4e42368e49163102e5a6eb9a032605a61 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 19 Sep 2024 15:40:47 -0400 Subject: [PATCH] [libc++] Adjust the version of __cpp_lib_ranges in C++20 mode Th

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

ldionne wrote: I think this is good to go, the CI is as green as it'll get without rebasing onto `release/19.x` again. https://github.com/llvm/llvm-project/pull/109291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lis

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/109291 * Update release notes and `Cxx23.html` * Update `__cpp_lib_ranges` feature test macro Cherry-pick of #88383 for LLVM 19. >From 9558a97c93be4fb957a82476f5fc1861aff1ed5d Mon Sep 17 00:00:00 2001 From: Jakub Mazu

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

ldionne wrote: CC @JMazurkiewicz @frederick-vs-ja @frederick-vs-ja Does the FTM change seem correct to you? IIUC this should have been done before the LLVM 19 branch but it slipped through the cracks, so this ought to be correct? https://github.com/llvm/llvm-project/pull/109291 _

[llvm-branch-commits] [libcxx] [libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/109291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format][3/3] Improves formatting performance. (PR #108990)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/108990 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format][3/3] Improves formatting performance. (PR #108990)

@@ -319,188 +353,222 @@ struct _LIBCPP_TEMPLATE_VIS __back_insert_iterator_container -class _LIBCPP_TEMPLATE_VIS __writer_container { +// A dynamically growing buffer. +template <__fmt_char_type _CharT> +class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_Ch

[llvm-branch-commits] [libcxx] [libc++][format][3/3] Improves formatting performance. (PR #108990)

@@ -53,24 +56,150 @@ _LIBCPP_BEGIN_NAMESPACE_STD namespace __format { +// A helper to limit the total size of code units written. +class _LIBCPP_HIDE_FROM_ABI __max_output_size { +public: + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI explicit __max_output_size(size_t __max_size) :

[llvm-branch-commits] [libcxx] [libc++][format][3/3] Improves formatting performance. (PR #108990)

https://github.com/ldionne approved this pull request. This LGTM once the comments have been addressed. In particular, we shouldn't need to change the transitive includes. https://github.com/llvm/llvm-project/pull/108990 ___ llvm-branch-commits mailin

[llvm-branch-commits] [libcxx] [libc++] Adjust the version of __cpp_lib_ranges in C++20 mode (PR #109324)

ldionne wrote: @tru Our CI is currently super unstable, that's the failures. We've been without CI for roughly the past week. We're working on it. https://github.com/llvm/llvm-project/pull/109324 ___ llvm-branch-commits mailing list llvm-branch-commit

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Fix name of is_always_lock_free test which was never being run (#106077) (PR #110838)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/110838 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Fix name of is_always_lock_free test which was never being run (#106077) (PR #110838)

ldionne wrote: Impact: basically none, this adds test coverage we should always have had. https://github.com/llvm/llvm-project/pull/110838 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[llvm-branch-commits] [libcxx] [release/19.x][libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109291 >From 094cc808ded9b00a50e26b91898323e17cc4840f Mon Sep 17 00:00:00 2001 From: Jakub Mazurkiewicz Date: Wed, 10 Apr 2024 23:12:22 +0200 Subject: [PATCH 1/2] [libc++] Follow-up to "Poison Pills are Too Toxic" * U

[llvm-branch-commits] [libc++abi] Stop copying headers to the build directory (PR #115086)

https://github.com/ldionne commented: Can't we do the same for libc++ as well? https://github.com/llvm/llvm-project/pull/115086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

https://github.com/ldionne commented: I think the most effective way of settling on the bit-stealing issue would be to benchmark something like this: 1. Set up ~100 functions that do random stuff (e.g. they all return numbers from 1 to 100) 2. Set up a `std::vector>` with some large number of

[llvm-branch-commits] [libc++abi] Stop copying headers to the build directory (PR #115086)

https://github.com/ldionne approved this pull request. LGTM, thanks for the cleanup! https://github.com/llvm/llvm-project/pull/115086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=flang-rt (PR #110217)

https://github.com/ldionne dismissed https://github.com/llvm/llvm-project/pull/110217 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO) endif() endif() -if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE) +if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA)) ldionne wrote: I don't understand why that diff is required since you're setting it pr

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/112277 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/115380 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

https://github.com/ldionne approved this pull request. This looks great, this is a really nice cleanup. Thank you! Let's just wait until we know what to do with the C++03 CMakeLists but I'm OK with merging this once that's settled, if CI is green. https://github.com/llvm/llvm-project/pull/1153

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1043,17 +1043,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) configure_file("${LIBCXX_ASSERTION_HANDLER_FILE}" "${LIBCXX_GENERATED_INCLUDE_DIR}/__assertion_handler" COPYONLY) -set(_all_includes "${LIBCXX_GEN

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1021,17 +1021,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) ldionne wrote: @philnik777 Should be be modifying the C++03 `CMakeLists.txt` at all? https://github.com/llvm/llvm-project/pull/1153

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

@@ -1285,7 +1285,7 @@ elseif(LLVM_ENABLE_LTO) endif() endif() -if(LLVM_ENABLE_FATLTO AND UNIX AND NOT APPLE) +if(LLVM_ENABLE_FATLTO AND ((UNIX AND NOT APPLE) OR FUCHSIA)) ldionne wrote: Sorry, I think I initially read `if (LLVM_ENABLE_FATLTO OR ((UNIX AND N

[llvm-branch-commits] [clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/112277 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -79,42 +79,46 @@ namespace std { } // namespace std */ - -#include <__config> -#include <__memory/allocator.h> -#include <__memory/allocator_destructor.h> -#include <__memory/allocator_traits.h> -#include <__memory/unique_ptr.h> -#include <__type_traits/add_cv_quals.h> -#in

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -152,11 +152,6 @@ _LIBCPP_HARDENING_MODE_DEBUG # define _LIBCPP_TOSTRING2(x) #x # define _LIBCPP_TOSTRING(x) _LIBCPP_TOSTRING2(x) -// NOLINTNEXTLINE(libcpp-cpp-version-check) -# if __cplusplus < 201103L -#define _LIBCPP_CXX03_LANG -# endif ldionne w

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -11,10 +11,6 @@ #include <__config> -#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) ldionne wrote: Merge conflict? https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-b

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne commented: Let's write down the order for landing this in smaller pieces: 1. Land the `#if 0` change which addresses the formatting issues. 2. Land the CMake changes that start installing the C++03 headers. 3. Switch to `#if __cplusplus < C++11 && USE_FROZEN_HEADERS` (

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/95264 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: > Could someone write a release note for this? https://github.com/llvm/llvm-project/pull/96116 https://github.com/llvm/llvm-project/pull/95264 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.or

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: @tickerguy Thanks for the heads up. @tstellar I read the thread in the linked FreeBSD tracker up to `2024-07-02 18:59:18 UTC`, and based on what I am seeing they are still investigating the cause of the issue. I don't think we have grounds to do anything at this point: we know

[llvm-branch-commits] [libcxx] [libcxx] Workaround for build error after #108999 (PR #110783)

ldionne wrote: The patch has since then been reverted, but I guess this is something that @philnik777 should have a look into before it is re-landed. https://github.com/llvm/llvm-project/pull/110783 ___ llvm-branch-commits mailing list llvm-branch-com

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] Align `__recommend() + 1` by __endian_factor (#90292) (PR #95264)

ldionne wrote: Approved per discussion in https://github.com/llvm/llvm-project/pull/90292. @vitalybuka It would be amazing if you could run this PR through the same tests that made you find the bug that you fixed with https://github.com/llvm/llvm-project/pull/90292 https://github.com/llvm/llv

[llvm-branch-commits] [libcxx] [llvm] Bump version to 20.1.0git (PR #125067)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/125067 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++][TZDB] Fixes %z escaping. (#125399) (PR #125730)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/125730 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Make benchmarks dry-run by default on the release branch (PR #126441)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/126441 As reported in #125510, doing a full run of the benchmarks during release testing breaks for some of the testers, and it also takes a long time. The proper fix would be for the release testing process to call `

[llvm-branch-commits] [libcxx] release/20.x: [libc++][format] Disables the FTM on older MacOS versions. (#126547) (PR #127232)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127232 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #129453)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/129453 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

@@ -0,0 +1,47 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/131382 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/134406 >From abb3af9e0f26cae7583efe2591fe870da7b87fa7 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 4 Apr 2025 11:48:46 -0400 Subject: [PATCH] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

ldionne wrote: (I'm going to tentatively close this since as I said we're not cherry-picking stuff back to LLVM 18 anymore, please reopen for more discussion) https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-b

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

ldionne wrote: The LLVM 18 release has been done for a long time, we're working on LLVM 20 now. https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

https://github.com/ldionne approved this pull request. Now that we have a better understanding that this is a workaround for an issue, how to reproduce the issue, etc, I am comfortable with cherry-picking this to LLVM 20. I don't think this is necessarily the workaround we'll want to keep fore

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/ldionne requested changes to this pull request. I am fine with the spirit of this patch. I think it needs a release note though since we're making library-wide changes. We don't think those changes are going to affect anyone, but I think it's a nice courtesy to give our users

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

@@ -64,25 +64,13 @@ Visibility Macros ABI, we should create a new _LIBCPP_HIDE_FROM_ABI_AFTER_XXX macro, and we can ldionne wrote: Not attached to this line: you should update the `Overview` at the beginning of this file to reflect the latest state of things.

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

ldionne wrote: The commit message should make it clear that this is a no-op on Clang. https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://li

[llvm-branch-commits] [libcxx] [NFC][libc++][test] Minor updates to generated header version test. (PR #134543)

@@ -1830,28 +1830,28 @@ def produce_tests(): // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===--===// -// -// WARNING: This test was generated by {script_name} + +// WARNING: This test was ge

[llvm-branch-commits] [libcxx] [NFC][libc++][test] Minor updates to generated header version test. (PR #134543)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/134543 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++][test] Backport test skipping for Apple Clang 17 (PR #131506)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/131506 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Add a missing include for __bit_iterator (#127015) (PR #131382)

ldionne wrote: I'd like us to validate that this is the right fix on `main` first. I've asked for a reproducer in #127015. https://github.com/llvm/llvm-project/pull/131382 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:/

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/134538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

@@ -2208,6 +2209,20 @@ def implemented_ftms(self) -> Dict[Ftm, Dict[Std, Optional[Value]]]: return get_ftms(self.__data, self.std_dialects, True) +def is_implemented(self, ftm: Ftm, std: Std) -> bool: +"""Has the FTM `ftm` been implemented in the dialect

[llvm-branch-commits] [libcxx] [libc++] Adds is_implemented function for new ftm generator. (PR #134538)

https://github.com/ldionne approved this pull request. LGTM with comment rewording. https://github.com/llvm/llvm-project/pull/134538 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Provide locale conversions to tests through lit substitution (#105651) (PR #136449)

ldionne wrote: @mstorsjo Is there a reason to want to backport this, since this is only fixing the test suite? I wouldn't oppose it, but it looks like this needs work to pass CI on the release branch and I'm not sure it's worth the trouble. https://github.com/llvm/llvm-project/pull/136449

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Re-introduce _LIBCPP_DISABLE_AVAILABILITY (#134158) (PR #138674)

ldionne wrote: The CI failures are caused by an automatic update of the Xcode version and can be ignored. https://github.com/llvm/llvm-project/pull/138674 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/c

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Fixes (|multi)_set spaceship operator. (#127326) (PR #127342)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127342 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Avoid including on arbitrary platforms (#125587) (PR #127310)

ldionne wrote: Thanks for the heads up. I think we should merge this but also cherry-pick https://github.com/llvm/llvm-project/pull/127691 into LLVM 20 to fix that issue. https://github.com/llvm/llvm-project/pull/127310 ___ llvm-branch-commits mailing

[llvm-branch-commits] [libcxx] release/20.x: Revert "[libc++] Reduce std::conjunction overhead (#124259)" (PR #127677)

https://github.com/ldionne approved this pull request. LGTM but we need CI to be green https://github.com/llvm/llvm-project/pull/127677 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [libcxx] release/20.x: [libc++][TZDB] Fixes mapping of nonexisting time. (#127330) (PR #127531)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127531 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Avoid including on arbitrary platforms (#125587) (PR #127310)

ldionne wrote: @tstellar Can we merge this one? I have another fix I want to cherry-pick which depends on this one. https://github.com/llvm/llvm-project/pull/127310 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.

[llvm-branch-commits] [flang] release/20.x: flang: Fix build with latest libc++ (#127362) (PR #127805)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/127805 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

@@ -0,0 +1,24 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

https://github.com/ldionne approved this pull request. LGTM with minor comment https://github.com/llvm/llvm-project/pull/128351 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

@@ -353,9 +354,9 @@ _LIBCPP_HIDE_FROM_ABI basic_ostream<_CharT, _Traits>& operator<<(basic_ostream<_ typedef ostreambuf_iterator<_CharT, _Traits> _Ip; if (std::__pad_and_output( _Ip(__os), - &__c, - (__os.flags() & ios_base::

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/128351 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/134406 There were some remaining headers that were not guarded with _LIBCPP_HAS_LOCALIZATION, leading to errors when trying to use modules on platforms that don't support localization (since all the headers get pulled

[llvm-branch-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (#131921) (PR #134406)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/134406 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxxabi] [release/18.x][backport][libc++abi] Use __has_feature check to enable usage of thread_local for exception storage (PR #132241)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/132241 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove code that is not used in C++03 (PR #134045)

https://github.com/ldionne approved this pull request. LGTM, please update the commit message to explain what's being done and this is part of the frozen header RFC. Thanks! https://github.com/llvm/llvm-project/pull/134045 ___ llvm-branch-commits mail

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove macros that expand to nothing (PR #134046)

https://github.com/ldionne approved this pull request. Same comment about commit message, please make it self-standing. https://github.com/llvm/llvm-project/pull/134046 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lis

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{, multi}map::value_compare (#137594) (PR #138880)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/138880 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

@@ -0,0 +1,187 @@ +# ===--===## +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

@@ -2555,6 +2645,72 @@ def generate_header_test_directory(self, path: os.path) -> None: f.write(self.generate_header_test_file(header)) +@functools.cached_property +def status_list_table(self) -> str: +"""Creates the rst status table using a l

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/139774 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Implements the new FTM documentation generator. (PR #139774)

https://github.com/ldionne approved this pull request. I am really excited for this change! This looks really good, with a few comments. https://github.com/llvm/llvm-project/pull/139774 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.ll

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Provide locale conversions to tests through lit substitution (#105651) (PR #136449)

https://github.com/ldionne approved this pull request. I am fine with this backport. I looked at the failure on macOS and they look like the ones we had after the unfortunate OS update on Github runners, so I think this patch is clean. Also this patch only touches the tests. https://github.com

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix a bunch of random tests (PR #144117)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/144117 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove tests from libcxx-03 which aren't run in C++03 mode (PR #144094)

https://github.com/ldionne approved this pull request. LGTM with CI passing. https://github.com/llvm/llvm-project/pull/144094 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-b

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove XFAILs from the non-frozen libc++-specific tests (PR #144101)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/144101 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

<    1   2   3   4   5   6   >