https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/126441
As reported in #125510, doing a full run of the benchmarks during release
testing breaks for some of the testers, and it also takes a long time. The
proper fix would be for the release testing process to call `check-cxx` instead
of running lit directly inside libc++'s test directory: that will also have the
benefit of actually running all of our tests, not only the Lit ones.
However, since that fix may take longer to happen, this patch tries to reduce
the pain of release testers by dry-running benchmarks by default instead.
>From 0fb2d9d5424f64a0239e21ff569d5b3b696ad2ae Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionn...@gmail.com>
Date: Sun, 9 Feb 2025 16:45:04 -0500
Subject: [PATCH] [libc++] Make benchmarks dry-run by default on the release
branch
As reported in #125510, doing a full run of the benchmarks during
release testing breaks for some of the testers, and it also takes a
long time. The proper fix would be for the release testing process to
call `check-cxx` instead of running lit directly inside libc++'s test
directory: that will also have the benefit of actually running all of
our tests, not only the Lit ones.
However, since that fix may take longer to happen, this patch tries
to reduce the pain of release testers by dry-running benchmarks by
default instead.
---
libcxx/utils/libcxx/test/params.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcxx/utils/libcxx/test/params.py
b/libcxx/utils/libcxx/test/params.py
index 8fd3872cd8cbb05..6e13ad75ea94971 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -371,7 +371,7 @@ def getSuitableClangTidy(cfg):
name="enable_benchmarks",
choices=["no", "run", "dry-run"],
type=str,
- default="run",
+ default="dry-run",
help="Whether to run the benchmarks in the test suite, to only dry-run
them or to disable them entirely.",
actions=lambda mode: [AddFeature(f"enable-benchmarks={mode}")],
),
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
