Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Leonard Mosescu via lldb-dev
Here's a snapshot of the old changes I had: https://reviews.llvm.org/D48381 (hopefully it helps a bit but caveat emptor: this is a quick merge from an old patch, so it's for illustrative purposes only) On Wed, Jun 20, 2018 at 10:26 AM, Pavel Labath wrote: > From the looks of it, the patch stall

Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Pavel Labath via lldb-dev
From the looks of it, the patch stalled on the part whether we can consider all-zero UUIDs as valid or not. I've dug around the code a bit now, and I've found this comment in ObjectFileMachO.cpp. // "main bin spec" (main binary specification) data payload is // formatted:

Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Stephane Sezer via lldb-dev
I had that issue a while back and uploaded a few diffs that fix the problem, but never landed them. I don't remember exactly what needed to change, but you can view them here: https://reviews.llvm.org/D40538 https://reviews.llvm.org/D40537 Let me know if you want to help get them committed to the

Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Leonard Mosescu via lldb-dev
I had made a local attempt at making UUID support arbitrary sizes (part of extracting the UUIDs from minidumps ). I ended up abandoning the UUID changes since there were not strictly in scope and I also had the same uneasy feeling about how flexible do we really wan

Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Scott Funkenhauser via lldb-dev
I took a quick look, it should be fairly straight forward. The one wrinkle (which is just a design decision) is how to represent the variable length UUID as a human readable string (Ex. 16 byte UUIDs are represented as ----). I guess the one thing that is giving me

Re: [lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Pavel Labath via lldb-dev
Thanks for the heads up Scott. I was not aware that lld generates build-ids with different length. Padding would be one option (we already do that to handle the crc pseudo-build-ids), but perhaps a better one would be to teach the class how to handle arbitrary-sized UUIDs (or up to 20 bytes, at le

[lldb-dev] LLDB does not support the default 8 byte build ID generated by LLD

2018-06-20 Thread Scott Funkenhauser via lldb-dev
Hey guys, LLDB uses source/Utility/UUID.cpp to store the build ID. This class only supports 16 or 20 byte IDs. When parsing the .note.gnu.build-id ELF section, any build ID between 4 and 20 bytes will be parsed and saved (which will silently fail if the size isn't 16 or 20 bytes) https://github.c

[lldb-dev] [Bug 37840] incorrect results of expression evaluation

2018-06-20 Thread via lldb-dev
https://bugs.llvm.org/show_bug.cgi?id=37840 lab...@google.com changed: What|Removed |Added Status|NEW |RESOLVED Assignee|lldb-dev@lists.l

[lldb-dev] [Bug 37873] Building LLDB with mingw-w64 broken

2018-06-20 Thread via lldb-dev
https://bugs.llvm.org/show_bug.cgi?id=37873 lab...@google.com changed: What|Removed |Added CC||lab...@google.com Status|NEW

[lldb-dev] [Bug 37873] New: Building LLDB with mingw-w64 broken

2018-06-20 Thread via lldb-dev
https://bugs.llvm.org/show_bug.cgi?id=37873 Bug ID: 37873 Summary: Building LLDB with mingw-w64 broken Product: lldb Version: 6.0 Hardware: PC OS: Windows NT Status: NEW Severity: normal Priority