Re: [lldb-dev] LLDB 4.0.0 crashes on Windows 7

Hello, I had a similar crash, and submitted a patch commited in rL285843 You could try to build afte this version from source, or wait for an updated build. On Sun, Nov 13, 2016 at 5:31 PM, Eli Zaretskii via lldb-dev < lldb-d

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

> On Nov 14, 2016, at 1:44 PM, Zachary Turner wrote: > > If the swap is correct, then wouldn't we also need to swap the variable list? That would make things more symmetrical, though all your doing is skipping the shared pointer ref count manipulations so it isn't terribly important. Jim >

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

Yea, sorry, some of my local changes were mixed in there. But the original code that you posted above still has the same issue. On Mon, Nov 14, 2016 at 1:52 PM Jason Molenda wrote: > For reference, the original code that Greg wrote in r112301 was > > +if (!m_disassembly.GetString().empty())

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

For reference, the original code that Greg wrote in r112301 was +if (!m_disassembly.GetString().empty()) +m_disassembly.GetString().swap (m_disassembly.GetString()); > On Nov 14, 2016, at 1:44 PM, Zachary Turner wrote: > > If the swap is correct, then wouldn't we also need to swa

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

If the swap is correct, then wouldn't we also need to swap the variable list? On Mon, Nov 14, 2016 at 10:58 AM Jim Ingham wrote: > > > On Nov 13, 2016, at 4:48 PM, Zachary Turner via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > > > I was going through doing some routine StringRef changes and

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

Looks incorrect to me. It was introduced with this change. Adding Greg. Author: Greg Clayton Date: Fri Aug 27 21:47:54 2010 + Made it so we update the current frames from the previous frames by doing STL swaps on the variable list, value object list, and disassembly. This avoid

Re: [lldb-dev] Bug in StackFrame::UpdateCurrentFrameFromPreviousFrame

> On Nov 13, 2016, at 4:48 PM, Zachary Turner via lldb-dev > wrote: > > I was going through doing some routine StringRef changes and I ran across > this function: > > std::lock_guard guard(m_mutex); > assert(GetStackID() == > prev_frame.GetStackID()); // TODO: remove this after s

Re: [lldb-dev] LLDB hang loading Linux core files from live processes (Bug 26322)

> You want to figure out which one the accurate signal and use that. > Doesn't matter how you do this, but this will be up to the > ProcessELFCore or ThreadELFCore classes. I'm going to do a little more research (books and google) to see if I can get an answer on this one. I'm actually having t