[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good catch https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace added a comment. Could you split the changes to the selected thread out of this? I'm seeing two features being implemented in this patch. Other than that, it looks pretty good! Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">, MetaVarName<"">

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 ___

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 __

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. wooo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154990/new/ https://reviews.llvm.org/D154990 _

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. fingers crossed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 __

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. you are my hero Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 __

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. fancy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156465/new/ https://reviews.llvm.org/D156465

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace added a comment. Greg hasn't been working for a while. You can go ahead and land this, and when he gets back he can share some feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 __

[Lldb-commits] [PATCH] D156977: [lldb][lldb-vscode] Fix nullptr dereference when JSON is not an object

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156977/new/ https://reviews.llvm.org/D156977 ___

[Lldb-commits] [PATCH] D156979: [lldb][lldb-vscode] Pretty print JSON to log files

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice improvement for sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156979/new/ https://reviews.llvm.org/D156979

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace created this revision. wallace added a reviewer: bulbazord. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0 c

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. Btw, the SBAPI expects the old behavior. // Set the timeout for the expression, 0 means wait forever. void SetTimeoutInMicroSeconds(uint32_t timeout = 0); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4dbdf474993: [LLDB] Allow expression evaluators to set arbitrary timeouts (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - electriclilies wrote: > jingham wrote: > > electriclilies wrote: > > > rriddle wrote: > > > > Why is this dropped? > > > Walter and I want to us

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. @jasonmolenda , yep. I have already reverted this patch. I'll figure out how to make that work nicely with these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

wallace added a comment. @JDevlieghere , that worked. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - wallace wrote: > electriclilies wrote: > > jingham wrote: > > > electriclilies wrote: > > > > rriddle wrote: > > > > > Why is this dropped? > >

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158788/new/ https://reviews.llvm.org/D158788 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158801/new/ https://reviews.llvm.org/D158801 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. In D158010#4617611 , @electriclilies wrote: > @wallace The type synthetic add command already disables itself if python is > not enabled (the check is at CommandObjectType::1564), so I think there > aren't any changes I need to

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Awesome!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace created this revision. wallace added reviewers: bulbazord, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The REPL has a default tab size of 4 spaces, which seems to be a bit too m

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace updated this revision to Diff 553804. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 Files: lldb/source/Core/CoreProperties.td Index: lldb/source/Core/CoreProperties.td

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

wallace added a comment. @aprantl, how should I proceed with the swift branch? Should I create a new branch in https://github.com/apple/swift and share it here so it's available for whoever does the merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace created this revision. wallace added reviewers: bulbazord, aprantl, JDevlieghere. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method was working as expected if `LLDB_ENABLE_LIBEDIT` is f

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace added inline comments. Comment at: lldb/source/Expression/REPL.cpp:535 + if (current_line_idx < current_lines.GetSize()) { +for (uint32_t i = 0; i < current_line_idx; ++i) { + const char *line_cstr = current_lines.GetStringAtIndex(i); aprantl wr

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace updated this revision to Diff 554712. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159031/new/ https://reviews.llvm.org/D159031 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editline.h lldb/source/Core/IOHandler.cpp lldb/source/Expression/REPL.cpp In

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace marked an inline comment as done. wallace added a comment. @aprantl , it turns out that there are no tests for this. I also don't know how easy it'd be to test this very specific feature, because it relies on the terminal not being affected by stuff like test runners. CHANGES SINCE LAS

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. For the sake of unblocking this diff, I'm accepting it because there's no clear actionable feedback at the moment. @electriclilies, please follow up any feedback that is submitted post-land

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

This revision was automatically updated to reflect the committed changes. Closed by commit rG79d5d9a0824d: [lldb] Allow synthetic providers in C++ and fix linking problems (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/ne

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace added a comment. > add a way to make an SBTypeSynthetic from the appropriate C++ class That's a great idea. Once we implement a couple of providers for our plugin I'll revisit the idea. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115033/new/ https://reviews.llvm.org/D115033 __

[Lldb-commits] [PATCH] D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115137/new/ https://reviews.llvm.org/D115137 ___

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. back to your queue until you get things working Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace added a comment. good job! Only some cosmetic changes are needed and you also need to delete the python code Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:775-779 + // AddCXXSummary(cpp_category_sp, + // lldb_private::formatte

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 ___

[Lldb-commits] [PATCH] D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one

wallace closed this revision. wallace added a comment. committed as 2ea3c8a50add5436cf939d59c3235408ca0255c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://re

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace added a comment. committed as cfb075089128b2e5918afd0ce21ec10bf455e5ab Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 __

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. much nicer than the first version. I'm just asking a few minor things. Comment at: lldb/include/lldb/Host/FileSystem.h:147 + /// + /// The path must specify a f

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324 _

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:279 m_mutex; // Provide thread safety for this symbol table - bool m_file_addr_to_index_computed : 1, m_name_indexes_computed : 1; + bool m_file_addr_to_index_computed : 1, m_name_indexes_comput

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some important remarks to the data formatter documentation. Repository: rG LLVM Github Monorepo https:

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 _

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

wallace updated this revision to Diff 397667. wallace added a comment. per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115974/new/ https://reviews.llvm.org/D115974 Files: lldb/docs/use/variable.rst Index: lldb/docs/use/variable.rst =

[Lldb-commits] [PATCH] D117288: [LLDB][NFC] Fix a typo in comment

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117288/new/ https://reviews.llvm.org/D117288 __

[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

wallace added a comment. good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119400/new/ https://reviews.llvm.org/D119400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

wallace added a comment. I agree with labath. Specially because I wouldn't like the user having aborted debug sessions if their setup takes longer than 10 seconds to get the process ready, which I imagine might happen with android or oculus devices using custom launch configs. What about using

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

wallace added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:256 void SourceInitFileHome(CommandReturnObject &result, bool is_repl); + void SourceSystemInitFile(CommandReturnObject &result); JDevlieghere wrote: > `SourceInit

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/tools/lldb-vscode/VSCode.cpp:533 + // Wait for the process hit a stopped state. When running a launch (with or + // without "launchCommands") or att

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. you got the flow correct. I left comments regarding specific details, but good job overall!! Comment at: lldb/docs/lldb-gdb-remote.txt:454-479 +//}], +//

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. in terms of functionality, everything is right, but you need to do some improvements Comment at: lldb/docs/lldb-gdb-remote.txt:454-479 +//}], +//... othe

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. I'm assuming this passes all tests locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120755/new/ https://reviews.llvm.org/D120755 ___

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added a comment. Thanks @davidca and @labath for chiming in. @jj10306, please rename IntelPTManager to IntelPTCollector for clarity. Comment at: lldb/docs/lldb-gdb-remote.txt:469 +// +//tsc_rate: { +// kind: "perf", davidca wrote: > why is all

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//"tsc_conversion"?: Optional<{ +// "kind": , The ? After the key name makes Optional<> redundant. Just keep the ? Comment at: lldb/docs/lldb-gdb-

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added a comment. The main change is to make the counter conversion generic, so that we don't need to add more APIs in the future. Besides that, you don't need to make any drastic change. Good job so far! Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//"tsc_conversion"?: Optional<{ +// "kind": , wallace wrote: > wallace wrote: > > wallace wrote: > > > The ? After the key name makes Optional<> redundant. Just keep

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

wallace created this revision. wallace added reviewers: persona0220, jj10306. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As previously discussed with @jj10306, we

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. @jingham, that's a pretty good idea. We'll see how to implement it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https:/

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

wallace added inline comments. Comment at: lldb/include/lldb/Core/PluginManager.h:346 - static TraceCreateInstanceForSessionFile + static TraceCreateInstanceForBundle GetTraceCreateCallback(llvm::StringRef plugin_name); jj10306 wrote: > nit: `FromBundle`

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current way ot traversing the cursor is a bit uncommon and it can't handl

[Lldb-commits] [PATCH] D128707: [lldb] Fix build on older Linux kernel versions

wallace added a comment. Herald added a subscriber: JDevlieghere. thanks a good point, Jakob. Let's keep it in mind. Maybe we can bootcamp that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128707/new/ https://reviews.llvm.org/D128707

[Lldb-commits] [PATCH] D128707: [lldb] Fix build on older Linux kernel versions

wallace added a comment. @kongyi thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128707/new/ https://reviews.llvm.org/D128707 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. remove unwanted files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 ___ lldb-comm

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:38 +void TraceCursorIntelPT::Next() { + m_pos += IsForwards() ? 1 : -1; jj10306 wrote: > should only do this increment or decrement if `HasValue()` is true? ot

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added inline comments. Comment at: lldb/include/lldb/Core/Disassembler.h:82-86 + lldb::InstructionControlFlowType + instruction_decode(uint8_t opcode, uint8_t modrm, uint8_t map); + + lldb::InstructionControlFlowType + GetControlFlowInstructionKind(const ExecutionCont

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added a comment. nice job!! Comment at: lldb/source/Commands/Options.td:304 + def disassemble_options_kind : Option<"kind", "k">, +Desc<"Show instruction control flow type.">; def disassemble_options_context : Option<"context", "C">, Arg<"NumLines">, ---

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D128453 recently added some safety checks for comman

[Lldb-commits] [PATCH] D128576: [trace] Make events first class items in the trace cursor and rework errors

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:171 + /// information failed to load, an \a llvm::Error is returned. + virtual llvm::Expected + CreateNewCursor(Thread &thread) = 0; jj10306 wrote: > Do we want to keep the cursor

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

wallace added a comment. what happens is that the specific failures are triggered by tests that require the cmake flag LIBIPT_INCLUDE_PATH to be configured, but all good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128775/new/ https://reviews.llv

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128874/new/ https://reviews.llvm.org/D128874 __

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

wallace added a comment. i can do it right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128874/new/ https://reviews.llvm.org/D128874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. much better! Thanks for doing this. There are two main things to do. 1. The algorithm you are using to classify the instructions uses too many acronyms and it's very well document

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. let's try to have tests soon. It seems that the code can be simplified and tests will be very handy Comment at: lldb/include/lldb/lldb-enumerations.h:976 + eIns

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A trace bundle contains many trace files, and, in the case of intel pt, the l

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582 } - + Target *target = m_exe_ctx.GetTargetPtr(); many formatting changes sneaked in. The actual changes are in the end of this file ===

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442759. wallace added a comment. minor improvements for autocompletion in the CLI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings/interface/SBT

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442765. wallace added a comment. make relative all paths being returned in the description file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442769. wallace added a comment. improve command handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings/interface/SBTrace.i lldb/include/ll

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442770. wallace added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings/interface/SBTrace.i lldb/include/lldb/API/SBTrace.

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442779. wallace added a comment. rename 'process trace save' to 'trace save' because it can actually dump the information of multiple processes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https:

[Lldb-commits] [PATCH] D129249: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This metric was missing. We were only measuring in per-thread mode, and this

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It turns out that cgroup filtering is relatively trivial and works really nic

[Lldb-commits] [PATCH] D129332: [trace][intel pt] Support dumping the trace info in json

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to ym...@fb.com for coming up with this change. `thread trace dump in

[Lldb-commits] [PATCH] D129332: [trace][intel pt] Support dumping the trace info in json

wallace updated this revision to Diff 443097. wallace added a comment. improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129332/new/ https://reviews.llvm.org/D129332 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to fredz...@fb.com for coming up with this feature. When tracing in p

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. almost there! I like the tests btw :) Comment at: lldb/source/Commands/Options.td:304 + def disassemble_options_kind : Option<"kind", "k">, +Desc<"Show instr

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace accepted this revision. wallace added a comment. I'll commit this for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D129588: [trace] Avoid a crash in the dumper when disassembling fails

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In rare situations, disassemblying would fail that produce an invalid Instruc

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

wallace created this revision. wallace added reviewers: persona0220, jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to rnofe...@fb.com for coming up with these changes. This diff adds s

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

wallace updated this revision to Diff 444132. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129613/new/ https://reviews.llvm.org/D129613 Files: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added a comment. I'll remove the unwanted formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:318 +should_copy = true; +} else if (perf_record.IsErrorRecord()) { + should_copy = true; jj10306 wrote: > why do we want the error record?

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

wallace requested review of this revision. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyCPU(execution.thread_execution.cpu_id); + jj10306 wrote: > Does this mean our trace will alw

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:87-90 +std::string slice = line.substr(line.find_first_of("/")); +if (slice.empty()) + return None; +std::string cgroup_file = formatv("/sys/fs/cgroup/{0}", slice);

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Decouple TSCs from trace items - Turn TSCs into events just like CPUs - Add a GetWallTime that returns the wall time that

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 445664. wallace edited the summary of this revision. wallace added a comment. Herald added subscribers: jsji, pengfei. fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 445980. wallace added a comment. .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceDu

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

wallace updated this revision to Diff 446281. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130054/new/ https://reviews.llvm.org/D130054 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceDum

  1   2   3   4   5   6   7   8   9   10   >