[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459120. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/in

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459208. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/in

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f54751048b: Add SBDebugger::GetSetting() public APIs (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.l

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:86-87 + // TODO: make this function pure virtual after implementing it in all + // child classes. + virtual llvm::json::Value ToJSON(const ExecutionContext *exe_ctx) {

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg , it is my intention to make `target.auto-deduce-source-map` boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I f

[Lldb-commits] [PATCH] D133908: Add auto deduce source map setting

yinghuitan created this revision. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new "target.auto-deduce-source-map" setting. If enabled, this setting may auto deduce a sourc

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460270. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive = request_file.IsCas

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460578. yinghuitan added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460973. yinghuitan added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h ll

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

yinghuitan added a comment. Do you plan to detect missing dwp file from `SymbolFileDWARF::GetDwpSymbolFile()` as well? Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755-1756 cu_die.GetAttributeValueAsString(dwarf_cu, DW_AT_comp_dir, nullptr);

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. Technical wise this patch looks good. One concern is that these error messages are user facing but we are making it favoring debugging, like skeleton DIE, showing the DIE offset etc...

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds auto

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan updated this revision to Diff 462298. yinghuitan added a comment. rebase and trigger linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/ https://reviews.llvm.org/D134483 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5073ed5f929: Add auto source map deduce count statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/ https://review

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM pending Pavel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 ___

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. I think @labath or anyone owns the ELF coredump debugging should take a look. I am surprised other major companies did not hit this issue. Otherwise, LGTM Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-vscode

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan updated this revision to Diff 466909. yinghuitan added a comment. Add comment per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/ https://reviews.llvm.org/D135620 Files: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

This revision was automatically updated to reflect the committed changes. Closed by commit rGef25a217266a: Prevent lldb-vscode tests from source lldbinit file (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/ https:

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468591. yinghuitan added a comment. Use async model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468592. yinghuitan added a comment. Update message per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468593. yinghuitan added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscod

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There is a

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469374. yinghuitan added a comment. Directly raise signal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469376. yinghuitan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldb

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://rev

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG51effa57818b: Fix exception description in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.l

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -# Trailing newline is needed for splitlines() -logMessage = logMessage_prefix + "{i +

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 470837. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Tes

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:29 +lldb::SBError BreakpointBase::AppendLogMessagePart(llvm::StringRef part, + bool is_expr) { + if (is_expr) { clayb

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:306 } + output.push_back('\n'); // Ensure log message has line break. g_vsc.SendOutput(OutputType::Console, output.c_str()); clayborg wrote: > I would still only push o

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471314. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Te

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:143 +llvm::StringRef value = v.GetValue(); +llvm::StringRef summary = v.GetSummary(); +llvm::StringRef type_name = v.GetType().GetDisplayTypeName(); Sorry for the late

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471318. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/Tes

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471676. yinghuitan added a comment. Add failure case testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files: lldb/test/API/tools/lldb-vscode/breakpoint/T

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8995649afa: Add formatting support for VSCode logpoints message (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https:

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

yinghuitan requested changes to this revision. yinghuitan added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/SymbolFileOnDemand.h:121 + lldb_private::Status + CalculateFrameVariableError(lldb_private::StackFrame &frame) ov

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:600 + // no member variables or member functions will be available. + if (GetCompilerType().IsForcefullyCompleted()) { + destination = ""; Is this shown in lldb-vscode? If so, c

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added a comment. Also, do you have any plan to record this happening in statistics dump so that our telemetry can report it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138259/new/ https://reviews.llvm.org/D138259 ___

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c16f89124f: Add runToBinaryEntry option for lldb-vscode (authored by yinghuitan). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D138536: Fix TestVSCode_launch.py test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, GeorgeHuyubo, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We changed the output to telemetry category but the test

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan added a comment. The test failure is fixed in https://reviews.llvm.org/D138536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 ___ lldb-commits maili

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch add

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan abandoned this revision. yinghuitan added a comment. Discussed offline. We can't rely on initialized event because it has to happen before all breakpoints are set. Will create a new design for htis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, wallace. Herald added a subscriber: jfb. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VScode now sends a "scopes" DAP request immediately after any expres

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355435. yinghuitan marked 37 inline comments as done. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files:

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355436. yinghuitan marked an inline comment as done. yinghuitan added a comment. Rerun linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files: lldb/tools/l

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355437. yinghuitan added a comment. rebase to latest master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files: lldb/tools/lldb-vscode/VSCode.cpp lldb/tools

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:531 +void Variables::Clear() { + locals.Clear(); clayborg wrote: > I am not sure. I like to call it Clear() in cause we will need to call it from other scenario beyond process co

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355942. yinghuitan marked 13 inline comments as done. yinghuitan added a comment. Address review comments and add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 360281. yinghuitan marked 33 inline comments as done. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files:

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:386-389 +var_ref = permanent_expr_varref_dict[expandable_expression['name']] +response = self.vscode.request_variables(var_ref) +self.verify_va

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 360340. yinghuitan added a comment. Last push failed to include the changes due to git issue. Push including the real changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added a comment. Debug console and VScode UI synchronization is a much bigger topic than instruction level stepping so I do not plan to fix in this patch. For example, if user change value via lldb comamnd, the watch/locals won't change. If user switch stack frames/threads, it won't

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:83 +struct Variables { + // Bit mask to tell if a variableReference is inside wallace wrote: > yinghuitan wrote: > > wallace wrote: > > > Move it to a new file and add a global comme

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2812 +g_vsc.variables.IsPermanentVariableReference(variablesReference); +g_vsc.variables.InserExpandableVariable(variable, is_permanent); } clayborg wr

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 361815. yinghuitan marked 4 inline comments as done. yinghuitan added a comment. Fix the issue in setVariable request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D1051

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1790 g_vsc.focus_tid = thread.GetThreadID(); +g_vsc.WillContinue(); thread.StepOver(); clayborg wrote: > Remove and handle in "eStateStopped" or "eStateRunning" as

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9139acb85a4: Fix expression evaluation result expansion in lldb-v

[Lldb-commits] [PATCH] D96623: [lldb-vscode] Fix lldb init file stdout issue

yinghuitan created this revision. yinghuitan added reviewers: clayborg, aadsm. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VScode DAP client uses stdout to receive protocol message. This means any stdout/stderr from debugger

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

yinghuitan added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:96 const uint32_t header_size = *offset_ptr - m_offset; const uint32_t tuple_size = m_header.addr_size << 1; uint32_t first_tuple_offset = 0; Unrel

<    1   2