[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. > Can you say (in english) what are the properties that you are trying to check > there? Maybe we can find a better way to do that... I'm trying to check for local variables values in inline functions by printing them (see inline comment on `PdbAstBuilder::ParseBlockCh

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 418094. zequanwu added a comment. - change live debugging test to cpp file. - mirror fix on previous change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 419521. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update live debugging test to build with no optimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp:7 +// RUN: %p/Inputs/inline_sites_live.lldbinit 2>&1 | FileCheck %s + +inline int bar(int bar_param) { labath wrote: > ``` > void __attribute__((optnone)) u

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45975cbf96a: [LLDB][NativePDB] Create inline function decls (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://revie

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Thanks for reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a variable is simple type and has 64 bits, the debug info may look like the f

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It fixes the following case: 0602 line 1 (+1) 0315 code 0x15 (+0x15) 0B2B code 0x20 (+0xB) line 2 (+

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu planned changes to this revision. zequanwu added a comment. Plan to apply similar change in D123151 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092 ___

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu updated this revision to Diff 421281. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122943/new/ https://reviews.llvm.org/D122943 Files: lldb/source/Plugins/Sym

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54 struct FindMembersSize : public TypeVisitorCallbacks { - FindMembersSize(std::vector> &members_info, + FindMembersSize(llvm::SmallVector> &members_info, TpiS

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu updated this revision to Diff 421352. zequanwu added a comment. Modity inline_sites.test to do non-live test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092 Files: lldb/source/Plugins/SymbolFi

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122943/new/ https://reviews.llvm.org/D122943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

This revision was automatically updated to reflect the committed changes. Closed by commit rGef7cba71486d: [LLDB][NativePDB] Fix inline line info in line table (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https:/

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dbf524ad75b: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu added a comment. In D122943#3453663 , @augusto2112 wrote: > Hi @zequanwu, your patch's new test seems to be failing on CI > (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). Could you fix > it or revert the changes? Thanks! Thanks

[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, I was assuming that S_DEFRANGE_SUBFIELD_REGISTERs are always in the inc

[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa2734690ff: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of… (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D124061?vs=423800&id=423957#toc Rep

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu created this revision. zequanwu added reviewers: labath, clayborg, jasonmolenda. Herald added subscribers: atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-c

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu planned changes to this revision. zequanwu added a comment. Thanks for the feedback. As you pointed out that stack scanning without symbol file info is fragile due to function pointers in stack and we don't know the parameter size pushed into the stack. Originally, I want lldb to do co

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu updated this revision to Diff 425928. zequanwu marked 4 inline comments as done. zequanwu added a comment. Update: address some inline comments. For testing, I don't know how to create minidump in yaml format like the one in `lldb/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-stack-w

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu added inline comments. Comment at: lldb/include/lldb/Symbol/UnwindPlan.h:225 + // Not the first search. + m_value.ra_search.search_offset |= 1; +} clayborg wrote: > What is this magic number/bit here? Is it ok to clobber bit zer

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu updated this revision to Diff 425930. zequanwu added a comment. Use extra bool variable for is_first_search, because search_offset might be an odd number if parameter byte size in stack is an odd number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu added inline comments. Comment at: lldb/include/lldb/Symbol/UnwindPlan.h:266 + int32_t GetRaSearchOffset() const { +return m_type == isRaSearch ? m_value.ra_search.search_offset & ~1 : 0; + } zequanwu wrote: > clayborg wrote: > > Are we

[Lldb-commits] [PATCH] D125509: [WIP][LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu created this revision. Herald added subscribers: hiraditya, mgorny. Herald added a reviewer: shafik. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. NativePDB often assumes that all debug info are available. This is one step to make it

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 430502. zequanwu added a comment. Add missing sort. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/lldb/Expression/DWARFExpression.h lldb/in

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 431022. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/dwp.s:22-23 # SYMBOLS-NEXT: Block{{.*}}, ranges = [0x-0x0001) -# SYMBOLS-NEXT: Variable{{.*}}, name = "x", {{.*}}, location = -# SYMBOLS-NEXT: DW_LLE_startx_length (0x

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c9f3ec4ad5d: [LLDB][NativePDB] Check for missing type info to avoid crash. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125844/new/

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - return Callback(Loc.takeError()); -if (*Loc) + consumeError(Loc.takeError()); +else if (*Loc) rnk wrote: > Did this change cause the pres

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 435625. zequanwu added a comment. Add missing check for Expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/lldb/Expression/DWARFExpressi

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - return Callback(Loc.takeError()); -if (*Loc) + consumeError(Loc.takeError()); +else if (*Loc)

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 437316. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. > The main thing I am wondering is if it wouldn't be better to (instead of > essentially duplicating the DWARFExpression interface in the > DWARFExpressionList class) somehow split the process of finding the > appropriate expression (for the given PC value or whatever)

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 438817. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:179 + if (m_exprs.GetSize() == 1) { +expr = m_exprs.Back()->data; + } else { labath wrote: > I don't think this is correct. > > We should be able to distinguish betw

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a subscriber: arphaman. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Usually PDB files have a string table (aka: Named

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG960126e04a6f: [LLDB][NativePDB] Check string table in PDB files. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145115/new/ https://r

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( int3 wrote: > Any reason why this doesn't instead store the module n

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

zequanwu created this revision. zequanwu added reviewers: labath, rnk, aganea. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two age fields in a PDB file. One from the PDB Stream and another

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9a7c22ee67: [LLDB][PDB] Fix age field in UUID in PDB file. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152189/new/ https://revie

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Since every FUNC record (in breakpad) is a compilation unit, creating t

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 384815. zequanwu marked an inline comment as done. zequanwu added a comment. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name)

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name)

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name)

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name)

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385109. zequanwu added a comment. Add FindFunctions. Remove the loop that adds FUNC to symtab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files: lldb/source/P

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Teach LLDB to understand INLINE and INLINE_ORIGIN records in breakpad.

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 385657. zequanwu marked an inline comment as done. zequanwu added a comment. add argument comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/ https://reviews.llvm.org/D113330 Files: lldb/inc

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385896. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files: lldb/source/P

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard guard(GetModuleMutex()); + if (!(name_type_mask & eFunctionNameTypeMethod)) +return; labath wrote: > How did you come to pick th

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 385903. zequanwu marked an inline comment as done. zequanwu added a comment. Use empty callsite_file or name if index is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/ https://reviews.

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

zequanwu created this revision. zequanwu added reviewers: labath, shafik. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As the deleted comment says, we don't care about the access specifier. I also encountered a crash at here (ca

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf665a0086c: [LLDB][Breakpad] Create a function for each compilation unit. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 386256. zequanwu added a comment. Rebased and add test cases for out of range file/origin index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/ https://reviews.llvm.org/D113330 Files: lldb/includ

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9ced0ed420: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in… (authored by zequanwu). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu created this revision. zequanwu added reviewers: rnk, labath, teemperor, shafik. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. I don't know how to add tests for this. I tested

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. `image lookup -a ` doesn't work because the compilands list is always e

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu added a comment. > The ast thing could be tested by running "image dump ast" on an appropriate > piece of debug info. I didn't observe any difference before and after this patch with `image dump ast` tested on https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/SymbolFile/N

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu updated this revision to Diff 387348. zequanwu marked an inline comment as done. zequanwu added a comment. Use `/base:0x40` in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821 Files

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a split of D113724 . Calling `TypeSystemClang::AddMethodToCXXRecordType`

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu abandoned this revision. zequanwu added a comment. Splitted into D113821 and D113930 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113724/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

zequanwu abandoned this revision. zequanwu added a comment. D113930 is the correct fix for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113533/new/ https://reviews.llvm.org/D113533

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

This revision was automatically updated to reflect the committed changes. Closed by commit rGf17404a733c1: [LLDB][NativePDB] Fix image lookup by address (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D113821?vs=387348&id=387355#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu added a comment. In D113821#3133324 , @stella.stamenova wrote: > I think this broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Thanks, hopefully this will fix it: rGb6d35352304601925bc1c055106949d2e27b3975

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu planned changes to this revision. zequanwu added a comment. I realized that the test case here is incorrect, because the output of `lldb-test symbols dump-ast ...` shows `void virtual_method()` twice. The `void virtual_method()` without `virtual` is created by the new code. Because `ll

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't see a reason why not to. If we allows lookup functions by full names, I can change the test case in D113930

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

This revision was automatically updated to reflect the committed changes. Closed by commit rG22ced33a2f76: [LLDB][NativePDB] Allow find functions by full names (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114467/new/ https:/

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 389364. zequanwu added a comment. This revision is now accepted and ready to land. Use `lldb-test symbols --find=function --name=full::name --function-flags=full` for testing. Add some information about static/virtual/artificial and access type. Repository

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a reviewer: rnk. zequanwu marked an inline comment as done. zequanwu added a subscriber: rnk. zequanwu added a comment. Add @rnk for code view records reading part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://re

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu added a comment. In D114467#3158778 , @stella.stamenova wrote: > This broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/12270 > > I'd like to get it back to green, so please address this ASAP or I'll follow > up with

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu added a comment. In D114467#3158960 , @stella.stamenova wrote: > @zequanwu : It looks like the bot is still broken: > https://lab.llvm.org/buildbot/#/builders/83/builds/12413 The printed names are different between windows and linux. https://

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 390845. zequanwu added a comment. Handle OverloadedMethodRecord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/SymbolFile/NativePDB/Pd

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 390847. zequanwu added a comment. use lower case for parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/SymbolFile/NativePDB/Pd

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391115. zequanwu marked an inline comment as done. zequanwu added a comment. Fix style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp:89 +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (void)" +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (char)" +// FIND-OVERLOAD: FuncType: id = {

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391147. zequanwu added a comment. Select correct the OneMethodRecord for overloaded method by checking TypeIndex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Fil

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391454. zequanwu added a comment. Add test with `lldb-test symbols --dump-ast` though it printed the methods twice. It is considered a separate bug that could be fixed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `PdbAstBuilder::GetParentDeclContextForSymbol` finds the public symbol that has sam

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 457752. zequanwu added a comment. Herald added a subscriber: JDevlieghere. Fix comment in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133243/new/ https://reviews.llvm.org/D133243 Files: lldb/so

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:634-659 +name_components = name_components.drop_back(); +if (!name_components.empty()) { + // Render the current list of scope nodes as a fully qualified name, and

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 458299. zequanwu added a comment. - Removed `GetParentDeclContextForSymbol` as this is not necesssary. We can get the demangled names from CVSymbol and then using it to create tag decl or namespace decl. - Add test cases with same base names, but with diffe

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a crash that mistaken global ctor/dtor as funciton methods. Repository

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 458583. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The block address range was missing before. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b825dcdb267: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D133243?vs=458299&id=458794#toc Repos

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

This revision was automatically updated to reflect the committed changes. Closed by commit rG32530e0493c1: [LLDB][NativePDB] Set block address range. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133461/new/ https://reviews.l

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 459145. zequanwu added a comment. Update test case after moving the check into `CreateDeclInfoForUndecoratedName`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Fi

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3779600 , @labath wrote: > I believe that this fixes the crash, but the names of generated functions > still look fairly weird. Could we create them using their mangled name > instead? That way, someone might actuall

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, it returns the outermost blocks if nested blocks have the same address rang

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/blocks.cpp:17 + +// CHECK: Function: id = {{.*}}, name = "main", range = [0x000140001000-0x00014000104b) +// CHECK-NEXT: FuncType: id = {{.*}}

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we don't add local variables with no location info, when trying to print it, lld

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedad60231fc: [LLDB][NativePDB] Add local variables with no location info. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133626/new/

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3786561 , @labath wrote: > In D133446#3780961 , @zequanwu > wrote: > >> In D133446#3779600 , @labath wrote: >> >>> I believe that thi

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3788956 , @labath wrote: > In D133446#3787362 , @zequanwu > wrote: > >> In D133446#3786561 , @labath wrote: >> >>> In D133446#3780961

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 460152. zequanwu added a comment. Move the logic into `MSVCUndecoratedNameParser`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Plugins/Langu

<    1   2   3   >