zequanwu added inline comments.
================
Comment at:
lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392
for (llvm::StringRef line : lines(Record::Func)) {
if (auto record = FuncRecord::parse(line))
add_symbol(record->Address, record->Size, record->Name);
}
----------------
labath wrote:
> Can you check if we can remove this now?
>
> I originally thought that we can remove this entire function, but I forgot
> about PUBLIC records -- we don't have functions or compile units for those,
> so they will have to stay.
Removing it causes FUNC records not showing up in symtab when doing `image dump
symtab ...` and fails some tests.
The Breakpad doc says
(https://chromium.googlesource.com/breakpad/breakpad/+/HEAD/docs/symbol_files.md#records-4):
> If a given address is covered by both a PUBLIC record and a FUNC record, the
> processor uses the FUNC data.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113163/new/
https://reviews.llvm.org/D113163
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
