[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

zequanwu added inline comments. Comment at: lldb/CodeOwners.rst:132 + +Breakpad + labath wrote: > @zequanwu I accept this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu created this revision. zequanwu added reviewers: shafik, labath, teemperor. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows access type be printed when running `lldb-test -dump-ast` and `lldb-test -dump-clang-a

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 391734. zequanwu added a comment. Add tests for alternating access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 Files: lldb/source/Plugins/TypeSystem/Clang/Typ

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 391740. zequanwu added a comment. Use a map to keep CXXRecordDecl to last added AccessSpecifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 Files: lldb/source

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1356 +clang::AccessSpecifier previous_access = clang::AccessSpecifier::AS_none; +for (DeclContext::decl_iterator I = cxx_record_

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391775. zequanwu added a comment. Deduplicate method decls in a class/struct by method's name and CompilerType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp:89 +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (void)" +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391777. zequanwu added a comment. Fix stale comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

zequanwu updated this revision to Diff 392126. zequanwu marked an inline comment as done. zequanwu added a comment. Erase the cxx_record_decl entry from map after completing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://revi

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a comment. In D113930#3173181 , @labath wrote: > While I'm not very familiar with PDBs or the process of clang ast creation, > it sounds to me like there is something wrong here, and I want to make sure > we're not using the deduplication

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a comment. In D113930#3174406 , @labath wrote: > I still think that the piecemeal addition of member functions is a problem. > While I don't think that changing the parsing order in > `Module::ParseAllDebugSymbols` would be a problem (tha

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a8ed33a1d6: [LLDB][NativePDB] Fix function decl creation for class methods (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D113930?vs=391777&id=392465#toc Repository: rG L

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

zequanwu created this revision. zequanwu added reviewers: labath, shafik, teemperor. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115308 Files: lldb/source/Plug

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

zequanwu updated this revision to Diff 392932. zequanwu added a comment. I found that is actually a problem in TypeList. We need to uniquify Type in TypeList. - Use an additional set of `Type*` to check if it exists or not. - Print number of types in TypeList. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu added a comment. In D115308#3184564 , @shafik wrote: > I would also like to know where this duplicate insertion is happening. Can > you walk us through the steps that lead to the duplicate entries? thank you! Firstly, I found that `SymbolFileDW

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu updated this revision to Diff 395543. zequanwu added a comment. Revert back to first diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://reviews.llvm.org/D115308 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPa

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu added a comment. In D115308#3189261 , @labath wrote: > I don't know whether the types should be uniqued at this level (obviously, > they should be uniqued somewhere), but these are the thoughts that spring to > mind: > > - if this is a problem

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu created this revision. zequanwu added reviewers: labath, clayborg. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems like that line entries in line table are assumed to always have distinct file address. This allows

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3f0e1ea3ef8: [LLDB][DWARF] Fix duplicate TypeSP in type list (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://revi

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu added a comment. In D116195#3207672 , @labath wrote: > How are you planning to make use of this functionality? > > I'm asking because I'm wondering if it wouldn't be better to do this kind of > processing in the PDB code, and then hand this clas

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu added a comment. In D116195#3211346 , @labath wrote: > In D116195#3208476 , @zequanwu > wrote: > >> In D116195#3207672 , @labath wrote: >> >>> How are you planni

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5b6e30ed3ac: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu created this revision. zequanwu added reviewers: labath, rnk, akhuang. Herald added a subscriber: arphaman. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This adds inline func

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu updated this revision to Diff 398772. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Store "temporary" line table in `CompileUnitIndex`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/ http

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu added a comment. > The one part that bothers me is the "two-phased" setting of line tables. > IIUC, the problem is that the inline line info is in the block descriptor, so > you need to parse block info in order to create a line table, but in order to > actually create an lldb_private:

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu updated this revision to Diff 399001. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/ https://reviews.llvm.org/D116845 Files: lldb/include/lldb/Symbo

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG945aa520ef07: [LLDB][NativePDB] Add support for inlined functions (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116845/new/ https://

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3e1ba1d0392: [LLDB] add sub regigter enums on x64 Windows (authored by zequanwu). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu created this revision. zequanwu added a reviewer: stella.stamenova. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This attempts to fix this bot failure: https://lab.llvm.org/buildbot/#/builders/83/builds/14736 caused by

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu updated this revision to Diff 405505. zequanwu added a comment. Un-xfail more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118866/new/ https://reviews.llvm.org/D118866 Files: lldb/test/API/commands/register/register/register_com

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu added inline comments. Comment at: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46 @skipIfTargetAndroid() # debuggerd interferes with this test on Android @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG607ffa5515b9: [LLDB] Fix window bot failure (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118866/new/ https://reviews.llvm.org/D1188

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu added a comment. In D118866#3294695 , @stella.stamenova wrote: > Thanks! > > It looks like there's a failure that was previously hidden by the unexpected > passes: > > https://lab.llvm.org/buildbot/#/builders/83/builds/14781 > > It seems like i

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows `image lookup -a ... -v` to print variables only if the given address is covered by the valid ranges of

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added a comment. In D119963#3327139 , @jingham wrote: > It's really useful to be able to see these variable ranges, so the feature > seems good to me, but I think the valid range output should be governed by > another flag, like --show-variable

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 409440. zequanwu added a comment. Herald added a subscriber: dang. Add `-show-variables-ranges`/`-R` flag to enable it with `-v`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:16 +# CHECK-LABEL: image lookup -v -a 0 -R +# CHECK: Variable: {{.*}}, name = "x0", type = "int", location = DW_OP_reg5 RDI, decl = , valid ranges = +# CHECK: Variable: {{.*}}, name = "x

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added a comment. > It is a little awkward to put it in "image lookup -va" however, and odder to > have it be part of the printing of an Address. It seems more like something > you should ask a function? When you look up a function, using `image lookup -n main`, it

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 410679. zequanwu added a comment. - Use `-show-variable-ranges/-R single/all` to dump single addres range that contains the querying address or all address ranges. It seeme like I can't use non-printable character like `\\x01` to omit short option when it t

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 410882. zequanwu marked 3 inline comments as done. zequanwu added a comment. - Remove short option. `-show-variable-ranges` prints all ranges. If not given, only print single range. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 411203. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.org/D119963 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/source/Core/Address.cpp:739 - s->PutCString(", location = "); - var_sp->DumpLocationForAddress(s, *this); - s->PutCString(", decl = "); labath wrote: > This place was the only

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 411446. zequanwu marked 5 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.org/D119963 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 411898. zequanwu marked 2 inline comments as done. zequanwu added a comment. Remove unnecessary `location_list_base_addr` parameter from `GetDescription()` as it doesn't do filtering when dumping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c9e20d7d0a7: [PDB] Add char8_t type (authored by zequanwu). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 412532. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.org/D119963 Files: lldb/include/l

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/source/Commands/Options.td:962 +"\\x01">, GroupRange<1, 6>, Desc<"Dump valid ranges of variables (must be " +"used in conjunction with --verbose">; def target_modules_lookup_verbose : Option<"verbose", "v">,

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG15983c28aa81: [LLDB] Dump valid ranges of variables (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added a comment. In D119963#3355563 , @jingham wrote: > In D119963#3355501 , @zequanwu > wrote: > >> Address comments > > This sort of thing is hard to check in the option groups w/o blowing out the > n

[Lldb-commits] [PATCH] D120961: [LLDB] Flush stream at the end of PrintCommandOutput

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Windows, lldb doesn't print any error message until exit. This fixes it. Repositor

[Lldb-commits] [PATCH] D120961: [LLDB] Flush stream at the end of PrintCommandOutput

This revision was automatically updated to reflect the committed changes. Closed by commit rGb31a1b4746c7: [LLDB] Flush stream at the end of PrintCommandOutput (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120961/new/ https:/

[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

zequanwu added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:752 eBasicTypeChar32, + eBasicTypeChar8, eBasicTypeShort, ljmf00 wrote: > You forgot to add it to the Python API. It should also be added at the end to > avoid user-code bre

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

zequanwu updated this revision to Diff 414210. zequanwu marked 3 inline comments as done. zequanwu edited the summary of this revision. zequanwu added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

zequanwu updated this revision to Diff 414464. zequanwu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119508/new/ https://reviews.llvm.org/D119508 Files: lldb/include/lldb/Utility/RangeMap.h lldb/source/Plugins

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e9c9b324a1f: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Fix infinite recursion when a class has static member with the class type.

zequanwu updated this revision to Diff 414529. zequanwu added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We simply shouldn't complete the types of static members at all, which is how dwarf does it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu updated this revision to Diff 415213. zequanwu added a comment. Testing with `image lookup -type` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030 Files: lldb/source/Plugins/SymbolFile/NativePDB

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1; labath wrote: > Would it be possible to put thi

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 439814. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/l

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227dffd0b6d7: [LLDB][NFC] Decouple dwarf location table from DWARFExpression. (authored by zequanwu). Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. In D125509#3637271 , @dyung wrote: > Hi @zequanwu, your change is causing a test failure in the cross-project-test > suite on the PS4 linux bot. Can you take a look and revert if you need time > to investigate? > > https://lab.

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129807 Files: lldb/source/Plugins/SymbolFile/NativePDB

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu updated this revision to Diff 445081. zequanwu added a reviewer: rnk. zequanwu added a comment. add testscase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129807/new/ https://reviews.llvm.org/D129807 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp lldb/source

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu added a comment. In D129807#3654447 , @DavidSpickett wrote: > Is this fixing a specific situation and if so, can a test be written for it? > I'm sure we have existing tests you can adapt. It fixed the issue

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

zequanwu updated this revision to Diff 445942. zequanwu marked 3 inline comments as done. zequanwu edited the summary of this revision. zequanwu added a comment. Use PointerToMemberRepresentation in pdb to get inheritance attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when creating pointer type that is a pointer to member.

This revision was automatically updated to reflect the committed changes. zequanwu marked 2 inline comments as done. Closed by commit rGb8cf916b89d4: [LLDB][NativePDB] Add MSInheritanceAttr when creating pointer type that is a… (authored by zequanwu). Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, NativePDB uses scoped range as a workaround for value range, that causes problems (e.g. a variable's value can o

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. > If you find yourself needing to do extra work to work its limitations, we > should fix that algorithm instead. That makes sense. I'll work on fixing `RangeVectorData`. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:37-39 + if (m_exprs.

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a reviewer: shafik. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is needed for object files with MS ABI and de

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3691227 , @zequanwu wrote: >> If you find yourself needing to do extra work to work its limitations, we >> should fix that algorithm instead. > > That makes sense. I'll work on fixing `RangeVectorData`. After thinkin

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3696351 , @labath wrote: > In D130796#3692243 , @zequanwu > wrote: > >> In D130796#3691227 , @zequanwu >> wrote: >> If you find

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 450408. zequanwu added a comment. - Recurse into parent classes when filling the offset to size map. - Previously the range parsed earlier is preferred, now it's the range parsed later is preferred, since it makes the code cleaner and it doesn't really matt

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 452031. zequanwu added a comment. - Add missing test case for simple type because subfield_register_simple_type.s is deleted, forgot to add it before. - Address rnk's comment by only accepting subfield locations that are on register, because we don't have t

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(resul

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG71d778f33e86: [LLDB][NativePDB] Switch to use DWARFLocationList. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D130796?vs=452031&id

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > mstorsjo wr

[Lldb-commits] [PATCH] D132187: [LLDB] Remove duplicate loop in FindMatchingModuleSpec.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The removed loop is the same as the one above it. If previous one success, it returns.

[Lldb-commits] [PATCH] D132187: [LLDB] Remove duplicate loop in FindMatchingModuleSpec.

zequanwu abandoned this revision. zequanwu added a comment. Herald added a subscriber: JDevlieghere. NVM, didn't see `exact_arch_match` is false in the second search. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132187/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu created this revision. zequanwu added a reviewer: JDevlieghere. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `CommandObject::CheckRequirements()` requires m_exe_ctx being cleaned up. Repos

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu updated this revision to Diff 455311. zequanwu added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/ https://reviews.llvm.org/D132397 Files: lldb/source/Interpreter/CommandObject.cpp lldb/test/She

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d56ddac1bf: [LLDB] Clean up after command fails (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu updated this revision to Diff 415501. zequanwu marked an inline comment as done. zequanwu added a comment. Remove `REQUIRES: system-windows`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030 Files

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1; labath wrote: > zequanwu wrote: > > labath wrot

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG583223cd5ec4: [LLDB][NativePDB] Don't complete static members' types when completing a record… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This creates inline functions decls in the TUs where the funcitons are inlined. Repository: rG LLVM Github Monorepo h

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 416621. zequanwu added a comment. Fixing bugs and refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstB

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. I think adding a live debugging test case is necessary. I found several bugs when working on this via live debugging the compiled `inline_sites.s` and printing variables, and those bugs were not revealed by `image lookup`. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417413. zequanwu marked an inline comment as done. zequanwu added a comment. - Split the inline_sites.s test into two. One for live testing on windows, another one for all platforms. - Fix wrong variable address range when there are gaps. Repository: rG

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417414. zequanwu added a comment. Use `cast` instead of `dyn_cast`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Plugins/SymbolFile/NativePDB

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. > I'd consider writing the live test case in c++ (with judicious use of > always_inline, noinline, etc. attributes) I think it's better to just add live test case on compiled `inline_sites.s` so the test result is not influenced by optimization change. =

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417419. zequanwu added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417432. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/P

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1155 + TypeDeserializer::deserializeAs(parent_cvt, sir)); + parent = GetOrCreateNamespaceDecl(sir.String.data(), *parent); +} rnk wrote: > Can

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417701. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1124 + // Inlinee is the id index to the function id record that is inlined. + PdbTypeSymId func_id(inline_site.Inlinee, true); + // Look up the function decl by the id index

  1   2   3   >