[Lldb-commits] [PATCH] D30807: Use LLVM's directory enumeration code

This revision was automatically updated to reflect the committed changes. Closed by commit rL297598: Use LLVM for file / directory enumeration. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30807?vs=91260&id=91513#toc Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

zturner added inline comments. Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66 + int error = ::sysctlbyname(feature, &answer, &answer_size, NULL, 0); + return !error & answer; +} jasonmolenda wrote: > I see what you're doing -- this

[Lldb-commits] [PATCH] D30942: Remove some ProcFileReader occurences

zturner added a comment. Code looks much nicer than before! Comment at: source/Host/linux/Host.cpp:59-60 - static const char tracerpid_token[] = "TracerPid:"; - char *buf_tracerpid = strstr((char *)buf_sp->GetBytes(), tracerpid_token); - if (buf_tracerpid) { -// Tracer

[Lldb-commits] [PATCH] D30894: Remove lldb streams from the Log class completely

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Looks great. Comment at: tools/lldb-server/LLDBServerUtilities.cpp:59-60 if (!success) { - fprintf(stderr, "Unable to open log file '%s' for channel \"%s\"\n", -

[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

zturner added a comment. You mention that this was the cause of dependencies from `Host` to `Target`, but I don't see any `#include "lldb/Target/*.h"` statements removed. Is this an oversight or not possible yet? https://reviews.llvm.org/D31031 _

[Lldb-commits] [PATCH] D55574: Remove else statements after returns

zturner added inline comments. Comment at: source/Commands/CommandObjectTarget.cpp:2569 + } + StreamString strm; + module_spec.GetUUID().Dump(&strm); aprantl wrote: > Can you manually double-check this one? For large complex cases like

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG182b4652e542: [StringRef] Add enable-if to StringLiteral. (authored by zturner). Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c03462f52a: Some fixes for case insensitive paths on Windows. (authored by zturner). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D17492?vs=48871&id=223585#toc Repo

[Lldb-commits] [PATCH] D13617: Fix ref-counting of Python objects

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8b22f8fea18: Fix ref counting of Python objects. (authored by zturner). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

zturner added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!size || size > 8 || size & (size - 1)) +return false; --

<    26   27   28   29   30   31