zturner added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:108
@@ +107,3 @@
+if (stat_result == 0)
+*stats_ptr = *reinterpret_cast(&file_stats);
+return stat_result == 0;
cameron314 wrote:
> zturner wrote:
> >
zturner added a comment.
Very excited to see more platforms trying to get Python 3 working.
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
init_lld*
+PyInit__lld*
I don't really know what the syntax of this file is, but the symbol is called
`PyInit__
zturner added a subscriber: zturner.
zturner added a comment.
Not going to block the change over this, but just as an fyi, you can
specify regexes without usign `re.compile`. You can literally just pass a
string that is a regex, it will still work
Repository:
rL LLVM
http://reviews.llvm.org/
Not going to block the change over this, but just as an fyi, you can
specify regexes without usign `re.compile`. You can literally just pass a
string that is a regex, it will still work
On Thu, Feb 11, 2016 at 11:22 PM Nitesh Jain via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> nitesh.j
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
This is a first attempt at getting `SymbolFilePDB` working with line table
support. A few notes:
* This won't compile until a corresponding patch goes in on the LLVM side. The
patch is
zturner added a comment.
Added a few notes to clarify things that might not be obvious upon a first look
at the patch.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:81
@@ +80,3 @@
+std::string exePath = m_obj_file->GetFileSpec().GetPath();
+auto er
Yes looks fine
On Wed, Feb 17, 2016 at 8:45 PM Bhushan Attarde
wrote:
> bhushan added a comment.
>
> Hi Zachary,
>
> Can you please find some time to review this?
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D17022
>
>
>
>
___
lldb-commits
zturner added a comment.
Yes looks fine
Repository:
rL LLVM
http://reviews.llvm.org/D17022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Ahh, I guess that's why that star was there before, maybe it makes the
entire symbol optional? Anyway lgtm
On Thu, Feb 18, 2016 at 8:36 AM Ewan Crawford wrote:
> EwanCrawford created this revision.
> EwanCrawford added reviewers: sivachandra, zturner, labath.
> EwanCrawford added a subscriber:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261240: Fix SocketTest on Windows. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17106?vs=47537&id=48360#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17106
Files:
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261241: Add target and host platform enumerations so we're
not using strings. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17088?vs=47684&id=48361#toc
Repository:
rL LLVM
Author: zturner
Date: Thu Feb 18 12:49:56 2016
New Revision: 261240
URL: http://llvm.org/viewvc/llvm-project?rev=261240&view=rev
Log:
Fix SocketTest on Windows.
Differential Revision: http://reviews.llvm.org/D17106
Modified:
lldb/trunk/unittests/Host/SocketAddressTest.cpp
Modified: lldb/tru
Author: zturner
Date: Thu Feb 18 12:50:02 2016
New Revision: 261241
URL: http://llvm.org/viewvc/llvm-project?rev=261241&view=rev
Log:
Add target and host platform enumerations so we're not using strings.
Differential Revision: http://reviews.llvm.org/D17088
Added:
lldb/trunk/packages/Python/
zturner created this revision.
zturner added reviewers: clayborg, labath, amccarth.
zturner added a subscriber: lldb-commits.
For seemingly no reason today, I started getting crashes on exit in
`CleanupProcessSpecificTempDirectory` when I ran certain tests. I determined
this wasn't related to a
zturner updated this revision to Diff 48414.
zturner added a comment.
This should make sure it happens if and only if the directory was successfully
created earlier during program execution.
http://reviews.llvm.org/D17420
Files:
include/lldb/Host/HostInfoBase.h
source/Host/common/HostInfoB
zturner marked an inline comment as done.
zturner added a comment.
http://reviews.llvm.org/D17420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:98-100
@@ +97,5 @@
+{
+auto global = m_session->getGlobalScope();
+auto compilands = global->findAllChildren();
+return compilands->getChildCount();
+}
clayborg
zturner added a comment.
I didn't respond to all your comments because I don't have the code in front of
me. I'll take a look at the rest of the comments tomorrow.
Comment at: source/Initialization/SystemInitializerCommon.cpp:202-204
@@ -198,1 +201,5 @@
+
+#if defined(_MSC_VER
zturner added inline comments.
Comment at:
packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27
@@ -25,4 +25,4 @@
@skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test
runner
-@expectedFailureFreeBSD('llvm.org/pr19011') #
On Fri, Feb 19, 2016 at 10:43 AM Greg Clayton wrote:
>
> We should be covering this using API tests that make an example like the
> one above and setting breakpoints in the inline header file. We have many
> tests for this. It is hard to get compilers to generate things that you can
> put in unit
Author: zturner
Date: Fri Feb 19 13:20:44 2016
New Revision: 261353
URL: http://llvm.org/viewvc/llvm-project?rev=261353&view=rev
Log:
Don't use an atexit handler for cleaning up the temp directory.
Differential Revision: http://reviews.llvm.org/D17420
Modified:
lldb/trunk/include/lldb/Host/H
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261353: Don't use an atexit handler for cleaning up the temp
directory. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17420?vs=48414&id=48528#toc
Repository:
rL LLVM
http:
zturner marked 6 inline comments as done.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:82-83
@@ +81,4 @@
+auto error = llvm::loadDataForEXE(llvm::PDB_ReaderType::DIA,
llvm::StringRef(exePath), m_session);
+if (error != llvm::PDB_ErrorCode::Success)
zturner updated this revision to Diff 48544.
zturner added a comment.
This should address all (I think) issues except for the one about
`check_inlines`, which I'll do in a followup. Can you respond to my comment in
a previous update about the uniqueness / index-ness of the comp_unit id?
http:
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:150
@@ +149,3 @@
+return TranslateLanguage(details->getLanguage());
+}
+
Ahh i see the problem. The problem is not the value Im' specifying for the id
of the compile u
zturner added a comment.
I'll have to look at this more carefully next week. I'm guessing the same
logic can eventually be re-used to live debug a 32-bit process from a 64-bit
LLDB? (Not that you have to address that now, just curious)
http://reviews.llvm.org/D17465
__
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:192
@@ +191,3 @@
+// only about the position of the TlsSlots.
+struct TEB64 {
+ULONG64 Reserved1[12];
I think this structure should go in a different head
zturner added a comment.
This probably seems like a lot of comments, but most of them are pretty minor.
Overall this looks like a good patch. When running the test suite with this
patch, did any tests start showing up as Unexpected Success?
Comment at: packages/Python/lldbsu
zturner created this revision.
zturner added reviewers: amccarth, Honsik.
zturner added a subscriber: lldb-commits.
Lots of new info about how to build / test on Windows.
1. Update for VS 2015 and Python 3.5
2. Remove old info about building with Python 2.7
3. Reformat the testing page to make it
zturner updated this revision to Diff 48737.
zturner added a comment.
Update to include full context.
http://reviews.llvm.org/D17521
Files:
www/build.html
www/test.html
Index: www/test.html
===
--- www/test.html
+++ www/test.h
zturner added inline comments.
Comment at: lldb/trunk/source/Core/Disassembler.cpp:881
@@ -878,3 +880,3 @@
}
-
-FILE *test_file = fopen (file_name, "r");
+FILE *test_file = nullptr;
+#if _WIN32
cameron314 wrote:
> cameron314 wrote:
> > zturner
zturner added a comment.
In http://reviews.llvm.org/D17521#359245, @Honsik wrote:
> Hello, newcomer here.
>
> Thanks zturner for you support.
> Shouldn't best workflow for VS also be mentioned? Like one solution for code
> editing generated by CMake -G "Visual Studio 14" that lacks directory
>
zturner updated this revision to Diff 48751.
zturner added a comment.
Updated with more info about using VS and ninja together, and a note about
`python_d` on Windows.
http://reviews.llvm.org/D17521
Files:
www/build.html
www/test.html
Index: www/test.html
=
zturner added inline comments.
Comment at: source/Core/ConstString.cpp:269
@@ +268,3 @@
+bool
+ConstString::Equals (const ConstString& lhs, const ConstString& rhs, const
bool case_sensitive)
+{
labath wrote:
> zturner wrote:
> > Looks like this code also isn't cl
zturner added inline comments.
Comment at: unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:212
@@ -211,3 +211,2 @@
PythonBytes python_bytes(PyRefType::Owned, py_bytes);
-EXPECT_EQ(PyObjectType::Bytes, python_bytes.GetObjectType());
Seems l
zturner added a comment.
http://reviews.llvm.org/D17545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: source/Host/common/FileSpec.cpp:519
@@ -515,3 +518,3 @@
// in one of the FileSpec objects.
if (full || (a.m_directory && b.m_directory))
Did the case sensitive check get removed here? I thought this would nee
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good after the fix of the misspelling. If you want I can fix it for you
and commit tomorrow.
I assume you ran the test suite and did not see any new errors?
Comment
zturner added a subscriber: zturner.
zturner added a comment.
Sorry that comment was a mistake. When you uploaded the most recent diff,
did you generate the diff against your first patch? Or against tip of
trunk? I think you may have generated it against your first patch, but
Phabricator gets c
Sorry that comment was a mistake. When you uploaded the most recent diff,
did you generate the diff against your first patch? Or against tip of
trunk? I think you may have generated it against your first patch, but
Phabricator gets confused and shows the wrong thing in that case.
It should be f
Ahh that could be. In any case when i view the full diff it looks ok. I'll
commit later today, thanks!
On Wed, Feb 24, 2016 at 8:00 AM Petr Hons wrote:
> Honsik added a comment.
>
> I have generated it against master branch. I used git reset HEAD~1,
> modified, commited and created patch.
>
> May
zturner added a comment.
Ahh that could be. In any case when i view the full diff it looks ok. I'll
commit later today, thanks!
http://reviews.llvm.org/D17492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: zturner
Date: Wed Feb 24 15:26:47 2016
New Revision: 261771
URL: http://llvm.org/viewvc/llvm-project?rev=261771&view=rev
Log:
Some fixes for case insensitive paths on Windows.
Paths on Windows are not case-sensitive. Because of this, if a file
is called main.cpp, you should be able to se
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Windows/Common/NtStructures.h:18
@@ +17,3 @@
+// only about the position of the TlsSlots.
+struct TEB64
+{
Just as a general tip for future referenc
Author: zturner
Date: Wed Feb 24 16:19:23 2016
New Revision: 261795
URL: http://llvm.org/viewvc/llvm-project?rev=261795&view=rev
Log:
Update the website with lots of new info about building / testing.
Modified:
lldb/trunk/www/build.html
lldb/trunk/www/test.html
Modified: lldb/trunk/www/b
Author: zturner
Date: Wed Feb 24 16:41:04 2016
New Revision: 261800
URL: http://llvm.org/viewvc/llvm-project?rev=261800&view=rev
Log:
xfail case sensitivity test on Linux.
There are two tests in this file. One which only runs on Windows
and tests that you can set a breakpoint with mismatched cas
zturner added a comment.
The non-Windows version of the test actually fails for some reason. I think
it's more likely to be a probelm in the test and not in the C++ side of the
patch, but I'm not sure. Do you by any chance have a Linux box to test on?
(It's not a big problem if you don't, I'
zturner added a comment.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11757/steps/test1/logs/stdio
There's the logs for the test that failed.
http://reviews.llvm.org/D17492
___
lldb-commits mailing list
lldb-commits@lists
We should have a different bug for this since the reason is different. Also
let's try to follow up with clang-cl people as soon as we can to determine
the expected behavior
On Wed, Feb 24, 2016 at 4:28 PM Adrian McCarthy via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: amccarth
> D
Sorry, was out for a few days and i missed this. Seems ok then
On Thu, Feb 25, 2016 at 8:25 AM Pavel Labath wrote:
> labath added a comment.
>
> Any thoughts on this?
>
> This is currently the only failing unit test on linux.
>
>
> http://reviews.llvm.org/D17545
>
>
>
>
_
zturner added a comment.
It doesn't look like `Process::PrivateResume()` returns an error if the process
is alive unless `WillResume()` returns an error, which is up to the individual
process implementation. So maybe the short circuit needs to happen there.
This isn't really my area though so
zturner added a comment.
I don't know where we draw the line between `test/lang` and
`test/functionalities` but I feel like the purpose of this test is just to make
sure LLDB has the general ability to handle setting breakpoints on inline call
sites. With that in mind, it make more sense to ha
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h:1-4
@@ +1,4 @@
+int inner_inline (int inner_input, int mod_value);
+int outer_inline (int outer_input);
+int not_inlined_2 (int input);
+int not_inlined_1 (int input);
On Thu, Feb 18, 2016 at 6:16 PM Greg Clayton wrote:
>
> > Just to make sure I understand, is it safe to say that:
> >
> > If check_inlines is false, sc_list should return with exactly 1
> SymbolContext with m_comp_unit set to the main source file?
>
> You would get one SymbolContext per compile u
On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton wrote:
>
> > On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote:
>
> > I'm coming back around to this now. What happens if check_inlines is
> False, but the FileSpec is a header file like . You said "If
> check_inl
ri, Feb 26, 2016 at 3:26 PM Greg Clayton wrote:
>
> > On Feb 26, 2016, at 3:22 PM, Zachary Turner wrote:
> >
> >
> >
> > On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton wrote:
> >
> > > On Feb 26, 2016, at 2:49 PM, Zachary Turner
> wrote:
> >
&
The reason for this is that msvc didn't support this until 2015. I'm fine
with these changes but i think you guys still need 2013 for a while longer,
right?
On Mon, Feb 29, 2016 at 3:38 AM Pavel Labath wrote:
> labath created this revision.
> labath added reviewers: clayborg, zturner.
> labath ad
Love this change in principle. I will look over it on the windows side to
make sure nothing breaks.
One question: we are using getopt still for parsing interactive command
lines right?
On Mon, Feb 29, 2016 at 9:26 AM Pavel Labath wrote:
> labath created this revision.
> labath added reviewers: c
Thanks! I think I've got a handle on it. I'll upload another patch this
week hopefully.
On Mon, Feb 29, 2016 at 10:30 AM Greg Clayton wrote:
>
> > On Feb 26, 2016, at 3:33 PM, Zachary Turner wrote:
> >
> > Ok, so back to check_inlines. I realized after I hi
long and short options are supported, but the one I'm not sure about is the
case where you use a short option with no space. Your example "-ax86_64"
might not work. It might, just that it should be tested. I'm 99%
confident the rest of them all work.
Also not sure about this example: "% lldb /b
okup this way, I need the same SymbolFilePDB
pointer that I created originally.
On Mon, Feb 29, 2016 at 10:40 AM Zachary Turner wrote:
> Thanks! I think I've got a handle on it. I'll upload another patch this
> week hopefully.
>
> On Mon, Feb 29, 2016 at 10:30 AM Greg Clayton w
2016 at 1:26 PM Zachary Turner wrote:
> I'm running into what I think is the final issue. My SymbolFilePDB plugin
> creates created many many times. Specifically, every single call to
> SymbolVendor::FindPlugin(module) will cause a brand new instance of
> SymbolFilePDB to get crea
the same SymbolVendor/SymbolFile for the life of the
> lldb_private::Module. If that isn't happening that is a bug that you will
> need to fix. DWARF creates a single instance.
>
> No need to do any fancy caching to any other work around.
>
> Greg
>
> > On Feb 29, 201
zturner updated this revision to Diff 49442.
zturner added a comment.
Note this should compile now on every platform. Look over the unit tests to
see my assumptions about how the API should work. Hopefully this makes
reviewing things easier (it definitely made getting things to work easier)
I think there's a lot of value in having lldb's help output and cl syntax
match all of the other llvm tools that people are already familiar with.
Simplicity through consistency. So lgtm
On Tue, Mar 1, 2016 at 4:22 AM Pavel Labath wrote:
> labath added a comment.
>
> In http://reviews.llvm.org/D1
zturner added a comment.
I think there's a lot of value in having lldb's help output and cl syntax
match all of the other llvm tools that people are already familiar with.
Simplicity through consistency. So lgtm
http://reviews.llvm.org/D17724
___
ll
On Tue, Mar 1, 2016 at 10:10 AM Greg Clayton wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> One general comment is the use of "auto". Although it makes the code
> shorter, it does make it quite a bit less read
Regarding the refactoring of ResolveSymbolContext to a lower level. It
seems like a worthwhile refactor but probably one that should be done as an
independent CL. It seems like it has potential to open up a bit of a rats
nest so to speak, and if something ends up breaking as a result, we can
revert
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:291-292
@@ +290,4 @@
+// , either directly or indirectly.
+auto compilands =
+m_session_up->findCompilandsForSourceFile(file_spec.GetPath(),
llvm::PDB_NameSearch
zturner added a comment.
In http://reviews.llvm.org/D17363#366522, @clayborg wrote:
> You are right. I am slowly seeing that PDB was designed well to be consumed
> as a user would want to, not compressed to the point of obfuscation and very
> difficult to extract data from like DWARF.
>
> So th
zturner added a comment.
I looked into this a little bit, it's going to be a couple days of work for me
to get termination entries set correctly. Can I go in as-is? I know you
already Accepted the revision, just want to double check.
I need to go make some changes to `llvm-pdbdump` on the LLV
zturner added a comment.
fwiw, here's my current output showing that things behave correctly for the
test case I've created.
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe
Current executable set to
'D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\I
zturner added a comment.
That should be easy enough. If we make the simplifying assumption "all
functions are represented contiguously in memory with no gaps", then I can just
create a termination entry at `start_of_function + num_bytes_in_function`.
Obviously this is a wrong assumption in the
zturner added a comment.
Is this what I should be seeing?
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe
Current executable set to
'D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe' (i686).
(lldb) target modules dump line-table
Author: zturner
Date: Wed Mar 2 16:05:52 2016
New Revision: 262528
URL: http://llvm.org/viewvc/llvm-project?rev=262528&view=rev
Log:
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to c
Sorry slipped under my radar, I'll look again today
On Mon, Mar 7, 2016 at 7:50 AM Cameron wrote:
> cameron314 added a comment.
>
> I don't want to be pushy, but is there a chance of this patch being
> accepted soon?
> It does depend on http://reviews.llvm.org/D17549 in LLVM which is also
> still
zturner added a subscriber: zturner.
zturner added a comment.
Sorry slipped under my radar, I'll look again today
http://reviews.llvm.org/D17107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
zturner added a comment.
Can you rebase against tip of trunk? I want to apply and run the test suite
with the patch applied, but I'm getting a lot of errors. After uploading a new
rebased patch, can you also respond with the revision you rebased against so I
can make sure I'm at the same plac
zturner added inline comments.
Comment at: lldb/trunk/source/Host/common/File.cpp:330
@@ +329,3 @@
+}
+::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYWR, mode);
+#else
cameron314 wrote:
> zturner wrote:
> > Any particular reason you're us
zturner added a comment.
Looks pretty non-controversial. Does this fix anything? Seems like there
should be a test that breaks somehow if this doesn't work. I don't know off
the top of my head what the debugger command is "get the address of the entry
point", but presumably it was broken bef
zturner added a subscriber: zturner.
zturner added a comment.
I was hoping there would be something like `image headers` that would just
display various information about the image, but it looks like we don't
have such a command that I can find. Seems like being able to find out the
entry point o
I was hoping there would be something like `image headers` that would just
display various information about the image, but it looks like we don't
have such a command that I can find. Seems like being able to find out the
entry point of a certain module would be useful.
On Tue, Mar 8, 2016 at 4:0
zturner added a comment.
I'm waiting for the LLVM side change to go in and this patch rebased on top of
that before I test it out.
In the meantime, one thing I'm concerned about is setting the codepage of the
console. You determined earlier that it affects the state of the console even
after
Sounds good. I will test this out once that patch goes in. And yea, I
would prefer to remove the codepage stuff for now, and we can re-consider
adding it back if/when someone actually needs it. Then we can discuss some
other options like a preprocessor define that enables setting the codepage,
o
zturner added a comment.
Sounds good. I will test this out once that patch goes in. And yea, I
would prefer to remove the codepage stuff for now, and we can re-consider
adding it back if/when someone actually needs it. Then we can discuss some
other options like a preprocessor define that enabl
zturner added a reviewer: labath.
zturner added a comment.
lgtm, Pavel does Android build infrastructure need these files for some reason?
http://reviews.llvm.org/D18017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
zturner added a comment.
Here's the commit that added this functionality:
D:\src\llvm\tools\lldb\test>git show a73ad66a
commit a73ad66a4ee96ccc8e6be4a645cd6b9180a72e4b
Author: Johnny Chen
Date: Thu Aug 16 19:15:21 2012 +
Catch timestamps for the beginning and end of the te
Author: zturner
Date: Wed Mar 9 18:06:26 2016
New Revision: 263078
URL: http://llvm.org/viewvc/llvm-project?rev=263078&view=rev
Log:
Fix SymbolFilePDB for discontiguous functions.
Previously line table parsing code assumed that the only gaps would
occur at the end of functions. In practice this
zturner added a comment.
I think this should be in `lldb/CMakeLists.txt`, not in `LLDBStandalone.cmake`.
What do you think?
Repository:
rL LLVM
http://reviews.llvm.org/D18018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
But in LLVM and clang as well, it's always set in top-level CMakeLists.txt
file, right? But you're saying for some reason that doesn't work in LLDB?
On Wed, Mar 9, 2016 at 5:12 PM Eugene Zelenko
wrote:
> Eugene.Zelenko added a comment.
>
> I didn't work in main CMakeLists.txt.
>
> From other si
Ahh that would make sense. I guess it needs to be set in both places in
that case?
On Wed, Mar 9, 2016 at 5:19 PM Eugene Zelenko
wrote:
> Eugene.Zelenko added a comment.
>
> My guess is that project() or cmake_minimum_required() resets policy value
> set in upper level make file.
>
>
> Reposito
But it also has a project() and a cmake_required_version() statement, so if
that is what is causing the policy to be reset in LLDBStandalone, the same
would be true in that case too. Also clang CMakeLists.txt has it as the
top, and it's basically the same as LLDB
On Wed, Mar 9, 2016 at 5:22 PM Eu
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good, and it doesn't break anything on Windows. Glad we got rid of
copying and duplication, that always seemed like unnecessary complexity.
http://reviews.llvm.org/D18057
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Good to see we have a way to generate reasonably sized core files on other
platforms as well.
http://reviews.llvm.org/D18176
___
lldb-commits
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
ClangASTContext was assuming the presence of DWARF debug info, so it was baked
into the class that DWARFASTParserClang would be used. This won't be the case
with PDB, which will need a P
zturner abandoned this revision.
zturner added a comment.
Abandoning this for now, I ran into some difficulties when trying to implement
the PDB version. Will have to resolve those first and then come back to this.
http://reviews.llvm.org/D18194
_
Is the stdint version better somehow? I thought C++ numeric_limits were
actually preferred over the C macros.
On Mon, Mar 14, 2016 at 7:59 AM Adrian McCarthy via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> If we're favoring the macros over the functions, then
> perhaps update the #inc
should have been
> LLDB_INVALID_FILE_INDEX32, for instance, though not all. At some point we
> should go clean up uses of *_MAX and use more meaningful defines where
> appropriate. But I can't see that there is any value to replacing the
> current _MAX usage with the much
This actually broke a couple of unit tests on Windows. Did you try running
these tests on Windows?
On Fri, Mar 11, 2016 at 12:49 AM Pavel Labath wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL263207: Fix a couple of cornercases in FileSpe
zturner added inline comments.
Comment at: tools/lldb-mi/Platform.h:73
@@ -74,4 +72,3 @@
// CODETAG_IOR_SIGNALS
// signal.h
#define SIGQUIT 3 // Terminal quit signal
amccarth wrote:
> As in the other file, now that we're including , I think the
1801 - 1900 of 3010 matches
Mail list logo
