zturner added a comment.

I don't know where we draw the line between `test/lang` and 
`test/functionalities` but I feel like the purpose of this test is just to make 
sure LLDB has the general ability to handle setting breakpoints on inline call 
sites.  With that in mind, it make more sense to have this test in 
`test/functionalities/inline-breakpoint`, but I don't think it's a big deal 
either way.


================
Comment at: packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h:1-4
@@ +1,4 @@
+int inner_inline (int inner_input, int mod_value);
+int outer_inline (int outer_input);
+int not_inlined_2 (int input);
+int not_inlined_1 (int input);
----------------
Why do we need this header file now?  It wasn't here before.


http://reviews.llvm.org/D17650



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to