Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

or someone else to actually test this on OSX, but at least on Windows it looks good with the attached patch. On Fri, May 20, 2016 at 5:54 PM Zachary Turner wrote: > zturner added a comment. > > I'm still getting a lot of crashes after this, but this will at least fix > the comp

Re: [Lldb-commits] [lldb] r270474 - Removed the m_decl_objects map from ClangASTContext.

Hi Sean, TestRedefinitionsInInline is not passing on Windows. I'm getting this when trying to reproduce manually: (lldb) expression b error: reference to 'b' is ambiguous candidate found by name lookup is 'b' candidate found by name lookup is 'b' error: 1 error parsing expression If you know wha

[Lldb-commits] [lldb] r270490 - xfail TestRedefinitionsInline on Windows.

Author: zturner Date: Mon May 23 16:22:11 2016 New Revision: 270490 URL: http://llvm.org/viewvc/llvm-project?rev=270490&view=rev Log: xfail TestRedefinitionsInline on Windows. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

Just chiming in to say modules is unsupported on Windows even with clang, so please make sure the gmodules support function takes this into account On Tue, May 24, 2016 at 9:05 AM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > tfiala added a comment. > > So at this point, it l

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Nothing obvious that will break on Windows here, so looks good. http://reviews.llvm.org/D20570 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. In `is_compiler_clang_with_gmodules` you will need to explicitly return false if the target is Windows, because clang help will still show the command line option as being valid, even though it doesn't work properly. http://reviews.llvm.org/D19998 __

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. In http://reviews.llvm.org/D19998#438586, @tfiala wrote: > F1982070: gmodules-test-support-v6.diff > > Updated gmodules.is_compiler_clang_with_gmodules() to guard on Windows with: > > def _gmodules_supported_internal(): > compile

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. Should this be disabled by default unless explicitly requested? Seems like "run the entire test suite N times" should be opt in, not opt out. If its opt in, I don't mind removing the os check for Windows. http://reviews.llvm.org/D19998 ___

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

Should this be disabled by default unless explicitly requested? Seems like "run the entire test suite N times" should be opt in, not opt out. If its opt in, I don't mind removing the os check for Windows. On Tue, May 24, 2016 at 6:25 PM Adrian Prantl wrote: > aprantl added a comment. > > In http

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. Going to try this out on Windows and see how it goes. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner accepted this revision. zturner added a reviewer: zturner. zturner added a comment. This revision is now accepted and ready to land. No problems here, I'd wait for Pavel for additional thoughts before going in. http://reviews.llvm.org/D19998 ___

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a subscriber: zturner. zturner added a comment. Wondering if this should go in llvm. What do you think? http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Wondering if this should go in llvm. What do you think? On Thu, May 26, 2016 at 7:31 AM Tamas Berghammer via lldb-commits < lldb-commits@lists.llvm.org> wrote: > tberghammer accepted this revision. > tberghammer added a comment. > This revision is now accepted and ready to land. > > looks good > >

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a comment. Ok, lgtm then http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Ok, lgtm then On Thu, May 26, 2016 at 7:46 AM Pavel Labath wrote: > labath added a comment. > > In http://reviews.llvm.org/D20671#440868, @zturner wrote: > > > Wondering if this should go in llvm. What do you think? > > > I don't see any uses of weak_ptr in the llvm repository, so this issue > sh

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

Don't think this is needed anymore, lgtm On Thu, May 26, 2016 at 8:59 AM Todd Fiala wrote: > tfiala added a comment. > > In http://reviews.llvm.org/D20673#440967, @labath wrote: > > > In http://reviews.llvm.org/D20673#440660, @labath wrote: > > > > > Enabling this should not make any difference i

Re: [Lldb-commits] [lldb] r270941 - Add a new "lldb" log channel named "demangle". If we have crashes that are related to demangling, we now can enable this logging and we will be able to reproduce de

Just curious, is this related to the dump I sent you a while back? On Thu, May 26, 2016 at 5:23 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: gclayton > Date: Thu May 26 19:17:18 2016 > New Revision: 270941 > > URL: http://llvm.org/viewvc/llvm-project?rev=270941

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

zturner resigned from this revision. zturner removed a reviewer: zturner. Comment at: cmake/modules/LLDBConfig.cmake:225-235 @@ -224,3 +224,4 @@ +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") check_cxx_compiler_flag("-Wno-deprecated-register" CXX_SUPPORTS_NO

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

zturner added a comment. For the diffing issue seems like we should be able to generate makefiles with stable separators. I haven't seen the generation code, but it seems like we could write a function lldbsuite.support.fs.unixpath() that works like normpath but always uses /, never \. Would that

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

For the diffing issue seems like we should be able to generate makefiles with stable separators. I haven't seen the generation code, but it seems like we could write a function lldbsuite.support.fs.unixpath() that works like normpath but always uses /, never \. Would that fix it? When you say it d

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

zturner added a comment. Excited to see this working. I will look at the patch in detail later, do you think you could make a test for it? http://reviews.llvm.org/D22231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [PATCH] D22404: [test] Report error when inferior test processes exit with a non-zero code

It's useful to have more descriptive error messages about why a test failed though. Saying that a test returned exit code 1 is worse than saying it had a bad decorator invocation On Fri, Jul 15, 2016 at 3:12 AM Pavel Labath wrote: > labath added a comment. > > I think this also makes the code in

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

I can't test this on Windows until Friday because I'm traveling and my laptop isn't set up to build lldb. Could Stephane maybe help? On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool wrote: > compnerd updated this revision to Diff 64448. > > https://reviews.llvm.org/D20436 > > Files: > inclu

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

zturner added a comment. Currently running the test suite, will report back when it's done. Comment at: include/lldb/Host/File.h:442 @@ -440,1 +441,3 @@ +class SelectInfo +{ labath wrote: > I am not sure about the location of this class, `File` seems l

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

zturner added a comment. Aside from the compilation error caused by not including `winsock2.h`, I saw no other obvious problems here, and there are no test regressions. https://reviews.llvm.org/D22950 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] r278177 - Delete Host/windows/win32.h

Author: zturner Date: Tue Aug 9 18:06:08 2016 New Revision: 278177 URL: http://llvm.org/viewvc/llvm-project?rev=278177&view=rev Log: Delete Host/windows/win32.h It's always hard to remember when to include this file, and when you do include it it's hard to remember what preprocessor check it nee

[Lldb-commits] [lldb] r278182 - Fix build on android and Linux.

Author: zturner Date: Tue Aug 9 19:02:58 2016 New Revision: 278182 URL: http://llvm.org/viewvc/llvm-project?rev=278182&view=rev Log: Fix build on android and Linux. gettimeofday() isn't defined without a special header. Rather than rely on C apis, let's just use modern C++11 to do this portably

Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.

This will make the tests start failing again on Windows. I #defined these in test_common.h, it should work. Does it not? On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Tue Aug 9 20:37:27 2016 > New Revision: 278197 > > URL

Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.

n Tue, Aug 9, 2016 at 8:26 PM Todd Fiala wrote: > Maybe those tests aren't including test_common.h? Dunno. > > On Tue, Aug 9, 2016 at 8:25 PM, Todd Fiala wrote: > >> No, sorry, it does not. >> >> Each of those got undefined macro errors on macOS. >> >

[Lldb-commits] [lldb] r278253 - Remove a circular include dependency.

Author: zturner Date: Wed Aug 10 12:59:03 2016 New Revision: 278253 URL: http://llvm.org/viewvc/llvm-project?rev=278253&view=rev Log: Remove a circular include dependency. lldb-private-interfaces.h included lldb-private.h, and lldb-private.h included lldb-private-interfaces.h. Modified: lldb

Re: [Lldb-commits] [lldb] r278304 - Fix a problem where if a uint64_t value is placed into a python dictionary and sent up to LLDB and converted to StructuredData, it would not be able to parse the fu

Couple of random style comments below. You don't have to fix these, just something to think about in the future. On Wed, Aug 10, 2016 at 4:33 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > + > +TEST_F(PythonDataObjectsTest, TestExtractingUInt64ThroughStructuredData) >

Re: [Lldb-commits] [PATCH] D23290: Added enforce-interactivity setting

Tbh I've no experience with ptys so I don't know if there is an equivalent I do know that more than one process can share a single console. So for example if you run a copy of lldb, you can have the ide and lldb share the same console. Not sure if this is similar to what you're doing though On Th

[Lldb-commits] [lldb] r278373 - Modify coding conventions to mention include ordering.

Author: zturner Date: Thu Aug 11 13:10:40 2016 New Revision: 278373 URL: http://llvm.org/viewvc/llvm-project?rev=278373&view=rev Log: Modify coding conventions to mention include ordering. Modified: lldb/trunk/www/lldb-coding-conventions.html Modified: lldb/trunk/www/lldb-coding-conventions.

[Lldb-commits] [lldb] r278526 - Fix build on Windows.

Author: zturner Date: Fri Aug 12 11:52:31 2016 New Revision: 278526 URL: http://llvm.org/viewvc/llvm-project?rev=278526&view=rev Log: Fix build on Windows. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Modified: lldb/trunk/source/Plugins/Process/gdb-remote/Proce

[Lldb-commits] [lldb] r278529 - Disable TestThreadSpecificBpPlusCondition on Windows.

Author: zturner Date: Fri Aug 12 12:15:38 2016 New Revision: 278529 URL: http://llvm.org/viewvc/llvm-project?rev=278529&view=rev Log: Disable TestThreadSpecificBpPlusCondition on Windows. Test frequently times out stalling the test runner. Modified: lldb/trunk/packages/Python/lldbsuite/test

Re: [Lldb-commits] [lldb] r278500 - Fix-up r278299 for windows

Yea, seems right On Fri, Aug 12, 2016 at 4:29 AM Pavel Labath wrote: > Fyi. Please check if I got that right. > > -- Forwarded message -- > From: Pavel Labath via lldb-commits > Date: 12 August 2016 at 12:20 > Subject: [Lldb-commits] [lldb] r278500 - Fix-up r278299 for windows >

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

I would prefer to use llvm types to do the parsing wherever possible. Why do we need DataExtractor? If the only reason is to force little endian, just use the types in llvm/Endian.h On Tue, Aug 16, 2016 at 8:13 AM Dimitar Vlahovski via lldb-commits < lldb-commits@lists.llvm.org> wrote: > dvlahovsk

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added a subscriber: zturner. Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35 @@ +30,7 @@ +// the signature might be byte swapped +data.SetByteOrder(lldb::eByteOrderBig); +*offset -= 4; +signature = data.GetU32(offset); +if (signature

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

I see. Let me follow up with the breakpad developers to ask them about that. If you only have to support one endianness the code can be much cleaner. On Tue, Aug 16, 2016 at 9:44 AM Dimitar Vlahovski wrote: > dvlahovski added inline comments. > > > Comment at: source/Plugins/P

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added a comment. LLVM does have something similar to DataExtractor, but unfortunately it's not present in the correct library for you to easily be able to reuse it. I actually own the code in question, so I'm willing to fix that for you if you're interested, but at the same time the co

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

Btw the endian aware types are usable, just include "llvm/Support/Endian.h". It's just the consumeObject functions that are not On Tue, Aug 16, 2016 at 10:01 AM Zachary Turner wrote: > zturner added a comment. > > LLVM does have something similar to DataExtractor, but

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:29 @@ +28,3 @@ + +lldb::ByteOrder byteorder = m_data.GetByteOrder(); +lldb::offset_t directory_list_offset = m_header->stream_directory_rva; I asked some people f

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67 @@ +66,3 @@ +bool m_valid_data; +llvm::DenseMap m_directory_map; +}; Can this be `llvm::DenseMap`? No point erasing the type information of the enum. =

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:259 @@ +258,3 @@ +static_assert(sizeof(MinidumpSystemInfo) == MINIDUMP_SYSTEM_INFO_SIZE, "sizeof MinidumpSystemInfo is not correct!"); + +struct MinidumpMiscInfo I think th

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67 @@ +66,3 @@ +bool m_valid_data; +llvm::DenseMap m_directory_map; +}; dvlahovski wrote: > zturner wrote: > > Can this be `llvm::DenseMap > MinidumpLocationDescrip

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:133 @@ +132,3 @@ +// This matches the Linux kernel definitions from +enum MinidumpPCPUInformationARMElfHwCaps +{ dvlahovski wrote: > amccarth wrote: > > zturner wrote: > >

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner added a comment. Were you still going to change all the `Optionals` to raw pointers (or even better, `llvm::Errors`) Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:21 @@ +20,3 @@ +MinidumpParser::MinidumpParser(const lldb::DataBufferSP &data_buf_sp) +

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

zturner accepted this revision. zturner added a reviewer: zturner. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:60 @@ +59,3 @@ +MinidumpParser parser(data_buf_sp, header, directory_map); +return llvm::Optio

Re: [Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

Unless we have a good reason to use const char* such as interoperability with a C api I would strongly prefer we standardize on llvm::StringRef On Fri, Aug 26, 2016 at 2:24 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > labath added a comment. > > Thank you for writing th

Re: [Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

zturner added a subscriber: zturner. zturner added a comment. I'm not sure I follow. `StringRef` is literally just a wrapper around a `const char*`, so if `const char*` works, why doesn't `StringRef`? `JSONParser` constructor is already taking a `const char*` in this patch, so it's not like i

Re: [Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

zturner added a comment. Actually it looks like `JSONParser` constructor takes a `StringRef` and then converts it to a `std::string` internally. Why can't it just store the `StringRef` internally? It doesn't modify the buffer, and incidentally it also keeps a `uint64_t` representing the "offs

Re: [Lldb-commits] [PATCH] D23884: Add StructuredData unit tests; remove JSON parsing string copy

zturner added a comment. You mention a `StringRefExtractor`. But nothing about `StringExtractor` that I can tell depends on the fact that it's null terminated. It only needs to know where to stop. A `StringRef` contains a length, so you stop when it gets to the end of the `StringRef`. It se

[Lldb-commits] [lldb] r279917 - Convert some functions to use StringRef instead of c_str, len

Author: zturner Date: Sat Aug 27 10:52:29 2016 New Revision: 279917 URL: http://llvm.org/viewvc/llvm-project?rev=279917&view=rev Log: Convert some functions to use StringRef instead of c_str, len This started as an effort to change StringExtractor to store a StringRef internally instead of a std:

[Lldb-commits] [lldb] r279919 - Add some unit tests for StringExtractor::GetNameColonValue.

Author: zturner Date: Sat Aug 27 11:35:15 2016 New Revision: 279919 URL: http://llvm.org/viewvc/llvm-project?rev=279919&view=rev Log: Add some unit tests for StringExtractor::GetNameColonValue. These are helpful on their own, but will be even more useful once the GetNameColonValue is updated to r

[Lldb-commits] [lldb] r279920 - Fix some build bot breakages.

Author: zturner Date: Sat Aug 27 11:38:11 2016 New Revision: 279920 URL: http://llvm.org/viewvc/llvm-project?rev=279920&view=rev Log: Fix some build bot breakages. There was some code that was ifdef'ed out that I didn't catch in my earlier patch. Modified: lldb/trunk/source/Plugins/Process/

[Lldb-commits] [lldb] r279994 - Remove std::atomic from lldb::Address.

Author: zturner Date: Mon Aug 29 14:30:26 2016 New Revision: 279994 URL: http://llvm.org/viewvc/llvm-project?rev=279994&view=rev Log: Remove std::atomic from lldb::Address. std::atomic requires 64-bit alignment in order to guarantee atomicity. Normally the compiler is pretty good about aligning

[Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

Author: zturner Date: Mon Aug 29 14:45:59 2016 New Revision: 279997 URL: http://llvm.org/viewvc/llvm-project?rev=279997&view=rev Log: Copy StringExtractor to StdStringExtractor. I have some improvements to make to StringExtractor that require using LLVM. debugserver can't take a dependency on LL

[Lldb-commits] [lldb] r280000 - Convert GetNameColonValue to return StringRefs.

Author: zturner Date: Mon Aug 29 14:58:14 2016 New Revision: 28 URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev Log: Convert GetNameColonValue to return StringRefs. StringExtractor::GetNameColonValue() looks for a substring of the form ":" and returns and to the caller. This re

[Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner created this revision. zturner added reviewers: labath, tberghammer. zturner added a subscriber: lldb-commits. The motivation here was that operations which were using the `const` version of this function might as well be using `Peek()`, since it does essentially the same thing. And sin

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1677 @@ -1676,3 +1676,2 @@ { -m_thread_ids.clear(); m_thread_pcs.clear(); Also, was this a bug? I fixed it because it certainly looks like a bug, but if t

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69635. zturner added a comment. Actually fix the bug this time instead of making worse. https://reviews.llvm.org/D24013 Files: include/lldb/Core/Event.h include/lldb/Core/RegularExpression.h include/lldb/Utility/StringExtractor.h source/Core/Event.c

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

Sorry, it's based on a few patches i have locally that I didn't put up for review but can't commit yet On Tue, Aug 30, 2016 at 6:13 AM Pavel Labath wrote: > labath added a comment. > > Which revision is this patch against? It does not seem to apply cleanly to > trunk for me. Could you try running

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

h is included in > such a funny way is source/Host/common/StringConvert.cpp > > > On 29 August 2016 at 20:46, Zachary Turner via lldb-commits > wrote: > > Author: zturner > > Date: Mon Aug 29 14:45:59 2016 > > New Revision: 279997 > > > > URL: http://ll

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

Looks good On Tue, Aug 30, 2016 at 5:38 AM Tamas Berghammer wrote: > tberghammer created this revision. > tberghammer added reviewers: jingham, zturner. > tberghammer added a subscriber: lldb-commits. > > Remove mention of autoconf from the build instructions > > autoconf+make have been removed f

Re: [Lldb-commits] [lldb] r280074 - Fix fallout from the GetNameColonValue() refactor (r280000)

Thanks, sorry about that On Tue, Aug 30, 2016 at 4:25 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Tue Aug 30 06:17:00 2016 > New Revision: 280074 > > URL: http://llvm.org/viewvc/llvm-project?rev=280074&view=rev > Log: > Fix fallout from the GetNa

[Lldb-commits] [lldb] r280123 - Convert some StringExtractor functions to accept MutableArrayRefs.

Author: zturner Date: Tue Aug 30 13:12:11 2016 New Revision: 280123 URL: http://llvm.org/viewvc/llvm-project?rev=280123&view=rev Log: Convert some StringExtractor functions to accept MutableArrayRefs. MutableArrayRef is essentially a safer version of passing around (T*, length) pairs and provides

[Lldb-commits] [lldb] r280124 - Add a few more unit tests for StringExtractor.

Author: zturner Date: Tue Aug 30 13:12:18 2016 New Revision: 280124 URL: http://llvm.org/viewvc/llvm-project?rev=280124&view=rev Log: Add a few more unit tests for StringExtractor. This is a NFC that adds more unit test coverage of the GetHex*** functions as well as the functions to extract numbe

[Lldb-commits] [lldb] r280137 - Use llvm to do endian conversions.

Author: zturner Date: Tue Aug 30 14:28:01 2016 New Revision: 280137 URL: http://llvm.org/viewvc/llvm-project?rev=280137&view=rev Log: Use llvm to do endian conversions. LLDB was rolling its own endian conversion code, but functions to do this already exist in LLVM. While the code was probably co

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69741. zturner added a comment. Rebased after submitting all local changes. This should apply cleanly on top of LLDB r280139. https://reviews.llvm.org/D24013 Files: include/lldb/Core/Event.h include/lldb/Core/RegularExpression.h include/lldb/Utility

[Lldb-commits] [lldb] r280139 - A few minor stylistic cleanups in StringExtractor.

Author: zturner Date: Tue Aug 30 14:47:05 2016 New Revision: 280139 URL: http://llvm.org/viewvc/llvm-project?rev=280139&view=rev Log: A few minor stylistic cleanups in StringExtractor. Makes Peek() return a StringRef instead of a const char*. This leads to a few callers of Peek() being able to b

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

zturner updated this revision to Diff 69750. zturner added a comment. Fixed a few build errors on Linux. Test suite is running right now, but it's taking a long time so it may be hung (on the other hand, I actually don't remember the last time I had a successful test run on Linux, even without

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

Is there going to be a test for this? On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Tue Aug 30 15:39:58 2016 > New Revision: 280151 > > URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev > Log: > Add SBType

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

u can hold your breath through it :-) > > On Aug 30, 2016, at 2:29 PM, Zachary Turner wrote: > > Is there going to be a test for this? > > On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: enrico

Re: [Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

Looks good, feel free to commit without review when you're fixing a build On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii wrote: > wttsugrii created this revision. > wttsugrii added a reviewer: zturner. > wttsugrii added a subscriber: lldb-commits. > > > https://github.com/llvm-mirror/lldb/commit/e

Re: [Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

Ahh right, in that case I can commit it in the morning unless someone else beats me to it. On Tue, Aug 30, 2016 at 6:55 PM Taras Tsugrii wrote: > Thanks for the review Zachary, but I don’t have commit privileges, so I > hope that someone can commit the change for me. > > > &g

Re: [Lldb-commits] [lldb] r280204 - Revert r280200 and put it a proper fix

SetName accepts a StringRef, why not just SetName(line_extractor.Peek())? On Wed, Aug 31, 2016 at 12:57 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Wed Aug 31 02:49:37 2016 > New Revision: 280204 > > URL: http://llvm.org/viewvc/llvm-project?rev=2

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

Can you post the exact contents of the string causing the crash? I'll add a unittest for it On Wed, Aug 31, 2016 at 1:51 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Wed Aug 31 03:43:37 2016 > New Revision: 280207 > > URL: http://llvm.org/viewvc/l

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

axU64(false, 0)); // instead it crashes > > > > On 31 August 2016 at 14:22, Zachary Turner wrote: > > Can you post the exact contents of the string causing the crash? I'll > add a > > unittest for it > > > > On Wed, Aug 31, 2016 at 1:51 AM Pavel Labath via

Re: [Lldb-commits] [lldb] r280207 - Revert r280137 and 280139 and subsequent build fixes

not flaky (and also > just generally being busy). Given the recent breakages, I am going to > rearrange the priorities a bit, and get the emails enabled. > > On 31 August 2016 at 14:45, Zachary Turner wrote: > > Thanks, I'll check it out. Are there any plans to make buildbots se

[Lldb-commits] [lldb] r280253 - Add more unit tests for StringExtractor hex/endian functions.

Author: zturner Date: Wed Aug 31 10:50:50 2016 New Revision: 280253 URL: http://llvm.org/viewvc/llvm-project?rev=280253&view=rev Log: Add more unit tests for StringExtractor hex/endian functions. There were a few corner cases that weren't tested for dealing with extraction of an odd number of nib

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

I will commit these today. On Wed, Aug 31, 2016 at 10:41 AM Taras Tsugrii via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Can someone please commit https://reviews.llvm.org/D23950, > https://reviews.llvm.org/D23951, https://reviews.llvm.org/D23952, > https://reviews.llvm.org/D23948 and h

[Lldb-commits] [lldb] r280283 - Remove unused variables.

Author: zturner Date: Wed Aug 31 15:03:14 2016 New Revision: 280283 URL: http://llvm.org/viewvc/llvm-project?rev=280283&view=rev Log: Remove unused variables. Patch by Taras Tsugrii Modified: lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp lldb/trunk/source/Plugins/LanguageRuntime/

Re: [Lldb-commits] [LLDB] Please commit accepted changes.

ary! > > > > *From: *Zachary Turner > *Date: *Wednesday, August 31, 2016 at 10:43 AM > *To: *Taras Tsugrii , via lldb-commits < > lldb-commits@lists.llvm.org> > *Subject: *Re: [Lldb-commits] [LLDB] Please commit accepted changes. > > > > I will commit these to

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

What about a case in the unit test where the value overflows the type? Would that be useful? On Thu, Sep 1, 2016 at 3:50 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > labath created this revision. > labath added reviewers: clayborg, granata.enrico. > labath added a subsc

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

verrides for each of the primitive > types. I cannot construct it with a value which is larger than it will > fit in the primitive type. I suppose I could try the boundary > conditions like UINT32_MAX, but that's about it. > > Or I am misunderstanding the question.. > > p

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

zturner added a subscriber: zturner. zturner added a comment. I like the approach taken here in general. One thing that I wonder about, if we have the Triple, why do we even need the PathSyntax at all? In light of the fact that not all Posix filesystems are case sensitive, this calls into ques

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

For #2 you can use llvm::GetProcessTriple(), i will think about #1 when I have a chance to look at the code On Sat, Sep 3, 2016 at 2:38 PM Vyacheslav Karpukhin < vyaches...@karpukhin.com> wrote: > stigger added a comment. > > In https://reviews.llvm.org/D20041#533725, @zturner wrote: > > > How dif

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

Assert probably On Mon, Sep 5, 2016 at 4:04 AM Pavel Labath wrote: > labath added a subscriber: labath. > labath added a comment. > > > > > > Comment at: include/lldb/Host/FileSpec.h:712 > @@ +711,3 @@ > + PathSyntax syntax = ePathSyntaxHostNative, > + ll

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

Also given that the reformat is going to happen today, I wonder if we should wait until after it is complete to put in any more high risk changes. On Tue, Sep 6, 2016 at 8:07 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > labath requested changes to this revision. > laba

[Lldb-commits] [lldb] r280757 - Make LLDB compile on Windows after the reformat.

Author: zturner Date: Tue Sep 6 16:52:14 2016 New Revision: 280757 URL: http://llvm.org/viewvc/llvm-project?rev=280757&view=rev Log: Make LLDB compile on Windows after the reformat. Most of these issues arose as a result of header re-ordering, but it turned up a real bug, which is that MSVC does

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

Why was this causing a problem? The only headers that were re-ordered are system headers. Does FreeBSD's libraries have requirements about certain headers being included before other headers? On Tue, Sep 6, 2016 at 2:33 PM Ed Maste via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author

[Lldb-commits] [lldb] r280758 - Put the LLVM_ALIGNAS directive in the right place.

Author: zturner Date: Tue Sep 6 17:02:06 2016 New Revision: 280758 URL: http://llvm.org/viewvc/llvm-project?rev=280758&view=rev Log: Put the LLVM_ALIGNAS directive in the right place. Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContext_x86.h Modified: lldb/trunk/source/Plugi

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

he above order. > It's crucial for and to be on a top as other > headers may assume that they were > already included. > > *Sent:* Wednesday, September 07, 2016 at 12:05 AM > *From:* "Dimitry Andric via lldb-commits" > *To:* "Zachary Turner" > *Cc:*

[Lldb-commits] [lldb] r280759 - Fix tests on Windows.

Author: zturner Date: Tue Sep 6 17:14:22 2016 New Revision: 280759 URL: http://llvm.org/viewvc/llvm-project?rev=280759&view=rev Log: Fix tests on Windows. This wasn't actually a problem with the reformat, but rather a problem with Visual Studio 2015 Update 3, which uses some c++14 features in it

[Lldb-commits] [lldb] r280763 - Revert "Fix tests on Windows."

Author: zturner Date: Tue Sep 6 17:40:11 2016 New Revision: 280763 URL: http://llvm.org/viewvc/llvm-project?rev=280763&view=rev Log: Revert "Fix tests on Windows." This reverts commit 9b757b6e3946311802972409f38c6cefbea917b3. This seems to cause strange breakages about on Ubuntu. Modified:

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Does this affect the running of the test suite in any way? Is anything fixed or regressed as a result of this? Repository: rL LLVM https://reviews.llvm.org/D24283 ___

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner added a comment. BTW, you will need to rebase this on top of trunk, and make sure you run clang-format before submitting. Repository: rL LLVM https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Can you rebase on top of tunk and re-upload? Also please use -U99 when generating the diff (assuming you are using git) so we can see context. Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mai

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Right, I'm just wondering if when you run `ninja check-lldb` before and after this patch, do the results differ at all? Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner added a comment. In https://reviews.llvm.org/D24283#535405, @wallace wrote: > This fixes some issues with arm architectures (where this was unsetting the > thumbv7 and was fallbacking to thumb). > This is also needed for https://reviews.llvm.org/D24284, where the objet > file requires

<    9   10   11   12   13   14   15   16   17   18   >