Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

I rebased it 2016-09-20 15:44 GMT-07:00 walter erquinigo : > wallace updated this revision to Diff 71995. > wallace added a comment. > > rebase > > > https://reviews.llvm.org/D24284 > > Files: > source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp > source/Plugins/ObjectFile/PECOFF/ObjectFil

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

Oh, I was doing it from linux, I will do it from Windows then... 2016-09-21 8:42 GMT-07:00 Zachary Turner : > If it helps, I can tell you that on line 623 of ObjectFilePECOFF.cpp, the > export_table has number of names == 64, but address of names = 0. So that > seems wrong. > > On Wed, Sep 21, 2

Re: [Lldb-commits] [PATCH] D110269: Fix LLDB build on old Linux kernels

I will! Thanks! Il Gio 23 Set 2021, 12:35 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> ha scritto: > labath added a comment. > > I'm pretty sure Caleb does not have commit access. Walter, would you do > the honors? > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAS

Re: [Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

Cool. I hope that vscode catches up. Do you have push permissions or should I land this for you? Il Mar 9 Nov 2021, 2:16 AM Andy Yankovsky via Phabricator < revi...@reviews.llvm.org> ha scritto: > werat added a comment. > > In D113400#3117500 , @wallace

Re: [Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

I'm reverting it asap Il giorno lun 21 giu 2021 alle ore 10:48 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > @wallace : Your most recent change to comment out > ProgressEventThreadFunction is causing warnings to be generated when

Re: [Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

> BTW, I thought when a command returned the command string for the next command, the command interpreter prepended it with the chain of parent commands containing the command that was presenting the “next command string”. That is correct. The GetRepeatCommand function gets the full command with t

Re: [Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

> - I am surprised that it was not necessary to create a special process plugin for this purpose. I have a feeling one will be necessary sooner or later because of the need to customize the step/continue/etc. flows. Currently, this will probably produce very bizarre if one tries to execute those co

Re: [Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

I totally agree with you, I didn't think about creating custom callbacks =P. I'll refactor the code accordingly. Thanks, man Il giorno ven 2 ott 2020 alle ore 01:51 Pavel Labath ha scritto: > On 01/10/2020 20:57, Walter wrote: > >> - I am surprised that it was not necessary to create a special p

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

I've tried to find a way to move the calls the way you mentioned, but it doesn't seem trivial. Some more information: - The invocation to the thread plan is done by Thread::ShouldStop, where it does ``` // We're starting from the base plan, so just let it decide; if (current_plan->IsBasePlan(

Re: [Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

I've already submitted a fix, let's see if the buildbot gets fixed Il giorno lun 25 gen 2021 alle ore 14:18 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > It looks like this broke the windows lldb bot: > > > Repository: > rG LLVM

Re: [Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

Good to know. I'll work on that right now. Thanks! Il giorno mer 27 gen 2021 alle ore 11:41 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added inline comments. > > > > Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 > + > +#if !de

Re: [Lldb-commits] [lldb] 0bca9a7 - Fix lldb-vscode builds on Windows targeting POSIX

This is great to know. Til. I'll change all of those macros to _WIN32 for consistency then Il Gio 4 Feb 2021, 3:25 AM Martin Storsjö ha scritto: > On Thu, 28 Jan 2021, Walter Erquinigo via lldb-commits wrote: > > > > > Author: Walter Erquinigo > > Date: 2021-01-28T09:36:13-08:00 > > New Revision

Re: [Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

I don't feel knowledgeable enough to backport the commit, so if you can do it, it would be great :) Il giorno gio 4 feb 2021 alle ore 13:04 Martin Storsjö via Phabricator < revi...@reviews.llvm.org> ha scritto: > mstorsjo added a comment. > > In D96060#2542890

Re: [Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

I'll revert this patch. This seems to be the reason Il Mer 24 Giu 2020, 6:27 AM Florian Hahn via Phabricator < revi...@reviews.llvm.org> ha scritto: > fhahn added a comment. > > I noticed that it appears that ` lldb-api :: > tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed i