Re: [Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

[Walter via lldb-commits]

I'm reverting it asap

Il giorno lun 21 giu 2021 alle ore 10:48 Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> ha scritto:

> stella.stamenova added a comment.
>
> @wallace : Your most recent change to comment out
> ProgressEventThreadFunction is causing warnings to be generated when
> building with clang. Please have a look:
>
>   /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
> -Itools/lldb/tools/lldb-vscode -I/mnt/vss/_work/1/s/lldb/tools/lldb-vscode
> -I/mnt/vss/_work/1/s/lldb/include -Itools/lldb/include -Iinclude
> -I/mnt/vss/_work/1/s/llvm/include
> -I/mnt/vss/_work/1/s/llvm/../clang/include -Itools/lldb/../clang/include
> -I/usr/include/libxml2 -fPIC -fvisibility-inlines-hidden -Werror
> -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra
> -Wno-unused-parameter -Wwrite-strings -Wcast-qual
> -Wmissing-field-initializers -pedantic -Wno-long-long
> -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default
> -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor
> -Wsuggest-override -Wstring-conversion -Wmisleading-indentation
> -fdiagnostics-color -ffunction-sections -fdata-sections
> -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing
> -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  -fno-exceptions
> -fno-rtti -UNDEBUG -std=c++14 -MD -MT
> tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o
> -MF
> tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o.d
> -o
> tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o
> -c /mnt/vss/_work/1/s/lldb/tools/lldb-vscode/lldb-vscode.cpp
>   /mnt/vss/_work/1/s/lldb/tools/lldb-vscode/lldb-vscode.cpp:370:6: error:
> unused function 'ProgressEventThreadFunction' [-Werror,-Wunused-function]
>   void ProgressEventThreadFunction() {
>        ^
>   1 error generated.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D101128/new/
>
> https://reviews.llvm.org/D101128
>
>

-- 
- Walter Erquínigo Pezo

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits