Author: tfiala
Date: Mon Sep 21 19:15:50 2015
New Revision: 248228
URL: http://llvm.org/viewvc/llvm-project?rev=248228&view=rev
Log:
test framework: parallel test runner sends terminate to formatter before
printing to stdout
The parallel test runner now sends the terminate event to the formatter
Author: tfiala
Date: Tue Sep 22 01:32:50 2015
New Revision: 248247
URL: http://llvm.org/viewvc/llvm-project?rev=248247&view=rev
Log:
xUnit test formatter: add options for ignoring skipped tests
Skipped tests can be dropped from xUnit reports if either
the name or the skip reason matches one of a
Author: tfiala
Date: Tue Sep 22 10:21:50 2015
New Revision: 248282
URL: http://llvm.org/viewvc/llvm-project?rev=248282&view=rev
Log:
test runner: Unix systems now put inferior dotest in its own process group.
This increases isolation as it relates to signal handling between parent and
children.
Author: tfiala
Date: Tue Sep 22 11:03:43 2015
New Revision: 248284
URL: http://llvm.org/viewvc/llvm-project?rev=248284&view=rev
Log:
Roll back r248282.
I'm seeing timed out tests not properly timing out on the Linux
build bot after this change. Not sure if it is related but
seems suspect.
Modif
Author: tfiala
Date: Tue Sep 22 13:05:11 2015
New Revision: 248306
URL: http://llvm.org/viewvc/llvm-project?rev=248306&view=rev
Log:
Test runner process group isolation take 2.
This one does not create a session, but just creates a
new process group in the same session.
Modified:
lldb/trunk/
Author: tfiala
Date: Tue Sep 22 16:19:40 2015
New Revision: 248323
URL: http://llvm.org/viewvc/llvm-project?rev=248323&view=rev
Log:
test framework: default to threading-based test runners
Windows gets threading-pool, OS X versions < 10.10 get
multiprocessing, everyone else gets threading.
Modif
Author: tfiala
Date: Tue Sep 22 17:47:34 2015
New Revision: 248337
URL: http://llvm.org/viewvc/llvm-project?rev=248337&view=rev
Log:
test runner: remove print from prior commit; fixup listner socket backlog
When doing test event collation from dotest inferiors to the parallel test
runner, I had a
tfiala accepted this revision.
tfiala added a comment.
LGTM as well. Thanks!
http://reviews.llvm.org/D13028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Sep 23 10:21:28 2015
New Revision: 248384
URL: http://llvm.org/viewvc/llvm-project?rev=248384&view=rev
Log:
Cleaned up results formatter options hand-off.
* --results-formatter-options renamed to --results-formatter-option,
with short version of -O
* Multiple --results
Author: tfiala
Date: Wed Sep 23 12:20:09 2015
New Revision: 248397
URL: http://llvm.org/viewvc/llvm-project?rev=248397&view=rev
Log:
test framework: fixed issue when using results formatter with no formatter
options
I broke the formatter options-passing parsing when no formatter
options are prov
tfiala accepted this revision.
tfiala added a comment.
This review is mighty stale, but going through my differentials I saw it was
still around. It looked good for the time.
http://reviews.llvm.org/D5503
___
lldb-commits mailing list
lldb-commits
tfiala created this revision.
tfiala added reviewers: zturner, clayborg, labath.
tfiala added a subscriber: lldb-commits.
For all the parallel test runners, provide a pure-Python mechanism for timing
out dotest inferior processes that run for too long.
Stock OS X and Windows do not have a built-
tfiala added inline comments.
Comment at: test/curses_results.py:223
@@ -223,1 +222,3 @@
+# Greg - not sure why this is here. It locks up on
exit.
+# self.main_window.key_event_loop()
lldbcurses.terminate_c
tfiala added a subscriber: tfiala.
tfiala added a comment.
Are you all still seeing this now? I am heading to sleep but can have a
look early in the morning...
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
Are you all still seeing this now? I am heading to sleep but can have a
look early in the morning...
On Wed, Sep 23, 2015 at 10:09 PM, Bruce Mitchener via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> brucem added a subscriber: brucem.
> brucem added a comment.
>
> I ran into this myself
tfiala added a comment.
In http://reviews.llvm.org/D13124#252564, @labath wrote:
> I don't want to stand in the way of progress (and I do think that getting rid
> of the timeout dependency is progress), but this implementation regresses in
> a couple of features compared to using timeout:
>
> -
tfiala added a comment.
In http://reviews.llvm.org/D13124#252784, @zturner wrote:
> If I understand correctly, the process hierarchy used to look like this:
>
> python - dotest.py
> |__ python - multiprocessing fork
>
> |__ python - lldbtest
> |__ inferior executable
>
>
> And now l
tfiala added a comment.
> Thanks for working on this once again :)
Sure thing!
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I filed this:
https://llvm.org/bugs/show_bug.cgi?id=24926
And I'm starting to look at it now.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tfiala added a comment.
> What is happening is that it is looking for argdumper and not finding it.
> This happens because it is looking in the lib directory within the build
> directory, but argdumper is in the bin directory (where it should be).
I'm not sure I would say that is accurate. ar
tfiala added a comment.
> Which reminds me of another thing: Since you're working heavily on the tet
> suite, one thing I've always wanted is what I just mentioned: Something
> like an lldbxplat module which is essentially a helper module that exposes
> a single interface for doing things
tfiala added a comment.
Hi Dawn,
See https://llvm.org/bugs/show_bug.cgi?id=24926 for a workaround. I'm
developing a fix for it. Still testing but what is there in that patch (in the
bug) works for your build scenario as long as you add '--executable
/path/to/your/just/build/lldb' when callin
tfiala added a comment.
> Hi Todd, yes, I read the bug report and updated my comment while you were
> writing yours :)
Great! Once I validate that the standard OS X build isn't busted (in
progress), I'll get it checked in.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
tfiala added a comment.
I do intend to get back to this after resolving the cmake build issue on OS X.
Hopefully by tonight.
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
tfiala added inline comments.
Comment at: test/curses_results.py:223
@@ -223,1 +222,3 @@
+# Greg - not sure why this is here. It locks up on
exit.
+# self.main_window.key_event_loop()
lldbcurses.terminate_c
Author: tfiala
Date: Thu Sep 24 16:59:48 2015
New Revision: 248545
URL: http://llvm.org/viewvc/llvm-project?rev=248545&view=rev
Log:
Fix tests on cmake-based OS X after rL248338
See:
https://llvm.org/bugs/show_bug.cgi?id=24926
for details. On OS X, when LLDB.framework is
not part of the lldb.dy
tfiala added a comment.
The cmake OS X fix went in here:
Sendingsource/Host/macosx/HostInfoMacOSX.mm
Transmitting file data .
Committed revision 248545.
Let me know if you still have trouble after that.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
tfiala added a comment.
> Fixed by Todd in r248545.
Oh good!
> Todd rocks!!! :)
You are far too kind :-)
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
tfiala added a comment.
> That's a good idea. I'm (somewhat slowly) attempting to work in some clean up
> each time I touch it. I'll hit that at some point. I'll start winding down on
> changes to the test infrastructure soon-ish. If I don't hit that by the time
> I stop heavy changes, definite
tfiala added a comment.
In http://reviews.llvm.org/D13124#253476, @zturner wrote:
> +100, great :)
:-)
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
tfiala updated this revision to Diff 35788.
tfiala added a comment.
Work in progess.
This patch is working and timing out consistently on Linux (on a Jenkins bot),
and is running normally on OS X. I haven't coerced a timeout on OS X yet.
I'll be adding some tests for the timeout and core gener
tfiala added inline comments.
Comment at: test/dosep.py:245
@@ +244,3 @@
+# binary should have called the results-generation code.
+raise Exception("no test results were generated whatsoever")
+return process_driver.results
This message should
tfiala added a comment.
In http://reviews.llvm.org/D13124#254082, @zturner wrote:
> I won't be able to have a serious look until Monday, as I'm still remote.
Oh no worries.
> Hopefully you arent working on weekends :)
:-P
http://reviews.llvm.org/D13124
__
Author: tfiala
Date: Sat Sep 26 18:00:35 2015
New Revision: 248676
URL: http://llvm.org/viewvc/llvm-project?rev=248676&view=rev
Log:
Added python script to support running pylint.
See the script comments for how to modify your
pylintrc file (e.g. $HOME/.pylintrc) to support
always finding the lld
tfiala updated this revision to Diff 35814.
tfiala added a comment.
Minor refactor, moving new components to test/test_runner/lib.
Will be adding test runner tests to test/test_runner/test and will make sure
the normal test runner doesn't try to run them. (These will be test
infrastructure tes
tfiala added a comment.
> When no cores are desired, we'll generate a SIGTERM instead of a SIGQUIT on
> the soft terminate request.
That on the POSIX-y systems, of course. It would be cool if Zachary can work
in the mini crashdumps or similar on Windows.
http://reviews.llvm.org/D13124
__
tfiala updated this revision to Diff 35829.
tfiala added a comment.
Tests added. Ready for review.
The change now has two levels of terminate:
- soft terminate, which uses a signal or process control mechanism to tell the
process to end. It optionally can use a mechanism that triggers a core
tfiala added a comment.
In http://reviews.llvm.org/D13124#254487, @labath wrote:
> Looks good to me. :)
>
> If you do end up adding a command line option, I think you can go for
> `--enable-core-on-timeout` and default to off for all platforms. I suspect I
> am the only one using this, and it m
tfiala added a comment.
In http://reviews.llvm.org/D13124#254900, @zturner wrote:
> Sorry, our desks were reconfigured over the weekend, so I just now got my
> computer turned on. I'm syncing code and hopefully will have a working
> build soon.
Sounds good. I expect you'll find a few things
tfiala added a comment.
In http://reviews.llvm.org/D13124#254935, @tfiala wrote:
> In http://reviews.llvm.org/D13124#254900, @zturner wrote:
>
> > Sorry, our desks were reconfigured over the weekend, so I just now got my
> > computer turned on. I'm syncing code and hopefully will have a working
tfiala added a comment.
In http://reviews.llvm.org/D13124#254950, @zturner wrote:
> Sorry, ignore me. My brain is just off, it's working
Okay, cool. Yeah I can update it if needed, I think I saw a 1-line dosep.py go
in between my last update late last night and early this morning. But it
s
tfiala added a comment.
In http://reviews.llvm.org/D13124#254958, @zturner wrote:
> This is what I get.
>
> d:\src\llvm\tools\lldb\test>cd test_runner
>
> d:\src\llvm\tools\lldb\test\test_runner>cd test
>
> d:\src\llvm\tools\lldb\test\test_runner\test>c:\Python27_LLDB\x86\python_d.exe
> process_
tfiala added a comment.
The "was_soft_terminate()" method is looking at the subprocess.Popen-like
object's returncode and, judging by that, certifying that it was (or was not) a
soft terminate that caused the exit.
If you need the Popen-like object to figure that out (e.g. if you need to look
tfiala added a comment.
In http://reviews.llvm.org/D13124#255034, @zturner wrote:
> As far as I can tell, the value of the return code is undocumented when you
> use Popen.terminate() on Windows.
Okay, interesting. I found what looked like a race on Linux and OS X where
calling the Popen-obj
tfiala added a comment.
> I can get that together (assuming option #1) relatively quickly.
>
> I don't think we can drop the complexity of the 2-tier kill level in the
> driver, though, given the desire to support core dump generation.
I'm not going to touch this until I hear back from you
tfiala added a comment.
In http://reviews.llvm.org/D13124#255044, @zturner wrote:
> Yea, on Windows we can support core dump generation externally without
> touching the python script, so that's not neded for us.
Okay, good!
> Ironically, at the system level there is a way to specify the retu
tfiala added inline comments.
Comment at: test/test_runner/test/process_control_tests.py:63
@@ +62,3 @@
+def _suppress_soft_terminate(cls, command):
+if platform.system() == 'nt':
+# Add whatever is needed to the command line to
zturner wro
tfiala added a comment.
In http://reviews.llvm.org/D13124#255058, @zturner wrote:
> Random thought: If you want to generate a core dump, we already have LLDB
> attached to the process, so you have an SBProcess. Couldn't you use
> Process.Halt, then call whatever method is necessary to have the
tfiala added a comment.
Ah I see I morphed all those together (the platform naming).
> ... bummed to see them under test_runner...
Heh, that's funny. I was attempting to do a service of decluttering that top
level test directory, which to me looks like somebody threw up a bunch of
python cod
tfiala added a comment.
In http://reviews.llvm.org/D13124#255142, @zturner wrote:
> In http://reviews.llvm.org/D13124#255140, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13124#255058, @zturner wrote:
> >
> > > Random thought: If you want to generate a core dump, we already have LLDB
> > > a
tfiala added a comment.
> If it weren't for the fact that we have all these switches on `os.name`,
> `sys.platform`, and `platform.system` inside the tests as well as the test
> running infrastructure, then hiding it would be good. But yea, the test
> suite itself is still really fragile due
tfiala updated this revision to Diff 35921.
tfiala added a comment.
Changes:
- soft terminate is now optional by platform, not supported by default, and
listed as supported on POSIX-y systems.
- run with timeout now uses soft terminate only when supported.
- soft terminate tests are now skipped
tfiala added inline comments.
Comment at: test/test_runner/lib/process_control.py:552
@@ +551,3 @@
+# We don't have anything else to try.
+terminated = self.process.returncode is not None
+done_trying = True
Drats, t
tfiala updated this revision to Diff 35925.
tfiala added a comment.
Fixed up my previous inline comments. I was caching the popen object's
returncode returned from wait(), since it was showing unstable characteristics
when reading after a successful wait(). But I failed to use it everywhere.
tfiala marked 6 inline comments as done.
tfiala added a comment.
Clearing out all fixed comments.
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Hey Zachary,
Have you seen diff 5 or diff 6 on Windows yet? What results did you get? I
think I'm just waiting on a clean Windows run at this point.
Thanks!
-Todd
http://reviews.llvm.org/D13124
___
lldb-commits mailing
tfiala added a comment.
Great, much appreciated, Zachary!
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
> Does that look right to you?
That result looks right - the two soft terminate tests get skipped when it's
not reported.
If you ran the lldb test suite with that setup, they should work as well as
they did before the change. (If they don't, I'm missing a lower level
Great, thanks! Will do after I fix up your bits. Out for a bit but will
get this in the afternoon.
On Tue, Sep 29, 2015 at 12:53 PM, Zachary Turner wrote:
> Unless you make significant other changes, feel free to just commit. I
> don't have any other concerns. Thanks for working on this!
>
>
tfiala added inline comments.
Comment at: test/test_runner/lib/process_control.py:214
@@ +213,3 @@
+"""
+raise Exception("platform needs to implement")
+
zturner wrote:
> Should this return `False` now that this is not supported on Windows, or do
tfiala updated this revision to Diff 36043.
tfiala added a comment.
Fixes for Windows per previous comments, for posterity's sake.
This is the patch I will be committing.
http://reviews.llvm.org/D13124
Files:
test/dosep.py
test/test_runner/README.txt
test/test_runner/lib/lldb_utils.py
tfiala closed this revision.
tfiala added a comment.
Committed here:
svn commit
Sendingtest/dosep.py
Adding test/test_runner
Adding test/test_runner/README.txt
Adding test/test_runner/lib
Adding test/test_runner/lib/lldb_utils.py
Adding
Author: tfiala
Date: Tue Sep 29 17:19:06 2015
New Revision: 248834
URL: http://llvm.org/viewvc/llvm-project?rev=248834&view=rev
Log:
test runner: switch to pure-Python timeout mechanism
The timeout mechanism has been implemented in python,
so there is no more dependence on external utilities
for
901 - 963 of 963 matches
Mail list logo
