Author: tfiala
Date: Sat Feb 27 16:48:50 2016
New Revision: 262156
URL: http://llvm.org/viewvc/llvm-project?rev=262156&view=rev
Log:
Revert "Fix bug with register values byte order in expression evaluation."
This reverts commit r262041, which caused asserts starting yesterday on the OS
X testbot
Hi all,
The new assert was failing on the OS X testbot here:
http://lab.llvm.org:8080/green/job/lldb_build_test/
The nag mail didn't make it to you since we have it only fire on the
transition from good build to bad build, and Tamas had the privilege of
earning that with a minor Xcode breakage ju
Nah - please go ahead and submit it. I'll just make sure I add the ability
to specify arbitrary git flags for the git part so you can have this when I
put the new change in.
On Mon, Feb 22, 2016 at 7:23 PM, Stephane Sezer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> sas added a subsc
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D17425#363665, @tfiala wrote:
> Nah - please go ahead and submit it. I'll just make sure I add the ability
> to specify arbitrary git flags for the git part so you
I brought the state of the lines changed there to what they were prior to the
change. If you adjusted those same lines, then yes that got undone.
We were failing different tests in those files. Your change may have fixed the
new issues on Linux, but did not address the new failures on OS X. Th
tfiala added a subscriber: tfiala.
tfiala added a comment.
LGTM!
-Todd
http://reviews.llvm.org/D17798
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
LGTM!
-Todd
> On Mar 2, 2016, at 2:49 AM, Pavel Labath wrote:
>
> labath created this revision.
> labath added a reviewer: tfiala.
> labath added a subscriber: lldb-commits.
>
> this enables download of remote log files for llgs and debugserver tests
> (previously we were just
> passing the h
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
I'm fine with nuking them.
Prior to the parallel test runner, they were probably the most reliable way to
tell if a test crashed in the middle of a run, and to figure out what it was.
(Maybe
tfiala accepted this revision.
tfiala added a comment.
This happened, right? Can we close?
http://reviews.llvm.org/D16872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this close?
http://reviews.llvm.org/D16615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Mar 11 02:12:36 2016
New Revision: 263205
URL: http://llvm.org/viewvc/llvm-project?rev=263205&view=rev
Log:
skip newly segfaulting test on OS X public CI
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/default-constructor/TestDefaultConstructorForAPIOb
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Pavel!
http://reviews.llvm.org/D18140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
tfiala added a subscriber: tfiala.
tfiala added a comment.
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
http://reviews.llvm.org/D18531
___
ll
The general idea looks good. You'll want to reach out to the Hexagon dynamic
loader author first on any proposed changes there, though.
Thanks!
-Todd
> On Mar 29, 2016, at 11:45 AM, Francis Ricci wrote:
>
> fjricci updated this revision to Diff 51962.
> fjricci added a comment.
>
> Refactor
LGTM, thanks for getting to that, Pavel!
On Wednesday, March 30, 2016, Pavel Labath wrote:
> labath created this revision.
> labath added reviewers: tberghammer, tfiala.
> labath added a subscriber: lldb-commits.
>
> Debug info is used only by the client and lldb-server tests do not even
> have
Author: tfiala
Date: Fri Apr 1 12:59:51 2016
New Revision: 265165
URL: http://llvm.org/viewvc/llvm-project?rev=265165&view=rev
Log:
Guard xunit result test class and test method name access to prevent testbot
breakage
http://llvm.org/bugs/show_bug.cgi?id=27179
Modified:
lldb/trunk/packages
Author: tfiala
Date: Fri Apr 1 13:42:45 2016
New Revision: 265175
URL: http://llvm.org/viewvc/llvm-project?rev=265175&view=rev
Log:
mark TestCallWithTimeout.py XFAIL on macosx.
This test is failing on the CI but not locally for me. Needs
investigation.
tracked by:
https://llvm.org/bugs/show_bu
Author: tfiala
Date: Fri Apr 1 16:36:58 2016
New Revision: 265188
URL: http://llvm.org/viewvc/llvm-project?rev=265188&view=rev
Log:
skip and xfail two std::list-related libcxx tests that fail on OS X with TOT
libcxx
Enrico has a bug on him to make this work across older libcxx list
and newer li
Author: tfiala
Date: Mon Apr 4 12:15:57 2016
New Revision: 265315
URL: http://llvm.org/viewvc/llvm-project?rev=265315&view=rev
Log:
Xcode: modify lldb-python-test-suite target to build inferiors with
$(LLDB_PYTHON_TESTSUITE_CC)
$(LLDB_PYTHON_TESTSUITE_CC) defaults to the just-built clang. Toge
Author: tfiala
Date: Mon Apr 4 14:40:29 2016
New Revision: 265340
URL: http://llvm.org/viewvc/llvm-project?rev=265340&view=rev
Log:
Xcode: run gtests when building the lldb-gtest target
This addresses the following task:
https://llvm.org/bugs/show_bug.cgi?id=27181 Xcode gtests: ensure they run,
Author: tfiala
Date: Mon Apr 4 14:58:24 2016
New Revision: 265342
URL: http://llvm.org/viewvc/llvm-project?rev=265342&view=rev
Log:
disabled TSAN tests until the author can help track down CI failures
These tests run fine locally for me but are failing on the Green Dragon
OS X CI.
Modified:
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
That looks fine. Thanks for the fix!
http://reviews.llvm.org/D18779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
Author: tfiala
Date: Tue Apr 5 20:14:37 2016
New Revision: 265498
URL: http://llvm.org/viewvc/llvm-project?rev=265498&view=rev
Log:
make TestRegisterVariables slightly more resilient
This test sets the compiler optimization level to -O1 and
makes some assumptions about how local frame vars will
I think it's the -O1 that is screwing it up. The test relies on setting
the optimization level, and then screws up the compiler's ability to find
the framework headers with more recent clangs on OS X (both in-tree built
and Xcode-delivered). Ultimately OS X has been shifting where the
/usr/includ
tfiala added a subscriber: tfiala.
tfiala added a comment.
I think it's the -O1 that is screwing it up. The test relies on setting
the optimization level, and then screws up the compiler's ability to find
the framework headers with more recent clangs on OS X (both in-tree built
and Xcode-delivere
CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the
majority of our tests, Makefile.rules correctly assumes optimizations are
turned off for maximal debug info). If that was the fix, that is
circumventing the check this test is doing.
What we really need (and I'll go back and
tfiala added a comment.
CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the
majority of our tests, Makefile.rules correctly assumes optimizations are
turned off for maximal debug info). If that was the fix, that is
circumventing the check this test is doing.
What we really ne
(And sorry for the breakage! I didn't see any nag mails).
On Wed, Apr 6, 2016 at 7:34 AM, Todd Fiala wrote:
> CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the
> majority of our tests, Makefile.rules correctly assumes optimizations are
> turned off for maximal debug info).
tfiala added a comment.
(And sorry for the breakage! I didn't see any nag mails).
Users:
tfiala (Author)
http://reviews.llvm.org/rL265498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
The exponential back off code forgot to import 'time'. This code will
trigger (and has on our end) a python exception for 'time' missing.
I'm fixing this now.
On Tue, Apr 5, 2016 at 7:13 AM, Tamas Berghammer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> This revision was automaticall
tfiala added a subscriber: tfiala.
tfiala added a comment.
The exponential back off code forgot to import 'time'. This code will
trigger (and has on our end) a python exception for 'time' missing.
I'm fixing this now.
Repository:
rL LLVM
http://reviews.llvm.org/D18789
___
Author: tfiala
Date: Fri Apr 8 13:06:11 2016
New Revision: 265821
URL: http://llvm.org/viewvc/llvm-project?rev=265821&view=rev
Log:
fix missing import of 'time' in lldbutil.wait_for_file_on_target
This triggers in some timeout scenarios in the LLDB test suite.
Fixes:
https://bugs.swift.org/brow
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
The swig call generates our Python bindings for LLDB. Fix a #if __APPLE___
directive in the type map file to be evaluated at LLDBWrapPython.cpp build time
rather than generation time.
http
Author: tfiala
Date: Fri Apr 8 13:58:07 2016
New Revision: 265829
URL: http://llvm.org/viewvc/llvm-project?rev=265829&view=rev
Log:
Fix #ifdef __APPLE__ code is the swig Python bindings
This code was getting evaluated unintentionally at binding
generation time instead of binding file compilation
tfiala closed this revision.
tfiala added a comment.
Closed with LLDB svn trunk r265829.
http://reviews.llvm.org/D18904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.
The race boiled down to this:
If a test worker queue is able to run the test inferior and
clean up before the dosep.py listener socket is spun up, and
the worker queue is the last o
tfiala added a comment.
The fix simply has the listener socket always send a byte, and the initiators
of the socket always wait for that byte before continuing. This ensures that
both cases where the sender is creating a socket and sending test events will
never exit the dosep.py main loop bef
tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.
Ensure all uses of a test filename in the test event infrastructure normalize
the test filename to end in the ".py" extension. Something here changed
recently such that normal code paths thro
tfiala created this revision.
tfiala added reviewers: zturner, labath.
tfiala added a subscriber: lldb-commits.
Also addresses a PEP8 name violation, converting lldb_utils.OptionalWith to
lldb_utils.optional_with.
http://reviews.llvm.org/D19216
Files:
packages/Python/lldbsuite/test/dosep.py
tfiala closed this revision.
tfiala added a comment.
Closing with commit:
r266624
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D19215#403844, @labath wrote:
> So, I think I have already fixed the problem with r266192.
I was able to replicate just prior to applying the change, but I'll double
check.
Regarding r266192 (which came through when I wasn't looking, sorry),
Author: tfiala
Date: Mon Apr 18 11:09:21 2016
New Revision: 266624
URL: http://llvm.org/viewvc/llvm-project?rev=266624&view=rev
Log:
fix a race is the LLDB test suite results collection
The race boiled down to this:
If a test worker queue is able to run the test inferior and
clean up before the
tfiala added a comment.
> I was able to replicate just prior to applying the change, but I'll double
> check.
Yeah that change didn't cover all the cases. The test_filename that comes from
this call stack (in startTest), originating within the unittest2 framework, has
the .pyc (assuming this
tfiala updated this revision to Diff 54078.
tfiala added a comment.
Change inspect.getfile() => inspect.getsourcefile().
http://reviews.llvm.org/D19215
Files:
packages/Python/lldbsuite/test/result_formatter.py
Index: packages/Python/lldbsuite/test/result_formatter.py
tfiala updated this revision to Diff 54079.
tfiala added a comment.
Whoops - don't include the 'raise' call.
http://reviews.llvm.org/D19215
Files:
packages/Python/lldbsuite/test/result_formatter.py
Index: packages/Python/lldbsuite/test/result_formatter.py
Yep, I agree with that now. Wasn't the case when I originally wrote it,
but yeah that can move. I'll adjust that.
On Mon, Apr 18, 2016 at 10:57 AM, Zachary Turner wrote:
> zturner added inline comments.
>
>
> Comment at: packages/Python/lldbsuite/test/test_runner/lldb_utils.py
tfiala added a subscriber: tfiala.
tfiala added a comment.
Yep, I agree with that now. Wasn't the case when I originally wrote it,
but yeah that can move. I'll adjust that.
http://reviews.llvm.org/D19216
___
lldb-commits mailing list
lldb-commits@
tfiala added a comment.
In http://reviews.llvm.org/D19215#404143, @zturner wrote:
> It seems very strange to me to be changing a .pyc filename to a .py
> filename. I think we should try to understand where the .pyc filename is
> coming from to begin with, and this is just masking the real erro
tfiala added a comment.
> The __file__ for lldbinline.py-based tests is getting set to .pyc via the
> unittest2 loader. This callstack comes from inserting this code into
> lldbinline.py:
>
> diff --git a/packages/Python/lldbsuite/test/lldbinline.py
> b/packages/Python/lldbsuite/test/lldb
tfiala added a comment.
Side note:
Okay I think the mystery of this was caught by Jim. When we started accepting
usage of .pycs again, we're allowing the python runtime to select using the pyc
if available and not older than the .py file. This makes it possible to get a
test file that is som
tfiala updated this revision to Diff 54102.
tfiala added a comment.
Final change: this change:
1. has the lldbinline.py test intercept its __file parameter and convert from
.pyc to .py before storing to the test.test_filename attribute.
2. has the test event creation mechanism and test_event usa
Author: tfiala
Date: Mon Apr 18 15:26:56 2016
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
ensure lldbinline remembers .py extension
This ensure lldbinline.test_file paths are tracked as .py
files rather than .pyc files.
Also, this change adds an assert
tfiala closed this revision.
tfiala added a comment.
Closed via commit:
r24
http://reviews.llvm.org/D19215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4907
@@ -4883,2 +4906,3 @@
+m_process->GetTarget().ModulesDidUnload (removed_modules, false);
new_modules.ForEach ([&target](const lldb::ModuleSP module_sp) -> bool
tfiala updated this revision to Diff 54115.
tfiala added a comment.
Moves optional_with into its own lldbsuite/support module.
http://reviews.llvm.org/D19216
Files:
packages/Python/lldbsuite/support/optional_with.py
packages/Python/lldbsuite/test/dosep.py
packages/Python/lldbsuite/test/te
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4907
@@ -4883,2 +4906,3 @@
+m_process->GetTarget().ModulesDidUnload (removed_modules, false);
Author: tfiala
Date: Mon Apr 18 23:20:35 2016
New Revision: 266710
URL: http://llvm.org/viewvc/llvm-project?rev=266710&view=rev
Log:
test infra cleanup: convert test_runner lib into package
Also does the following:
* adopts PEP8 naming convention for OptionalWith class (now
optional_with).
* mo
tfiala closed this revision.
tfiala added a comment.
Closed via commit:
r266710
commit 4ef9c1c5dcb05a159929cd3b407481ed86a73ef5 (HEAD -> master,
origin/master, origin/HEAD)
Author: Todd Fiala
Date: Mon Apr 18 21:20:35 2016
test infra cleanup: convert test_runner lib into packag
tfiala added a comment.
Interesting, thanks Pavel!
I'll look at those as I start looking to test the test infrastructure.
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
tfiala added a comment.
Okay I just looked at those, Pavel.
They fall into a category that I know is not yet handled. This is the category:
- No test method is "open" (i.e. the dotest.py inferior is not in between a
start_test/end_test) when the timeout occurs. Thus, we cannot "charge" the
t
tfiala added a comment.
I filed this bug to track it:
https://llvm.org/bugs/show_bug.cgi?id=27423
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
If you're in a position where you can grab a sample (using the OS X sample
tool) on the bot when they're "hanging", we can try to find out where they are
at.
The reason I *think* they're not in a method is because they don't have test
method information associated with
tfiala added a comment.
Comment at: packages/Python/lldbsuite/test_event/formatter/curses.py:1
@@ +1,2 @@
+#!/usr/bin/env python
+
labath wrote:
> Is this actually supposed to be executable?
No, there is no need for it to be executable. That can come out.
Goo
tfiala closed this revision.
tfiala added a comment.
Closed with commit r266885.
@zturner, we can post-commit adjust if you see any improvements. I want to get
moving on writing the package-level tests for it.
http://reviews.llvm.org/D19288
___
l
Author: tfiala
Date: Wed Apr 20 15:54:59 2016
New Revision: 266917
URL: http://llvm.org/viewvc/llvm-project?rev=266917&view=rev
Log:
update Jenkins Xcode buildbot target for r266885
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: tfiala
Date: Mon Apr 25 10:48:34 2016
New Revision: 267421
URL: http://llvm.org/viewvc/llvm-project?rev=267421&view=rev
Log:
skip TestBitfields.py on OS X
tracked by:
https://llvm.org/bugs/show_bug.cgi?id=27515
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/bitfields/Test
tfiala added a comment.
My guess here would be that the fixing of the race - i.e. ensuring the
listening side is up and running before allowing the sender to continue, is
probably keeping more sockets open than before (i.e. fixing the race, but doing
so by using an average larger number of reso
tfiala added a comment.
Didn't get to it in time, but yes this looks fine.
Repository:
rL LLVM
http://reviews.llvm.org/D19082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Ick. Yeah that sounds like something to resolve quickly.
They shouldn't be getting stuck. That would imply that the side running via
dosep.py (the listener socket) is either (1) no longer running and therefore
the listener isn't spinning up, although that would be cata
Awesome! Good catch, Adrian!
(And my pleasure!)
-Todd
> On Apr 25, 2016, at 4:13 PM, Adrian McCarthy wrote:
>
> amccarth added a comment.
>
> I got it. There was an exception being thrown from asyncore so early that it
> didn't give a proper stack trace. The problem boils down to Python 3
tfiala added a subscriber: tfiala.
tfiala added a comment.
Awesome! Good catch, Adrian!
(And my pleasure!)
-Todd
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
tfiala created this revision.
tfiala added a reviewer: sivachandra.
tfiala added a subscriber: lldb-commits.
Comment out a line of diagnostic information that is printed many times during
test runs when using DWARFCompileUnit.cpp to build the address range table.
http://reviews.llvm.org/D12380
tfiala added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:445
@@ -444,3 +444,3 @@
debug_aranges->AppendRange(cu_offset,
range.GetRangeBase(), range.GetRangeEnd());
-printf ("0x%8.8x: [0x%16.16"
Author: tfiala
Date: Wed Aug 26 17:08:26 2015
New Revision: 246091
URL: http://llvm.org/viewvc/llvm-project?rev=246091&view=rev
Log:
http://reviews.llvm.org/D12380: remove DWARFCompileUnit printf spam.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Modified: lldb/t
tfiala closed this revision.
tfiala added a comment.
Committed:
Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Transmitting file data .
Committed revision 246091.
http://reviews.llvm.org/D12380
___
lldb-commits mailing list
lld
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
The new script can be run against output of dotest.py/dosep.py, with the
primary benefit of providing a detailed breakdown of the number of test methods
that skip for a given reason.
Output
tfiala added a comment.
Note the output is formatted for whitespace and left justified, with the
numeric columns all lined up. My verbatim mode above doesn't look like it did
what I expected...
http://reviews.llvm.org/D12416
___
lldb-commits mail
tfiala added a comment.
And, the file is actually in test/reports/, not reports/...
http://reviews.llvm.org/D12416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 33375.
http://reviews.llvm.org/D12416
Files:
test/reports/dotest_stats.py
Index: test/reports/dotest_stats.py
===
--- test/reports/dotest_stats.py
+++ test/reports/dotest_stats.py
@@ -0,0 +1,14
tfiala added a comment.
In http://reviews.llvm.org/D12416#235112, @labath wrote:
> Same question as Zachary. This sounds like a very useful feature and it would
> be nice to have it integrated into the current test system,
Well, I'd be happy to do that in dosep.py. There are a couple of chall
tfiala added a comment.
> Then the user requirement becomes "add so and such an option to your
> dotest.py invocation options and you'll get skip counts in your dosep.py
> output."
And the "add so and such an option" may already be there for many. Not a new
dotest.py option, just to be clear
tfiala added a comment.
> > Seem reasonable?
>
>
> Sounds great to me. :)
Okay, I'll give that a shot and we can see what that looks like.
http://reviews.llvm.org/D12416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tfiala added a comment.
In http://reviews.llvm.org/D12416#235191, @clayborg wrote:
> I would like to see a few things as long as we are chaning things:
>
> - get rid of dosep.py and just put the functionality into dotest.py if
> possible, it can just spawn itself in different modes
I'm all for
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
This is a change discussed in http://reviews.llvm.org/D12416.
This change does the following:
* Removes the need to call dosep.py directly. Indeed, calling dosep.py now
errors out (intentio
tfiala added a comment.
> Removes the need to call dosep.py directly. Indeed, calling dosep.py now
> errors out (intentionally).
Calling it *directly* errors out. detest.py still uses it under the covers at
the moment.
http://reviews.llvm.org/D12587
__
tfiala added a comment.
I just put up http://reviews.llvm.org/D12587 to take care of merging the user
experience of dosep.py and dotest.py into dotest.py. I want to knock that and
another change out before coming back to the skip reason tallying here.
http://reviews.llvm.org/D12416
___
Yep, all good. I was planning on waiting for feedback first.
I've checked on Linux but don't have a Windows box available at the moment.
On Wednesday, September 2, 2015, Zachary Turner wrote:
> zturner added a subscriber: zturner.
> zturner added a comment.
>
> Are there any plans to actually j
tfiala added a comment.
In http://reviews.llvm.org/D12587#239054, @labath wrote:
> I very much like the direction this is going in. We will need to update our
> buildbots when this lands (we need to run dosep manually to setup remote
> testing), but I have tested this manually and didn't see an
tfiala added inline comments.
Comment at: test/dosep.py:503
@@ +502,3 @@
+"Please call dotest.py directly. The dosep.py-specific arguments "
+"have been added under the Parallel processing arguments.")
+sys.exit(128)
labath wrote:
> You should
tfiala updated this revision to Diff 33951.
tfiala added a comment.
Added newline to dosep.py error sent via sys.stderr.write() when called
directly.
http://reviews.llvm.org/D12587
Files:
test/CMakeLists.txt
test/Makefile
test/dosep.py
test/dotest.py
test/dotest_args.py
www/test.ht
tfiala added a comment.
Also, I should mention this was tested on OS X in addition to Linux.
Let me know when you get a chance to run it on Windows, Zachary.
> Are there any plans to actually just kill dosep.py at some point?
Hmm not seeing my response to this from my phone last night, so at t
tfiala added a subscriber: tfiala.
tfiala added a comment.
In http://reviews.llvm.org/D12599#239281, @labath wrote:
> The linux parts are ok. This reduces the size of liblldb by about 13%. Good
> work. :)
13% size decrease sounds nice! Was that with a DebugAsserts build, optimized,
or what?
tfiala added a reviewer: zturner.
tfiala added a comment.
http://reviews.llvm.org/D12587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D12587#239410, @zturner wrote:
> About to take a look at this
Great, thanks.
http://reviews.llvm.org/D12587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
tfiala added inline comments.
Comment at: test/CMakeLists.txt:65
@@ -64,3 +64,3 @@
${LLDB_SOURCE_DIR}/test/dotest.py
- "${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
+ "--no-multiprocess;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
"Testing LLDB with args: ${LLDB_TE
Author: tfiala
Date: Thu Sep 3 13:58:44 2015
New Revision: 246794
URL: http://llvm.org/viewvc/llvm-project?rev=246794&view=rev
Log:
Roll dosep.py parallel test runner into dotest.py command line
See the following for details:
http://reviews.llvm.org/D12587
Modified:
lldb/trunk/test/CMakeLis
tfiala closed this revision.
tfiala added a comment.
Submitted here:
$ svn commit
Sendingtest/CMakeLists.txt
Sendingtest/Makefile
Sendingtest/dosep.py
Sendingtest/dotest.py
Sendingtest/dotest_args.py
Sendingwww/test.html
Transmitting
tfiala added a comment.
In http://reviews.llvm.org/D12587#239494, @zturner wrote:
> Ok, seems fine. No other issues on my side
Great, thanks. I'm going to get this in.
http://reviews.llvm.org/D12587
___
lldb-commits mailing list
lldb-commits@li
tfiala added a comment.
In http://reviews.llvm.org/D12587#239625, @chying wrote:
> Sorry, coming late to this thread.
> This change works ok on linux and darwin systems.
Hi @chying,
> But it has some problem on Windows, the main code has to be protected with
> the following statement on Wind
701 - 800 of 963 matches
Mail list logo
