The general idea looks good. You'll want to reach out to the Hexagon dynamic 
loader author first on any proposed changes there, though.

Thanks!

-Todd

> On Mar 29, 2016, at 11:45 AM, Francis Ricci <fjri...@fb.com> wrote:
> 
> fjricci updated this revision to Diff 51962.
> fjricci added a comment.
> 
> Refactor to remove code duplication
> 
> 
> http://reviews.llvm.org/D18531
> 
> Files:
>  include/lldb/Target/DynamicLoader.h
>  source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
>  source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
>  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
>  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
> 
> <D18531.51962.patch>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to