Author: tfiala
Date: Mon Sep 5 17:03:02 2016
New Revision: 280675
URL: http://llvm.org/viewvc/llvm-project?rev=280675&view=rev
Log:
remove dependence of TestGdbRemoteExitCode.py on parent directory source
As Pavel pointed out in a comment on llvm.org/pr30271, the VPATH I was
using here to elimin
Thanks, Pavel!
I grepped around the code for all the keys used, but looks like I missed
that one. Thanks for addressing.
-Todd
On Mon, Sep 5, 2016 at 1:34 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: labath
> Date: Mon Sep 5 03:34:56 2016
> New Revision: 2
Author: tfiala
Date: Fri Sep 9 12:07:15 2016
New Revision: 281058
URL: http://llvm.org/viewvc/llvm-project?rev=281058&view=rev
Log:
xfail DarwinLog "filter message by regex" tests
These tests are not working reliably. I'm marking them
xfail until I resolve the issue.
Tracked by:
llvm.org/pr302
tfiala added a subscriber: tfiala.
tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
Accepting and then closing.
https://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
tfiala added inline comments.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHES "Fr
tfiala added a comment.
Getting back to this change.
I'm going to rebase for code reformatting, remove the signature change on the
JSON parsing, adjust my call sites for it, refactor the structured data parsing
in the gdb-remote reception to a separate function, and then put this back up
for r
tfiala retitled this revision from "Add StructuredData unit tests; remove JSON
parsing string copy" to "Add StructuredData unit tests; move packet processing
into delegate.".
tfiala updated this revision to Diff 70909.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/G
tfiala marked 3 inline comments as done.
tfiala added a comment.
I'll make a few more adjustments here based on Zachary's feedback.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4812
@@ +4811,3 @@
+static const std::string &GetStructuredDataPacketPrefix() {
tfiala added a comment.
In https://reviews.llvm.org/D23884#539142, @tfiala wrote:
> I'll make a few more adjustments here based on Zachary's feedback.
Heh, ahem, that was meant to be "global *destructor*" above, not global
constructor.
https://reviews.llvm.org/D23884
_
tfiala updated this revision to Diff 70930.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Plugins/Process/gdb-remote/Pro
tfiala updated this revision to Diff 70931.
tfiala added a comment.
Re-uploaded last patch with full context.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugins/Process/gdb
tfiala added inline comments.
Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:38
@@ -36,2 +37,3 @@
unsigned stop_reply_called = 0;
+ std::vector structured_data_packets;
Yeah, I did try a std::vector but that actually blew up since
the
tfiala added a comment.
I'm going to go ahead with this since I think the biggest concerns have been
addressed. @labath we can adjust more later if you still have concerns.
https://reviews.llvm.org/D23884
___
lldb-commits mailing list
lldb-commits
Author: tfiala
Date: Fri Sep 9 19:06:29 2016
New Revision: 281121
URL: http://llvm.org/viewvc/llvm-project?rev=281121&view=rev
Log:
async structured data packet handling improvements
This change does the following:
* Changes the signature for the continuation delegate method that handles
async
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281121: async structured data packet handling improvements
(authored by tfiala).
Changed prior to commit:
https://reviews.llvm.org/D23884?vs=70931&id=70933#toc
Repository:
rL LLVM
https://reviews.ll
tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
This revision is now accepted and ready to land.
Accepting so this can be closed.
https://reviews.llvm.org/D23747
___
lldb-commits mailing list
lldb-commits@list
tfiala closed this revision.
tfiala added a comment.
Closing - this was submitted a few weeks ago.
https://reviews.llvm.org/D23747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala reclaimed this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Reclaiming. I'll be working on this now.
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
tfiala added a comment.
This will unfortunately get a little messy due to the code reformatting. My
first patch up for it will be to get the existing impl refreshed for the code
reformatting.
https://reviews.llvm.org/D20835
___
lldb-commits maili
Author: tfiala
Date: Mon Sep 12 13:49:22 2016
New Revision: 281243
URL: http://llvm.org/viewvc/llvm-project?rev=281243&view=rev
Log:
fix Xcode build after r281226
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj
Modified: lldb/trunk/tools/debugserver/debugserver.x
Author: tfiala
Date: Mon Sep 12 15:23:13 2016
New Revision: 281251
URL: http://llvm.org/viewvc/llvm-project?rev=281251&view=rev
Log:
xfail TestQueues.py and TestDarwinLogFilterMatchMessage.py
It looks like the message-content-retrieval aspect of DarwinLog
support is flaky, not just the regex matc
tfiala updated this revision to Diff 71180.
tfiala added a comment.
Updated patch, tweaked and verified it is working, rebased against r281243.
I'd like to add some unittests for this, so this isn't ready quite yet.
https://reviews.llvm.org/D20835
Files:
include/lldb/API/SBSourceManager.h
Author: tfiala
Date: Tue Sep 13 11:53:07 2016
New Revision: 281352
URL: http://llvm.org/viewvc/llvm-project?rev=281352&view=rev
Log:
fixup Xcode build for removal of MIUtilParse.*
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
ht
tfiala updated this revision to Diff 71253.
tfiala added a comment.
This change does the following:
- Removes storing the ANSI escape support flag from the stream and directly
consults the Debugger::GetUseColor() method. We should be able to change this
during a debug session (via settings set
tfiala updated this revision to Diff 71262.
tfiala added a comment.
Minor tweak:
- Shut off color usage in the shared object unloading test. One of the
screen-scraped results it is checking for is not set up to handle the ansi
underline sequence on the column where the process is stopped.
ht
tfiala added a comment.
In https://reviews.llvm.org/D20835#541901, @jingham wrote:
> See inlined comments. Otherwise this is great.
Great, I'll fix those up. I like the command-line option idea.
https://reviews.llvm.org/D20835
___
lldb-commits
tfiala added a comment.
Greg had a few pieces of feedback as well that we just discussed:
- Change the on/off switch for column marking to support the following states:
- terminal-code-only (i.e. only do terminal code highlighting, not the text
caret)
- terminal-code + text caret
- text ca
tfiala added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py:163
@@ +162,3 @@
+# mixed in with stop locations.
+self.dbg.SetUseColor(False)
+
Upon further reflection, there is a logically m
tfiala added a comment.
Looks like a nice start. Thanks for pulling this together, Chris!
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
+
The macOS bots (and all the Swift ones) build wi
tfiala added inline comments.
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
+
tfiala wrote:
> The macOS bots (and all the Swift ones) build with in-tree clang. I'm glad
> to have this opt
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Assuming this doesn't break anybody, this LGTM.
https://reviews.llvm.org/D24591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
tfiala added a comment.
One other items we discussed that is sure to come up:
- Right now this is geared towards one compile per .test file (similar to
something Zachary brought up before). One way we could get the multiple debug
info formats handled is to have a .test for each of the formats,
Author: tfiala
Date: Thu Sep 15 13:28:03 2016
New Revision: 281639
URL: http://llvm.org/viewvc/llvm-project?rev=281639&view=rev
Log:
added LLDB_PYTHON_TESTSUITE_ARCH Xcode variable
This Xcode build variable defaults to x86_64. It can be set to i386
to cause the lldb-python-test-suite target run
Author: tfiala
Date: Thu Sep 15 22:07:14 2016
New Revision: 281696
URL: http://llvm.org/viewvc/llvm-project?rev=281696&view=rev
Log:
add availability check to DarwinLog event tests
The pexpect-based tests properly checked for the stub reporting
DarwinLog support. The event-based ones did not. T
Author: tfiala
Date: Mon Sep 19 11:42:41 2016
New Revision: 281913
URL: http://llvm.org/viewvc/llvm-project?rev=281913&view=rev
Log:
Xcode: support gtests that use the Inputs dir
This change adds support for the gtests that require input data
in the Inputs files. This is done through a new Xcode
tfiala added a comment.
@sylvestre.ledru, I think this will be ready to go if you can convert that
check to a CMake built-in check. Maybe you can pass that along to Pino Toscano?
https://reviews.llvm.org/D23977
___
lldb-commits mailing list
lldb-c
tfiala added a comment.
Coming back to this today.
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a subscriber: labath.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
Chris - you might want to add @labath to this as well.
Comment at: source/API/CMakeLists.txt:9
@@ -8,1 +8,3 @@
+option(LLDB_BUILD_F
On Mon, Sep 19, 2016 at 7:39 PM, Zachary Turner wrote:
> Unless someone has a strong desire to keep it and it adds necessary
> functionality I would vote for removing it.
I think it's fine to remove the other support if nobody else has a good
reason to want to keep it, but we're not to that poi
tfiala updated this revision to Diff 71996.
tfiala added a comment.
This change addresses Jim's and Greg's suggestions.
- stop-show-column now is a quad-state:
- ansi-or-caret (default): Shows ANSI if color is enabled; otherwise, uses
the text-based caret.
- ansi-only: ANSI highlighting is
tfiala marked an inline comment as done.
Comment at: source/Core/Disassembler.cpp:292-294
@@ -291,2 +291,5 @@
decl_line.line = func_decl_line;
+ // TODO do we care about column on these entries? If so, we need to
+ // plumb that through GetStartLineSourceInfo.
+
tfiala added a comment.
I'd say the install rpath change is probably worth doing on the first round. I
think the top-level concept for frameworks is interesting but would be fine to
come in as another change.
I'd like to start being able to use this.
Comment at: cmake/module
tfiala updated this revision to Diff 72084.
tfiala added a comment.
Updates for Greg's latest comments.
https://reviews.llvm.org/D20835
Files:
include/lldb/API/SBSourceManager.h
include/lldb/Core/Debugger.h
include/lldb/Core/Disassembler.h
include/lldb/Core/SourceManager.h
include/lld
tfiala added a comment.
Okay, LGTM.
https://reviews.llvm.org/D24749
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Sep 21 15:13:14 2016
New Revision: 282105
URL: http://llvm.org/viewvc/llvm-project?rev=282105&view=rev
Log:
add stop column highlighting support
This change introduces optional marking of the column within a source
line where a thread is stopped. This marking will show u
Author: tfiala
Date: Wed Sep 21 19:59:23 2016
New Revision: 282128
URL: http://llvm.org/viewvc/llvm-project?rev=282128&view=rev
Log:
fix Args function broken in r281942
The method was hard-coded to check only the 0th element of the array.
This manifested as NSLog messages behaving incorrectly on
Author: tfiala
Date: Thu Sep 22 11:00:01 2016
New Revision: 282171
URL: http://llvm.org/viewvc/llvm-project?rev=282171&view=rev
Log:
added environment variable-related Args gtests
Also fixed up a couple misbehaving functions. It is perfectly
legal to have env vars with no values (i.e. the '=' an
n Thu, Sep 22, 2016 at 9:12 AM, Zachary Turner wrote:
> Thanks for the test. Is there any practical difference between "ARGS="
> and "ARGS"?
>
> On Thu, Sep 22, 2016 at 9:08 AM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>>
Author: tfiala
Date: Thu Sep 22 11:29:48 2016
New Revision: 282172
URL: http://llvm.org/viewvc/llvm-project?rev=282172&view=rev
Log:
fix DarwinLog no-info/no-debug case
This started failing recently:
TestDarwinLogSourceDebug.py
It looks like the behavior of specifying the OS_ACTIVITY_MODE
env va
iables.
>>
>> As to whether there is a difference between ARG1=\0 and ARG1\0, I'm not sure.
>>
>> On Thu, Sep 22, 2016 at 9:12 AM, Zachary Turner wrote:
>> Thanks for the test. Is there any practical difference between "ARGS=" and
>> "AR
tfiala created this revision.
tfiala added reviewers: clayborg, labath.
tfiala added a subscriber: lldb-commits.
This change introduces the concept of a platform-specific, pre-kill-hook
mechanism. If a platform defines the hook, then the hook gets called right
after a timeout is detected in a t
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:238-245
@@ +237,10 @@
+# runner for our platform.
+module_name = "lldbsuite.pre_kill_hook." + platform.system().lower()
+try:
+import importlib
+module
tfiala added a comment.
Greg also had the idea of having a fallback mechanism that uses a newly-spun-up
lldb to attach to the to-be-killed process, and retrieves the threads and
backdtraces, to dump out a compact description. That's nice in that it should
work on any host that has a working ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
I think it's fine landing here for now based on your earlier comments about the
refactoring effort to get it into LLVM/clang. I do think it's worth trying to
sink it lower when t
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/test_runner/process_control.py:514
@@ +513,3 @@
+# to it later.
+self.command = command
+
labath wrote:
> Is this actually used anywhere?
No - I originally was parsing some op
tfiala updated this revision to Diff 72294.
tfiala added a comment.
I'm about to check this in. I just wanted to put up my final change, which
includes the following:
- README.md - documents the new pre_kill_hook package in lldbsuite.
- added a runner_context/context_dict argument to the pre-k
Author: tfiala
Date: Fri Sep 23 11:10:01 2016
New Revision: 282258
URL: http://llvm.org/viewvc/llvm-project?rev=282258&view=rev
Log:
add hook for calling platform-dependent pre-kill action on a timed out test
differential review: https://reviews.llvm.org/D24850
reviewers: clayborg, labath
Added
tfiala closed this revision.
tfiala added a comment.
Closed by r282258
https://reviews.llvm.org/D24850
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
(I'll close this out as soon as Jim accepts).
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
> > There is no reasonable thing we can base the expectation as the exact same
> > device with a different cpu revision could support watchpoints just fine,
> > so we could just define the list of these tests externally (in this case, I
> > would probably annotate them w
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
I am accepting this with one strong reservation which I will explicitly call
out here:
- If somebody checks in changes that are broken, and claims they missed it
because they have an xfail ex
tfiala closed this revision.
tfiala added a comment.
Closing per comments on this already being checked in.
Repository:
rL LLVM
https://reviews.llvm.org/D21152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
tfiala closed this revision.
tfiala added a comment.
Closing this out as it appears to be resolved one way or another.
Repository:
rL LLVM
https://reviews.llvm.org/D21032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
tfiala closed this revision.
tfiala added a comment.
Thanks, Jim!
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala created this revision.
tfiala added reviewers: labath, tberghammer.
tfiala added a subscriber: lldb-commits.
This is the Linux counterpart to the recently-added macOS-side support for
sampling a test process that times out, prior to killing it.
This implementation is based on the Linux pe
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/pre_kill_hook/linux.py:68
@@ +67,3 @@
+else:
+raise Exception("failed to call 'perf record .., error: ")
+
Haha woops - that should be:
```
raise Exception("failed to call 'per
Author: tfiala
Date: Mon Sep 26 15:25:47 2016
New Revision: 282436
URL: http://llvm.org/viewvc/llvm-project?rev=282436&view=rev
Log:
added Linux support for test timeout sampling
This is the Linux counterpart to the sampling support I added
on the macOS side.
This change also introduces zip-file
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282436: added Linux support for test timeout sampling
(authored by tfiala).
Changed prior to commit:
https://reviews.llvm.org/D24890?vs=72382&id=72553#toc
Repository:
rL LLVM
https://reviews.llvm.or
tfiala added a comment.
BTW, regarding this part:
> On Ubuntu 16.04, the requisite support can be retrieved with:
>
> sudo apt-get install perf-tools-unstable
This was incorrect. The perf tool was actually present even without the
perf-tools-unstable on Ubuntu 16.04 x86_64. It is just tha
Author: tfiala
Date: Tue Sep 27 10:57:12 2016
New Revision: 282496
URL: http://llvm.org/viewvc/llvm-project?rev=282496&view=rev
Log:
xfail TestExec.py on macOS
Tracked by:
rdar://28476369
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
Modified:
lldb/tr
Author: tfiala
Date: Tue Sep 27 12:17:21 2016
New Revision: 282508
URL: http://llvm.org/viewvc/llvm-project?rev=282508&view=rev
Log:
convert TestFatArchives.py over to no-debug-info test
We only use the .o-style debug info here regardless, so having
it run all three debuginfo styles was a waste.
Author: tfiala
Date: Wed Sep 28 11:43:47 2016
New Revision: 282605
URL: http://llvm.org/viewvc/llvm-project?rev=282605&view=rev
Log:
zorg Xcode python test suite target arch update
This changes the Xcode target used by the Green Dragon Xcode CI.
When calling xcodebuild with LLDB_PYTHON_TESTSUITE_
Author: tfiala
Date: Wed Sep 28 15:39:50 2016
New Revision: 282628
URL: http://llvm.org/viewvc/llvm-project?rev=282628&view=rev
Log:
use assertEquals in TestSBTypeClassMembers
This change replaces the self.assertTrue() calls with
self.assertEquals() so that test failures get more context on failu
Author: tfiala
Date: Fri Sep 30 19:17:08 2016
New Revision: 282990
URL: http://llvm.org/viewvc/llvm-project?rev=282990&view=rev
Log:
test infra: clear file-charged issues on rerun of file
This change addresses the corner case bug in the test
infrastructure where a test file times out *outside*
of
tfiala added a comment.
Hey @fjricci ,
What is the motivation for this change? It looks like the existing code works
based on file names, which are required to be unique in the system. It looks
like you're attempting to move it over to a classname.method scheme. Is that
right? If so, class
tfiala added a comment.
@zturner , Greg is out this week (and was last Friday as well).
I'll get somebody over here to review.
https://reviews.llvm.org/D25099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Yep I plan on doing that.
-Todd
> On Oct 3, 2016, at 10:29 AM, Zachary Turner wrote:
>
> He lgtm'ed my last patch, so I guess he's ok with the general concept.
> Perhaps if someone could just run the test suite for me that would be good
> enough.
>
>> On Mon, Oct 3, 2016 at 10:25 AM Todd Fi
tfiala added a comment.
I will test this on macOS. I will have the results this afternoon.
https://reviews.llvm.org/D25099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala requested changes to this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
This revision now requires changes to proceed.
I'm getting one test crash (segfault) in logging/TestLogging.py:
Exception Type:EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVAL
tfiala added a comment.
In https://reviews.llvm.org/D25099#559701, @zturner wrote:
> I know what this is. It should be fixed in this patch, I guess I didn't have
> the newest patch uploaded.
Okay, I'll give that a shot now.
https://reviews.llvm.org/D25099
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
That works fine.
LGTM.
https://reviews.llvm.org/D25099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
tfiala added a comment.
In https://reviews.llvm.org/D24988#559314, @fjricci wrote:
> For an example of something that couldn't be disabled with the original
> implementation, consider a test like:
>
> `CreateDuringStepTestCase.test_step_inst`
>
> Disabling by method name (`test_step_inst`) would
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Much better. I see you found test.id(), which gets as the
module.class.test_method setup. That will be unique.
Thanks! LGTM.
https://reviews.llvm.org/D24988
___
Author: tfiala
Date: Mon Oct 3 17:49:13 2016
New Revision: 283156
URL: http://llvm.org/viewvc/llvm-project?rev=283156&view=rev
Log:
add a simple test case to validate test id()
Since we count on it in a few places, the test verifies that the
test instance has an id() method that returns somethin
tfiala added a comment.
I also just added a test case to validate we get a non-None answer to test
instance self.id() calls. We use it in several places, so might as well make
that explicit.
That went in as r283156.
https://reviews.llvm.org/D24988
_
Author: tfiala
Date: Fri Dec 11 18:34:57 2015
New Revision: 255400
URL: http://llvm.org/viewvc/llvm-project?rev=255400&view=rev
Log:
Decouple test execution and test finder logic in parallel test runner.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dosep.py
Modified: lldb/trunk/packag
Author: tfiala
Date: Sat Dec 12 13:26:56 2015
New Revision: 255438
URL: http://llvm.org/viewvc/llvm-project?rev=255438&view=rev
Log:
test infra: adds book-keeping for rerunnable tests
Also adds full path info for exceptional exits and timeouts when
no test method is currently running.
Adds --rer
On Mon, Dec 14, 2015 at 5:39 AM, Tamas Berghammer
wrote:
> tberghammer added inline comments.
>
>
> Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
> @@ +517,3 @@
> +if hasattr(func, "categories"):
> +cat.extend(func.categories)
> +func.cate
Author: tfiala
Date: Mon Dec 14 15:28:46 2015
New Revision: 255543
URL: http://llvm.org/viewvc/llvm-project?rev=255543&view=rev
Log:
test infra: enable single-worker rerun phase for flakey tests.
Use of --rerun-all-issues will enable any test method failure, not just
test methods marked with the
Author: tfiala
Date: Mon Dec 14 15:49:39 2015
New Revision: 255549
URL: http://llvm.org/viewvc/llvm-project?rev=255549&view=rev
Log:
Temporarily skip TestWithLimitDebugInfo on Darwin and OS X
This test is erroring out on a sequence call to a function.
Modified:
lldb/trunk/packages/Python/ll
Author: tfiala
Date: Mon Dec 14 16:04:20 2015
New Revision: 27
URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev
Log:
Revert "Temporarily skip TestWithLimitDebugInfo on Darwin and OS X"
This reverts commit 30ed0826a1bb800454088ea1ae16c113a69b92b1.
Modified:
lldb/trunk/package
Author: tfiala
Date: Mon Dec 14 17:45:38 2015
New Revision: 255581
URL: http://llvm.org/viewvc/llvm-project?rev=255581&view=rev
Log:
test infra: catch and print exception info on test runner socket listener
This is the listener's spawned connection, not the listener itself.
(i.e. this is the test
tfiala added a comment.
Yep this fixed the issues I was having on OS X with the related change.
Thanks, Siva!
Repository:
rL LLVM
http://reviews.llvm.org/D15511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
This seems right:
python
Python 2.7.10 (default, Oct 23 2015, 18:05:06)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> s = 'abc'
>>> 'bc' in 'abc'
True
>>> 'bc' in s
True
>>> 'clang' in 'clang'
True
O
Yeah I find some of these things not always obvious (I'm sure the docs are
there, but I don't always find them ;-)). What I was hoping was this
wasn't a python 2 vs. 3 thing.
On Mon, Dec 14, 2015 at 7:30 PM, Zachary Turner wrote:
> I tried to google the semantics of the in keyword, but Python
>
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good!
http://reviews.llvm.org/D15530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: tfiala
Date: Tue Dec 15 15:33:38 2015
New Revision: 255676
URL: http://llvm.org/viewvc/llvm-project?rev=255676&view=rev
Log:
test-infra: refactored new summary results into base ResultsFormatter class
This allows more specialized formatters to still reuse the results
summarization display
tfiala added a comment.
Hey Pavel,
Change r255676 changed a few things that will require this patch to get
updated. I think the main code change will be that
ResultsFormatter._make_rerun_eligibility_key(self) has been renamed to
ResultsFormatter._make_key(self). I folded the BasicResultsForm
Author: tfiala
Date: Tue Dec 15 17:25:56 2015
New Revision: 255705
URL: http://llvm.org/viewvc/llvm-project?rev=255705&view=rev
Log:
test infra: support test reruns in xunit formatter.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/xunit_formatter.py
Modified: lldb/trunk/packages/Python
Author: tfiala
Date: Tue Dec 15 17:56:26 2015
New Revision: 255719
URL: http://llvm.org/viewvc/llvm-project?rev=255719&view=rev
Log:
prevent rerun logic from kicking in on test runs including aarch64.
This is a workaround for:
llvm.org/pr25844
Modified:
lldb/trunk/packages/Python/lldbsuite/t
501 - 600 of 963 matches
Mail list logo
