tfiala added a comment.
(And nice work on the underlying change - with libedit it works quite nicely
for basic line editing and history!)
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
Author: tfiala
Date: Sat Oct 3 20:28:51 2015
New Revision: 249256
URL: http://llvm.org/viewvc/llvm-project?rev=249256&view=rev
Log:
cmake: ensure readline python module target is added before finishing swig.
When the readline target exists (only for non-Android Linux currently),
ensure that targ
tfiala added a comment.
And if you'd prefer, I'd be happy to put in that patch as is (the one I tested
with both libedit included and libedit excluded).
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commit
tfiala added a comment.
In http://reviews.llvm.org/D13362#259543, @labath wrote:
> In http://reviews.llvm.org/D13362#258972, @tfiala wrote:
>
> > I've fixed:
> > https://llvm.org/bugs/show_bug.cgi?id=25019
> >
> > I think for now I am not interested in trying to tackle the intent of this
> > ch
ing the shell scripts currently support. It's been lingering long
> enough that there's obviously no rush, but if you ever feel the urge to
> look at it, I think it would be easy.
>
>
Sure, tell me a bit more and I can look into getting this on my queue.
-Todd
> On S
here was just one script.
>>>
>>> As far as I know it should be a drop-in replacement, and it supports
>>> everything the shell scripts currently support. It's been lingering long
>>> enough that there's obviously no rush, but if you ever feel the urge to
>&g
t;> technical debt that we could get rid of if there was just one script.
>>>>
>>>> As far as I know it should be a drop-in replacement, and it supports
>>>> everything the shell scripts currently support. It's been lingering long
>>>> enough that there&#x
tfiala added a comment.
> Todd, I'm putting you as the reviewer since you seem to be the most
> knowledgeable about Python. If you can think of someone better, let me know.
I'll have a look tonight.
http://reviews.llvm.org/D13448
___
lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D13448#260194, @tfiala wrote:
> > Todd, I'm putting you as the reviewer since you seem to be the most
> > knowledgeable about Python. If you can think of someone better, let me know.
>
>
> I'll have a look tonight.
I may try to switch over the
tfiala added a comment.
In http://reviews.llvm.org/D13448#260195, @tfiala wrote:
> In http://reviews.llvm.org/D13448#260194, @tfiala wrote:
>
> > > Todd, I'm putting you as the reviewer since you seem to be the most
> > > knowledgeable about Python. If you can think of someone better, let me
>
tfiala added a comment.
Okay all that said, the change itself looks fine. Have you tried it on Linux?
I'll give it a go there in the morning. If it doesn't break there, I have no
issues with this change.
http://reviews.llvm.org/D13448
___
lldb-c
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM. I saw no issues on Ubuntu 14.04 x86_64 and the changes all look
reasonable.
http://reviews.llvm.org/D13448
___
lldb-commits mailing list
Author: tfiala
Date: Tue Oct 6 10:23:52 2015
New Revision: 249419
URL: http://llvm.org/viewvc/llvm-project?rev=249419&view=rev
Log:
Switching TestCallUserDefinedFunction from xfail to flaky on OS X.
This is passing 50/50 times for me. Moving to flaky as precautionary
measure.
Modified:
ll
Author: tfiala
Date: Tue Oct 6 10:33:51 2015
New Revision: 249421
URL: http://llvm.org/viewvc/llvm-project?rev=249421&view=rev
Log:
Reduce load on TestMultipleDebuggers.
4-core CPUs have a hard time keeping up with the number of debuggers
we were simultaneously spawning. This leads to a timeout
Author: tfiala
Date: Tue Oct 6 10:57:55 2015
New Revision: 249425
URL: http://llvm.org/viewvc/llvm-project?rev=249425&view=rev
Log:
Convert expectedFlakeyDarwin to expectedFlakeyDsym for
TestCallUserDefinedFunction.py
Closes:
https://llvm.org/bugs/show_bug.cgi?id=25076
Modified:
lldb/trun
Author: tfiala
Date: Tue Oct 6 14:15:56 2015
New Revision: 249446
URL: http://llvm.org/viewvc/llvm-project?rev=249446&view=rev
Log:
Address failing Go tests on go version from Ubuntu 14.04
Go tests fail on Ubuntu 14.04's go1.2.1. This change puts a minimum
go version in the skipUnlessGoInstalle
Author: tfiala
Date: Tue Oct 6 14:23:22 2015
New Revision: 249448
URL: http://llvm.org/viewvc/llvm-project?rev=249448&view=rev
Log:
Bungled my last change in a tweak.
I took out a skip_test check that wasn't necessary, but
didn't fully yank it out. Would break a normal go install.
Modified:
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks, Ryan!
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
Okay, I can adjust that.
On Tue, Oct 6, 2015 at 1:24 PM, Ryan Brown wrote:
> I was wondering if we'd need this. Go 1.4 is the minimum supported version.
>
> On Tue, Oct 6, 2015 at 12:17 PM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>>
gt;
>> I was wondering if we'd need this. Go 1.4 is the minimum supported
>> version.
>>
>> On Tue, Oct 6, 2015 at 12:17 PM Todd Fiala via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: tfiala
>>> Date: Tue Oct 6 14
Author: tfiala
Date: Tue Oct 6 17:14:33 2015
New Revision: 249477
URL: http://llvm.org/viewvc/llvm-project?rev=249477&view=rev
Log:
Modify minimumg go version to 1.4.0 for tests.
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org/viewvc/llvm-pr
Author: tfiala
Date: Thu Oct 8 12:43:02 2015
New Revision: 249705
URL: http://llvm.org/viewvc/llvm-project?rev=249705&view=rev
Log:
syncsource.py: a specific dir's source_excludes may now include the special
entry "".
The special entry will prevent that specific directory's excludes
from
rece
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks great. Thanks for tracking that down!
http://reviews.llvm.org/D13583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Author: tfiala
Date: Fri Oct 9 20:26:47 2015
New Revision: 249930
URL: http://llvm.org/viewvc/llvm-project?rev=249930&view=rev
Log:
Fixup log enable --stack so it works on Linux.
The underlying raw_string_stream buffer was not being flushed
after asking llvm to collect the backtrace. This worke
tfiala added a comment.
> Unless someone else (@emaste?) objects, I think this looks fine to land and
> iterate on trunk as discussed in the mailing list thread. Just one minor
> comment based on cleanups that are on-going on trunk now.
Sounds reasonable.
Repository:
rL LLVM
http://review
tfiala created this revision.
tfiala added reviewers: labath, dawn.
tfiala added a subscriber: lldb-commits.
This change fixes 'lldb -P' (retrieve lldb-module python path) to work
correctly on cmake-based builds on POSIX systems.
Previously, this would assume the python module installation path
tfiala added a comment.
LGTM, Adrian!
http://reviews.llvm.org/D13555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala abandoned this revision.
tfiala added a comment.
I'm going to redo this some time in the future based on the test event
architecture.
http://reviews.llvm.org/D12416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
tfiala added a comment.
Did this go in, Zachary? I'm just looking to clear out my reviews and this one
seems to still be open.
http://reviews.llvm.org/D12612
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
tfiala added a comment.
Hey Zachary, I think this one went in, didn't it? Can you close it out if so?
Thanks!
http://reviews.llvm.org/D13448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
tfiala closed this revision.
tfiala added a comment.
I'm going ahead and closing this one out. It either went in or is not
interesting to the author any more. Last ping was over a couple weeks ago.
http://reviews.llvm.org/D5503
___
lldb-commits m
tfiala closed this revision.
tfiala added a comment.
Great! Closing out.
http://reviews.llvm.org/D13448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala closed this revision.
tfiala added a comment.
Great, thanks!
http://reviews.llvm.org/D12612
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D13625#264786, @labath wrote:
> Could you submit the change with full context next time? It makes review much
> easier.
Tell me the diff line you want. I'm doing the same type of diffs I have
submitted for years. I'll adjust my process.
>
tfiala added a comment.
Also - there are some places in the code where the lib dir (as 'lib') is
assumed, and those would need to change as well. Including taking note of
where it was passed in cmake, which will look something similar to what I did
here, but now with the added burden that two
tfiala added a comment.
> Tell me the diff line you want. I'm doing the same type of diffs I have
> submitted for years. I'll adjust my process.
Are you wanting something like this (assuming done with git diff)?
git diff --no-prefix
-U{SOME-REALLY-BIG-NUMBER-GREATER-THAN-NUMBER-OF-LINES-IN-THE
tfiala added a comment.
In http://reviews.llvm.org/D13625#264879, @labath wrote:
> In http://reviews.llvm.org/D13625#264862, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13625#264786, @labath wrote:
> >
> > > Could you submit the change with full context next time? It makes review
> > > much
tfiala added a comment.
> If it is proven we are doing something wrong for cross compiling, and
> somebody wants to make that right, we then change over from using the
> disutils approach both in generating the partial relative directory for
> answering 'lldb -P' and in the finalization of pyth
tfiala added a comment.
In http://reviews.llvm.org/D13625#264889, @labath wrote:
> In http://reviews.llvm.org/D13625#264888, @tfiala wrote:
>
> > > Tell me the diff line you want. I'm doing the same type of diffs I have
> > > submitted for years. I'll adjust my process.
> >
> >
> > Are you wanti
tfiala added a comment.
In http://reviews.llvm.org/D13625#264951, @labath wrote:
> > RHEL 7 is already doing this - most of lib is 64-bit. All of lib64 is
> > 64-bit. They already use both (~600 MB in lib, ~1GB in lib64 on a stock
> > system). I have also built custom pythons, and by default
tfiala created this revision.
tfiala added reviewers: emaste, chaoren.
tfiala added subscribers: lldb-commits, labath.
This change addresses:
https://llvm.org/bugs/show_bug.cgi?id=25133
On Linux (and likely other GNU ld-based systems), the llvm backtrace utility
used by 'log enable --stack' cann
tfiala added a comment.
> I'll wait for a while to hear if either @emaste or @dawn chime in.
I'm going to get this in. If any of the rest of you find issues, we'll get
them taken care of at that point. Thanks!
http://reviews.llvm.org/D13625
___
tfiala closed this revision.
tfiala added a comment.
Committed here:
svn commit
Adding scripts/get_relative_lib_dir.py
Sendingsource/Host/CMakeLists.txt
Sendingsource/Host/posix/HostInfoPosix.cpp
Sendingwww/build.html
Transmitting file data
Commi
Author: tfiala
Date: Mon Oct 12 15:12:27 2015
New Revision: 250093
URL: http://llvm.org/viewvc/llvm-project?rev=250093&view=rev
Log:
Support RHEL 7 and similar systems that use architecture-specific Python lib
dirs
This change commits: http://reviews.llvm.org/D13625
Added:
lldb/trunk/script
Author: tfiala
Date: Tue Oct 13 18:41:19 2015
New Revision: 250253
URL: http://llvm.org/viewvc/llvm-project?rev=250253&view=rev
Log:
ArchSpec: fix unintentional promotion of unspecified unknowns to specified
unknowns
* ArchSpec::MergeFrom() would erroneously promote an unspecified
unknown to a
tfiala added a comment.
I've been using this now for a couple days and it seems to work fine on both OS
X and Linux. The Linux side enables the 'log enable --stack' to work.
Any concerns with this?
http://reviews.llvm.org/D13667
___
lldb-commits
Author: tfiala
Date: Wed Oct 14 09:52:15 2015
New Revision: 250299
URL: http://llvm.org/viewvc/llvm-project?rev=250299&view=rev
Log:
cmake: provide flag that enables 'log enable --stack' to provide useful
file/function info on POSIX systems
Adding the following flag to a cmake line:
-DLLDB_EXPOR
tfiala closed this revision.
tfiala added a comment.
Closed by the following commit:
svn commit
Sendingcmake/modules/AddLLDB.cmake
Sendingcmake/modules/LLDBConfig.cmake
Sendingsource/API/CMakeLists.txt
Transmitting file data ...
Committed revision 250299.
htt
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13742
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
tfiala created this revision.
tfiala added a reviewer: tberghammer.
tfiala added a subscriber: lldb-commits.
This addresses an assert that has started firing recently on the OS X test
suite.
The change was proposed by the assert's author, Tamas Berghammer. (Thanks for
the fix, Tamas!)
http://
tfiala closed this revision.
tfiala added a comment.
Closed by commit:
$ svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Transmitting file data .
Committed revision 250426.
http://reviews.llvm.org/D13777
___
lldb-comm
Author: tfiala
Date: Thu Oct 15 11:35:59 2015
New Revision: 250426
URL: http://llvm.org/viewvc/llvm-project?rev=250426&view=rev
Log:
Fix broken assert in DWARFDIE.cpp on OS X
See:
http://reviews.llvm.org/D13777
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Modified: lldb
tfiala added a subscriber: tfiala.
tfiala added a comment.
In http://reviews.llvm.org/D13727#268053, @zturner wrote:
> The main thought I had was just that it would make the code simpler and
> delegate more of the synchronization stuff to the library. But if we don't
> get any of that benefit
Author: tfiala
Date: Thu Oct 15 15:27:23 2015
New Revision: 250453
URL: http://llvm.org/viewvc/llvm-project?rev=250453&view=rev
Log:
Modify pylint/flake8 path helper to add lldb python module to path.
It was adding all the test infrastructure paths properly, but it
was not adding the lldb module.
Author: tfiala
Date: Thu Oct 15 15:32:25 2015
New Revision: 250454
URL: http://llvm.org/viewvc/llvm-project?rev=250454&view=rev
Log:
Fixup previous commit.
Looks like I blasted something into my editor...
Modified:
lldb/trunk/test/lldb_pylint_helper.py
Modified: lldb/trunk/test/lldb_pylint_
tfiala added a comment.
In http://reviews.llvm.org/D13727#268096, @clayborg wrote:
> In http://reviews.llvm.org/D13727#268091, @tberghammer wrote:
>
> > I agree that parking the threads in the kernel should be very cheap (I am
> > not sure about Windows) but on high end multi core machines havin
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Adrian. Thanks!
http://reviews.llvm.org/D13788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
tfiala added a comment.
I'm in agreement with Pavel's assessment on this.
Regarding the tests, I had brought that up with Greg earlier. We can handle
that in a few different ways:
- We do nothing, and perhaps some collections of tests run slower if they are
all pounding on their thread pools
tfiala added a comment.
That seems totally reasonable. We're fine with "this isn't an issue until it's
proven to be an issue."
(And I like stressing the concurrency - we initially found a number of issues
when the concurrent test runner came online in the first place).
http://reviews.llvm.or
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Zachary!
http://reviews.llvm.org/D13879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tfiala added a comment.
In http://reviews.llvm.org/D13880#270742, @zturner wrote:
> Todd, do you have any good ideas on how to organize this and make it play
> nicely with python's module / package system? `dotest` is just an arbitrary
> script under lldb/test and is not part of any installed
tfiala added a comment.
In http://reviews.llvm.org/D13880#271483, @tfiala wrote:
> In http://reviews.llvm.org/D13880#270742, @zturner wrote:
>
> > Todd, do you have any good ideas on how to organize this and make it play
> > nicely with python's module / package system? `dotest` is just an
> >
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
All that aside, LGTM.
http://reviews.llvm.org/D13880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Yep, like it.
http://reviews.llvm.org/D13906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tfiala added a comment.
In http://reviews.llvm.org/D13912#271481, @zturner wrote:
> Thanks. This is still blocked on my 2 earlier CLs (one adding six to the
> repo, and the other hooking up six to be recognized by dotest). If you get a
> chance can you take a look at those?
Yep, I didn't re
tfiala added a comment.
Sure thing!
http://reviews.llvm.org/D13912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tfiala created this revision.
tfiala added a reviewer: granata.enrico.
tfiala added a subscriber: lldb-commits.
This change fixes data formatters for libstdc++ 6.0.21:
* Adds std::string data formatter support in C++ (rather than Python) for
6.0.21+.
* Uses std::list count field support when pre
Author: tfiala
Date: Wed Oct 21 19:23:38 2015
New Revision: 250965
URL: http://llvm.org/viewvc/llvm-project?rev=250965&view=rev
Log:
Fix libstdc++ data formatters on Ubuntu 15.10 x86_64
See http://reviews.llvm.org/D13964 for details.
Modified:
lldb/trunk/examples/synthetic/gnu_libstdcpp.py
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM. Good catch!
http://reviews.llvm.org/D13985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
tfiala added a comment.
(I don't think you need to wait for Enrico, btw.)
http://reviews.llvm.org/D13985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Yeah, if you can make that happen, that sounds good to me. This is a "if you
have libc++, please build with it, otherwise skip this test"-kinda test... :-)
http://reviews.llvm.org/D13964
___
lldb-commits mailing list
lldb-c
tfiala closed this revision.
tfiala added a comment.
Forgot to mark this as closed:
Closed by commit:
r250965 | tfiala | 2015-10-21 17:23:38 -0700 (Wed, 21 Oct 2015) | 4 lines
Fix libstdc++ data formatters on Ubunt
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
I like it.
http://reviews.llvm.org/D14020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
tfiala added inline comments.
Comment at: test/lang/go/types/TestGoASTContext.py:134
@@ -131,3 +133,3 @@
self.assertEqual(5, v.GetNumChildren())
-for i in xrange(5):
+for i in six.moves.xrange(5):
self.assertEqual(str(i + 1), v.GetChildAtIndex
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
> I've been putting most of this stuff in withouty review, but I figure every
> once in a while I should pass one your way as a sanity check to make sure I'm
> still on the right path.
That'
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D14028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: tfiala
Date: Sun Oct 25 11:22:46 2015
New Revision: 251240
URL: http://llvm.org/viewvc/llvm-project?rev=251240&view=rev
Log:
Add lldb/unittests files to the Xcode lldb project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL
Author: tfiala
Date: Sun Oct 25 11:53:08 2015
New Revision: 251243
URL: http://llvm.org/viewvc/llvm-project?rev=251243&view=rev
Log:
Added some top-level unittests files that I missed in the last check-in.
I am also letting a debugserver-related project entry slide in
since Xcode seems to insist
Author: tfiala
Date: Sun Oct 25 16:42:35 2015
New Revision: 251261
URL: http://llvm.org/viewvc/llvm-project?rev=251261&view=rev
Log:
Xcode: added lldb-gtest target to build and run the gtests in the unittests
directory.
Also added a placeholder Editline gtest for some code that I'll add as soon
Author: tfiala
Date: Sun Oct 25 16:54:56 2015
New Revision: 251264
URL: http://llvm.org/viewvc/llvm-project?rev=251264&view=rev
Log:
Fix a copy-and-paste error on new Editline test cmake configuration.
Modified:
lldb/trunk/unittests/Editline/CMakeLists.txt
Modified: lldb/trunk/unittests/Edit
tfiala accepted this revision.
tfiala added a comment.
LGTM.
Who currently owns the MI tests (or system) these days? I suppose you are
doing this to squelch them from failing on the buildbots. On our end, we see
the MI tests fail fairly frequently, typically intermittently.
http://reviews.l
tfiala added a comment.
In http://reviews.llvm.org/D14060#275211, @labath wrote:
> We have XFAILed MI tests that were failing on our linux build bot. Atm, I am
> seeing expected passes, so I might try enabling them soon...
I have been seeing them fail intermittently on both OS X and Ubuntu
14
Author: tfiala
Date: Tue Oct 27 16:53:39 2015
New Revision: 251457
URL: http://llvm.org/viewvc/llvm-project?rev=251457&view=rev
Log:
Fix editline unindentation code for more recent libedits.
This code was modifying the cursor and then expecting the editline
API call to see the effect for the next
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D14131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: tfiala
Date: Wed Oct 28 10:24:19 2015
New Revision: 251522
URL: http://llvm.org/viewvc/llvm-project?rev=251522&view=rev
Log:
Fix build break on OS X from cleanup check-in.
I'll track down why our CI is not sending out emails on build breaks.
Modified:
lldb/trunk/source/Core/IOHandler
tfiala created this revision.
tfiala added reviewers: labath, zturner, jasonmolenda.
tfiala added a subscriber: lldb-commits.
Distributions that put lldb binaries in /usr/bin and whatnot are going to put
argdumper in the same place. argdumper is way too generic a name. Rename to
lldb-argdumper
tfiala added a comment.
In http://reviews.llvm.org/D14169#277545, @labath wrote:
> Looks good.
>
> argdumper should probably go to /usr/libexec, but then I guess we won't be
> able to find it, so that's a different story...
Exactly right. That will require more work.
http://reviews.llvm.org/
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good.
We were having trouble running the script from the top level earlier and were
directly calling the one that you're disabling. That'll be nice to get the top
level one working aga
tfiala added a comment.
> scripts/Python/finish-swig-Python-LLDB.sh
Hmm I think there is a python implementation of this script that I may have
missed. Checking on that now.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
Just one question on the python 3 return code for non-exceptional exit.
Comment at: packages/Python/lldbsuite/support/seven.py:12
@@ +11,3 @@
+import subprocess
+return (0, subprocess.check_output(command, shell=True))
+exc
tfiala added a comment.
In http://reviews.llvm.org/D14169#277587, @tfiala wrote:
> > scripts/Python/finish-swig-Python-LLDB.sh
>
>
> Hmm I think there is a python implementation of this script that I may have
> missed. Checking on that now.
Yes there is. I need to adjust one other place. I'
tfiala updated this revision to Diff 38715.
tfiala added a comment.
Fixed up one missed spot, the python-based class completion script.
I think the original clean build and test run on Linux missed this because I
don't think we actually use it on Linux. It's primarily useful on OS X 10.11
and
tfiala added a comment.
I'm out the next couple days at the LLVM conference. I'm going to put this in.
We'll revert it out if it causes any trouble on Windows and fix it up.
http://reviews.llvm.org/D14169
___
lldb-commits mailing list
lldb-commit
Author: tfiala
Date: Thu Oct 29 00:07:12 2015
New Revision: 251616
URL: http://llvm.org/viewvc/llvm-project?rev=251616&view=rev
Log:
Rename argdumper to lldb-argdumper
http://reviews.llvm.org/D14169
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/scripts/Python/finish-swig
tfiala closed this revision.
tfiala added a comment.
Closed by commit:
$ svn commit
Sendinglldb.xcodeproj/project.pbxproj
Sendingscripts/Python/finish-swig-Python-LLDB.sh
Sendingscripts/Python/finishSwigPythonLLDB.py
Sendingsource/Host/macosx/Host.mm
Se
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
OK looks good then.
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: tfiala
Date: Thu Oct 29 21:54:52 2015
New Revision: 251681
URL: http://llvm.org/viewvc/llvm-project?rev=251681&view=rev
Log:
Added real editline tests.
These are two simple tests that make sure single line and
multiline content are processed and received by Editline.cpp.
Fancier tests to
t 11:26 PM, Zachary Turner wrote:
>
>
> On Thu, Oct 29, 2015 at 7:57 PM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: tfiala
>> Date: Thu Oct 29 21:54:52 2015
>> New Revision: 251681
>>
>> URL: http://llvm.org
101 - 200 of 963 matches
Mail list logo
