tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

> I've been putting most of this stuff in withouty review, but I figure every 
> once in a while I should pass one your way as a sanity check to make sure I'm 
> still on the right path.


That's fine.  As long as it isn't breaking anything, which so far it seems like 
hasn't :-)

> xrange() is removed from Python 3, and range() is no longer a function but a 
> "sequence object" which must be converted to a list. In theory I could have 
> used six.moves.xrange, but I decided that the efficiency provided by xrange 
> wasn't important in the code, so I changed it all to use range instead.


Looks good!


http://reviews.llvm.org/D14023



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to