Author: tberghammer
Date: Sat Nov 4 11:25:51 2017
New Revision: 317411
URL: http://llvm.org/viewvc/llvm-project?rev=317411&view=rev
Log:
Improve the posix core file triple detection
Summary:
Posix core files sometime don't contain enough information to correctly
detect the OS. If that is the cas
Author: tberghammer
Date: Tue Nov 7 02:39:22 2017
New Revision: 317563
URL: http://llvm.org/viewvc/llvm-project?rev=317563&view=rev
Log:
Support scoped enums in the DWARF AST parser
Subscribers: JDevlieghere
Differential Revision: https://reviews.llvm.org/D39545
Modified:
lldb/trunk/includ
Author: tberghammer
Date: Tue Nov 7 05:43:55 2017
New Revision: 317574
URL: http://llvm.org/viewvc/llvm-project?rev=317574&view=rev
Log:
Fix an issue in r317563 causing a clang assert
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.c
Author: tberghammer
Date: Sat Mar 18 12:33:00 2017
New Revision: 298189
URL: http://llvm.org/viewvc/llvm-project?rev=298189&view=rev
Log:
Remove some dead code from DumpValueObjectOptions::PointerDepth
Modified:
lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h
lldb/trunk/so
It is possible to vend one of the actual backing object as a synthetic
child using the SB API. What is not possible from the SB API at the moment
(we might want to fix it) is to vend one of the actual backing object with
a different name then the underlying object itself. You can still say that
obj
Created bug for exposing ValueObject::Clone as SB API:
http://bugs.llvm.org/show_bug.cgi?id=32477
On Thu, Mar 30, 2017 at 1:04 PM Jim Ingham via Phabricator <
revi...@reviews.llvm.org> wrote:
> jingham accepted this revision.
> jingham added a comment.
> This revision is now accepted and ready to
Author: tberghammer
Date: Fri Mar 31 15:07:20 2017
New Revision: 299249
URL: http://llvm.org/viewvc/llvm-project?rev=299249&view=rev
Log:
Do not dereference std::unique_ptr by default
Summary:
Displaying the object pointed by the unique_ptr can cause an infinite
recursion when we have a pointer l
Author: tberghammer
Date: Fri Mar 31 15:23:22 2017
New Revision: 299251
URL: http://llvm.org/viewvc/llvm-project?rev=299251&view=rev
Log:
Add support for sythetic operator dereference
Summary:
After this change a sythetic child provider can generate a special child
named "$$dereference$$" what if
Author: tberghammer
Date: Fri Mar 31 15:48:00 2017
New Revision: 299259
URL: http://llvm.org/viewvc/llvm-project?rev=299259&view=rev
Log:
Stop calling ValueObject::SetName from synthetic child providers
Summary:
Calling ValueObject::SetName from a sythetic child provider would change
the underyin
Author: tberghammer
Date: Thu Apr 6 13:15:43 2017
New Revision: 299677
URL: http://llvm.org/viewvc/llvm-project?rev=299677&view=rev
Log:
XFAIL TestDataFormatterLibcxxVBool on Linux & Android
The skipping logic for the test have been fixed recently but the test is
very flakey on the buildbot.
Mo
Author: tberghammer
Date: Thu Jul 27 05:01:32 2017
New Revision: 309265
URL: http://llvm.org/viewvc/llvm-project?rev=309265&view=rev
Log:
XFAIL/XFlakey some tests what become very flakey on the Linux buildbot
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/concurre
Author: tberghammer
Date: Mon Jul 31 03:26:19 2017
New Revision: 309554
URL: http://llvm.org/viewvc/llvm-project?rev=309554&view=rev
Log:
Add support for base address entries in the .debug_ranges section
Summary:
Clang recently started to emit base address entries into the
.debug_ranges section t
Author: tberghammer
Date: Wed Aug 16 04:45:10 2017
New Revision: 311000
URL: http://llvm.org/viewvc/llvm-project?rev=311000&view=rev
Log:
Remove the DWARFExpression -> Clang ExpressionParser dependency
It was completly unused and broke the part of the encapsulation that
common code shouldn't depe
Author: tberghammer
Date: Fri Aug 25 06:56:14 2017
New Revision: 311775
URL: http://llvm.org/viewvc/llvm-project?rev=311775&view=rev
Log:
Add support for the DWP debug info format
Summary:
The DWP (DWARF package) format is used to pack multiple dwo files
generated by split-dwarf into a single ELF
Author: tberghammer
Date: Mon Sep 18 03:24:48 2017
New Revision: 313525
URL: http://llvm.org/viewvc/llvm-project?rev=313525&view=rev
Log:
Fix Linux remote debugging after r313442
On Linux lldb-server sends an OK response to qfThreadInfo if no process
is started yet. I don't know why would LLDB is
Hi Vadim,
This change broke remote debugging on Linux and Android as for some reason
LLDB sends a qfThreadInfo on those platforms before starting a process (not
sure why, will investigate when I have a bit more time) and lldb-server
sends an OK response to it. After your change it will generate a
Are you building with cmake or with XCode? If you are using cmake then you
should be able to reproduce it with running "ninja check-lldb-unit". It
failed to link one of the unittest targets because UtilityTests don't have
an explicit dependency on lldbHost (where ThreadLauncher is defined). You
can
On linux when you call fork the new process will only have the thread what
called fork. Other threads will be ignored with leaving whatever dirty
state they had left in the new process. Regarding execve it doesn't do fork
so we would have to do fork & execve what have the same issue (actually we
ar
It is using "gcc version 4.9 20150123 (prerelease) (GCC)"
On Wed, Oct 5, 2016 at 11:12 AM Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> I don't know for sure, but I'm guessing it's using GCC, and perhaps even
> an old one at that.
>
> On Wed, Oct 5, 2016 at 11:10 AM Enri
Hi Jason,
Thank you for adding unit test for this code. I think the current
implementation doesn't fail terribly on 16 vs 32 byte stack alignment
because we use the "opc" from the instruction to calculate the write back
address (to adjust the SP) so having the wrong size of the register won't
effe
I am a bit surprised that we don't define the smaller floating point
registers on AArch64 the same way we do it on x86/x86_64/Arm (have no idea
about MIPS) and I would consider this as a bug what we should fix (will
gave it a try when I have a few free cycles) because currently it is very
difficult
In case of Linux and Android we are using the qRegisterInfo packet and
lldb-server fills it in based on the register definitions inside LLDB so
for those targets it would be important to have all of the alias registers
available.
I don't have an AArch64-BE target at hand but I am pretty sure you a
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Improve the libstdc++ smart pointer formatters
- Display the strong/weak count in the summary
- Display the pointed object as a synthetic member
- Create s
tberghammer updated this revision to Diff 75025.
tberghammer added a comment.
Herald added subscribers: mgorny, beanz.
Move the code to a new cpp file
https://reviews.llvm.org/D25726
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/T
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: mgorny, beanz.
Add data formatter for libstdc++ tuple
https://reviews.llvm.org/D25733
Files:
packages/Python/lldbsuite/test/function
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Add data formatter for libstdc++ unique_ptr
https://reviews.llvm.org/D25734
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatte
tberghammer added a comment.
In https://reviews.llvm.org/D25726#573127, @Eugene.Zelenko wrote:
> Please run Clang-format over new code.
I run it before upload but it mush have picked up some strange config. Will run
it again before submit. Thanks for noticing it.
https://reviews.llvm.org/D25
Modified:
lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html?rev=284725&r1=284724&r2=284725&view=diff
=
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138
+return 3;
+ return UINT32_MAX;
+}
labath wrote:
> I know you just copied it, but this seems wrong (size_t can be 64-bit). Will
> this work if you
tberghammer updated this revision to Diff 75300.
tberghammer marked 5 inline comments as done.
https://reviews.llvm.org/D25726
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.py
source/Plugins/Language/C
tberghammer added a comment.
A few high level comments:
- I have the feeling you ported much more code over to use the LLDB register
numbers then it would be strictly necessary. I am not sure if it is good or bad
as it can help us consolidate the confusion around the different register
numberi
tberghammer updated this revision to Diff 75417.
tberghammer marked 4 inline comments as done.
https://reviews.llvm.org/D25733
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile
packages/Python/lldbsuite/test/functionalities/data
tberghammer updated this revision to Diff 75425.
tberghammer marked 2 inline comments as done.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D25734
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
packa
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110
+ if (name == ConstString("ptr") || name == ConstString("pointer")) return 2;
+ return UINT32_MAX;
+}
labath wrote:
> ~0 ?
The user compares the resu
Author: tberghammer
Date: Fri Oct 21 10:02:32 2016
New Revision: 284828
URL: http://llvm.org/viewvc/llvm-project?rev=284828&view=rev
Log:
Improve the libstdc++ smart pointer formatters
* Display the strong/weak count in the summary
* Display the pointed object as a synthetic member
* Create synth
Author: tberghammer
Date: Fri Oct 21 10:02:38 2016
New Revision: 284829
URL: http://llvm.org/viewvc/llvm-project?rev=284829&view=rev
Log:
Add data formatter for libstdc++ tuple
Differential revision: https://reviews.llvm.org/D25733
Added:
lldb/trunk/packages/Python/lldbsuite/test/functional
Author: tberghammer
Date: Fri Oct 21 10:02:44 2016
New Revision: 284830
URL: http://llvm.org/viewvc/llvm-project?rev=284830&view=rev
Log:
Add data formatter for libstdc++ unique_ptr
Differential revision: https://reviews.llvm.org/D25734
Added:
lldb/trunk/packages/Python/lldbsuite/test/funct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284830: Add data formatter for libstdc++ unique_ptr
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25734?vs=75425&id=75432#toc
Repository:
rL LLVM
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284828: Improve the libstdc++ smart pointer formatters
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25726?vs=75300&id=75431#toc
Repository:
rL LLVM
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284829: Add data formatter for libstdc++ tuple (authored by
tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25733?vs=75417&id=75433#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: tberghammer
Date: Fri Oct 21 10:05:03 2016
New Revision: 284831
URL: http://llvm.org/viewvc/llvm-project?rev=284831&view=rev
Log:
Fix incorrect header order introduced in rL284830
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp
lldb/trunk/source/Plugins/L
tberghammer added a comment.
Sorry, I missed that part. I just submitted r284831 what should fix the header
order for both case.
Repository:
rL LLVM
https://reviews.llvm.org/D25733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
The patch generally looks good to me. I added a few high level thought about
register context but they are clearly out of scope for this change. Also next
time please upload your pat
tberghammer added a comment.
My understanding (can be wrong) is that there IS a difference between not
specifying a register in the unwind info versus specifying it as "is same" for
volatile (caller saved) registers. I think for volatile registers not
specifying them means that we can't access
The problem is that if we reuse the LLVM disassembler (I am not sure if we
do it in TestArm64InstEmulation or not but we definitely should) then we
need LLVM to be build with support for that specific architecture as
otherwise the assembly analysis based unwinding test won't work.
On Mon, Nov 7, 2
I think the UnwindAssemblyInstEmulation tracks every register without
knowing if it is volatile or not and then RegisterContextLLDB will consult
with the ABI (during RegisterRead) to decide which registers can it recover
(based on volatile/non-volatile). For x86 I think the long term solution
would
Author: tberghammer
Date: Wed Nov 9 05:52:12 2016
New Revision: 286360
URL: http://llvm.org/viewvc/llvm-project?rev=286360&view=rev
Log:
Fix expectation in TestStaticVariables.py after rL286302
The debug info emitted by clang for static variables improved by
rL286302 and it exposed an incorrect
Author: tberghammer
Date: Fri Nov 11 05:39:23 2016
New Revision: 286581
URL: http://llvm.org/viewvc/llvm-project?rev=286581&view=rev
Log:
Fix TestHelp on linux after version number syntax change
Modified:
lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py
Modified: lldb/trunk/package
Author: tberghammer
Date: Tue Jan 3 10:29:43 2017
New Revision: 290895
URL: http://llvm.org/viewvc/llvm-project?rev=290895&view=rev
Log:
Improve the performance of jModulesInfo in lldb-server
Previously it parsed /proc//maps for every module separately
resulting in a very slow response time. Thi
Author: tberghammer
Date: Sat Jan 7 10:39:02 2017
New Revision: 291349
URL: http://llvm.org/viewvc/llvm-project?rev=291349&view=rev
Log:
Remove an incorrect byte size calculation in DWARFASTParserClang
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: ll
Author: tberghammer
Date: Sat Jan 7 10:39:07 2017
New Revision: 291350
URL: http://llvm.org/viewvc/llvm-project?rev=291350&view=rev
Log:
Fix dereferencing of pointers to empty classes
Added:
lldb/trunk/packages/Python/lldbsuite/test/python_api/value/empty_class/
lldb/trunk/packages/Pyth
Author: tberghammer
Date: Tue Jan 10 05:13:59 2017
New Revision: 291559
URL: http://llvm.org/viewvc/llvm-project?rev=291559&view=rev
Log:
Improve Type::GetTypeScopeAndBasenameHelper and add unit tests
Previously it failed to handle nested types inside templated classes
making it impossible to loo
Sure, it isn't urgent at all. I created this as a resolution for the crash
reported by Ramana (
http://lists.llvm.org/pipermail/lldb-dev/2017-February/012001.html) but I
don't fully understand the use case he/she is working on when wanting to
open a ".o" file yet (but I still wanted to get rid of a
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Restrict the scope of a hack in DYLDRendezvous
The hack is there to work around an incorrect load address reported
by t
Author: tberghammer
Date: Wed Sep 30 08:42:06 2015
New Revision: 248901
URL: http://llvm.org/viewvc/llvm-project?rev=248901&view=rev
Log:
XFAIL 2 test in TestTargetCommands on android-aarch64
The 2 test just get enabled with the recemt test system refactor.
Modified:
lldb/trunk/test/function
tberghammer marked an inline comment as done.
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
labath wrote:
> Is there a reason DataExtractor::GetULEB128 could
Author: tberghammer
Date: Wed Sep 30 08:50:14 2015
New Revision: 248903
URL: http://llvm.org/viewvc/llvm-project?rev=248903&view=rev
Log:
Add support for .ARM.exidx unwind information
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an excepti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248903: Add support for .ARM.exidx unwind information
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13245?vs=35970&id=36101#toc
Repository:
rL LLVM
http://reviews.llvm
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Make the ArmUnwindInfo parsing code endian independent
http://reviews.llvm.org/D13291
Files:
include/lldb/Symbol/ArmUnwindInfo.h
Author: tberghammer
Date: Wed Sep 30 09:55:08 2015
New Revision: 248908
URL: http://llvm.org/viewvc/llvm-project?rev=248908&view=rev
Log:
Fix xcode build after rL248903
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.o
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL248910: Make the ArmUnwindInfo parsing code endian
independent (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13291?vs=36103&i
Author: tberghammer
Date: Wed Sep 30 10:17:06 2015
New Revision: 248910
URL: http://llvm.org/viewvc/llvm-project?rev=248910&view=rev
Log:
Make the ArmUnwindInfo parsing code endian independent
Differential revision: http://reviews.llvm.org/D13291
Modified:
lldb/trunk/include/lldb/Symbol/ArmU
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:683
@@ +682,3 @@
+
+if (m_use_alt_disaasm == true)
+decode_status = m_alt_dis
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile
http://reviews.llvm.org/D13293
Files:
source/Plugins/Platfor
I haven't managed to reproduce the issue you reported (what OS and Android
version do you use?), but based on the description this change (not
committed in yet) might fix the issue: http://reviews.llvm.org/D13293. Can
you take a look?
Thanks,
Tamas
On Wed, Sep 30, 2015 at 12:49 AM Oleksiy Vyalov
tberghammer created this revision.
tberghammer added reviewers: clayborg, tfiala, zturner, emaste, labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Run tests with dwo symbol file
dwo symbol files are generated when code compiled with
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: tberghammer
Date: Thu Oct 1 04:42:23 2015
New Revision: 248998
URL: http://llvm.org/viewvc/llvm-project?rev=248998&view=rev
Log:
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile
Differential revision: http://reviews.llvm.org/D13293
Modified:
lldb/trunk/source/Plugins/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248998: Trim the output of mktem in
PlatformAndroid::DownloadSymbolFile (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13293?vs=36111&id=36209#toc
Repository:
rL LLVM
h
Author: tberghammer
Date: Thu Oct 1 08:57:54 2015
New Revision: 249012
URL: http://llvm.org/viewvc/llvm-project?rev=249012&view=rev
Log:
Restrict the scope of a hack in DYLDRendezvous
The hack is there to work around an incorrect load address reported
by the android linker on API 21 and 22 devic
Author: tberghammer
Date: Thu Oct 1 08:58:01 2015
New Revision: 249014
URL: http://llvm.org/viewvc/llvm-project?rev=249014&view=rev
Log:
Fix Android-SDK detection on API 10 device
Run the getprop command with AdbClient::Shell instead of
Platform::RunShellCommand because getting the output from g
Author: tberghammer
Date: Thu Oct 1 08:57:57 2015
New Revision: 249013
URL: http://llvm.org/viewvc/llvm-project?rev=249013&view=rev
Log:
Fix breakpoint opcode calculation on Linux
Change the way we detect if we have to place a thumb breakpoint instead
of an arm breakpoint in the case when no sym
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249012: Restrict the scope of a hack in DYLDRendezvous
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13288?vs=36097&id=36240#toc
Repository:
rL LLVM
http://reviews.llv
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instru
Author: tberghammer
Date: Fri Oct 2 06:58:26 2015
New Revision: 249119
URL: http://llvm.org/viewvc/llvm-project?rev=249119&view=rev
Log:
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instruction emulation based unwin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249119: Fix several issues around .ARM.exidx section
handling (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13380?vs=36338&id=36343#toc
Repository:
rL LLVM
http://revi
Author: tberghammer
Date: Fri Oct 2 07:00:04 2015
New Revision: 249120
URL: http://llvm.org/viewvc/llvm-project?rev=249120&view=rev
Log:
Change expected stop reason in TestInferiorAssert for Android API <= 16
Modified:
lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py
Mo
tberghammer accepted this revision.
tberghammer added a comment.
I agree with Pavel, that you don't have to send these trivial changes for core
review
http://reviews.llvm.org/D13462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
Author: tberghammer
Date: Tue Oct 6 09:39:05 2015
New Revision: 249407
URL: http://llvm.org/viewvc/llvm-project?rev=249407&view=rev
Log:
Rename a test case to avoid name conflict
Rename the python source file for DataFormatterOSTypeTestCase to match
the purpose of the test and to avoid a name co
Author: tberghammer
Date: Wed Oct 7 05:02:17 2015
New Revision: 249530
URL: http://llvm.org/viewvc/llvm-project?rev=249530&view=rev
Log:
Run tests with dwo symbol files
dwo symbol files are generated when code compiled with the "-gsplit-dwarf"
command option (https://gcc.gnu.org/wiki/DebugFissio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249530: Run tests with dwo symbol files (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13300?vs=36114&id=36723#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13300
F
tberghammer added a comment.
I committed in this CL in its current state (with fixing the issues raised by
Pavel).
If you see any of the newly added dwo test failing on your platform then please
skip/xfail them accordingly or let me know so I can take a look.
If you have to disable the running
Author: tberghammer
Date: Wed Oct 7 06:40:10 2015
New Revision: 249539
URL: http://llvm.org/viewvc/llvm-project?rev=249539&view=rev
Log:
XFAIL new dwo test failing with totclang on linux i386
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.p
Author: tberghammer
Date: Wed Oct 7 07:38:29 2015
New Revision: 249541
URL: http://llvm.org/viewvc/llvm-project?rev=249541&view=rev
Log:
Remove working directory from remote platform in the test suite
Previously we haven't cleaned up the working directory we created on
the remote platform and be
Author: tberghammer
Date: Wed Oct 7 09:52:16 2015
New Revision: 249549
URL: http://llvm.org/viewvc/llvm-project?rev=249549&view=rev
Log:
Fix race condition in the working directory cleanup code
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org
Author: tberghammer
Date: Fri Oct 9 06:01:56 2015
New Revision: 249821
URL: http://llvm.org/viewvc/llvm-project?rev=249821&view=rev
Log:
Fix regression caused by r249769
* Change TestSettings to test qith go instead of pascal as ToT pascal
support isn't complete
* Fix crash inside PluginManage
Author: tberghammer
Date: Fri Oct 9 07:06:07 2015
New Revision: 249825
URL: http://llvm.org/viewvc/llvm-project?rev=249825&view=rev
Log:
Fix the way dwo tests are skipped on darwin
We want to skip these tests when the target platform is darwin, not
when the host because they have to be enabled i
Author: tberghammer
Date: Fri Oct 9 07:06:10 2015
New Revision: 249826
URL: http://llvm.org/viewvc/llvm-project?rev=249826&view=rev
Log:
Fix the windows build after r249747
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
ht
tberghammer added a comment.
In general I like the approach you are taking and creating
IsAlwaysThumbInstructions sounds like a good idea, but I would implement it a
bit differently.
llvm::Triple already contains a SubArch field what is filled in from the first
part of the triple in case of ar
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: tberghammer
Date: Fri Oct 9 07:43:08 2015
New Revision: 249827
URL: http://llvm.org/viewvc/llvm-project?rev=249827&view=rev
Log:
Fix a crash, an UB and add some assert to dwo symbol file handling
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/tr
Author: tberghammer
Date: Mon Oct 12 05:33:04 2015
New Revision: 250024
URL: http://llvm.org/viewvc/llvm-project?rev=250024&view=rev
Log:
Improve TestValueOfVectorVariable
* XFAIL it for android arm/aarch64 as watchpoints aren't supported there
* Remove the dwarf/dsym test separation as they will
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Change ConstString to support massive multi-threaded access
Previously ConstString had a single mutex guarding the global string
pool for each access what become a bottl
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Make dwarf parsing multi-threaded
Loading the debug info from a large application is the slowest task
LLDB do. This CL makes most of the dwarf parsing code multi-threade
tberghammer added a comment.
It is depending on the implementation of std::async what AFAIK isn't defined by
the standard, but I would expect that a decent stl implementation will create a
reasonable number of threads (in some sense).
While developing/testing the code (with ~3000 CU in a Symbol
tberghammer added inline comments.
Comment at: source/Core/ConstString.cpp:147-152
@@ -165,7 +146,8 @@
protected:
-//--
-// Typedefs
-//--
-
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Look good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
tberghammer updated this revision to Diff 37258.
tberghammer added a comment.
Use llvm::sys::RWMutex
Using it have a minor performance hit for debug info parsing because of the
intensive write operations, but should have a positive impact on all reads
(most access after debug info parsing). If
Author: tberghammer
Date: Tue Oct 13 11:48:04 2015
New Revision: 250180
URL: http://llvm.org/viewvc/llvm-project?rev=250180&view=rev
Log:
Fix cast in arm watchpoint handling code
We had an incorrect sign extension when castion from a pointer to an
lldb::addr_t what broke the watchpoint hit detect
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:859-870
@@ -853,1 +858,14 @@
+
+// If this and other are both arm ArchSpecs and this ArchSpec is a generic
"some kind of arm"
+// spec but the other ArchSpec is a specific arm core, adopt the specific
1 - 100 of 725 matches
Mail list logo
