[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. When you send a review for the fix, please add me to it. Could you also take care of the extra space in the output? Thanks! Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. Please fix the space. The test will process it fine, but that doesn't mean we shouldn't fix it. I'll email you with the setup we use for tests. Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commit

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

This revision was automatically updated to reflect the committed changes. Closed by commit rL337397: Fix variables.test after D49018 (authored by stella.stamenova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49475?vs=156049&id=1560

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. Can you test this change and send it for review? Thanks! Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

stella.stamenova added a comment. There are a number of minidump tests that started failing for us on both Linux and Windows and I suspect it's due to this change. Did the unit tests pass for you with the changes on either Linux or Windows? Failing Tests (6): lldb-Unit :: Process/minidump/.

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s One thing to consider here is that any extra parameters passed w

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s apolyakov wrote: > stella.stamenova wrote: > > One thing to cons

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t <

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s labath wrote: > aprantl wrote: > > stella.stamenova wrote: > > >

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

stella.stamenova added a comment. I am not 100% sure yet, but this change is the most likely culprit for one of the SymbolFile tests to start failing, namely: SymbolFile/DWARF/dwarf5-index-is-used.cpp. This fails for us on both Windows and Linux with the following: FAIL: lldb :: SymbolFile/D

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

stella.stamenova added a comment. In https://reviews.llvm.org/D49980#1208096, @aleksandr.urakov wrote: > It's also possible that the test has been failing since some commit in > another repository (e.g. `clang`, `lld` or `llvm`). It seems that it was ok > several days ago... I think you are r

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, clayborg. Herald added a subscriber: lldb-commits. These are already skipped on Darwin because they cause build bot failures. Both on the build bots as well as in our testing we have seen a number of these tests fa

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova updated this revision to Diff 162444. Repository: rLLDB LLDB https://reviews.llvm.org/D51227 Files: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py pac

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova marked an inline comment as done. stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

stella.stamenova added a comment. In https://reviews.llvm.org/D51227#1212838, @aprantl wrote: > Looks like we *really* need to figure out what the underlying bug is here, > because there's not many platforms left after this patch. > This patch is fine as a stopgap, but we can't have a feature l

[Lldb-commits] [PATCH] D51227: [vscode] Skip some of the vscode tests on Linux and fix one

stella.stamenova updated this revision to Diff 162467. stella.stamenova retitled this revision from "[vscode] Skip the vscode tests on Linux" to "[vscode] Skip some of the vscode tests on Linux and fix one". stella.stamenova edited the summary of this revision. stella.stamenova added a comment. I

[Lldb-commits] [PATCH] D51227: [vscode] Skip some of the vscode tests on Linux and fix one

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL340658: [vscode] Skip some of the vscode tests on Linux and fix one (authored by stella.stamenova, committed by ). Herald

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

stella.stamenova added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194 +# of the test build dir is the LLVM build dir. +llvm_build_dir = os.path.dirname(os.path.abspath(test_build_dir)) +assert os.path.lexists(llvm_build_d

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

stella.stamenova added a comment. This change causes one of the LLDB tests to fail on Windows. More specifically: FAIL: lldb :: Settings/TestDisableColor.test (42646 of 43956) TEST 'lldb :: Settings/TestDisableColor.test' FAILED ***

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

stella.stamenova added a comment. In https://reviews.llvm.org/D51615#1226386, @davide wrote: > You can probably revert it. BTW, is the bot public? I would like to > understand whether I broke something after I commit. > > - Davide It's not public (yet) because there's one more failure in the L

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

stella.stamenova added a comment. In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote: > Bot sure how to fix tests since this is somehow hard to problematic. I think the fix for this is simply to not make the call to SetUseColor here. Is there a reason for the call? It looks like the c

[Lldb-commits] [PATCH] D51615: Set Windows console mode to enable support for ansi escape codes

stella.stamenova added a comment. In https://reviews.llvm.org/D51615#1226494, @xbolva00 wrote: > In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote: > > > > > Bot sure how to fix tests since this is somehow hard t

[Lldb-commits] [PATCH] D51772: Check if a terminal supports colors on Windows properly

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

stella.stamenova added a comment. This change is causing three of the symbol file PDB tests to fail: lldb-Unit :: SymbolFile/PDB/release/SymbolFilePDBTests.exe/SymbolFilePDBTests.TestClassInNamespace lldb-Unit :: SymbolFile/PDB/release/SymbolFilePDBTests.exe/SymbolFilePDBTests.TestNestedCla

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

stella.stamenova accepted this revision. stella.stamenova added a comment. LGTM, but I'd wait till @teemperor approves as well. https://reviews.llvm.org/D50751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

stella.stamenova added a comment. This broke the windows build: ##[error]llvm\tools\lldb\source\plugins\process\windows\common\processwindows.cpp(840,0): Error C2664: 'void lldb_private::Target::SetExecutableModule(lldb::ModuleSP &,lldb_private::LoadDependentFiles)': cannot convert argument

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

stella.stamenova added inline comments. Comment at: lldb/trunk/source/Target/Target.cpp:1449 ObjectFile *executable_objfile = executable_sp->GetObjectFile(); +bool load_dependens; +switch (load_dependent_files) { I think it's a good idea to either in

[Lldb-commits] [PATCH] D42994: Only throw -fPIC when building a shared library

stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:49 os.mkdir(newdir) -except OSError, e: +except OSError as e: if e.errno != os.errno.EEXIST: -

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

stella.stamenova added inline comments. Comment at: lit/CMakeLists.txt:10-13 +string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER ${LLDB_TEST_C_COMPILER}) +string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER ${LLDB_TEST_CXX_COMPIL

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

stella.stamenova added inline comments. Comment at: lit/CMakeLists.txt:10-13 +string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER ${LLDB_TEST_C_COMPILER}) +string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER ${LLDB_TEST_CXX_COMPIL

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

stella.stamenova added a comment. Since Visual Studio as a Generator supports multiple build configurations, each of the CMakeLists.txt that correspond to lit tests also need to include handling of the build mode unless you can guarantee that all the properties are set correctly before test/CMa

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

stella.stamenova added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

stella.stamenova added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. I am going to run the tests after you make the last few changes. I want to make sure the compiler path is no longer being overwritten by the test cmake before I run them. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEN

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. The tests passed, but check-single was not created correctly. I added a comment above. Comment at: test/CMakeLists.txt:101 ${LLDB_SOURCE_DIR}/test/dotest.py "--no-multiprocess;${LLDB_DOTEST_ARGS}" "Testing LLDB with args: ${LLDB_DOTES

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. In its current version, the patch won't *break* the windows build (the previous change broke the build as well as tests), so if it will unblock the bots, Jonas could check it in and then fix check-single in a follow up patch. I think it needs to be explicit if

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. If by as-is you mean with a big comment in the config file before the creation of check-single that it is broken, then yes, let's get the bots unblocked and then fix the issue. https://reviews.llvm.org/D46334 ___

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I still need to verify this works with VS on Windows, but feel free to check in to unblock the bots https://reviews.llvm.org/D46334

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lit/CMakeLists.txt:14 -if (NOT LLDB_TEST_USE_CUSTOM_C_COMPILER) - string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

stella.stamenova added inline comments. Comment at: CMakeLists.txt:61 + # Use LLDB_TEST_COMPILER_IS_DEFAULT to determine whether or not to replace + # CMAKE_CFG_INTDIR with LLVM_BUILD_MODE for dotest. + if(LLDB_TEST_COMPILER) If it's true that we don't need th

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: CMakeLists.txt:49 set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SU

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

stella.stamenova added a comment. The Windows Buildbot is failing because of one of the tests (SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s) added in this change. You can see the failure here: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/666. It looks like it i

[Lldb-commits] [PATCH] D56798: Change TypeSystem::GetBitSize() to return an optional result.

stella.stamenova added a comment. TestFunctionRefs is failing on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/677 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56798/new/ https://reviews.llvm.org/D56798 _

[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

stella.stamenova added a comment. I don't have a strong preference between using a separate module for interopability between python versions and implementing the functions as part of dotest if there are few of them, but I have to agree with @zturner that if we have more than a couple of functi

[Lldb-commits] [PATCH] D57273: Make Type::GetByteSize optional

stella.stamenova added a comment. I am not sure if you saw this, but it looks like it broke one of the tests on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1092 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57273/new/ https:/

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

stella.stamenova added a comment. This change broke one of the tests on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1099 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 _

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

stella.stamenova added a comment. This is failing on the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1379 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/support/seven.py:28 + +def bytes_to_string(b): +"""Take a string(PY2) or a bytes(PY3) object and r

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

stella.stamenova added a comment. This looks to have broken the windows build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1665 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58090/new/ https://reviews.llvm.org/D58090

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. In D58177#1397873 , @labath wrote: > Thanks for the review Stella. I was hoping someone would step in and tell me > that there is a

[Lldb-commits] [PATCH] D58050: PECOFF: Implement GetBaseAddress

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Now might not be the best time to commit it though because the LLDB build is broken on Windows. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D58303: [win] Resolve the module only if there isn't one already

stella.stamenova created this revision. stella.stamenova added reviewers: labath, asmith. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This commit modifies the OnLoadModule method to resolve the module unless we already have one Change by Hui Huang to fix the faili

[Lldb-commits] [PATCH] D58303: [win] Resolve the module only if there isn't one already

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354172: [win] Resolve the module only if there isn't one already (authored by stella.stamenova, committed by ). Reposi

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

stella.stamenova added a comment. This broke the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1894 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 _

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

stella.stamenova added a comment. This is causing a failure on the Windows Bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2299/steps/test/logs/stdio It was broken because of another change which is why you probably didn't get a notification. Please, fix this quickly or rev

[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

stella.stamenova added a comment. This introduced a build break on Windows (which happened to coincide with another build break). http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2317 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58748/new/ htt

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

stella.stamenova added a comment. This caused a failure on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2356 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58962/new/ https://reviews.llvm.org/D58962 ___

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

stella.stamenova added a comment. This broke the Windows bot because now one of the TestPaths tests passes on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394 There's also this comment in the test file: 1. TODO: Merge into test_path when GetClangResourceDir is impl

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

stella.stamenova added a comment. This is causing failures on the windows bot. Please fix it or revert it. http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/3066 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59847/new/ https://reviews.llvm.org/D5984

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

stella.stamenova added a comment. In D59847#1446671 , @shafik wrote: > @stella.stamenova I committed a fix, please let me know if this does not > address the regression: > > http://llvm.org/viewvc/llvm-project?view=revision&revision=357210 @shafik Thank

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59968/new/ https://reviews.llvm.org/D59968

[Lldb-commits] [PATCH] D60458: [zorg] Add lldb-x86_64-debian builder

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60458/new/ https://reviews.llvm.org/D60458 ___ lldb-commits maili

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

stella.stamenova added a comment. I ran local tests with this and a couple of the tests from the lldb suite failed: lldb-Suite :: functionalities/inferior-crashing/TestInferiorCrashing.py lldb-Suite :: functionalities/thread/crash_during_step/TestCrashDuringStep.py Here's the error from one

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

stella.stamenova added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s Is this not testing f

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pdb lldb tests do not work correctly with both the VS2019 and VS2017 toolsets at the moment. This change updates several of the te

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/SymbolFile/PDB/enums-layout.test:13 -ENUM: Type{{.*}} , name = "Enum", size = 4, decl = simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum { +ENUM: Type

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4abf28c0a0b: [lldb] Update the PDB tests to pass with the VS2019 toolset (authored by stella.stamenova). Repository: r

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

stella.stamenova added a comment. The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to se

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116972/new/ https://reviews.llvm.org/D116972 ___ lldb-commits maili

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:73 +#if defined(_WIN32) +// Don't mess with the signal handlers on Windows. Were these not used on Windows at all before? CHANGES SIN

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/new/ https://reviews.llvm.org/D104886 ___ lldb-commits mail

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 __

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova added a comment. Since @omjavaid is working on a related change in https://reviews.llvm.org/D117363, perhaps he can make the necessary changes there to support `-j` for the tests? Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11697

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, clayborg, labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current default is to not use lldb-server on Windows, however, ll

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This does not build correctly with gcc 7.3.1 on CentOS: /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/resource/1/b/llvm

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova added a comment. So, sadly, I am going to have to backtrack here. When I set `LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me. Running the test

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117637/new/ https://reviews.llvm.org/D117637 ___

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova abandoned this revision. stella.stamenova added a comment. I spent a bit of time trying to investigate the failures, but I couldn't make much progress and I don't have time to dedicate to a more thorough investigation. It looks like there are a few tests that outright fail (inc

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, dblaikie. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The existing instructions for lldb on Windows can be more explicit. This adds

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

stella.stamenova updated this revision to Diff 404065. stella.stamenova added a comment. Add more details for developer command prompt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 Files: lldb/docs/resources/build.rst Index: lldb/docs/re

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also nee

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG738d73fbf4ed: [lldb] Update the lldb build instructions on Windows (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot in the best way possible - by making some tests pass now that didn't use to. Could you un-xfail those too? https://lab.llvm.org/buildbot/#/builders/83/builds/14736 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. They should correspond to these files: lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py => test/API/functionalities/inferior-crashing/TestInferiorCrashing.py lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py => t

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM, I think there might be a couple more places to remove the xfail, but otherwise ship it! Comment at: lldb/test/API/functionalities/inferior-crashin

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added inline comments. Comment at: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46 @skipIfTargetAndroid() # debuggerd interferes with this test on Android @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr247

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. Thanks! It looks like there's a failure that was previously hidden by the unexpected passes: https://lab.llvm.org/buildbot/#/builders/83/builds/14781 It seems like it's been in all of the previous builds as well, but it was not reported separately for some re

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

stella.stamenova added a comment. It looks like the new test is failing on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/15049 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 __

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Prepare decouple instance and plugin names

stella.stamenova added a comment. It looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/15999 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/D119146 _

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20566 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

stella.stamenova added a comment. Looks like this broke the Windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/21186 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 __

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/22557/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131983/new/ https://reviews.llvm.org/D131983

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/18228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. These changes (the set of [trace][intelpt] changes) broke the windows lldb bot. It's most likely this particular change, but it could be one of the others. Unfortunately, the bot had just been broken by https://reviews.llvm.org/D127882, so it didn't show the fa

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3586910 , @wallace wrote: > yes, i'm trying to fix it now. Thanks! Thanks! One more to add to the list: FAILED: tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThre

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3587778 , @wallace wrote: > @stella.stamenova, I've just tried that compile command with several versions > of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't > install 7.3.1. Could

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

stella.stamenova added a comment. This broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

stella.stamenova added a comment. Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

stella.stamenova added a comment. Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of `TestCommandScript.py`, so you might have missed this. Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3   4   >