stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed.
================ Comment at: packages/Python/lldbsuite/support/seven.py:28 + +def bytes_to_string(b): + """Take a string(PY2) or a bytes(PY3) object and return a string.""" ---------------- There are other places in the lldb test suite and lit where similar functions are defined. Rather than just adding new ones here, can you normalize them and perhaps use your functions everywhere instead of ending up with two (or three) solutions? One place that comes to mind is lit\helper\build.py: to_string. There are others as well that implement conversions in-place and usually use isinstance to determine what to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58177/new/ https://reviews.llvm.org/D58177 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
