[Lldb-commits] [PATCH] D25391: Remove usages of TimeValue from gdb-remote process plugin

labath updated this revision to Diff 76442. labath added a comment. Clean up the code a bit now that I have learned better how to use the chrono library. https://reviews.llvm.org/D25391 Files: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp source/Plugins/Process/gdb-remote/

[Lldb-commits] [lldb] r285602 - Remove usages of TimeValue from gdb-remote process plugin

Author: labath Date: Mon Oct 31 12:19:42 2016 New Revision: 285602 URL: http://llvm.org/viewvc/llvm-project?rev=285602&view=rev Log: Remove usages of TimeValue from gdb-remote process plugin Summary: Most of the changes are very straight-forward, the only tricky part was the "packet speed-test" f

[Lldb-commits] [PATCH] D25391: Remove usages of TimeValue from gdb-remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL285602: Remove usages of TimeValue from gdb-remote process plugin (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25391?vs=76442&id=76443#toc Repository: rL LLVM https://rev

[Lldb-commits] [PATCH] D26171: [LLDB] Fix RHEL 6 build and some Include What You Use warnings

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. thanks Repository: rL LLVM https://reviews.llvm.org/D26171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [lldb] r285587 - Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull

Thanks for the heads-up, Chris. Dimitar, we have had a similar problem for elf core file tests, where lldb would get confused if we get a running process with the same pid as the core file. I fixed this in , and I suspect you will need a similar fix for your Proces

[Lldb-commits] [PATCH] D26170: Find clang resource directory via *nix-style lookup

labath added a comment. looks good in general, but please check whether this is correct with LLVM_LIBDIR_SUFFIX=64. Comment at: source/Host/posix/HostInfoPosix.cpp:176 + file_spec, + llvm::Twine("/lib/clang/", llvm::StringRef(CLANG_VERSION_STRING)).str()); +} ---

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

labath created this revision. labath added reviewers: beanz, zturner, tfiala, clayborg, abidh. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, ki.stfu. This solves the ODR violations by exporting all symbols in the llvm namespace to all users of liblldb, which can then a

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath created this revision. labath added reviewers: beanz, zturner, tfiala, clayborg, abidh. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, ki.stfu. This "solves" the ODR violations by making the linker firewall a feature. llvm libraries used by liblldb are considered

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

labath added a comment. In https://reviews.llvm.org/D26188#584614, @tfiala wrote: > I'll let Greg comment on the public ABI expansion (i.e. including llvm of a > specific version, which may differ from LLDB.framework clients that contain > different versions of LLVM). My guess is this is not g

Re: [Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

See . Basically the problem is that we are pulling in llvm symbols twice into lldb-mi (once in liblldb, and once in lldb-mi proper). This was causing runtime errors if we did not have the "linker firewall" in place. I am proposing to either make sure things build w

[Lldb-commits] [PATCH] D26193: Minidump plugin: Fix flaky test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D26193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

labath added a comment. I thought removing it will cause it to export everything. If it doesn't, then we can put whatever magic is necessary there. :) Although, if exporting everything does require some fancy linker flags, then I probably wouldn't make it the default. https://reviews.llvm.org

[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

labath added inline comments. Comment at: include/lldb/Host/FileSystem.h:69-71 + static std::chrono::time_point + GetModificationTime(const FileSpec &file_spec); labath wrote: > zturner wrote: > > I wonder if it would be worth defining some typedefs in LLVM's `

[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

labath updated this revision to Diff 76573. labath marked 2 inline comments as done. labath added a comment. - cleanup constructors - use llvm's stat() implementation https://reviews.llvm.org/D25392 Files: include/lldb/Core/Module.h include/lldb/Core/ModuleSpec.h include/lldb/Core/SourceM

[Lldb-commits] [lldb] r285702 - Remove TimeValue usage from FileSpec.h

Author: labath Date: Tue Nov 1 11:11:14 2016 New Revision: 285702 URL: http://llvm.org/viewvc/llvm-project?rev=285702&view=rev Log: Remove TimeValue usage from FileSpec.h Summary: The only usage there was in GetModificationTime(). I also took the opportunity to move this function from FileSpec t

[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL285702: Remove TimeValue usage from FileSpec.h (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25392?vs=76573&id=76576#toc Repository: rL LLVM https://reviews.llvm.org/D2539

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

labath added a comment. In https://reviews.llvm.org/D26188#584710, @zturner wrote: > On Windows if you have a DLL (.so) that links against a .lib (.a), and an EXE > links against both the DLL and the .lib, then both the DLL and the EXE will > each get their own private copy of the symbols in th

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

labath added a comment. Ok, I guess we're leaning towards option two then, which is more-or-less status quo as well. I am going to leave this open for a while in case anyone has more input. Todd, for you this means that you cannot export *all* symbols from liblldb, as that would break the link

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath added a comment. In https://reviews.llvm.org/D26190#584882, @mehdi_amini wrote: > > and has potential to introduce latent bugs. > > Can you elaborate on this? If some of the duplicated objects get passed across the api boundary, things will start to break, although the breakage may not

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath added a comment. In https://reviews.llvm.org/D26190#584933, @mehdi_amini wrote: > OK! > > How is it different from the other proposal? In the other proposal, using a > LLVM class in the API boundary would break the same way under the same > conditions, or did I miss something? In the o

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath added a comment. In https://reviews.llvm.org/D26190#585016, @mehdi_amini wrote: > > Does that make sense? > > This makes sense (assuming static linking reduces some possibility though) I am not sure we are on the same page here. What is the scenario you have in mind here? I am not forbi

[Lldb-commits] [PATCH] D26209: Fix windows build after r285702, missing include to define PATH_MAX

labath closed this revision. labath added a comment. I believe Zachary already fixed this. https://reviews.llvm.org/D26209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath added a comment. In https://reviews.llvm.org/D26190#585106, @mehdi_amini wrote: > >> , but LLVM is not robust to mix and match build settings: building half of > >> the source with -DNDEBUG and not the other is likely to cause weird > >> runtime failures. That can be an issue because now

[Lldb-commits] [lldb] r285795 - Remove TimeValue usages from MacOSX-Kernel process plugin. NFC

Author: labath Date: Wed Nov 2 05:13:54 2016 New Revision: 285795 URL: http://llvm.org/viewvc/llvm-project?rev=285795&view=rev Log: Remove TimeValue usages from MacOSX-Kernel process plugin. NFC Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/trunk/sou

[Lldb-commits] [lldb] r285797 - Remove TimeValue from UnwindLLDB.cpp

Author: labath Date: Wed Nov 2 05:27:54 2016 New Revision: 285797 URL: http://llvm.org/viewvc/llvm-project?rev=285797&view=rev Log: Remove TimeValue from UnwindLLDB.cpp Really NFC, as the code is #ifdefed out, but I did make sure it compiles if I enable it. Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r285798 - Fix printf errors in ProcessMinidump

Author: labath Date: Wed Nov 2 05:29:47 2016 New Revision: 285798 URL: http://llvm.org/viewvc/llvm-project?rev=285798&view=rev Log: Fix printf errors in ProcessMinidump Modified: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp Modified: lldb/trunk/source/Plugins/Process/minid

[Lldb-commits] [PATCH] D26237: Remove KQueue.cpp

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: modocache, mgorny. This class is unused (and apple specific, so it does not really belong into generic code). Can we remove it? https://reviews.llvm.org/D26237 Fil

[Lldb-commits] [lldb] r285801 - Remove TimeValue usage from two files

Author: labath Date: Wed Nov 2 07:18:42 2016 New Revision: 285801 URL: http://llvm.org/viewvc/llvm-project?rev=285801&view=rev Log: Remove TimeValue usage from two files Modified: lldb/trunk/source/Core/Communication.cpp lldb/trunk/source/Core/Log.cpp Modified: lldb/trunk/source/Core/Co

[Lldb-commits] [PATCH] D26243: Refactor Timer class

labath created this revision. labath added reviewers: tberghammer, clayborg. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. While removing TimeValue from this class I noticed a lot of room for small simplifications here. Main are: - instead of complicated start-stop d

[Lldb-commits] [PATCH] D26243: Refactor Timer class

labath updated this revision to Diff 76701. labath added a comment. run clang-format https://reviews.llvm.org/D26243 Files: include/lldb/Core/Timer.h source/Core/Timer.cpp unittests/Core/CMakeLists.txt unittests/Core/TimerTest.cpp Index: unittests/Core/TimerTest.cpp ===

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

labath accepted this revision. labath added a comment. nice Repository: rL LLVM https://reviews.llvm.org/D26233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r285847 - Remove KQueue.cpp

Author: labath Date: Wed Nov 2 13:06:17 2016 New Revision: 285847 URL: http://llvm.org/viewvc/llvm-project?rev=285847&view=rev Log: Remove KQueue.cpp Summary: This class is unused. Reviewers: clayborg Subscribers: mgorny, modocache, lldb-commits Differential Revision: https://reviews.llvm.org

[Lldb-commits] [PATCH] D26237: Remove KQueue.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL285847: Remove KQueue.cpp (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26237?vs=76689&id=76745#toc Repository: rL LLVM https://reviews.llvm.org/D26237 Files: lldb/trunk

[Lldb-commits] [lldb] r285890 - Refactor Timer class

Author: labath Date: Thu Nov 3 04:14:09 2016 New Revision: 285890 URL: http://llvm.org/viewvc/llvm-project?rev=285890&view=rev Log: Refactor Timer class Summary: While removing TimeValue from this class I noticed a lot of room for small simplifications here. Main are: - instead of complicated

[Lldb-commits] [PATCH] D26243: Refactor Timer class

This revision was automatically updated to reflect the committed changes. Closed by commit rL285890: Refactor Timer class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26243?vs=76701&id=76822#toc Repository: rL LLVM https://reviews.llvm.org/D26243 Files: lldb/tr

[Lldb-commits] [lldb] r285891 - Remove TimeSpecTimeout class

Author: labath Date: Thu Nov 3 04:29:56 2016 New Revision: 285891 URL: http://llvm.org/viewvc/llvm-project?rev=285891&view=rev Log: Remove TimeSpecTimeout class the class is unused. Removed: lldb/trunk/source/Utility/TimeSpecTimeout.cpp lldb/trunk/source/Utility/TimeSpecTimeout.h Modifi

[Lldb-commits] [lldb] r285892 - Fix Timer unit test

Author: labath Date: Thu Nov 3 05:07:47 2016 New Revision: 285892 URL: http://llvm.org/viewvc/llvm-project?rev=285892&view=rev Log: Fix Timer unit test I did not take into account that the output of the Dump function will be non-deterministic. Fix that by increasing of the times, this also makes

[Lldb-commits] [PATCH] D26275: Remove TimeValue usage from Core/Module

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. The only interesting part here is that TimePoint and TimeValue have different natural string representations, which affects "target modules list" output. It is now "2016-07-09 04:02:21.000

[Lldb-commits] [lldb] r285894 - Link lldb-mi only to the llvm components it uses

Author: labath Date: Thu Nov 3 05:52:17 2016 New Revision: 285894 URL: http://llvm.org/viewvc/llvm-project?rev=285894&view=rev Log: Link lldb-mi only to the llvm components it uses Summary: liblldb does not re-export the llvm library contained within, so lldb-mi needs to manage its own dependen

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

This revision was automatically updated to reflect the committed changes. Closed by commit rL285894: Link lldb-mi only to the llvm components it uses (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26190?vs=76554&id=76833#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [lldb] r285992 - Fix GDBRemoteCommunicationClientTest.TestPacketSpeedJSON

Author: labath Date: Fri Nov 4 06:49:06 2016 New Revision: 285992 URL: http://llvm.org/viewvc/llvm-project?rev=285992&view=rev Log: Fix GDBRemoteCommunicationClientTest.TestPacketSpeedJSON The mock server was listening for only one packet (I forgot to put a loop around it), which caused the clie

Re: [Lldb-commits] GDBRemoteCommunicationClientTest.TestPacketSpeedJSON unit test hanging for anyone else?

a debug build (GDBRemoteCommunication.cpp:136). Things may behave differently for a release build, where the timeout is 1, but I don't think that will make the test pass. I will > > I'll try to build this up & test it on my more common external-mac setup at > home, bu

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. I was very successful in creating tiny core files by avoiding linking with the standard library (you don't really need a full libc to crash :P ). I think this file should use the same approach as well (see the other core files in this directory, and the make-core.sh scrip

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nice. https://reviews.llvm.org/D26315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. In https://reviews.llvm.org/D26300#587333, @emaste wrote: > Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD > support to make-core.sh -- just avoiding /bin/bash, and the core file handler > check. Great. I am glad the `_start` thingy works the

[Lldb-commits] [lldb] r286101 - Make space for FreeBSD core file tests

Author: labath Date: Mon Nov 7 03:58:58 2016 New Revision: 286101 URL: http://llvm.org/viewvc/llvm-project?rev=286101&view=rev Log: Make space for FreeBSD core file tests This renames the functionalities/postmortem/linux-core to elf-core and puts the "linux" part into the individual names of the

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. I've renamed to folder into elf-core and put "linux" into the individual file names. I did not rename `TestLinuxCore.py` as I am still not sure what to do about it -- if we end up having a lot of these tests, we may want a separate `TestFreeBSDCore.py`, with the common c

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

labath created this revision. labath added reviewers: amccarth, zturner. labath added subscribers: lldb-commits, dvlahovski. This commit disables the windows-only minidump plugin and enables the new cross-platform plugin for windows minidump files. Test decorators are adjusted to reflect that: wi

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

labath created this revision. labath added reviewers: tberghammer, granata.enrico. labath added a subscriber: lldb-commits. r284830 added a summary provider for unique_ptr in libstdc++, whose value printed the value of the pointee. This is a bit unintuitive as it becomes unobvious that the value

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

labath added a comment. In https://reviews.llvm.org/D26393#589363, @amccarth wrote: > I started testing the new plugin on Windows yesterday, and it doesn't work > (all the tests fail). I'm planning to debug today, and, once I get it > working, I'd be happy to switch it over. Interesting. It

[Lldb-commits] [PATCH] D26275: Remove TimeValue usage from Core/Module

labath updated this revision to Diff 77209. labath added a comment. It turns out this was the only usage of TimeValue::Dump. I've changed that into a standalone function so it can be called without a TimeValue. Once Zachary lands the formatting change in llvm I'd like add a more generic time form

[Lldb-commits] [lldb] r286349 - Remove TimeValue usage from Core/Module

Author: labath Date: Wed Nov 9 03:59:18 2016 New Revision: 286349 URL: http://llvm.org/viewvc/llvm-project?rev=286349&view=rev Log: Remove TimeValue usage from Core/Module Summary: The only interesting part here is that TimePoint and TimeValue have different natural string representations, which

[Lldb-commits] [PATCH] D26275: Remove TimeValue usage from Core/Module

This revision was automatically updated to reflect the committed changes. Closed by commit rL286349: Remove TimeValue usage from Core/Module (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26275?vs=77209&id=77323#toc Repository: rL LLVM https://reviews.llvm.org/D262

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

labath added a comment. Yeah, feel free to take over. I was not planning to do any more work here - just wanted to wrap things up. I am going to commit this then, and leave the rest to you. https://reviews.llvm.org/D26393 ___ lldb-commits mailing

[Lldb-commits] [lldb] r286352 - Disable windows-only minidump plugin

Author: labath Date: Wed Nov 9 04:16:11 2016 New Revision: 286352 URL: http://llvm.org/viewvc/llvm-project?rev=286352&view=rev Log: Disable windows-only minidump plugin Summary: This commit disables the windows-only minidump plugin and enables the new cross-platform plugin for windows minidump f

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL286352: Disable windows-only minidump plugin (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26393?vs=77175&id=77325#toc Repository: rL LLVM https://reviews.llvm.org/D26393

[Lldb-commits] [lldb] r286355 - Display the pointer value in the libstdc++ unique_ptr summary

Author: labath Date: Wed Nov 9 04:42:29 2016 New Revision: 286355 URL: http://llvm.org/viewvc/llvm-project?rev=286355&view=rev Log: Display the pointer value in the libstdc++ unique_ptr summary Summary: r284830 added a summary provider for unique_ptr in libstdc++, whose value printed the value

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

This revision was automatically updated to reflect the committed changes. Closed by commit rL286355: Display the pointer value in the libstdc++ unique_ptr summary (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26403?vs=77202&id=77329#toc Repository: rL LLVM https:/

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

labath added inline comments. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:129 if (m_ptr_obj->GetValueAsUnsigned(0) == 0) { stream.Printf("nullptr"); granata.enrico wrote: > This is very nitpick-y but why not > > lldb::addr_

[Lldb-commits] [lldb] r286366 - Remove TimeValue usage from lldb/Core. NFC.

Author: labath Date: Wed Nov 9 08:04:08 2016 New Revision: 286366 URL: http://llvm.org/viewvc/llvm-project?rev=286366&view=rev Log: Remove TimeValue usage from lldb/Core. NFC. Modified: lldb/trunk/include/lldb/Core/ModuleSpec.h lldb/trunk/include/lldb/Core/SourceManager.h lldb/trunk/

[Lldb-commits] [lldb] r286369 - Remove TimeValue usage from lldb/Interpreter

Author: labath Date: Wed Nov 9 08:33:22 2016 New Revision: 286369 URL: http://llvm.org/viewvc/llvm-project?rev=286369&view=rev Log: Remove TimeValue usage from lldb/Interpreter Modified: lldb/trunk/include/lldb/Interpreter/OptionValueFileSpec.h lldb/trunk/source/Commands/CommandObjectTar

[Lldb-commits] [lldb] r286372 - Remove unused TimeValue include

Author: labath Date: Wed Nov 9 08:53:37 2016 New Revision: 286372 URL: http://llvm.org/viewvc/llvm-project?rev=286372&view=rev Log: Remove unused TimeValue include Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h Modified: lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r286371 - Remove TimeValue usage from lldb/Host

Author: labath Date: Wed Nov 9 08:53:32 2016 New Revision: 286371 URL: http://llvm.org/viewvc/llvm-project?rev=286371&view=rev Log: Remove TimeValue usage from lldb/Host Modified: lldb/trunk/source/Host/common/Socket.cpp lldb/trunk/source/Host/windows/ConnectionGenericFileWindows.cpp Mo

[Lldb-commits] [lldb] r286374 - Remove TimeValue usage from lldb/Target

Author: labath Date: Wed Nov 9 09:05:48 2016 New Revision: 286374 URL: http://llvm.org/viewvc/llvm-project?rev=286374&view=rev Log: Remove TimeValue usage from lldb/Target It was only used for declaring unused variables. :) Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trun

[Lldb-commits] [lldb] r286373 - Remove TimeValue usage from ObjectContainerBSDArchive

Author: labath Date: Wed Nov 9 09:05:45 2016 New Revision: 286373 URL: http://llvm.org/viewvc/llvm-project?rev=286373&view=rev Log: Remove TimeValue usage from ObjectContainerBSDArchive Modified: lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp lldb/t

[Lldb-commits] [PATCH] D26451: Remove TimeValue class

labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. All usages have been replaced by appropriate std::chrono funcionality, and the class is now unused. The only used part of the cpp file is the DumpTim

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

labath added a comment. Woohoo. https://reviews.llvm.org/D26478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26505: Remove a hack from the Android toolchain file

labath created this revision. labath added reviewers: tberghammer, beanz. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. The fix is to make sure llvm does not pull in dlopen() in configurations where it is not available. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. Looks great. Ed, do you want to give this a try run? Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:113 +self.assertTrue(target, VALID_TARGET) +process = target.LoadCore("fpr_sse_x86_64.

[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

labath added a comment. Several people have expressed objections to this patch, so I guess the answer is no. :) However, I have made some changes to lldb's build system (https://reviews.llvm.org/D25680) which should fix the original issue you were experiencing (Sorry, I forgot to loop you in o

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

labath added a comment. Ed, what do you think about this one? Is there anyone with a FreeBSD arm64 setup that could verify this? https://reviews.llvm.org/D25947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. Thank you for looking into this. This has been a long standing issue that we haven't got time to address. Could you also add some tests to cover the new functionality? It sounds like it would be easy to generate tiny core files which trigger this. You can look at tests

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:224 + // If all else fails force the first thread to be SIGSTOP + m_thread_data.begin()->signo = SIGSTOP; +} You should not use signal numbers from the host

[Lldb-commits] [PATCH] D26697: Remove Windows-specific minidump plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. https://reviews.llvm.org/D26697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

labath added a comment. Yes, I'd like to do similar refactorings to other contexts as well. I'll wait until next week so Ed can give this a shot -- I am busy with other stuff these days anyway. Ed, if I may suggest, while you are playing with the arm machine, could you grab us a core file or t

[Lldb-commits] [lldb] r287095 - Fix printf warning I introduced in ModuleSpec.h

Author: labath Date: Wed Nov 16 04:54:17 2016 New Revision: 287095 URL: http://llvm.org/viewvc/llvm-project?rev=287095&view=rev Log: Fix printf warning I introduced in ModuleSpec.h Modified: lldb/trunk/include/lldb/Core/ModuleSpec.h Modified: lldb/trunk/include/lldb/Core/ModuleSpec.h URL: h

[Lldb-commits] [lldb] r287096 - Remove TimeValue class

Author: labath Date: Wed Nov 16 04:54:22 2016 New Revision: 287096 URL: http://llvm.org/viewvc/llvm-project?rev=287096&view=rev Log: Remove TimeValue class Summary: All usages have been replaced by appropriate std::chrono funcionality, and the class is now unused. The only used part of the cpp fi

[Lldb-commits] [PATCH] D26451: Remove TimeValue class

This revision was automatically updated to reflect the committed changes. Closed by commit rL287096: Remove TimeValue class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26451?vs=77346&id=78159#toc Repository: rL LLVM https://reviews.llvm.org/D26451 Files: lldb/

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. I can't say we're being very consistent in enforcing it, but general llvm policy is for tests to go together with the changes. I am curious, how do you go about creating these core files? The core files I created were very tiny as I did not require any syscalls, so I co

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. In https://reviews.llvm.org/D26676#598559, @hhellyer wrote: > I haven't solved that yet! ;-) > > I'm currently ending up with cores of ~500kb which is probably too big. I'm > seeing what I can do to bring them down but it might be that I can't shrink > them that much. I

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. We probably don't want to check in zillions of core files, but I believe having a couple of them is fine, particularly when care is taken to minimize their size. I believe the benefits (being able to run tests on a piece of code in a reproducible and platform-independent

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

labath added a comment. I don't know how deep do you want this refactor to be, but there is one issue I would like us to consider, if only to decide it is out of scope of this change. I am talking about the `quote_char` thingy. The main problem for me is that I don't think it's possible to sane

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

labath added a comment. > Assuming we do that, what interface do you think would be simpler? We still > need easy access to both a StringRef and a c_str(), since StringRef::data > is not guaranteed to be null terminated, so the entry thing is still nice. I was assuming (possibly incorrectly, I

Re: [Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

On 18 November 2016 at 19:54, Jim Ingham wrote: > If we are going to do that, I wonder if we should start having tests share > their inputs. We don’t do that for source files because the cost of > duplication is so small, and then you don’t have the hassle of adding > something to a source fie

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

labath added a comment. In https://reviews.llvm.org/D26883#601638, @jingham wrote: > The outermost quote character is syntactically significant in the lldb > command language. If you say: > > memory read -c `count_var` 0x123345 > > then lldb evaluates the expression in the backticks, replacing

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath created this revision. labath added reviewers: clayborg, zturner, jingham. labath added a subscriber: lldb-commits. This replaces the usage of raw integers with duration classes in the gdb-remote packet management functions. The values are still converted back to integers once they go into

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

labath created this revision. labath added reviewers: zturner, beanz, tfiala. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. This basically just inlines the LLDBDependencies.cmake file into lldb-server CMakeLists.txt. The reason is that most of these

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath added a comment. I suppose we could create a new class (I am not sure what a good name for that would be... `OptionalDuration`, which inherits from `llvm:Optional`, but provides the additional conversion operator to make things work seamlessly. Something like: template class Optiona

[Lldb-commits] [PATCH] D23290: Added enforce-interactivity setting

labath abandoned this revision. labath added a comment. This has been abandoned some time ago. https://reviews.llvm.org/D23290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56 -response, - std::chrono::duration_cast(kInterruptTimeout) -.count(), zturner wrote: > I think we should all be willing to agree tha

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath added a comment. In https://reviews.llvm.org/D26971#602738, @clayborg wrote: > It would be nice if we can find a way to be able to use any time units we > want when specifying the timeout. I would rather not have everyone have to > convert their times to microseconds. Maybe we just add s

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath updated this revision to Diff 78895. labath added a comment. A new version, which uses a helper class which enables all the implicit conversions that one would normally expect from the duration classes. Things left TBD: - name - where to put it - whether inheriting from Optional is fine (

[Lldb-commits] [PATCH] D26971: Introduce chrono to more gdb-remote functions

labath updated this revision to Diff 79050. labath added a comment. Changes since last version: - Rename the class to Timeout<>, to reflect the fact that I'd like to use it as a general method for describing timeouts. - add "using namespace std::chrono" to files with significat chrono usage. I

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. I just tried it, and these tests run fine without the executable file. Just remove those, and I think we're ready. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/TestGCore.py:38 +def do_test(self, filename, pid

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

labath added a comment. Ed, have you had a chance to try this out? I'd like to put this in soon. https://reviews.llvm.org/D25947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27010: Refactor LLDB's Windows process plugin (NFC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. seems reasonable. https://reviews.llvm.org/D27010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D27085: [LLDB][MIPS] Fix TestMultipleHits for MIPS

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you. https://reviews.llvm.org/D27085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Looks fine in principle, but please encapsulate this better. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:569 sel

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. It fails on the linux buildbot, but not when I run it locally. I am going to investigate the issue. https://reviews.llvm.org/D26676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

labath added a comment. Oh, you fixed it. Thank you. :) https://reviews.llvm.org/D26676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    5   6   7   8   9   10   11   12   13   14   >