[Lldb-commits] [PATCH] D26170: Find clang resource directory via *nix-style lookup

[Pavel Labath via lldb-commits]

labath added a comment.

looks good in general, but please check whether this is correct with 
LLVM_LIBDIR_SUFFIX=64.



================
Comment at: source/Host/posix/HostInfoPosix.cpp:176
+      file_spec,
+      llvm::Twine("/lib/clang/", llvm::StringRef(CLANG_VERSION_STRING)).str());
+}
----------------
I think you need to include the `LLVM_LIBDIR_SUFFIX` here. At least that's what 
the usage of this directory in source/API/CMakeLists.txt leads me to believe.


https://reviews.llvm.org/D26170



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits