Re: [Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

On 23 February 2018 at 15:42, Jim Ingham wrote: > BTW, one thing I like about writing dotest.py tests is that it is easy to > craft fairly rich failure messages so if you get errors on systems you don't > have access to or are dealing with something that fails intermittently on a > bot somewher

Re: [Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

On 27 February 2018 at 07:11, Greg Clayton via Phabricator wrote: > clayborg added a comment. > > In https://reviews.llvm.org/D32167#1020032, @labath wrote: > >> In https://reviews.llvm.org/D32167#1019702, @clayborg wrote: >> >> > I am afraid of the opposite: we test what we think we need to test

[Lldb-commits] [lldb] r326218 - Move TestGdbRemoteExitCode next to the other llgs tests

Author: labath Date: Tue Feb 27 10:07:53 2018 New Revision: 326218 URL: http://llvm.org/viewvc/llvm-project?rev=326218&view=rev Log: Move TestGdbRemoteExitCode next to the other llgs tests This test contained a copy of the inferior used by most of llgs test. This was done to enable better paralel

[Lldb-commits] [lldb] r326224 - [LLDB] Initial version of PPC64 InstEmulation

Author: labath Date: Tue Feb 27 10:42:46 2018 New Revision: 326224 URL: http://llvm.org/viewvc/llvm-project?rev=326224&view=rev Log: [LLDB] Initial version of PPC64 InstEmulation Summary: Supports common prologue/epilogue instructions. Reviewers: clayborg, labath Reviewed By: clayborg, labath

[Lldb-commits] [lldb] r326261 - [lldb] Use vFlash commands when writing to target's flash memory regions

Author: labath Date: Tue Feb 27 14:14:33 2018 New Revision: 326261 URL: http://llvm.org/viewvc/llvm-project?rev=326261&view=rev Log: [lldb] Use vFlash commands when writing to target's flash memory regions Summary: When writing an object file over gdb-remote, use the vFlashErase, vFlashWrite, an

[Lldb-commits] [lldb] r326264 - Fix lldbinline tests for remote targets

Author: labath Date: Tue Feb 27 14:45:49 2018 New Revision: 326264 URL: http://llvm.org/viewvc/llvm-project?rev=326264&view=rev Log: Fix lldbinline tests for remote targets r326140 exposed the fact that we are not actually running inline tests on remote targets. The tests fail to launch the infer

[Lldb-commits] [lldb] r326367 - Revert "[lldb] Use vFlash commands when writing to target's flash memory regions"

Author: labath Date: Wed Feb 28 12:42:29 2018 New Revision: 326367 URL: http://llvm.org/viewvc/llvm-project?rev=326367&view=rev Log: Revert "[lldb] Use vFlash commands when writing to target's flash memory regions" This reverts commit r326261 as it introduces inconsistencies in the handling of l

[Lldb-commits] [lldb] r326369 - Adapt some tests to work with PPC64le architecture

Author: labath Date: Wed Feb 28 12:57:26 2018 New Revision: 326369 URL: http://llvm.org/viewvc/llvm-project?rev=326369&view=rev Log: Adapt some tests to work with PPC64le architecture Summary: Merge branch 'master' into adaptPPC64tests Reviewers: clayborg, alexandreyy, labath Reviewed By: clayb

[Lldb-commits] [lldb] r326449 - Make TestDynamicValueSameBase gcc-compatible

Author: labath Date: Thu Mar 1 08:56:28 2018 New Revision: 326449 URL: http://llvm.org/viewvc/llvm-project?rev=326449&view=rev Log: Make TestDynamicValueSameBase gcc-compatible gcc will say that the type of "this" is "T * const", clang "T *". Compare the unqualified type names to erase the diffe

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

On 1 March 2018 at 10:34, Adrian Prantl wrote: > >> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: >> >> I have no general objections to macros, and reducing boiler-plate is good. >> They do get in the way of debugging because of the weird C rule that a macro >> has to pretend that it is all o

[Lldb-commits] [lldb] r326514 - Speed up TestWatchpointMultipleThreads

Author: labath Date: Thu Mar 1 16:17:05 2018 New Revision: 326514 URL: http://llvm.org/viewvc/llvm-project?rev=326514&view=rev Log: Speed up TestWatchpointMultipleThreads Summary: The inferior was sleeping before doing any interesting work. I remove that to make the test faster. While looking a

Re: [Lldb-commits] [lldb] r326634 - Don't compile testcase with clang modules enabled.

That didn't seem to do the trick: TBH, I'd be surprised if you can pull off compiling a fully working objc executable on linux. On 2 March 2018 at 15:15, Adrian Prantl via lldb-commits wrote: > Author: adrian > Date:

[Lldb-commits] [lldb] r326667 - ObjectFileMachO: use early return to remove one nesting level from CreateSections()

Author: labath Date: Sat Mar 3 14:07:47 2018 New Revision: 326667 URL: http://llvm.org/viewvc/llvm-project?rev=326667&view=rev Log: ObjectFileMachO: use early return to remove one nesting level from CreateSections() NFCI Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO

[Lldb-commits] [lldb] r326671 - llgs-tests: use the auto-parsing form of SendMessage for sending the continue packets

Author: labath Date: Sat Mar 3 18:12:18 2018 New Revision: 326671 URL: http://llvm.org/viewvc/llvm-project?rev=326671&view=rev Log: llgs-tests: use the auto-parsing form of SendMessage for sending the continue packets Modified: lldb/trunk/unittests/tools/lldb-server/tests/MessageObjects.h

Re: [Lldb-commits] [lldb] r326739 - [test] Skip pexpect-based lldb-mi tests on Darwin

For the record, our bots don't run any of the lldb-mi tests. I don't know if it is an issue with pexpect, the way we are using, or genuine issues, but I found pretty much all of lldb-mi tests flaky, and it's code too hairy to understand what is going on. On Mon, 5 Mar 2018 at 20:19, Vedant Kumar

[Lldb-commits] [lldb] r326775 - [LLDB][PPC64] Fixed issues with expedited registers

Author: labath Date: Tue Mar 6 03:54:41 2018 New Revision: 326775 URL: http://llvm.org/viewvc/llvm-project?rev=326775&view=rev Log: [LLDB][PPC64] Fixed issues with expedited registers Summary: - reg_nums were missing the end marker entry - marked FP test to be skipped for ppc64 Reviewers: labat

[Lldb-commits] [lldb] r326777 - HostThreadPosix::Cancel: remove android-specific implementation

Author: labath Date: Tue Mar 6 04:46:05 2018 New Revision: 326777 URL: http://llvm.org/viewvc/llvm-project?rev=326777&view=rev Log: HostThreadPosix::Cancel: remove android-specific implementation Noone is calling this function on android, so we can just use the generic llvm_unreachable "implemen

[Lldb-commits] [lldb] r326791 - ObjectFileMachO: split CreateSections mega-function into more manageable chunks

Author: labath Date: Tue Mar 6 05:53:26 2018 New Revision: 326791 URL: http://llvm.org/viewvc/llvm-project?rev=326791&view=rev Log: ObjectFileMachO: split CreateSections mega-function into more manageable chunks Summary: In an effort to understand the function's operation, I've split it into log

[Lldb-commits] [lldb] r326805 - Rewrite TestTargetSymbolsBuildidCase to be more focused

Author: labath Date: Tue Mar 6 07:56:20 2018 New Revision: 326805 URL: http://llvm.org/viewvc/llvm-project?rev=326805&view=rev Log: Rewrite TestTargetSymbolsBuildidCase to be more focused Summary: The test was failing in remote debugging scenario with windows as a host as cmd.exe is not able to

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for foobár - > between the two implementations. So if you build with an older clang, and > test with a new lldb, the type lookup fa

[Lldb-commits] [lldb] r327013 - [LLDB][PPC64] Fix single step and LldbGdbServer tests

Author: labath Date: Thu Mar 8 07:41:13 2018 New Revision: 327013 URL: http://llvm.org/viewvc/llvm-project?rev=327013&view=rev Log: [LLDB][PPC64] Fix single step and LldbGdbServer tests Summary: On PPC64, the tested functions were being entered through their local entry point, while the tests e

[Lldb-commits] [lldb] r327016 - Install lldb's SB headers (pr36630)

Author: labath Date: Thu Mar 8 07:52:46 2018 New Revision: 327016 URL: http://llvm.org/viewvc/llvm-project?rev=327016&view=rev Log: Install lldb's SB headers (pr36630) These were removed in r309021 in what looks like an accidentally committed change. This brings them back. I also rename the hea

[Lldb-commits] [lldb] r327017 - Fix std unique pointer pretty-printer for new stl versions

Author: labath Date: Thu Mar 8 08:03:09 2018 New Revision: 327017 URL: http://llvm.org/viewvc/llvm-project?rev=327017&view=rev Log: Fix std unique pointer pretty-printer for new stl versions Summary: The unique pointer layout was changed in libstdc++ 6.0.23. Reviewers: labath, clayborg Reviewe

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > > > > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano > wrote: > > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > > The hashing algorithm gives different values - at least f

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

It seems my compiler is magic as well. Running the test against /usr/bin/clang also succeeds (all variants)... On Fri, 9 Mar 2018 at 10:19, Pavel Labath wrote: > > > > On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > >> >> >> > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >> > >> > >> > >>

[Lldb-commits] [lldb] r327110 - Move option parsing out of the Args class

Author: labath Date: Fri Mar 9 02:39:40 2018 New Revision: 327110 URL: http://llvm.org/viewvc/llvm-project?rev=327110&view=rev Log: Move option parsing out of the Args class Summary: The args class is used in plenty of places (a lot of them in the lower lldb layers) for representing a list of ar

[Lldb-commits] [lldb] r327123 - [elf] Remove one copy of the section merging code

Author: labath Date: Fri Mar 9 04:30:09 2018 New Revision: 327123 URL: http://llvm.org/viewvc/llvm-project?rev=327123&view=rev Log: [elf] Remove one copy of the section merging code Summary: Besides being superfluous, this double merging was actually wrong and causing some sections to be added t

[Lldb-commits] [lldb] r327133 - Make TestCompletion work on windows

Author: labath Date: Fri Mar 9 06:32:16 2018 New Revision: 327133 URL: http://llvm.org/viewvc/llvm-project?rev=327133&view=rev Log: Make TestCompletion work on windows The test I added in r327110 is failing on windows because of "import pexpect". However, this import is no longer necessary as th

[Lldb-commits] [lldb] r327379 - Fix linux s390x build (pr36694)

Author: labath Date: Tue Mar 13 02:46:00 2018 New Revision: 327379 URL: http://llvm.org/viewvc/llvm-project?rev=327379&view=rev Log: Fix linux s390x build (pr36694) Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp Modified: lldb/trunk/source/Plugins/Pro

[Lldb-commits] [lldb] r327380 - Fix clang-3.8 build

Author: labath Date: Tue Mar 13 02:46:10 2018 New Revision: 327380 URL: http://llvm.org/viewvc/llvm-project?rev=327380&view=rev Log: Fix clang-3.8 build clang-3.8 complains that constructor for '...' must explicitly initialize the const member. Newer clangs and gcc seem to be fine with this, but

[Lldb-commits] [lldb] r327413 - include locale.h in IOHandler.cpp

Author: labath Date: Tue Mar 13 08:55:00 2018 New Revision: 327413 URL: http://llvm.org/viewvc/llvm-project?rev=327413&view=rev Log: include locale.h in IOHandler.cpp This is needed for the setlocale() call, and it seems that it is not transitively pulled in for some build configurations. Modifi

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

I'm not familiar with all of the magic we do when we synthesize clang Decls, but I feel I should point out that we can't get out of business of sanity-checking the declarations we inject into clang. The reason for that is, even if we had debug info for operator==, the debug info itself could descri

[Lldb-commits] [lldb] r327483 - Skip TestWatchedVarHitWhenInScope.py everywhere

Author: labath Date: Wed Mar 14 02:13:33 2018 New Revision: 327483 URL: http://llvm.org/viewvc/llvm-project?rev=327483&view=rev Log: Skip TestWatchedVarHitWhenInScope.py everywhere The expression-hits tracking logic is not available on any platform. The reason this tests happens to pass on some p

[Lldb-commits] [lldb] r327490 - [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

Author: labath Date: Wed Mar 14 03:08:21 2018 New Revision: 327490 URL: http://llvm.org/viewvc/llvm-project?rev=327490&view=rev Log: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687) Summary: To make this build work, I needed to add detection code for the pthread library. This is neces

Re: [Lldb-commits] [lldb] r327512 - [test] Disable TestMachCore everywhere except on Darwin

Take a look at #ifdef __APPLE__ around ObjectFileMachO in SystemInitializerCommon.cpp. I tried removing that, but that led to a bunch of undefined symbol errors (because of other stuff that was ifdefed out). It could be this is just a matter of removing enough ifdefs, but I haven't tried following

[Lldb-commits] [lldb] r327611 - @skipUnlessDarwin TestTargetSourceMap

Author: labath Date: Thu Mar 15 02:16:15 2018 New Revision: 327611 URL: http://llvm.org/viewvc/llvm-project?rev=327611&view=rev Log: @skipUnlessDarwin TestTargetSourceMap Our MachO parser works only on darwin. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/source-map/Te

[Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

Author: labath Date: Thu Mar 15 06:47:09 2018 New Revision: 327625 URL: http://llvm.org/viewvc/llvm-project?rev=327625&view=rev Log: Next batch of test-tree-cleaning changes Summary: The changes here fall into several categories. - some tests were redirecting inferior stdout/err to a file. For t

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

ke a look? > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/ > > > Thanks! > > -- > Davide > > On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > > Date: Thu Mar 15 06:47:09 2018 > > New Revisi

[Lldb-commits] [lldb] r327633 - Fix TestProcessLaunch breakage on MacOS

Author: labath Date: Thu Mar 15 08:21:54 2018 New Revision: 327633 URL: http://llvm.org/viewvc/llvm-project?rev=327633&view=rev Log: Fix TestProcessLaunch breakage on MacOS This test started failing after r327625. The cause seems difference in the treatment of relative --stdin paths between MacOS

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

st likely cause for the failures we're starting to see > >> on both our bots on greendragon. > >> Can you please take a look? > >> > >> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/ > >> > >> > >> Thanks! > >&g

[Lldb-commits] [lldb] r327643 - [dotest] remove confirm_directory_exclusivity remnants

Author: labath Date: Thu Mar 15 09:52:37 2018 New Revision: 327643 URL: http://llvm.org/viewvc/llvm-project?rev=327643&view=rev Log: [dotest] remove confirm_directory_exclusivity remnants Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lld

[Lldb-commits] [lldb] r327703 - [dotest] Clean up test folder clean-up

Author: labath Date: Fri Mar 16 05:04:46 2018 New Revision: 327703 URL: http://llvm.org/viewvc/llvm-project?rev=327703&view=rev Log: [dotest] Clean up test folder clean-up Summary: This patch implements a unified way of cleaning the build folder of each test. This is done by completely removing t

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a clear consensus on what to do with them. The last discussion abou

[Lldb-commits] [lldb] r327970 - Re-land: [lldb] Use vFlash commands when writing to target's flash memory regions

Author: labath Date: Tue Mar 20 04:56:24 2018 New Revision: 327970 URL: http://llvm.org/viewvc/llvm-project?rev=327970&view=rev Log: Re-land: [lldb] Use vFlash commands when writing to target's flash memory regions The difference between this and the previous patch is that now we use ELF physica

[Lldb-commits] [lldb] r327977 - Fix some tests for PPC64le architecture

Author: labath Date: Tue Mar 20 05:46:33 2018 New Revision: 327977 URL: http://llvm.org/viewvc/llvm-project?rev=327977&view=rev Log: Fix some tests for PPC64le architecture Summary: - Fix test jump for powerpc64le Jumping directly to the return line on power architecture dos not means returni

[Lldb-commits] [lldb] r327981 - [LLDB] Fix TestTargetXMLArch's expected arch

Author: labath Date: Tue Mar 20 06:46:05 2018 New Revision: 327981 URL: http://llvm.org/viewvc/llvm-project?rev=327981&view=rev Log: [LLDB] Fix TestTargetXMLArch's expected arch Summary: When running on an architecture other than x86_64, the target.ConnectRemote() part of the test may add platfor

[Lldb-commits] [lldb] r327996 - Move StringExtractorGDBRemote.h to the include folder

Author: labath Date: Tue Mar 20 09:14:00 2018 New Revision: 327996 URL: http://llvm.org/viewvc/llvm-project?rev=327996&view=rev Log: Move StringExtractorGDBRemote.h to the include folder While trying to use this header I noticed that it is not in the include folder. Move it to there and update al

[Lldb-commits] [lldb] r328083 - Fix TestOperatorOverload for 32-bit builds

Author: labath Date: Wed Mar 21 02:43:50 2018 New Revision: 328083 URL: http://llvm.org/viewvc/llvm-project?rev=328083&view=rev Log: Fix TestOperatorOverload for 32-bit builds - use more goodies from Makefile.rules to correctly build a 32-bit binary. - avoid hardcoding typeof(nil) in the test. T

Re: [Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

Instead of trying to guess how the shell will interpret your command line, it would be better to just use a primitive which bypasses the shell altogether. For example you can use subprocess.call(), and just forward it the list of arguments verbatim. You'd need to do some special processing on the

[Lldb-commits] [lldb] r328088 - Fix crash exposed by r328025

Author: labath Date: Wed Mar 21 04:10:57 2018 New Revision: 328088 URL: http://llvm.org/viewvc/llvm-project?rev=328088&view=rev Log: Fix crash exposed by r328025 The issue was that the ASTDumper was being passed a null pointer (because we did not create any declaration for the operator==). The c

Re: [Lldb-commits] [lldb] r328025 - [ExpressionParser] Re-implement r327356 in a less disruptive way.

It wasn't actually a linux issue, but a logging issue. The reason you couldn't reproduce this locally is because we don't have logging on by default (but our bot does, to help figuring out what's wrong when things break). I haven't tried, but I'm pretty sure the test would break on mac as well if y

Re: [Lldb-commits] [lldb] r328025 - [ExpressionParser] Re-implement r327356 in a less disruptive way.

BTW, during the "great lldb reformat" it was decided that our python files should follow the official python formatting rules (4 space indent) and not the llvm style guide (2 space). On Wed, 21 Mar 2018 at 11:35, Pavel Labath wrote: > It wasn't actually a linux issue, but a logging issue. The r

[Lldb-commits] [lldb] r328106 - Last batch of test-tree cleaning changes

Author: labath Date: Wed Mar 21 08:29:32 2018 New Revision: 328106 URL: http://llvm.org/viewvc/llvm-project?rev=328106&view=rev Log: Last batch of test-tree cleaning changes - postmortem tests: make sure the core files are created in the build folder - TestSourceManager: copy the .c file into t

Re: [Lldb-commits] [lldb] r328083 - Fix TestOperatorOverload for 32-bit builds

2:43 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > > Date: Wed Mar 21 02:43:50 2018 > > New Revision: 328083 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=328083&view=rev > > Log: > > Fix TestOperatorOverload for 32-bit

Re: [Lldb-commits] [lldb] r328365 - Log ObjC Runtime messages only in verbose mode

On Fri, 23 Mar 2018 at 20:20, Adrian Prantl via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Mar 23 13:17:39 2018 > New Revision: 328365 > > URL: http://llvm.org/viewvc/llvm-project?rev=328365&view=rev > Log: > Log ObjC Runtime messages only in verbose mode > > M

[Lldb-commits] [lldb] r328485 - Add a test for setting the load address of a module with differing physical/virtual addresses

Author: labath Date: Mon Mar 26 04:45:32 2018 New Revision: 328485 URL: http://llvm.org/viewvc/llvm-project?rev=328485&view=rev Log: Add a test for setting the load address of a module with differing physical/virtual addresses Summary: First attempt at landing D42145 was reverted because it caus

[Lldb-commits] [lldb] r328486 - [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport

Author: labath Date: Mon Mar 26 05:00:52 2018 New Revision: 328486 URL: http://llvm.org/viewvc/llvm-project?rev=328486&view=rev Log: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport Summary: PPC64's auxvec has a special key that must be ignored. Reviewers: clayborg, labath Reviewed By: clayborg, laba

[Lldb-commits] [lldb] r328488 - Add and fix some tests for PPC64

Author: labath Date: Mon Mar 26 05:42:07 2018 New Revision: 328488 URL: http://llvm.org/viewvc/llvm-project?rev=328488&view=rev Log: Add and fix some tests for PPC64 Summary: TestExprsChar.py Char is unsigned char by default in PowerPC. TestDisassembleBreakpoint.py Modify disassemble testcase to

[Lldb-commits] [lldb] r328489 - Make @skipUnlessSupportedTypeAttribute windows-compatible

Author: labath Date: Mon Mar 26 05:47:40 2018 New Revision: 328489 URL: http://llvm.org/viewvc/llvm-project?rev=328489&view=rev Log: Make @skipUnlessSupportedTypeAttribute windows-compatible - close_fds is not compatible with stdin/out redirection on windows. I just remove it, as this is not re

[Lldb-commits] [lldb] r328504 - Fix TestDisassembleBreakpoint broken by r328488

Author: labath Date: Mon Mar 26 08:17:58 2018 New Revision: 328504 URL: http://llvm.org/viewvc/llvm-project?rev=328504&view=rev Log: Fix TestDisassembleBreakpoint broken by r328488 The first issue was that the test was capturing the "before" disassembly before launching, and the "after" after. Th

Re: [Lldb-commits] [lldb] r328488 - Add and fix some tests for PPC64

Davide > > On Mon, Mar 26, 2018 at 5:42 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > > Date: Mon Mar 26 05:42:07 2018 > > New Revision: 328488 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=328488&view=rev > > Log: > > A

[Lldb-commits] [lldb] r328693 - gdb-remote: Fix checksum verification for messages with escape chars

Author: labath Date: Wed Mar 28 03:19:10 2018 New Revision: 328693 URL: http://llvm.org/viewvc/llvm-project?rev=328693&view=rev Log: gdb-remote: Fix checksum verification for messages with escape chars Summary: We've had a mismatch in the checksum computation between the sender and receiver. The

[Lldb-commits] [lldb] r328770 - NativeThreadProtocol: delete dead code

Author: labath Date: Thu Mar 29 03:09:11 2018 New Revision: 328770 URL: http://llvm.org/viewvc/llvm-project?rev=328770&view=rev Log: NativeThreadProtocol: delete dead code These functions were unused as everyone just went straight for the direct operations on the register context. In fact, the Sa

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

On Wed, 4 Apr 2018 at 16:47, Zachary Turner wrote: > > On Wed, Apr 4, 2018 at 8:11 AM Jonas Devlieghere via Phabricator < > revi...@reviews.llvm.org> wrote: > >> JDevlieghere added a comment. >> >> In https://reviews.llvm.org/D45215#1056917, @zturner wrote: >> >> > I haven’t had time to look at t

[Lldb-commits] [lldb] r329296 - Remove unused NativeProcessProtocol.h include from Platform.h

Author: labath Date: Thu Apr 5 08:17:51 2018 New Revision: 329296 URL: http://llvm.org/viewvc/llvm-project?rev=329296&view=rev Log: Remove unused NativeProcessProtocol.h include from Platform.h After removing it, I got a couple of compile errors because we were missing some symbols (SIGKILL and

[Lldb-commits] [lldb] r329295 - Fix error in QEnableErrorStrings gdb-remote docs

Author: labath Date: Thu Apr 5 08:17:43 2018 New Revision: 329295 URL: http://llvm.org/viewvc/llvm-project?rev=329295&view=rev Log: Fix error in QEnableErrorStrings gdb-remote docs this probably happened because we changed the name of the packet mid-review. Modified: lldb/trunk/docs/lldb-gd

[Lldb-commits] [lldb] r329309 - Fix windows build after r329296

Author: labath Date: Thu Apr 5 09:23:54 2018 New Revision: 329309 URL: http://llvm.org/viewvc/llvm-project?rev=329309&view=rev Log: Fix windows build after r329296 Add a couple of #include s. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

[Lldb-commits] [lldb] r329314 - One more windows build fix

Author: labath Date: Thu Apr 5 09:59:36 2018 New Revision: 329314 URL: http://llvm.org/viewvc/llvm-project?rev=329314&view=rev Log: One more windows build fix Modified: lldb/trunk/source/Target/Platform.cpp Modified: lldb/trunk/source/Target/Platform.cpp URL: http://llvm.org/viewvc/llvm-pr

Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

On Fri, 6 Apr 2018 at 23:36, Jason Molenda wrote: > > > > On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > labath added inline comments. > > > > > > > > Comment at: > packages/Python/lldbsuite/test/settings/TestSettings.py:544-

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

I generally try to stay away from debug info, but since I ended up working on the accelerator tables, and I am about to embark on the lldb part of that project I figure I should chime in. I am mostly speaking to the "using llvm libraries for parsing" part of the discussion, I don't have an opinions

[Lldb-commits] [lldb] r329677 - Move Args::StringTo*** functions to a new OptionArgParser class

Author: labath Date: Tue Apr 10 02:03:59 2018 New Revision: 329677 URL: http://llvm.org/viewvc/llvm-project?rev=329677&view=rev Log: Move Args::StringTo*** functions to a new OptionArgParser class Summary: The idea behind this is to move the functionality which depend on other lldb classes into a

[Lldb-commits] [lldb] r329679 - Move OptionElementVector helper structs from Args to Options

Author: labath Date: Tue Apr 10 02:48:05 2018 New Revision: 329679 URL: http://llvm.org/viewvc/llvm-project?rev=329679&view=rev Log: Move OptionElementVector helper structs from Args to Options These are not used anywhere in the Args class. They should have been moved as a part of r327110 (Moving

[Lldb-commits] [lldb] r329682 - Args: replace isprint8 usage with isprint

Author: labath Date: Tue Apr 10 03:07:22 2018 New Revision: 329682 URL: http://llvm.org/viewvc/llvm-project?rev=329682&view=rev Log: Args: replace isprint8 usage with isprint It looks like we introduced isprint8 way back in r169417 to be used on getopt's short_options, which we sometimes set to v

[Lldb-commits] [lldb] r329803 - llgs: Send "rich" errors in response to vAttach packets

Author: labath Date: Wed Apr 11 06:30:54 2018 New Revision: 329803 URL: http://llvm.org/viewvc/llvm-project?rev=329803&view=rev Log: llgs: Send "rich" errors in response to vAttach packets There are plenty of ways attaching can go wrong. Having the server report the exact error means we can give

[Lldb-commits] [lldb] r330200 - Move Args.cpp from Interpreter to Utility

Author: labath Date: Tue Apr 17 11:53:35 2018 New Revision: 330200 URL: http://llvm.org/viewvc/llvm-project?rev=330200&view=rev Log: Move Args.cpp from Interpreter to Utility Summary: The Args class is used in plenty of places besides the command interpreter (e.g., anything requiring an argc+argv

[Lldb-commits] [lldb] r330247 - Report more precise error message when attach fails

Author: labath Date: Wed Apr 18 04:56:21 2018 New Revision: 330247 URL: http://llvm.org/viewvc/llvm-project?rev=330247&view=rev Log: Report more precise error message when attach fails Summary: If the remote stub sends a specific error message instead of just a E?? code, we can use this to displa

[Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

Author: labath Date: Thu Apr 19 02:38:42 2018 New Revision: 330314 URL: http://llvm.org/viewvc/llvm-project?rev=330314&view=rev Log: Attempt to fix TestMiniDump on windows It was failing because the modules names were coming out as C:\Windows\System32/MSVCP120D.dll (last separator is a forward sl

Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

ing true. > > On Apr 19, 2018, at 2:38 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > > > Author: labath > > Date: Thu Apr 19 02:38:42 2018 > > New Revision: 330314 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=330

Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

On Thu, 19 Apr 2018 at 18:11, Leonard Mosescu wrote: > The mix of backward and forward slashes doesn't impact my current project but it would be nice to have a consistent path syntax (both within a single path and also cross platforms). >> Leonard, is it reasonable to assume that all paths in t

[Lldb-commits] [lldb] r330405 - Move FileSpecTest to Utility

Author: labath Date: Fri Apr 20 01:27:27 2018 New Revision: 330405 URL: http://llvm.org/viewvc/llvm-project?rev=330405&view=rev Log: Move FileSpecTest to Utility FileSpec class was moved to the Utility module a while ago, but the test file was left behind. This corrects that. Added: lldb/tru

[Lldb-commits] [lldb] r330578 - llgs-tests: Increase packet time out

Author: labath Date: Mon Apr 23 04:22:44 2018 New Revision: 330578 URL: http://llvm.org/viewvc/llvm-project?rev=330578&view=rev Log: llgs-tests: Increase packet time out The default packet timeout of 1 second is a bit too small for these tests, particularly as they are working in ack-mode, which

[Lldb-commits] [lldb] r330708 - [dotest] Make the set of tests independent of the test configuration

Author: labath Date: Tue Apr 24 03:51:44 2018 New Revision: 330708 URL: http://llvm.org/viewvc/llvm-project?rev=330708&view=rev Log: [dotest] Make the set of tests independent of the test configuration Summary: In the magic test duplicator, we were making the decision whether to create a test var

Re: [Lldb-commits] [lldb] r330708 - [dotest] Make the set of tests independent of the test configuration

On Wed, 25 Apr 2018 at 19:07, Vedant Kumar wrote: > Hi Pavel, > > On Apr 24, 2018, at 3:51 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > +def checkDebugInfoSupport(): > > +import lldb > > + > > +platform = lldb.DBG.

[Lldb-commits] [lldb] r331172 - Fixup r331049 (FileSpec auto-normalization)

Author: labath Date: Mon Apr 30 05:59:14 2018 New Revision: 331172 URL: http://llvm.org/viewvc/llvm-project?rev=331172&view=rev Log: Fixup r331049 (FileSpec auto-normalization) A typo in the patch (using syntax instead of m_syntax) resulted in the normalization not working properly for windows fi

[Lldb-commits] [lldb] r331173 - ObjectFileELF: Add support for arbitrarily named code sections

Author: labath Date: Mon Apr 30 06:23:47 2018 New Revision: 331173 URL: http://llvm.org/viewvc/llvm-project?rev=331173&view=rev Log: ObjectFileELF: Add support for arbitrarily named code sections ObjectFileELF assumes that code section has ".text" name. There is an exception for kalimba toolchain

[Lldb-commits] [lldb] r331180 - llgs tests: Use noack-mode for communication to avoid pr37294

Author: labath Date: Mon Apr 30 07:30:02 2018 New Revision: 331180 URL: http://llvm.org/viewvc/llvm-project?rev=331180&view=rev Log: llgs tests: Use noack-mode for communication to avoid pr37294 Modified: lldb/trunk/unittests/tools/lldb-server/tests/TestClient.cpp lldb/trunk/unittests/too

[Lldb-commits] [lldb] r331250 - Split TestGlobalVariables into two and xfail one of them for arm64 linux

Author: labath Date: Tue May 1 03:09:53 2018 New Revision: 331250 URL: http://llvm.org/viewvc/llvm-project?rev=331250&view=rev Log: Split TestGlobalVariables into two and xfail one of them for arm64 linux Displaying of global pointer variables is not working on arm64 linux (pr37301). I've moved

[Lldb-commits] [lldb] r331350 - Predicate.h: remove unused functions

Author: labath Date: Wed May 2 06:14:18 2018 New Revision: 331350 URL: http://llvm.org/viewvc/llvm-project?rev=331350&view=rev Log: Predicate.h: remove unused functions The functions are unused, their comments are out of date with the implementation, and the implementation is out of date with th

[Lldb-commits] [lldb] r331374 - Fix gdb-remote qMemoryRegionInfo unit tests for xml-enabled builds

Author: labath Date: Wed May 2 10:00:33 2018 New Revision: 331374 URL: http://llvm.org/viewvc/llvm-project?rev=331374&view=rev Log: Fix gdb-remote qMemoryRegionInfo unit tests for xml-enabled builds In case we are building with xml enabled, the GetMemoryRegionInfo function will send extra packet

Re: [Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

That's kind of true, but also not really.. :) If I were writing this test in dotest style (*), I would probably write these as multiple **assertions** within a single test. So it would be something like: def single_test(): module = prepare() assertEquals(module.operation1(), ["result1a", "re

[Lldb-commits] [lldb] r331447 - lldb-test symbols: Add ability to do name-based lookup

Author: labath Date: Thu May 3 03:57:16 2018 New Revision: 331447 URL: http://llvm.org/viewvc/llvm-project?rev=331447&view=rev Log: lldb-test symbols: Add ability to do name-based lookup Summary: lldb-test already had the ability to dump all symbol information in a module. This is interesting, b

[Lldb-commits] [lldb] r331458 - Remove the timed_out out-argument from Predicate::WaitForValueEqualTo

Author: labath Date: Thu May 3 08:33:41 2018 New Revision: 331458 URL: http://llvm.org/viewvc/llvm-project?rev=331458&view=rev Log: Remove the timed_out out-argument from Predicate::WaitForValueEqualTo The function can only return in one of two ways: the Predicate value is successfully set withi

Re: [Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

I remember hearing some people use the check-lldb-single target, but it had to do with running the tests against some remote devices/stubs that did not handle multiple connections very well. However, the way it seems to me, with the transition to lit, this target will have to go away sooner or lat

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

I am still building a picture for myself of how the accelerator tables and our name lookup works, but from what I managed to learn so far, adding an accelerator for "C" seems like a useful thing to do. However, this does go beyond what the DWARF 5 spec says we should do (we are only required to add

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

Well.. it encodes some assumptions about how a class name looks like, which are probably valid for C++, but they don't have to hold for any language frontend LLVM supports. That said, I am not saying this is worth the trouble of adding a special "these are the additional names you are to insert int

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

On Tue, 8 May 2018 at 17:12, via lldb-commits wrote: > So…. if the name in the type entry did not include the then the indexing would automatically do what you want; you would need to reconstruct the from the template parameter children of the DIE. Would that help? > On the LLVM side we have

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

I think we should fix lldb to reconstruct the full name based on the information from the dwarf. Right now, it seems both clang and gcc provide enough information to do this. If we start doing that, then it should also be fairly easy to implement some kind of fancy formatting (like we spoke about i

[Lldb-commits] [lldb] r331855 - [DWARF] Align non-accelerated function fullname searching with the apple-tables path

Author: labath Date: Wed May 9 01:21:25 2018 New Revision: 331855 URL: http://llvm.org/viewvc/llvm-project?rev=331855&view=rev Log: [DWARF] Align non-accelerated function fullname searching with the apple-tables path Summary: Before this patch the two paths were doing very different things - th

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

On Tue, 8 May 2018 at 18:27, via lldb-commits wrote: > Clang can control the emission of or not in the name, using the "debugger tuning" feature. It sounds like neither LLDB nor PS4 will mind losing the in the name, and it makes the indexing simpler. If the tuning is set for GDB then we can s

[Lldb-commits] [lldb] r331880 - Modernize and clean-up the Predicate class

Author: labath Date: Wed May 9 07:29:30 2018 New Revision: 331880 URL: http://llvm.org/viewvc/llvm-project?rev=331880&view=rev Log: Modernize and clean-up the Predicate class Summary: The comments on this class were out of date with the implementation, and the implementation itself was inconsist

<    1   2   3   4   5   6   7   8   9   10   >