Re: [Lldb-commits] [lldb] r245216 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

Hi all, This commit was reverted in r245222 as it was causing failures on the linux build-bot. It has a number of issues and I would prefer if it were not merged until these are resolved. And in any case, this doesn't seem like a "critical bug fix" suitable for m

Re: [Lldb-commits] [PATCH] D12083: [LLGS] Avoid misrepresenting log lines as inferior output

This revision was automatically updated to reflect the committed changes. Closed by commit rL245272: [LLGS] Avoid misrepresenting log lines as inferior output (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12083?vs=32298&id=32383#toc Repository: rL LLVM http://revie

[Lldb-commits] [lldb] r245272 - [LLGS] Avoid misrepresenting log lines as inferior output

Author: labath Date: Tue Aug 18 03:23:35 2015 New Revision: 245272 URL: http://llvm.org/viewvc/llvm-project?rev=245272&view=rev Log: [LLGS] Avoid misrepresenting log lines as inferior output Summary: in case we are logging to stdout, any log lines from the forked child can be misconstrued to be

[Lldb-commits] [lldb] r245275 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core, unify closing inclusion guards

Author: labath Date: Tue Aug 18 03:39:09 2015 New Revision: 245275 URL: http://llvm.org/viewvc/llvm-project?rev=245275&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core, unify closing inclusion guards patch by Eugene Zelenko Differential Revision: http:/

[Lldb-commits] [lldb] r245277 - Fix Clang-tidy misc-use-override warnings in include/lldb/Utility and some files in include/lldb/Target, unify closing inclusion guards

Author: labath Date: Tue Aug 18 03:54:26 2015 New Revision: 245277 URL: http://llvm.org/viewvc/llvm-project?rev=245277&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/Utility and some files in include/lldb/Target, unify closing inclusion guards patch by Eugene Zelenko. D

[Lldb-commits] [lldb] r245279 - Fix Clang-tidy misc-use-override warnings in include/lldb/DataFormatters and include/lldb/Host, unify closing inclusion guards

Author: labath Date: Tue Aug 18 04:06:31 2015 New Revision: 245279 URL: http://llvm.org/viewvc/llvm-project?rev=245279&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/DataFormatters and include/lldb/Host, unify closing inclusion guards patch by Eugene Zelenko. Differenti

[Lldb-commits] [lldb] r245283 - Fix Clang-tidy misc-use-override warnings in include/lldb/Expression and include/lldb/Initialization, unify inclusion guards

Author: labath Date: Tue Aug 18 04:18:19 2015 New Revision: 245283 URL: http://llvm.org/viewvc/llvm-project?rev=245283&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/Expression and include/lldb/Initialization, unify inclusion guards patch by Eugene Zelenko. Differential

[Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath created this revision. labath added reviewers: ovyalov, tberghammer. labath added a subscriber: lldb-commits. There was a bug in NativeProcessLinux, where doing an instruction-level single-step over the thread-creation syscall resulted in loss of control over the inferior. This happened b

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good as far as I am concerned. Repository: rL LLVM http://reviews.llvm.org/D12100 ___ lldb-commits mailing list lldb-commits@lists.llvm.

Re: [Lldb-commits] [PATCH] D12138: On Linux, clear the signal mask of the launched inferior

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for catching this. Does the test you mentioned pass after this, or does it still fail intermittently as the original bug indicates? If it seems to pass, you should also ena

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath updated this revision to Diff 32526. labath marked 4 inline comments as done. labath added a comment. - Address review comments http://reviews.llvm.org/D12104 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.h source/Plugins

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457 @@ -1453,3 +1456,3 @@ -thread_sp = AddThread(pid); +thread_sp = std::static_pointer_cast(AddThread(pid)); assert (thread_sp.get() && "failed to create the

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath updated this revision to Diff 32545. labath added a comment. Fix test on android arm - skip single-stepping over some functions http://reviews.llvm.org/D12104 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.h source/Plugins

Re: [Lldb-commits] [PATCH] D12138: On Linux, clear the signal mask of the launched inferior

labath added a comment. Ok, I see what you mean. I will commit it with the test enabled, and I will keep an eye out on the buildbots. http://reviews.llvm.org/D12138 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [PATCH] D12138: On Linux, clear the signal mask of the launched inferior

This revision was automatically updated to reflect the committed changes. Closed by commit rL245436: On Linux, clear the signal mask of the launched inferior (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12138?vs=32529&id=32546#toc Repository: rL LLVM http://review

[Lldb-commits] [lldb] r245436 - On Linux, clear the signal mask of the launched inferior

Author: labath Date: Wed Aug 19 08:47:57 2015 New Revision: 245436 URL: http://llvm.org/viewvc/llvm-project?rev=245436&view=rev Log: On Linux, clear the signal mask of the launched inferior Summary: Due to fork()/execve(), the launched inferior inherits the signal mask of its parent (lldb-server

[Lldb-commits] [lldb] r245440 - Add TestCrashDuringStep

Author: labath Date: Wed Aug 19 09:15:45 2015 New Revision: 245440 URL: http://llvm.org/viewvc/llvm-project?rev=245440&view=rev Log: Add TestCrashDuringStep this tests that a crash that happens during instruction step is reported correctly. Added: lldb/trunk/test/functionalities/thread/cras

[Lldb-commits] [lldb] r245448 - Increase timeout in TestCallThatRestarts

Author: labath Date: Wed Aug 19 10:24:02 2015 New Revision: 245448 URL: http://llvm.org/viewvc/llvm-project?rev=245448&view=rev Log: Increase timeout in TestCallThatRestarts the test was failing on android because processing 30 signals involved a lot of round-trips, which was not possible in the

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath updated this revision to Diff 32571. labath marked an inline comment as done. labath added a comment. Herald added subscribers: srhines, danalbert, tberghammer. Address review comments http://reviews.llvm.org/D12104 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Pl

[Lldb-commits] [lldb] r245545 - [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

Author: labath Date: Thu Aug 20 04:06:12 2015 New Revision: 245545 URL: http://llvm.org/viewvc/llvm-project?rev=245545&view=rev Log: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation Summary: There was a bug in NativeProcessLinux, where doing an instruction-level single

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

This revision was automatically updated to reflect the committed changes. Closed by commit rL245545: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12104?vs=32571&id=32669#toc Repository: rL

[Lldb-commits] [PATCH] D12187: [NativeProcessLinux] Reduce the number of casts

labath created this revision. labath added reviewers: ovyalov, tberghammer. labath added a subscriber: lldb-commits. NPL used to be peppered with casts of the NativeThreadProtocol objects into NativeThreadLinux. I move these closer to the source where we obtain these objects. This way, the rest

[Lldb-commits] [lldb] r245552 - Skip TestCreateDuringInstructionStep on android aarch64

Author: labath Date: Thu Aug 20 06:37:19 2015 New Revision: 245552 URL: http://llvm.org/viewvc/llvm-project?rev=245552&view=rev Log: Skip TestCreateDuringInstructionStep on android aarch64 we are unable to step through _M_start_thread due to atomic instruction sequences. Modified: lldb/tru

[Lldb-commits] [lldb] r245555 - Increase timeout in TestCallWithTimeout to reduce flakyness

Author: labath Date: Thu Aug 20 07:12:09 2015 New Revision: 24 URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev Log: Increase timeout in TestCallWithTimeout to reduce flakyness The test was flaky on the android buildbot, because the 10ms test completed before we got a chance to i

Re: [Lldb-commits] [PATCH] D12025: Make UriParser to support [$HOSTNAME] notation.

labath added a subscriber: labath. Comment at: source/Utility/UriParser.cpp:13 @@ -12,4 +12,3 @@ // C Includes -#include -#include +#include ovyalov wrote: > tberghammer wrote: > > I think you wanted to include , not > I need string.h for strlen - it's requ

Re: [Lldb-commits] [PATCH] D12187: [NativeProcessLinux] Reduce the number of casts

labath marked an inline comment as done. labath added a comment. Passing around pointers (shared or otherwise) encourages people to litter the code with null pointer checks. For the next cleanup, I would like to move these checks to a single place and then convert more of these functions to take

[Lldb-commits] [lldb] r245681 - [NativeProcessLinux] Reduce the number of casts

Author: labath Date: Fri Aug 21 04:13:53 2015 New Revision: 245681 URL: http://llvm.org/viewvc/llvm-project?rev=245681&view=rev Log: [NativeProcessLinux] Reduce the number of casts Summary: NPL used to be peppered with casts of the NativeThreadProtocol objects into NativeThreadLinux. I move thes

Re: [Lldb-commits] [PATCH] D12187: [NativeProcessLinux] Reduce the number of casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL245681: [NativeProcessLinux] Reduce the number of casts (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12187?vs=32673&id=32805#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [lldb] r245687 - Add repro test case for bug #24530

Author: labath Date: Fri Aug 21 05:38:31 2015 New Revision: 245687 URL: http://llvm.org/viewvc/llvm-project?rev=245687&view=rev Log: Add repro test case for bug #24530 Modified: lldb/trunk/test/functionalities/signal/raise/TestRaise.py Modified: lldb/trunk/test/functionalities/signal/raise/T

[Lldb-commits] [lldb] r245691 - Increase timeout in TestExpressionInSyscall

Author: labath Date: Fri Aug 21 05:52:02 2015 New Revision: 245691 URL: http://llvm.org/viewvc/llvm-project?rev=245691&view=rev Log: Increase timeout in TestExpressionInSyscall test times out on the windows->android buildbot (probably due to android emulator being slow) Modified: lldb/trun

[Lldb-commits] [PATCH] D12237: [NativeProcessLinux] Pass around threads by reference

labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Most NPL private functions took (shared) pointers to threads as arguments. This meant that the callee could not be sure if the pointer was valid and so most functions were peppered with n

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:24 @@ -25,1 +23,3 @@ +static DWARFFormValue::FixedFormSizes +g_form_sizes_addr4 { 0, // 0x00 unused Will these be linker-initialized? As I understand it, we are tryin

Re: [Lldb-commits] [PATCH] D12238: Add support for DW_FORM_GNU_[addr, str]_index

labath added a comment. Looks reasonable at a first glance, but I'll leave the review to someone else. http://reviews.llvm.org/D12238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r245831 - [NativeProcessLinux] Pass around threads by reference

Author: labath Date: Mon Aug 24 04:22:04 2015 New Revision: 245831 URL: http://llvm.org/viewvc/llvm-project?rev=245831&view=rev Log: [NativeProcessLinux] Pass around threads by reference Summary: Most NPL private functions took (shared) pointers to threads as arguments. This meant that the calle

Re: [Lldb-commits] [PATCH] D12237: [NativeProcessLinux] Pass around threads by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rL245831: [NativeProcessLinux] Pass around threads by reference (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12237?vs=32824&id=32937#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. There were a number of issues about the way I have designed this test originally: - it relied on single-stepping through large pa

Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

labath added a comment. There is a similar issue during thread destruction, although the underlying reason is a bit different. I have created bug #24551 to track that. http://reviews.llvm.org/D12280 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] r245838 - Make TestCreateDuringInstructionStep linux-specific

Author: labath Date: Mon Aug 24 08:23:48 2015 New Revision: 245838 URL: http://llvm.org/viewvc/llvm-project?rev=245838&view=rev Log: Make TestCreateDuringInstructionStep linux-specific Summary: There were a number of issues about the way I have designed this test originally: - it relied on singl

Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

This revision was automatically updated to reflect the committed changes. Closed by commit rL245838: Make TestCreateDuringInstructionStep linux-specific (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12280?vs=32950&id=32952#toc Repository: rL LLVM http://reviews.llv

[Lldb-commits] [lldb] r245839 - Simplify NativeThreadLinux includes

Author: labath Date: Mon Aug 24 08:25:54 2015 New Revision: 245839 URL: http://llvm.org/viewvc/llvm-project?rev=245839&view=rev Log: Simplify NativeThreadLinux includes there is no need to include architecture-specific register contexts when the generic one will suffice. Modified: lldb/trun

[Lldb-commits] [lldb] r245842 - Fix TestCreateDuringInstructionStep on i386

Author: labath Date: Mon Aug 24 09:24:20 2015 New Revision: 245842 URL: http://llvm.org/viewvc/llvm-project?rev=245842&view=rev Log: Fix TestCreateDuringInstructionStep on i386 Modified: lldb/trunk/test/linux/thread/create_during_instruction_step/main.cpp Modified: lldb/trunk/test/linux/thre

[Lldb-commits] [lldb] r245848 - Add the correct decorator to TestCreateDuringInstructionStep

Author: labath Date: Mon Aug 24 10:49:12 2015 New Revision: 245848 URL: http://llvm.org/viewvc/llvm-project?rev=245848&view=rev Log: Add the correct decorator to TestCreateDuringInstructionStep apparently, just placing the file under linux/ does not make the test linux specific. :) Modified:

Re: [Lldb-commits] [lldb] r246004 - In SendContinuePacketAndWaitForResponse there is a special bit of

On 26 August 2015 at 05:07, Jason Molenda via lldb-commits wrote: > There's a timeout where we wait to get this second stop reply packet > in SendContinuePacketAndWaitForResponse, currently 1ms. For a slow > remote target, it may take longer than that to send the second stop > reply packet. If t

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

labath added a subscriber: labath. labath added a comment. Same question as Zachary. This sounds like a very useful feature and it would be nice to have it integrated into the current test system, instead of making another layer on top of that (it's bad enough we have dosep and dotest already).

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

labath added a subscriber: labath. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853 @@ -852,3 +852,3 @@ if (platform_sp && platform_sp->IsConnected()) -SetUnixSignals(platform_sp->GetUnixSignals()); + SetUnixSignals(std::make_

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

labath added a comment. In http://reviews.llvm.org/D12416#235166, @tfiala wrote: > > instead of making another layer on top of that (it's bad enough we have > > dosep and dotest already). > > > The existence of those two is at least partly due to the organic nature in > which they developed.

[Lldb-commits] [lldb] r246536 - Revert "Add support for language plugins to provide data formatters"

Author: labath Date: Tue Sep 1 04:02:54 2015 New Revision: 246536 URL: http://llvm.org/viewvc/llvm-project?rev=246536&view=rev Log: Revert "Add support for language plugins to provide data formatters" This reverts r246515 (and related cmake fixes) as it breaks all libcxx tests. Removed: lld

Re: [Lldb-commits] [lldb] r246518 - Attempt at fixing the CMake build

Hello, the cmake fixes seem fine, but something about your changes broke all libcxx tests, regardless of the build system: osx/xcode: < http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5309>, linux/cmake: < http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/575

[Lldb-commits] [lldb] r246539 - [NativeProcessLinux] Fix assertion failure when killing a process

Author: labath Date: Tue Sep 1 05:59:36 2015 New Revision: 246539 URL: http://llvm.org/viewvc/llvm-project?rev=246539&view=rev Log: [NativeProcessLinux] Fix assertion failure when killing a process Linux sometimes sends us a PTRACE_EVENT_EXIT when an inferior process gets a SIGKILL. This can be

[Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

labath created this revision. labath added reviewers: zturner, clayborg. labath added a subscriber: lldb-commits. The test (among other things) attempts to verify that detaching works while the inferior is running. However, this was racy since the inferior could end up stopping again before we g

Re: [Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

labath updated this revision to Diff 33689. labath added a comment. I've found another source or racyness in the test. The test verified that the process resumes and stops after a "continue". However, if these two events happened two fast, the initial start event would be lost, and the test woul

Re: [Lldb-commits] [PATCH] D12531: Fix tab completion for command arguments containing spaces

labath added inline comments. Comment at: source/Interpreter/Options.cpp:996 @@ +995,3 @@ +{ +if (c == ' ' || c == '\\') +s.push_back('\\'); If there is any chance quotes will appear here (', ", `), you will need to escape thos

[Lldb-commits] [lldb] r246549 - [NativeProcessLinux] Fix detach of multithreaded inferiors

Author: labath Date: Tue Sep 1 10:00:51 2015 New Revision: 246549 URL: http://llvm.org/viewvc/llvm-project?rev=246549&view=rev Log: [NativeProcessLinux] Fix detach of multithreaded inferiors When detaching, we need to detach from all threads of the inferior and not just the main one. Without th

[Lldb-commits] [lldb] r246623 - Address flakyness in TestAttachResume

Author: labath Date: Wed Sep 2 04:12:28 2015 New Revision: 246623 URL: http://llvm.org/viewvc/llvm-project?rev=246623&view=rev Log: Address flakyness in TestAttachResume Summary: The test (among other things) attempts to verify that detaching works while the inferior is running. However, this w

Re: [Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

This revision was automatically updated to reflect the committed changes. Closed by commit rL246623: Address flakyness in TestAttachResume (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12527?vs=33689&id=33785#toc Repository: rL LLVM http://reviews.llvm.org/D12527

[Lldb-commits] [lldb] r246624 - Fix Clang-tidy misc-use-override warnings in include/lldb/API, Breakpoint and Symbol, unify closing inclusion guards

Author: labath Date: Wed Sep 2 04:19:24 2015 New Revision: 246624 URL: http://llvm.org/viewvc/llvm-project?rev=246624&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/API, Breakpoint and Symbol, unify closing inclusion guards patch by Eugene Zelenko. Modified: lldb/t

[Lldb-commits] [lldb] r246626 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Target, unify closing inclusion guards

Author: labath Date: Wed Sep 2 04:24:21 2015 New Revision: 246626 URL: http://llvm.org/viewvc/llvm-project?rev=246626&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Target, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision: htt

[Lldb-commits] [lldb] r246627 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter, unify closing inclusion guards

Author: labath Date: Wed Sep 2 04:28:35 2015 New Revision: 246627 URL: http://llvm.org/viewvc/llvm-project?rev=246627&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision

[Lldb-commits] [lldb] r246628 - Fix Clang-tidy misc-use-override warnings in source/Commands headers, unify closing inclusion guards

Author: labath Date: Wed Sep 2 04:33:09 2015 New Revision: 246628 URL: http://llvm.org/viewvc/llvm-project?rev=246628&view=rev Log: Fix Clang-tidy misc-use-override warnings in source/Commands headers, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision: http://review

[Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

labath created this revision. labath added reviewers: clayborg, ovyalov. labath added a subscriber: lldb-commits. There was a race condition in the AsyncThread, where we would end up sending a vAttach notification to the thread before it got a chance set up its listener (this can be reproduced b

Re: [Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

This commit seems to be breaking TestObjCBreakpoints.py on mac: . On 2 September 2015 at 02:59, Jim Ingham via lldb-commits wrote: > Author: jingham > Date: Tue Sep 1 20:59:14 2015 > New Revision: 246616 > > URL: http://llvm.

[Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

Author: labath Date: Wed Sep 2 07:09:31 2015 New Revision: 246644 URL: http://llvm.org/viewvc/llvm-project?rev=246644&view=rev Log: XFAIL new tests in TestCompletion on windows due to missing pexpect Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py Modified: lldb/trunk

[Lldb-commits] [lldb] r246645 - Fix test.html webpage alignment

Author: labath Date: Wed Sep 2 07:20:41 2015 New Revision: 246645 URL: http://llvm.org/viewvc/llvm-project?rev=246645&view=rev Log: Fix test.html webpage alignment Modified: lldb/trunk/www/test.html Modified: lldb/trunk/www/test.html URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/www/

[Lldb-commits] [lldb] r246647 - Enable a couple of tests in TestExitDuringStep on linux

Author: labath Date: Wed Sep 2 08:01:21 2015 New Revision: 246647 URL: http://llvm.org/viewvc/llvm-project?rev=246647&view=rev Log: Enable a couple of tests in TestExitDuringStep on linux tests have been reliably passing at least the last 100 runs of the build bot. Modified: lldb/trunk/tes

Re: [Lldb-commits] [PATCH] D12553: Fix arm disassambler with specifying armv8.1a architecture

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable to me Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:668 @@ +667,3 @@ +// If no sub architecture specified then use the most recent a

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

an explicit goal to avoid pexpect tests unless the test > specificially requires launching lldb from the command line. > > On Wed, Sep 2, 2015 at 5:10 AM Pavel Labath via lldb-commits > wrote: >> >> Author: labath >> Date: Wed Sep 2 07:09:31 2015 >> New Revisio

[Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

labath created this revision. labath added reviewers: clayborg, ovyalov. labath added a subscriber: lldb-commits. There was a race condition in Process class, where we would not wait for process stdout to propagate fully before we would shut down the connection (repro case: slow down the stdio t

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added subscribers: zturner, labath. labath added a comment. Since we already have an implementation of getopt for windows, couldn't you use that one (or improve/replace it if it is missing some features) for netbsd also? I don't see why it would be necessary to have two independent reimp

Re: [Lldb-commits] [PATCH] D12586: [cmake] Remove LLVM_NO_RTTI.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D12586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

labath added subscribers: chying, labath. labath added a comment. I very much like the direction this is going in. We will need to update our buildbots when this lands (we need to run dosep manually to setup remote testing), but I have tested this manually and didn't see any problems.

[Lldb-commits] [lldb] r246753 - Fix rare failure in TestProcessIO

Author: labath Date: Thu Sep 3 04:30:17 2015 New Revision: 246753 URL: http://llvm.org/viewvc/llvm-project?rev=246753&view=rev Log: Fix rare failure in TestProcessIO Summary: There was a race condition in Process class, where we would not wait for process stdout to propagate fully before we wou

Re: [Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

This revision was automatically updated to reflect the committed changes. Closed by commit rL246753: Fix rare failure in TestProcessIO (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12558?vs=33815&id=33917#toc Repository: rL LLVM http://reviews.llvm.org/D12558 File

[Lldb-commits] [lldb] r246756 - Fix deadlock while attaching to inferiors

Author: labath Date: Thu Sep 3 04:36:22 2015 New Revision: 246756 URL: http://llvm.org/viewvc/llvm-project?rev=246756&view=rev Log: Fix deadlock while attaching to inferiors Summary: There was a race condition in the AsyncThread, where we would end up sending a vAttach notification to the threa

Re: [Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

This revision was automatically updated to reflect the committed changes. Closed by commit rL246756: Fix deadlock while attaching to inferiors (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12552?vs=33795&id=33918#toc Repository: rL LLVM http://reviews.llvm.org/D125

Re: [Lldb-commits] [lldb] r246709 - We want Python int or long to both be usable as-a tid_t for API purposes. Introduce a typemap to this effect

Hi, this commit seems to break TestPythonOSPlugin.py on the windows builtbot and I expect any other 32-bit system. It fails with the error "OverflowError: Python int too large to convert to C long", because the test tries to pass

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added a comment. Thanks for merging the two implementations. However, the way you have implemented it enables the getopt replacement for all platforms. We need to have it on only for platforms that don't have a native one. Comment at: include/lldb/Host/HostGetOpt.h:11 @

[Lldb-commits] [lldb] r246761 - Enable TestFdLeak on linux

Author: labath Date: Thu Sep 3 07:00:15 2015 New Revision: 246761 URL: http://llvm.org/viewvc/llvm-project?rev=246761&view=rev Log: Enable TestFdLeak on linux it has been consistently passing at least the last 100 builds on the bot. Modified: lldb/trunk/test/functionalities/avoids-fd-leak/T

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added inline comments. Comment at: include/lldb/Host/HostGetOpt.h:11 @@ -10,3 +10,1 @@ -#ifndef _MSC_VER - krytarowski wrote: > labath wrote: > > How about just putting here > > ``` > > #if !defined(_MSC_VER) && !defined(__NetBSD__) > > ``` > I dislike ha

[Lldb-commits] [lldb] r246766 - XFAIL TestFormatters on android (llvm.org/pr24691)

Author: labath Date: Thu Sep 3 08:52:29 2015 New Revision: 246766 URL: http://llvm.org/viewvc/llvm-project?rev=246766&view=rev Log: XFAIL TestFormatters on android (llvm.org/pr24691) the test is hitting an assertion in clang. Modified: lldb/trunk/test/expression_command/formatters/TestForma

Re: [Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

labath added a comment. Looks good after fixing inverting one condition, but I would like to wait for an ok from zachary also. Linux builds fine after this patch. Comment at: source/Host/common/GetOptInc.cpp:3 @@ +2,3 @@ + +#if !defined(REPLACE_GETOPT) && !defined(REPLACE_GETOP

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

labath added a comment. The linux parts are ok. This reduces the size of liblldb by about 13%. Good work. :) http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] r246777 - Mark TestAttachResume as flaky on linux

Author: labath Date: Thu Sep 3 10:44:16 2015 New Revision: 246777 URL: http://llvm.org/viewvc/llvm-project?rev=246777&view=rev Log: Mark TestAttachResume as flaky on linux There is a more race condition regarding process detach, which this test exposes, marking as flaky until it is fixed. Modi

[Lldb-commits] [lldb] r246776 - Fix logging message

Author: labath Date: Thu Sep 3 10:44:14 2015 New Revision: 246776 URL: http://llvm.org/viewvc/llvm-project?rev=246776&view=rev Log: Fix logging message Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL: http://llvm.org/viewvc/llvm-project/lld

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

labath added a comment. In http://reviews.llvm.org/D12599#239378, @tfiala wrote: > 13% size decrease sounds nice! Was that with a DebugAsserts build, > optimized, or what? This was a release build (-O3 -DNDEBUG). Size went down from ~58 to ~51 MB. > tfiala, on Mac OS X with this change, the

[Lldb-commits] [lldb] r246843 - Move GetOptInc to the common namespace

Author: labath Date: Fri Sep 4 04:06:15 2015 New Revision: 246843 URL: http://llvm.org/viewvc/llvm-project?rev=246843&view=rev Log: Move GetOptInc to the common namespace Summary: GetOptInc provides getopt(), getopt_long() and getopt_long_only(). Windows (for defined(_MSC_VER)) doesn't ship wit

Re: [Lldb-commits] [PATCH] D12582: Move GetOptInc to the common namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rL246843: Move GetOptInc to the common namespace (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12582?vs=33944&id=34020#toc Repository: rL LLVM http://reviews.llvm.org/D12582

[Lldb-commits] [lldb] r246845 - Add a repro case for bug llvm.org/pr24702

Author: labath Date: Fri Sep 4 05:21:15 2015 New Revision: 246845 URL: http://llvm.org/viewvc/llvm-project?rev=246845&view=rev Log: Add a repro case for bug llvm.org/pr24702 Added: lldb/trunk/test/functionalities/jitloader_gdb/ lldb/trunk/test/functionalities/jitloader_gdb/Makefile l

Re: [Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I would rather see the register variables laid out in a way which makes the offsets meaningful. I.e., instead of having m_fpr, m_gpr, ... we put something like struct Regs { uint32_t gp

[Lldb-commits] [lldb] r246956 - Extend the XFAIL for TestMiBreak

Author: labath Date: Mon Sep 7 02:58:29 2015 New Revision: 246956 URL: http://llvm.org/viewvc/llvm-project?rev=246956&view=rev Log: Extend the XFAIL for TestMiBreak the test is occasionally failing on linux for all tested scenarios. Modified: lldb/trunk/test/tools/lldb-mi/breakpoint/TestMiB

[Lldb-commits] [lldb] r246957 - Fixup TestRegisters after r246955

Author: labath Date: Mon Sep 7 03:54:34 2015 New Revision: 246957 URL: http://llvm.org/viewvc/llvm-project?rev=246957&view=rev Log: Fixup TestRegisters after r246955 - clang is picky about inline assembly: add the correct instruction size suffix - mark the new test as expectedFailureClang: the t

Re: [Lldb-commits] [lldb] r246955 - Bug 24457 - X87 FPU Special Purpose Registers

Hi, this new test fails when the inferior is compiled with clang, as the produced line tables are not what you expect. I have marked it as XFAIL to get the bots green, but it would be great if we could write it in a way that works on clang as well. pl On 7 September 2015 at 08:40, Abhishek Agga

Re: [Lldb-commits] [PATCH] D12661: NetBSD doesn't provide struct statfs, make use of struct statvfs

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D12661#240625, @joerg wrote: > One good question is whether using statvfs(3) shouldn't be the default as it > is the POSIX interface. Unfortunately, that will not work as linux does not define the MNT_LOCAL f

[Lldb-commits] [lldb] r246964 - Skip RegisterCommandsTestCase.test_fp_register_write on Android i386

Author: labath Date: Mon Sep 7 06:59:01 2015 New Revision: 246964 URL: http://llvm.org/viewvc/llvm-project?rev=246964&view=rev Log: Skip RegisterCommandsTestCase.test_fp_register_write on Android i386 it appears a kernel bug is preventing us from writing into the register. Modified: lldb/tr

[Lldb-commits] [lldb] r246966 - Mark TestCreateDuringInstructionStep as flaky on android arm

Author: labath Date: Mon Sep 7 07:15:27 2015 New Revision: 246966 URL: http://llvm.org/viewvc/llvm-project?rev=246966&view=rev Log: Mark TestCreateDuringInstructionStep as flaky on android arm Modified: lldb/trunk/test/linux/thread/create_during_instruction_step/TestCreateDuringInstructionS

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

labath added a subscriber: lldb-commits. Comment at: test/functionalities/register/TestRegisters.py:195 @@ +194,3 @@ +for x in range(0,16): +self.runCmd ("si", RUN_SUCCEEDED) + First I would like to applaud for writing a test case for s

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. please also close the relevant bug after submission. http://reviews.llvm.org/D12677 ___ lldb-commits mailing list lldb-commits@lists.

Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

I think the main reason behind it is that we have about three build systems. Any check you write will need to be implemented in all of them. Maybe when autoconf goes away, we can do a build check in cmake and xcode can just hardcode -DPIPE2_SUPPORTED=0, since it is only used on darwin anyway. On 1

Re: [Lldb-commits] [PATCH] D12756: Build Plugin/JITLoader/GDB on all platforms.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

Re: [Lldb-commits] [PATCH] D12792: Clean up build of JITLoader/GDB in autoconf build.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D12792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D12795: Switch default disposition of realtime signals

labath created this revision. labath added reviewers: ovyalov, emaste. labath added a subscriber: lldb-commits. Herald added a subscriber: emaste. Realtime signals generally do not represent an error condition in an application but are more like a regular means of IPC. As such, we shouldn't inter

<    18   19   20   21   22   23   24   25   26   27   >