labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I would rather see the register variables laid out in a way which makes the
offsets meaningful. I.e., instead of having m_fpr, m_gpr, ... we put something
like
struct Regs {
uint32_t gpr[...];
FPU fpu;
DREG hbr_regs;
...
};
Regs m_registers;
Then the byte offset field in Register Info structure will truly correspond to
the offset in this structure, and we can index it simply with:
assert(offset < sizeof m_register);
address = (char *)&m_registers + offset;
But if you want to keep this change small then it's ok for now.
http://reviews.llvm.org/D12636
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
