Author: labath
Date: Fri Feb 19 04:36:31 2016
New Revision: 261313
URL: http://llvm.org/viewvc/llvm-project?rev=261313&view=rev
Log:
Mark TestLldbGdbServer.test_software_breakpoint_set_and_remove_work_llgs as
flaky on linux
The problem is the asynchronous arrival of inferior stdio (pr25652).
Mo
Author: labath
Date: Fri Feb 19 04:36:38 2016
New Revision: 261314
URL: http://llvm.org/viewvc/llvm-project?rev=261314&view=rev
Log:
Enable TestUnicodeLiterals
Test should work everywhere except windows now.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestU
Author: labath
Date: Mon Feb 22 03:51:32 2016
New Revision: 261519
URL: http://llvm.org/viewvc/llvm-project?rev=261519&view=rev
Log:
Mark TestMiBreak.test_lldbmi_break_insert_function_pending as flaky on linux
Test has become flaky again. Attempts to investigate the triggering commit have
failed
labath updated this revision to Diff 48690.
labath added a comment.
Avoid an unused function warning on non-arm64 arches.
http://reviews.llvm.org/D17509
Files:
source/Plugins/Process/Linux/CMakeLists.txt
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/Nati
labath created this revision.
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
On arm64, linux<=4.4 and Android<=M there is a bug, which prevents
single-stepping from working when
labath created this revision.
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Signalfd is not used in the code anymore, and given that the same functionality
can be achieved
with the new MainLoop cla
labath added a subscriber: labath.
Comment at: source/Core/ConstString.cpp:269
@@ +268,3 @@
+bool
+ConstString::Equals (const ConstString& lhs, const ConstString& rhs, const
bool case_sensitive)
+{
zturner wrote:
> Looks like this code also isn't clang-formatted.
I agree with Adrian. I don't think the section comments are supposed
to apply to the "main header file", which should always come first.
On 23 February 2016 at 00:17, Eugene Zelenko via lldb-commits
wrote:
> On Mon, Feb 22, 2016 at 4:14 PM, Adrian McCarthy wrote:
>> It looks like this patch reor
labath added a subscriber: labath.
labath added a comment.
I'll leave the final review to Tamas, just a couple of comments here.
Comment at:
packages/Python/lldbsuite/test/functionalities/single_step_atomic_sequence/TestStepInAtomicSequence.py:70
@@ +69,3 @@
+inst_o
Author: labath
Date: Tue Feb 23 06:26:08 2016
New Revision: 261631
URL: http://llvm.org/viewvc/llvm-project?rev=261631&view=rev
Log:
[linux] Remove all traces of signalfd(2)
Summary:
Signalfd is not used in the code anymore, and given that the same functionality
can be achieved
with the new Main
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261631: [linux] Remove all traces of signalfd(2) (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D17510?vs=48692&id=48805#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1751
Author: labath
Date: Tue Feb 23 07:56:30 2016
New Revision: 261636
URL: http://llvm.org/viewvc/llvm-project?rev=261636&view=rev
Log:
Work around a stepping bug in arm64 android M
Summary:
On arm64, linux<=4.4 and Android<=M there is a bug, which prevents
single-stepping from working when
the sys
This revision was automatically updated to reflect the committed changes.
labath marked 2 inline comments as done.
Closed by commit rL261636: Work around a stepping bug in arm64 android M
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D17509?vs=48690&id=48811#toc
Reposi
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
the python2 branch seems erroneous as it expected the object to be both a
"String" and "Bytes".
Fix the expectation.
http://reviews.llvm.org/D17545
Files:
unittests/ScriptInterpreter/Pytho
labath added inline comments.
Comment at: unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:212
@@ -211,3 +211,2 @@
PythonBytes python_bytes(PyRefType::Owned, py_bytes);
-EXPECT_EQ(PyObjectType::Bytes, python_bytes.GetObjectType());
zturner
labath added a comment.
Any thoughts on this?
This is currently the only failing unit test on linux.
http://reviews.llvm.org/D17545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
Author: labath
Date: Thu Feb 25 11:41:59 2016
New Revision: 261901
URL: http://llvm.org/viewvc/llvm-project?rev=261901&view=rev
Log:
Fix PythonDataObjectsTests for python 2
Summary:
the python2 branch seems erroneous as it expected the object to be both a
"String" and "Bytes".
Fix the expectatio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261901: Fix PythonDataObjectsTests for python 2 (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D17545?vs=48820&id=49081#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17545
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
"Initialization of function-local statics is guaranteed to occur only once even
when called from
multiple threads, and may be more efficient than the equivalent code using
std::call_
Author: labath
Date: Mon Feb 29 05:44:15 2016
New Revision: 262214
URL: http://llvm.org/viewvc/llvm-project?rev=262214&view=rev
Log:
Fix compiler warnings in the java code
Modified:
lldb/trunk/source/Plugins/Language/Java/JavaLanguage.h
lldb/trunk/source/Symbol/JavaASTContext.cpp
Modifie
Author: labath
Date: Mon Feb 29 08:26:45 2016
New Revision: 262223
URL: http://llvm.org/viewvc/llvm-project?rev=262223&view=rev
Log:
Revert a part of "Add/Improve complex, vector, aggregate types handling for
SysV ARM (hard/soft) ABI."
This partially reverts commit r262218.
The commit added add
labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
I agree with Tamas here. Your previous patch also added a some tests here,
which were breaking on some configuratio
labath added a comment.
I suspected something like that might be up. Thanks.
The VS2015 migration for us is taking longer than expected, but we are now
nearing the end, hopefully. If there are no objections, I'll land this after we
are done.
http://reviews.llvm.org/D17710
_
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
This replaces the hand-rolled getopt option parser in lldb driver with the one
in llvm. This
results in a lot less code, as the llvm's parser does much of the work (e.g.,
formatting
labath added a comment.
Yes, we are, and unfortunately we can't get rid of it that easily there, as
llvm:cl does not really have interactive uses in mind (global variables
everywhere, --help kills your program, etc.). It probably wouldn't be **too**
hard to add a version which can do that, as a
labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
The actual changes aren't too bad, but I wonder why you need to add them at
all. These files all assume they will b
Author: labath
Date: Tue Mar 1 05:40:47 2016
New Revision: 262322
URL: http://llvm.org/viewvc/llvm-project?rev=262322&view=rev
Log:
Fix warning in NSDictionary.cpp
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
Modified: lldb/trunk/source/Plugins/Language/ObjC/NSDictiona
labath added a comment.
In http://reviews.llvm.org/D17724#364450, @clayborg wrote:
> As long as both long and short options are still supported? Can you still
> type any of:
>
> - --arch=x86_64
> - --arch x86_64
> - -arch=x86_64
> - -arch x86_64
> - -ax86_64
> - -a x86_64
All the variants work
Author: labath
Date: Tue Mar 1 08:04:41 2016
New Revision: 262333
URL: http://llvm.org/viewvc/llvm-project?rev=262333&view=rev
Log:
Slightly improve logging in LLGS tests
we're sometimes getting an exception here, and I want to see why...
Modified:
lldb/trunk/packages/Python/lldbsuite/test
labath added a subscriber: jingham.
labath added a comment.
Greg, Jim,
any objections?
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
this enables download of remote log files for llgs and debugserver tests
(previously we were just
passing the host file name which obviously did not work). Note this also
changes the debugserv
labath abandoned this revision.
labath added a comment.
Ok, fair enough. I'll see if I can do something like that in the future, but
I'm going to abandon this for the moment.
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262597: Fetch remote log files from LLGS tests (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D17798?vs=49593&id=49720#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17798
Author: labath
Date: Thu Mar 3 03:02:52 2016
New Revision: 262597
URL: http://llvm.org/viewvc/llvm-project?rev=262597&view=rev
Log:
Fetch remote log files from LLGS tests
Summary:
this enables download of remote log files for llgs and debugserver tests
(previously we were just
passing the host
labath added a subscriber: lldb-commits.
labath added a comment.
I noticed this while debugging an importing issue in LLDB.
I am not sure if I have selected the right reviewer, and also how/if to test
this...
http://reviews.llvm.org/D17845
___
lld
Author: labath
Date: Thu Mar 3 04:39:24 2016
New Revision: 262602
URL: http://llvm.org/viewvc/llvm-project?rev=262602&view=rev
Log:
Fix OSX breakage caused by r262597
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Modified:
lldb/trunk/packages/
labath created this revision.
labath added a reviewer: nlewycky.
labath added subscribers: cfe-commits, lldb-commits.
While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(),
which expect to be
called with a valid source location. This causes an assertion failure if the
locatio
Author: labath
Date: Thu Mar 3 09:19:14 2016
New Revision: 262622
URL: http://llvm.org/viewvc/llvm-project?rev=262622&view=rev
Log:
Revert "Fetch remote log files from LLGS tests"
Even after the last fixup, there still seems to be one failure left. Revert
until I figure out
what is going on.
M
labath created this revision.
labath added a reviewer: spyffe.
labath added subscribers: lldb-commits, paulherman, sivachandra.
referencing a user-defined operator new was triggering an assert in clang
because we were
registering the function name as string "operator new", instead of using the
s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262700: [SemaExprCXX] Avoid calling isInSystemHeader for
invalid source locations (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D17847?vs=49725&id=49805#toc
Repository:
rL LL
Author: labath
Date: Fri Mar 4 05:27:00 2016
New Revision: 262713
URL: http://llvm.org/viewvc/llvm-project?rev=262713&view=rev
Log:
Resumbit "Fetch remote log files from LLGS tests"
The problem with the original patch (and my first attempt to fix) was that the
value debug
monitor flags could pe
Author: labath
Date: Fri Mar 4 05:26:56 2016
New Revision: 262712
URL: http://llvm.org/viewvc/llvm-project?rev=262712&view=rev
Log:
Fix warning in IRExecutionUnit.cpp
Modified:
lldb/trunk/source/Expression/IRExecutionUnit.cpp
Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp
URL:
Author: labath
Date: Fri Mar 4 06:43:05 2016
New Revision: 262715
URL: http://llvm.org/viewvc/llvm-project?rev=262715&view=rev
Log:
Add a log statement
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Modified:
lldb/trunk/packages/Python/lldbsuit
labath accepted this revision.
labath added a comment.
In http://reviews.llvm.org/D18017#371362, @zturner wrote:
> lgtm, Pavel does Android build infrastructure need these files for some
> reason?
Nope, let's get rid of them.
http://reviews.llvm.org/D18017
labath created this revision.
labath added reviewers: clayborg, zturner.
labath added a subscriber: lldb-commits.
This fixes a couple of corner cases in FileSpec, related to AppendPathComponent
and
handling of root directory (/) file spec. I add a bunch of unit tests for the
new behavior.
Summa
labath added a comment.
Comment at: unittests/Host/FileSpecTest.cpp:57
@@ +56,3 @@
+// We get "F:/bar" instead.
+// EXPECT_STREQ("F:\\bar",
fs_windows_trailing_slash.GetDirectory().GetCString());
+EXPECT_STREQ(".", fs_windows_trailing_slash.GetFilename().GetCString
Author: labath
Date: Fri Mar 11 02:44:44 2016
New Revision: 263207
URL: http://llvm.org/viewvc/llvm-project?rev=263207&view=rev
Log:
Fix a couple of cornercases in FileSpec + tests
Summary:
This fixes a couple of corner cases in FileSpec, related to AppendPathComponent
and
handling of root direc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263207: Fix a couple of cornercases in FileSpec + tests
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18044?vs=50275&id=50396#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: labath
Date: Fri Mar 11 03:00:23 2016
New Revision: 263209
URL: http://llvm.org/viewvc/llvm-project?rev=263209&view=rev
Log:
Fix a bunch of signedness warnings in unittests
Modified:
lldb/trunk/unittests/Editline/EditlineTest.cpp
lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTe
labath added a comment.
Any thoughts on this?
http://reviews.llvm.org/D17856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
If I understand correctly, you have simply copied the implementation from
PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since
it's going to inherit the implementation anyway?
Apart from that, it looks good to me, but let's give a chance for @c
labath accepted this revision.
labath added a comment.
Looks great. Thank you.
Repository:
rL LLVM
http://reviews.llvm.org/D18082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
labath added a subscriber: labath.
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
This revision is now accepted and ready to land.
I think that's fine (you may want to add a note about the crc to the comment).
http://reviews.llvm.org/D18096
___
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
Some tests (Hc_then_Csignal_signals_correct_thread, at least) were sending a
"continue" packet in
one expect_gdbremote_sequence invocation, and "expecting" the stop-reply in
another call. This
Author: labath
Date: Mon Mar 14 06:19:39 2016
New Revision: 263421
URL: http://llvm.org/viewvc/llvm-project?rev=263421&view=rev
Log:
Extend XFlaky in TestProcessIO to linux as well
The test sometimes fails on local linux as well. The cause is the same.
Modified:
lldb/trunk/packages/Python/l
labath created this revision.
labath added reviewers: tfiala, tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Normally, when the remote stub is not ready, we will get ECONNREFUSED during
the connect()
attempt. However, due to the wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263439: [test] Correctly retry connections on android
targets (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18146?vs=50600&id=50601#toc
Repository:
rL LLVM
http://reviews.l
labath updated this revision to Diff 50600.
labath added a comment.
Fix comment
http://reviews.llvm.org/D18146
Files:
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Index: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
=
Author: labath
Date: Mon Mar 14 10:33:25 2016
New Revision: 263439
URL: http://llvm.org/viewvc/llvm-project?rev=263439&view=rev
Log:
[test] Correctly retry connections on android targets
Summary:
Normally, when the remote stub is not ready, we will get ECONNREFUSED during
the connect()
attempt.
labath added a subscriber: labath.
Comment at:
packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8
@@ +7,2 @@
+clean::
+ rm -rf $(wildcard *.o *.d *.dSYM)
clayborg wrote:
> Maybe we can have a standard clean rule in the ma
labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
I am cleaning out my review queue. Feel free to add me back when you want to
get this moving again...
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
labath closed this revision.
labath added a comment.
This was committed ages ago.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath closed this revision.
labath added a comment.
This was committed ages ago.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
This also adds a basic smoke test for linux core file reading. I'm checking in
the core files as
well, so that the tests can run on all platforms. With some tricks I was able
to produce
reaso
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
These are not needed in lldb-server. Removing them shrinks the server size by
about 1.5%.
http://reviews.llvm.org/D18188
Files:
source/API/SystemInitializerFull.cpp
source/Initialization
Author: labath
Date: Wed Mar 16 03:48:56 2016
New Revision: 263625
URL: http://llvm.org/viewvc/llvm-project?rev=263625&view=rev
Log:
Move OperatingSystem plugins to SystemInitializerFull
Summary: These are not needed in lldb-server. Removing them shrinks the server
size by about 1.5%.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263625: Move OperatingSystem plugins to
SystemInitializerFull (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18188?vs=50740&id=50802#toc
Repository:
rL LLVM
http://reviews.l
labath added a comment.
Interesting... I didn't run the tests on windows. I was hoping they would run
mostly the same on all platforms. I'll try to give them a spin now...
Repository:
rL LLVM
http://reviews.llvm.org/D18044
___
lldb-commits maili
Author: labath
Date: Wed Mar 16 04:19:57 2016
New Revision: 263628
URL: http://llvm.org/viewvc/llvm-project?rev=263628&view=rev
Log:
Fix thread/process ID reading from linux core files
Summary:
This also adds a basic smoke test for linux core file reading. I'm checking in
the core files as
well,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263628: Fix thread/process ID reading from linux core files
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18176?vs=50709&id=50806#toc
Repository:
rL LLVM
http://reviews.llv
Author: labath
Date: Wed Mar 16 04:44:49 2016
New Revision: 263629
URL: http://llvm.org/viewvc/llvm-project?rev=263629&view=rev
Log:
[test] Persist packets between expect_gdbremote_sequence invocations
Summary:
Some tests (Hc_then_Csignal_signals_correct_thread, at least) were sending a
"continu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263629: [test] Persist packets between
expect_gdbremote_sequence invocations (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18140?vs=50577&id=50809#toc
Repository:
rL LLVM
h
Author: labath
Date: Wed Mar 16 04:58:34 2016
New Revision: 263631
URL: http://llvm.org/viewvc/llvm-project?rev=263631&view=rev
Log:
Mark an LLGS test as flaky
cause: Async output arrival over pty
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py
Mo
Author: labath
Date: Wed Mar 16 05:39:33 2016
New Revision: 263633
URL: http://llvm.org/viewvc/llvm-project?rev=263633&view=rev
Log:
Switch from unittest2.expectedFailure to our own decorator on TestSTL
the main reason is that our decorator contains extra fluff to "expect" crashes
(which seem to
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
These are not needed by lldb-server. Removing them shrinks the server by about
0.5%.
http://reviews.llvm.org/D18206
Files:
source/API/SystemInitializerFull.cpp
source/Initialization/Syst
labath added inline comments.
Comment at: lldb/trunk/unittests/Host/FileSpecTest.cpp:25
@@ +24,3 @@
+EXPECT_STREQ("F:\\bar", fs_windows.GetCString());
+EXPECT_STREQ("F:", fs_windows.GetDirectory().GetCString());
+EXPECT_STREQ("bar", fs_windows.GetFilename().GetCString(
Author: labath
Date: Wed Mar 16 09:03:20 2016
New Revision: 263637
URL: http://llvm.org/viewvc/llvm-project?rev=263637&view=rev
Log:
Fix null pointer "dereference" in DomainSocket
offsetof is the official way to get the offset of a field in a structure.
Modified:
lldb/trunk/source/Host/posix
labath added a comment.
So I ran the tests on windows (http://reviews.llvm.org/W7 Enterprise) now and I
did indeed get the long "0:0:...:1" version here instead of "::1". Maybe we
should just accept both versions as correct?
Repository:
rL LLVM
http://reviews.llvm.org/D17106
Author: labath
Date: Sun Mar 20 08:37:55 2016
New Revision: 263899
URL: http://llvm.org/viewvc/llvm-project?rev=263899&view=rev
Log:
Attempt to fix MSVC build (no __attribute__ there)
Modified:
lldb/trunk/include/lldb/Expression/DiagnosticManager.h
Modified: lldb/trunk/include/lldb/Expressio
labath added a subscriber: labath.
labath added a comment.
Some more "why do this?" questions from me...
I was looking into using mingw a couple weeks ago, but gave up, so I'm
interested to see your progress here. However, I'd like to avoid adding hacks
into the cmake files if it is not complet
Author: labath
Date: Tue Mar 29 05:41:40 2016
New Revision: 264713
URL: http://llvm.org/viewvc/llvm-project?rev=264713&view=rev
Log:
Add missing swig wrappers for r264662
Modified:
lldb/trunk/scripts/interface/SBExpressionOptions.i
Modified: lldb/trunk/scripts/interface/SBExpressionOptions.i
Author: labath
Date: Tue Mar 29 07:06:37 2016
New Revision: 264721
URL: http://llvm.org/viewvc/llvm-project?rev=264721&view=rev
Log:
Add ClangUtil.cpp to the xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llv
labath created this revision.
labath added reviewers: tberghammer, clayborg.
labath added a subscriber: lldb-commits.
Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files
(previously, this
attribute was only present in main object files), breaking pretty much every
dwo t
labath marked an inline comment as done.
labath added a comment.
@clayborg: I am going to put this in now, to stabilize the buildbot situation.
I'll be happy to address any concerns in a follow-up commit.
http://reviews.llvm.org/D18547
___
lldb-com
Author: labath
Date: Tue Mar 29 08:42:02 2016
New Revision: 264729
URL: http://llvm.org/viewvc/llvm-project?rev=264729&view=rev
Log:
Fix infinite recursion in DWO file parsing
Summary:
Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files
(previously, this
attribute was o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264729: Fix infinite recursion in DWO file parsing (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D18547?vs=51896&id=51897#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18
labath added inline comments.
Comment at: CMakeLists.txt:3
@@ -2,1 +2,3 @@
+if(MINGW_DEBUG)
+# force debugging info into lldb sources
eran.ifrah wrote:
> labath wrote:
> > Why do we need this? Why is `-DCMAKE_BUILD_TYPE=Debug` not sufficient?
> No. As I ment
labath added a comment.
So, the way I would achieve this is to have a way to specify "i want to run the
tests with hard-float", or "I want to use thumb instruction set" when running
dotest.py and then based on this information, set the correct compiler flags
**and** xfail/skip tests. When we do
Author: labath
Date: Tue Mar 29 09:39:10 2016
New Revision: 264733
URL: http://llvm.org/viewvc/llvm-project?rev=264733&view=rev
Log:
Revert the "build fix" in r264104
this was needed because lldb-mi temporarily contained references to private
lldb symbols
(lldb_private namespace), which it shoul
Author: labath
Date: Tue Mar 29 10:00:26 2016
New Revision: 264735
URL: http://llvm.org/viewvc/llvm-project?rev=264735&view=rev
Log:
Move DynamicLoader plugins to SystemInitializerFull
Summary: These are not needed by lldb-server. Removing them shrinks the server
by about 0.5%.
Reviewers: zturn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264735: Move DynamicLoader plugins to SystemInitializerFull
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18206?vs=50813&id=51917#toc
Repository:
rL LLVM
http://reviews.llv
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a subscriber: lldb-commits.
the inferior in the test deliberately does not lock a mutex when accessing the
watched variable.
The reason for that is unclear as, based on the logs, the original intention of
the t
Author: labath
Date: Wed Mar 30 03:43:54 2016
New Revision: 264846
URL: http://llvm.org/viewvc/llvm-project?rev=264846&view=rev
Log:
Fix flakyness in TestWatchpointMultipleThreads
Summary:
the inferior in the test deliberately does not lock a mutex when accessing the
watched variable.
The reason
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264846: Fix flakyness in TestWatchpointMultipleThreads
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D18558?vs=51929&id=52028#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: labath
Date: Wed Mar 30 03:45:37 2016
New Revision: 264847
URL: http://llvm.org/viewvc/llvm-project?rev=264847&view=rev
Log:
Fix warning in ClangExpressionParser
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins/
Author: labath
Date: Wed Mar 30 04:42:59 2016
New Revision: 264849
URL: http://llvm.org/viewvc/llvm-project?rev=264849&view=rev
Log:
Fix warning in ThreadSanitizerRuntime
Modified:
lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
Modified:
lldb/tr
Author: labath
Date: Wed Mar 30 04:43:04 2016
New Revision: 264850
URL: http://llvm.org/viewvc/llvm-project?rev=264850&view=rev
Log:
Fix SocketAddressTest (again)
On some versions of Windows, the address is returned as "::1", while on others
it's
"0:0:...:0:1". Accept both versions, as they repr
labath created this revision.
labath added reviewers: tberghammer, tfiala.
labath added a subscriber: lldb-commits.
Debug info is used only by the client and lldb-server tests do not even have
the client component
running, as they communicate with the server directly. Therefore, running the
test
labath created this revision.
labath added reviewers: tberghammer, clayborg.
labath added a subscriber: lldb-commits.
In case of Dwo, DIERef stores a compile unit offset in the main object file,
and not in the dwo.
The implementation of SymbolFileDWARFDwo::GetDIE inherited from SymbolFileDWARF
t
Author: labath
Date: Thu Mar 31 08:30:04 2016
New Revision: 265011
URL: http://llvm.org/viewvc/llvm-project?rev=265011&view=rev
Log:
Fix DWO breakage in r264909
Summary:
In case of Dwo, DIERef stores a compile unit offset in the main object file,
and not in the dwo.
The implementation of SymbolF
2001 - 2100 of 6833 matches
Mail list logo
