[Lldb-commits] [lldb] r298058 - Remove HostThreadLinux/Free/NetBSD

Author: labath Date: Fri Mar 17 04:51:23 2017 New Revision: 298058 URL: http://llvm.org/viewvc/llvm-project?rev=298058&view=rev Log: Remove HostThreadLinux/Free/NetBSD Summary: These classes existed only because of the GetName() static function, which can be moved to a more natural place anyway.

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

labath added a subscriber: labath. Comment at: scripts/Python/modules/readline/readline.cpp:17 @@ -15,3 +16,3 @@ moduleDocumentation, "Stub module meant to effectively disable readline support."); Given the code you are adding, this comment seems out o

[Lldb-commits] [lldb] r248889 - Fix TestAttachDenied on linux

Author: labath Date: Wed Sep 30 05:59:39 2015 New Revision: 248889 URL: http://llvm.org/viewvc/llvm-project?rev=248889&view=rev Log: Fix TestAttachDenied on linux This test was timing out because the test inferior was forking a child, which was not terminated correctly. The test contained provis

Re: [Lldb-commits] [PATCH] D13288: Restrict the scope of a hack in DYLDRendezvous

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:421 @@ +420,3 @@ +uint32_t os_major = 0, os_minor = 0, os_update = 0; +if (arch.GetTr

Re: [Lldb-commits] [PATCH] D13291: Make the ArmUnwindInfo parsing code endian independent

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, after fixing some typos. Comment at: include/lldb/Symbol/ArmUnwindInfo.h:55 @@ -46,1 +54,3 @@ + +const ObjectFile& m_objfile; lldb::SectionSP m_arm_exidx_

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

labath added a comment. This is definitely not a proper fix for this problem, it merely sweeps the problem under the carpet. If something like this makes a difference then it means something has gone horribly wrong a long time ago. I haven't been able to reproduce this locally, but I'd recommen

Re: [Lldb-commits] [PATCH] D13300: Run tests with dwo symbol files

labath added a comment. Only small comments from me. Comment at: test/dotest_args.py:63 @@ -62,3 +62,3 @@ group = parser.add_argument_group('Test filtering options') -group.add_argument('-N', choices=['dwarf', 'dsym'], help="Don't do test cases marked with the @dsym de

[Lldb-commits] [lldb] r248995 - Revert "Fixing a subtle issue on Mac OS X systems with dSYMs..."

Author: labath Date: Thu Oct 1 04:03:33 2015 New Revision: 248995 URL: http://llvm.org/viewvc/llvm-project?rev=248995&view=rev Log: Revert "Fixing a subtle issue on Mac OS X systems with dSYMs..." This reverts commit r248985, as it was breaking all remote expression-evaluating tests (on android

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

Hi, I have reverted this as it was causing many failures on our remote android buildbots . I am hoping I will get a chance to investigate and give you a more accurate error description by EOD (your morning). Given that

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

From one of the failing tests: === runCmd: expr release_child_flag = 1 output: (volatile int) $0 = 1 Expecting sub string: = 1 Matched runCmd: print (int)getpgid(0) runCmd failed! error: use of undeclared identifier 'getpgid' error: 1 errors parsing expression === he

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added subscribers: emaste, labath. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// This platform code looks like it was copy-pasted from Platform

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// krytarowski wrote: > labath wrote: > > This platform code looks like it wa

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// krytarowski wrote: > labath wrote: > > krytarowski wrote: > > > labath wro

Re: [Lldb-commits] [lldb] r249020 - [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target

On 1 October 2015 at 16:05, Sagar Thakur via lldb-commits wrote: > +printf("Symbol: name=%s, Type:%d value=%08lx\n", symbol_name, > symbol_type, symbol.st_value); > + You seem to have left a debugging statement in. :) ___ lldb-commits mailing l

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of global variables

labath added a subscriber: labath. labath added a comment. Could you please put the examples you cite above into the test suite? http://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [PATCH] D13380: Fix several issues around .ARM.exidx section handling

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good http://reviews.llvm.org/D13380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

labath added a comment. In http://reviews.llvm.org/D13362#258314, @tfiala wrote: > The OS X one seems to be related to load (not terribly surprising). I'm > seeing timeouts as I crank up the --threads. But I don't think that's the > whole story. On the Linux side, I've been cranking down th

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

labath added a comment. In http://reviews.llvm.org/D13362#258972, @tfiala wrote: > I've fixed: > https://llvm.org/bugs/show_bug.cgi?id=25019 > > I think for now I am not interested in trying to tackle the intent of this > change as it unduly complicates the timeout detection logic. > > I am oka

Re: [Lldb-commits] [PATCH] D13462: Fix virtual/override warnings in new MIPS code.

labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. I think you can commit things like this as obvious. :) http://reviews.llvm.org/D13462 ___

Re: [Lldb-commits] [PATCH] D13503: commands: Use override instead of virtual.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. You can also fix a couple of style issues, if you feel like it (or just keep it in mind for next time). Comment at: source/Commands/CommandObjectMemory.cpp:381 @@

[Lldb-commits] [lldb] r249554 - Resumbit "Fix race condition during process detach"

Author: labath Date: Wed Oct 7 10:11:11 2015 New Revision: 249554 URL: http://llvm.org/viewvc/llvm-project?rev=249554&view=rev Log: Resumbit "Fix race condition during process detach" This is a resubmission of r248371. It also incorporates the process event hijack patch by Kyrill Lapshin in D12

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

labath added a comment. I have committed http://reviews.llvm.org/D13056 with the event hijacking portion from your patch. I think your use case should be working now. I am planning to return to this later, as I believe there are still some edge cases lurking here. Repository: rL LLVM http:

Re: [Lldb-commits] [PATCH] D13581: Remove long-forgotten plugin virtuals.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] r249819 - Fix disabling of dwo tests

Author: labath Date: Fri Oct 9 05:09:36 2015 New Revision: 249819 URL: http://llvm.org/viewvc/llvm-project?rev=249819&view=rev Log: Fix disabling of dwo tests without this, dwo tests would be run even if they were meant to be disabled. Modified: lldb/trunk/test/dotest.py Modified: lldb/tru

[Lldb-commits] [PATCH] D13583: dotest.py: Remove useless AttributeError catches

labath created this revision. labath added reviewers: zturner, tfiala. labath added subscribers: lldb-commits, iancottrell. Test decorators were ignoring AttributeError exceptions. These were introduced three years ago, and copied to all decorators. They seem to serve no purpose and removing them

[Lldb-commits] [lldb] r249823 - Rename one of the TestGoASTContexts

Author: labath Date: Fri Oct 9 06:15:50 2015 New Revision: 249823 URL: http://llvm.org/viewvc/llvm-project?rev=249823&view=rev Log: Rename one of the TestGoASTContexts Added: lldb/trunk/test/lang/go/runtime/TestGoLanguageRuntime - copied, changed from r249819, lldb/trunk/test/lang/go/

[Lldb-commits] [PATCH] D13588: dotest.py: Fail if we detect multiple tests with the same name

labath created this revision. labath added reviewers: tberghammer, zturner. labath added subscribers: lldb-commits, iancottrell. Log files produced by dotest have names derived from the test name, and this produces errors in case we have multiple tests with the same name. Additionally, it's good

[Lldb-commits] [lldb] r249828 - dotest.py: Fail if we detect multiple tests with the same name

Author: labath Date: Fri Oct 9 07:48:17 2015 New Revision: 249828 URL: http://llvm.org/viewvc/llvm-project?rev=249828&view=rev Log: dotest.py: Fail if we detect multiple tests with the same name Summary: Log files produced by dotest have names derived from the test name, and this produces error

Re: [Lldb-commits] [PATCH] D13588: dotest.py: Fail if we detect multiple tests with the same name

This revision was automatically updated to reflect the committed changes. Closed by commit rL249828: dotest.py: Fail if we detect multiple tests with the same name (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13588?vs=36939&id=36941#toc Repository: rL LLVM http://

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

labath added a subscriber: labath. labath added a comment. The fact that LinuxSignals specifies different numbers and dispositions for SIGCHLD and SIGCLD is certainly a bug. If you fix that, then your alternative (2) becomes feasible. I think (2) is a better solution than the current proposed o

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added a comment. I would like to see these platforms merged, but I don't think that is up to me. Feel free to go ahead. Repository: rL LLVM http://reviews.llvm.org/D13334 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

Re: [Lldb-commits] [PATCH] D13625: Support RHEL 7 and similar systems that use architecture-specific Python lib dirs.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Could you submit the change with full context next time? It makes review much easier. I don't understand what are you trying to achieve completely, but it feels to me you are trying

Re: [Lldb-commits] [PATCH] D13583: dotest.py: Remove useless AttributeError catches

This revision was automatically updated to reflect the committed changes. Closed by commit rL250038: dotest.py: Remove useless AttributeError catches (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13583?vs=36933&id=37102#toc Repository: rL LLVM http://reviews.llvm.o

[Lldb-commits] [lldb] r250038 - dotest.py: Remove useless AttributeError catches

Author: labath Date: Mon Oct 12 08:42:16 2015 New Revision: 250038 URL: http://llvm.org/viewvc/llvm-project?rev=250038&view=rev Log: dotest.py: Remove useless AttributeError catches Summary: Test decorators were ignoring AttributeError exceptions. These were introduced three years ago, and copie

Re: [Lldb-commits] [PATCH] D13625: Support RHEL 7 and similar systems that use architecture-specific Python lib dirs.

labath added a comment. In http://reviews.llvm.org/D13625#264862, @tfiala wrote: > In http://reviews.llvm.org/D13625#264786, @labath wrote: > > > Could you submit the change with full context next time? It makes review > > much easier. > > > Tell me the diff line you want. I'm doing the same ty

Re: [Lldb-commits] [PATCH] D13625: Support RHEL 7 and similar systems that use architecture-specific Python lib dirs.

labath added a comment. In http://reviews.llvm.org/D13625#264888, @tfiala wrote: > > Tell me the diff line you want. I'm doing the same type of diffs I have > > submitted for years. I'll adjust my process. > > > Are you wanting something like this (assuming done with git diff)? > git diff --no-

Re: [Lldb-commits] [PATCH] D13625: Support RHEL 7 and similar systems that use architecture-specific Python lib dirs.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > RHEL 7 is already doing this - most of lib is 64-bit. All of lib64 is > 64-bit. They already use both (~600 MB in lib, ~1GB in lib64 on a stock > system). I have also built custom pythons

Re: [Lldb-commits] [PATCH] D13652: Change ConstString to support massive multi-threaded access

labath added a comment. Looks reasonable to me, but please with for ok from clayborg. http://reviews.llvm.org/D13652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250069 - TestAttachResume is still flaky on linux. mark it as such

Author: labath Date: Mon Oct 12 12:43:03 2015 New Revision: 250069 URL: http://llvm.org/viewvc/llvm-project?rev=250069&view=rev Log: TestAttachResume is still flaky on linux. mark it as such Modified: lldb/trunk/test/functionalities/attach_resume/TestAttachResume.py Modified: lldb/trunk/test

[Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

labath created this revision. labath added reviewers: tberghammer, jasonmolenda. labath added subscribers: lldb-commits, iancottrell. This commit adds support for binary memory reads ($x) to lldb-server. It also removes the "0x" prefix from the $x client packet, to make it more compatible with th

Re: [Lldb-commits] [PATCH] D13667: cmake: provide flag that enables 'log enable --stack' to provide useful file/line info on POSIX systems

labath added a comment. sounds reasonable http://reviews.llvm.org/D13667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250280 - Mark TestBatchMode as flaky on linux

Author: labath Date: Wed Oct 14 03:57:55 2015 New Revision: 250280 URL: http://llvm.org/viewvc/llvm-project?rev=250280&view=rev Log: Mark TestBatchMode as flaky on linux Modified: lldb/trunk/test/driver/batch_mode/TestBatchMode.py Modified: lldb/trunk/test/driver/batch_mode/TestBatchMode.py

[Lldb-commits] [lldb] r250282 - Fix compiler warnings in ScriptInterpreterPython

Author: labath Date: Wed Oct 14 04:18:23 2015 New Revision: 250282 URL: http://llvm.org/viewvc/llvm-project?rev=250282&view=rev Log: Fix compiler warnings in ScriptInterpreterPython Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

labath added a subscriber: labath. labath added a comment. Hi Ewan, this commit introduces a new warning: lldb/source/Commands/CommandObjectMemory.cpp:1502:21: warning: enumeration value 'eFormatVectorOfFloat16' not handled in switch [-Wswitch] switch (m_format_options.GetFormat

[Lldb-commits] [lldb] r250290 - Revert "RenderScript command for printing allocation contents"

Author: labath Date: Wed Oct 14 06:50:37 2015 New Revision: 250290 URL: http://llvm.org/viewvc/llvm-project?rev=250290&view=rev Log: Revert "RenderScript command for printing allocation contents" This commit breaks TestDataFormatterSmartArray on all buildbots. Modified: lldb/trunk/include/ll

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

labath added a comment. Hi, I have reverted this as all the bots were getting red. In the test, variable was getting printed as `[{},{},{},{},{},{},{}]` instead of `{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}`. Please resubmit once the issue is resolved. Repository: rL LLVM http://

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

labath updated this revision to Diff 37340. labath added a comment. The new functionality gets picked up by the client and automatically used everywhere, so I'm not really worried about testing it. A more important issue would be making sure that the legacy read packet does not rot as it is now

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

labath updated this revision to Diff 37341. labath added a comment. Remove files which slipped in... http://reviews.llvm.org/D13695 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h source/Plu

[Lldb-commits] [lldb] r250295 - lldb-server: add support for binary memory reads

Author: labath Date: Wed Oct 14 07:59:37 2015 New Revision: 250295 URL: http://llvm.org/viewvc/llvm-project?rev=250295&view=rev Log: lldb-server: add support for binary memory reads Summary: This commit adds support for binary memory reads ($x) to lldb-server. It also removes the "0x" prefix fro

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

This revision was automatically updated to reflect the committed changes. Closed by commit rL250295: lldb-server: add support for binary memory reads (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13695?vs=37341&id=37342#toc Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Although it may not seem from the number of my comments, I actually quite like this implementation. However, I think more work needs to be done to make this future-proof. - we defin

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

labath accepted this revision. labath added a comment. Looks good, with some random comments you can ignore. Comment at: include/lldb/Host/Socket.h:55 @@ -55,1 +54,3 @@ +virtual Error Connect(llvm::StringRef host_and_port); +virtual Error Listen(llvm::StringRef host_an

[Lldb-commits] [lldb] r250409 - Fix temporary directory computation on linux (pr25147)

Author: labath Date: Thu Oct 15 09:44:29 2015 New Revision: 250409 URL: http://llvm.org/viewvc/llvm-project?rev=250409&view=rev Log: Fix temporary directory computation on linux (pr25147) On linux, the environment variables for temp directories that lldb checks for are generally not defined, and

[Lldb-commits] [lldb] r250412 - Revert "Fix temporary directory computation on linux (pr25147)"

Author: labath Date: Thu Oct 15 09:46:46 2015 New Revision: 250412 URL: http://llvm.org/viewvc/llvm-project?rev=250412&view=rev Log: Revert "Fix temporary directory computation on linux (pr25147)" I actually did not want to commit this without review, but I mistyped. :/ Modified: lldb/trunk/

[Lldb-commits] [PATCH] D13772: Fix temporary directory computation on linux (pr25147)

labath created this revision. labath added reviewers: clayborg, tberghammer. labath added subscribers: emaste, lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. On linux, the environment variables for temp directories that lldb checks for are generally not defined, and the

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

labath added a comment. This looks much better, I just have a couple of small remarks. Comment at: include/lldb/Target/UnixSignals.h:116 @@ -114,1 +115,3 @@ + const char *description, + const char *alias = NULL); nullptr ==

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

labath added inline comments. Comment at: source/Host/posix/DomainSocket.cpp:74 @@ +73,3 @@ +FileSystem::Unlink(FileSpec{name, true}); + +Error error; If we're going to use unique names, then this won't be necessary (and I would much rather see a random e

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

labath added a subscriber: labath. labath added a comment. Not really my area, but couldn't the needed functionality be implemented on top of GetChildAtIndex(). I mean, if GetChildAtIndex(50) returns a valid SBValue, then the container has at least 50 elements, right? Then `HasAtLeastNChildren(n

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

labath added a comment. Zachary, I don't think using std::async is a good idea because it provides a very different threading model than the one we want here. Let me demonstrate that with an example: #include #include #include #include #include using namespace std; u

[Lldb-commits] [lldb] r250502 - Fix temporary directory computation on linux (pr25147)

Author: labath Date: Fri Oct 16 04:32:05 2015 New Revision: 250502 URL: http://llvm.org/viewvc/llvm-project?rev=250502&view=rev Log: Fix temporary directory computation on linux (pr25147) Summary: On linux, the environment variables for temp directories that lldb checks for are generally not def

Re: [Lldb-commits] [PATCH] D13772: Fix temporary directory computation on linux (pr25147)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250502: Fix temporary directory computation on linux (pr25147) (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13772?vs=37485&id=37565#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

labath added a comment. In http://reviews.llvm.org/D13727#268747, @tberghammer wrote: > Based on Pavel's example and some additional experimenting we done I am not > sure if std::async will give us any benefit even on Windows as it don't limit > the number of threads to the number of cores (bec

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

labath added a comment. How big of an error does it have to be for that to happen? Is that something we would consider an "lldb bug"/"data formatter bug" or it can be caused by something out of our control, like missing debug info on one of the children? http://reviews.llvm.org/D13778 _

[Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath created this revision. labath added reviewers: clayborg, tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. ADB packets have a fixed size of 4k. This means the size of memory reads does not affect speed too much (as long as it f

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

labath added a subscriber: labath. labath added a comment. If the registers are not present, wouldn't it be better to *not* include them in qRegisterInfo response in the first place? Repository: rL LLVM http://reviews.llvm.org/D13859 ___ lldb-co

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this can go in now. Currently, the paralelization happens on compile unit level, and the test programs generally only have one compile unit. Since the threads are created on an as-need

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath updated this revision to Diff 37776. labath added a comment. Adress review comments. http://reviews.llvm.org/D13812 Files: include/lldb/Target/Platform.h source/Plugins/Platform/Android/PlatformAndroid.cpp source/Plugins/Platform/Android/PlatformAndroid.h source/Target/Process.cp

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath added a comment. New version of the patch. I agree that it looks better like this. I have put the setting logic in the process constructor, rather than doing it lazily - if anyone was observing the setting value, it would seem strange that the value of setting changed suddenly after the

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

labath added a comment. I *think* it looks good, but I find it quite hard to review a change of this size. A wise man once said "if your commit description contains bullet points, you are doing too much". I think it would be better to split up changes like this in the future. > Make PlatformRe

[Lldb-commits] [lldb] r250814 - Increase default memory cache line size for android

Author: labath Date: Tue Oct 20 05:33:17 2015 New Revision: 250814 URL: http://llvm.org/viewvc/llvm-project?rev=250814&view=rev Log: Increase default memory cache line size for android Summary: ADB packets have a maximum size of 4k. This means the size of memory reads does not affect speed too m

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath added a comment. Good catch. fixed and committed. Repository: rL LLVM http://reviews.llvm.org/D13812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

This revision was automatically updated to reflect the committed changes. Closed by commit rL250814: Increase default memory cache line size for android (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13812?vs=37776&id=37845#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath added a comment. I believe adding this to qHostInfo is over-engineering at the moment. But it's a good idea, and we can do it if we have a need for more control of this in the future. Repository: rL LLVM http://reviews.llvm.org/D13812 __

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

labath added a comment. I think this should go in a little bit deeper, i.e., inside the NativeRegisterContextLinux_mips, or whatever is the right class for you. I think this is better for several reasons: - if the register is physically not present, the register context should not report it (t

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

labath added a comment. > When such an error occurs, it is unlikely to be an lldb bug, or > data-formatter bug. One can come up with a data structure for which reading a > child element would require complete debug info, but reading the # of child > elements need not require complete debug info

[Lldb-commits] [PATCH] D13902: [DataFormatters] Make libc++ list loop detection linear

labath created this revision. labath added a reviewer: granata.enrico. labath added subscribers: sivachandra, lldb-commits. Loop detection code is being called before every element access. Although it tries to cache some of the data by remembering the loop-free initial segment, every time it need

Re: [Lldb-commits] [lldb] r248028 - Make libc++ tests skip themselves if libc++ is not actually loaded in the target

Hi Enrico, Could you explain what was the motivation behind this change? I am asking because, I have just learned that this commit has caused all libc++ tests to be skipped on linux*, silently decreasing test coverage on linux. I would like to replace this with some other mechanism, which is not

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

labath accepted this revision. labath added a comment. looks good, thanks. Comment at: source/Plugins/Platform/Android/AdbClient.cpp:151 @@ +150,3 @@ +char message[PATH_MAX]; +snprintf (message, sizeof (message), "forward:tcp:%d;localfilesystem:%s", local_port, remote_s

Re: [Lldb-commits] [PATCH] D13902: [DataFormatters] Make libc++ list loop detection linear

This revision was automatically updated to reflect the committed changes. Closed by commit rL250890: [DataFormatters] Make libc++ list loop detection linear (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13902?vs=37891&id=37981#toc Repository: rL LLVM http://reviews

[Lldb-commits] [lldb] r250890 - [DataFormatters] Make libc++ list loop detection linear

Author: labath Date: Wed Oct 21 05:17:21 2015 New Revision: 250890 URL: http://llvm.org/viewvc/llvm-project?rev=250890&view=rev Log: [DataFormatters] Make libc++ list loop detection linear Summary: Loop detection code is being called before every element access. Although it tries to cache some o

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

labath added a subscriber: labath. labath added a comment. Hi, you seem to have an out-of-bounds access here: /lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1629:5: warning: array index 3 is past the end of the array (which contains 3 elements) [-Wa

[Lldb-commits] [lldb] r250896 - Clean up more .dwo files after the tests run

Author: labath Date: Wed Oct 21 07:56:37 2015 New Revision: 250896 URL: http://llvm.org/viewvc/llvm-project?rev=250896&view=rev Log: Clean up more .dwo files after the tests run Modified: lldb/trunk/test/lang/cpp/incomplete-types/Makefile lldb/trunk/test/make/Makefile.rules lldb/trunk

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D13948: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

labath created this revision. labath added reviewers: clayborg, jingham. labath added a subscriber: lldb-commits. This short-circuits the GetObjCVersion function to avoid iterating through target modules on non-apple targets. This function is called on every Process::IsDynamicValue call, so this

Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

labath accepted this revision. labath added a comment. The new version of the patch looks much cleaner than the old one. Thanks. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:641 @@ -669,3 +640,3 @@ { -if (m_flags.IsClear (got_flag)) +std::call_once(da

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

labath added a subscriber: labath. Comment at: test/make/Makefile.rules:304 @@ -303,3 +303,3 @@ else - CXXFLAGS += -stdlib=libc++ + CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP LDFLAGS += -stdlib

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

Re: [Lldb-commits] [PATCH] D13948: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL251004: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13948?vs=38020&id=38103#toc Repository: rL

[Lldb-commits] [lldb] r251004 - [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

Author: labath Date: Thu Oct 22 04:34:40 2015 New Revision: 251004 URL: http://llvm.org/viewvc/llvm-project?rev=251004&view=rev Log: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets Summary: This short-circuits the GetObjCVersion function to avoid iterating through ta

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks reasonable Repository: rL LLVM http://reviews.llvm.org/D13602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

labath added a subscriber: labath. labath added a comment. Could you also file a bug about that? most of these are real problems I think, and we should not forget them... http://reviews.llvm.org/D13981 ___ lldb-commits mailing list lldb-commits@lis

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

labath added a subscriber: labath. labath added a comment. I don't think we should bump the version over a trivial issue like this. cmake 2.8 is still the default on alot of systems. Wouldn't a well placed quote work also? Like, `FOO="${BAR}" codesign --force --end` Or just putting the command i

[Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

labath created this revision. labath added reviewers: granata.enrico, tfiala. labath added a subscriber: lldb-commits. The list of loaded modules which skip_if_library_missing is depending on is not available on linux until after we run the target. This causes the tests to be wrongfully skipped.

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL251102: Enable the libc++ tests on linux (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13985?vs=38129&id=38221#toc Repository: rL LLVM http://reviews.llvm.org/D13985 Files

[Lldb-commits] [lldb] r251102 - Enable the libc++ tests on linux

Author: labath Date: Fri Oct 23 04:17:30 2015 New Revision: 251102 URL: http://llvm.org/viewvc/llvm-project?rev=251102&view=rev Log: Enable the libc++ tests on linux Summary: The list of loaded modules which skip_if_library_missing is depending on is not available on linux until after we run the

[Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

labath created this revision. labath added reviewers: tberghammer, tfiala, granata.enrico, zturner. labath added a subscriber: lldb-commits. Per discussions on the mailing list, I have implemented a decorator which annotates individual test methods with categories. I have used this framework to r

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

labath added a comment. test_categories is the name of .py file. :/ How about `add_test_categories` ? http://reviews.llvm.org/D14020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

Re: [Lldb-commits] [PATCH] D14020: Port the python api decorator to use test categories

This revision was automatically updated to reflect the committed changes. Closed by commit rL251277: Port the python api decorator to use test categories (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14020?vs=38235&id=38383#toc Repository: rL LLVM http://reviews.ll

[Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

labath created this revision. labath added reviewers: tfiala, dawn, ki.stfu, abidh. labath added a subscriber: lldb-commits. This change deprecates -m/+m dotest options (the options are still recognized but they print an error message pointing to the new options) and adds a new lldb-mi test categ

Re: [Lldb-commits] [PATCH] D14060: Deprecate -m/+m dotest options in favor of test categories

labath added a comment. In http://reviews.llvm.org/D14060#274952, @tberghammer wrote: > Before commit please sync with Ying about updating all android build bot to > still skip the MI tests after the change. I've got it covered. :) I will commit this tomorrow, to give more people a chance to

<    8   9   10   11   12   13   14   15   16   17   >