Re: [Lldb-commits] [PATCH] D13503: commands: Use override instead of virtual.

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. You can also fix a couple of style issues, if you feel like it (or 
just keep it in mind for next time).


================
Comment at: source/Commands/CommandObjectMemory.cpp:381
@@ -380,3 +380,3 @@
 
-    virtual const char *GetRepeatCommand (Args &current_command_args, uint32_t 
index)
+    const char *GetRepeatCommand (Args &current_command_args, uint32_t index) 
override
     {
----------------
You might as well reformat this when you are touching it (line break after the 
type).

================
Comment at: source/Commands/CommandObjectMemory.cpp:1719
@@ -1718,3 +1718,3 @@
     
-    virtual const char *GetRepeatCommand (Args &current_command_args, uint32_t 
index)
+    const char *GetRepeatCommand (Args &current_command_args, uint32_t index) 
override
     {
----------------
same here

================
Comment at: source/Commands/CommandObjectProcess.cpp:179
@@ -178,3 +178,3 @@
 
-    virtual const char *GetRepeatCommand (Args &current_command_args, uint32_t 
index)
+    const char *GetRepeatCommand (Args &current_command_args, uint32_t index) 
override
     {
----------------
and here


http://reviews.llvm.org/D13503



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits