[Lldb-commits] [lldb] r294036 - Add a missing break statement

2017-02-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 3 14:26:57 2017 New Revision: 294036 URL: http://llvm.org/viewvc/llvm-project?rev=294036&view=rev Log: Add a missing break statement Modified: lldb/trunk/source/Commands/CommandObjectLog.cpp Modified: lldb/trunk/source/Commands/CommandObjectLog.cpp URL: http://

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Pavel Labath via lldb-commits
esitant since it doesn't look like it's fixing a > regression. Pavel, what do you think? > > On Fri, Feb 3, 2017 at 9:42 AM, Pavel Labath via lldb-commits > wrote: >> Author: labath >> Date: Fri Feb 3 11:42:04 2017 >> New Revision: 294019 >> >>

[Lldb-commits] [lldb] r294113 - Remove LIBLLDB_LOG_VERBOSE category

2017-02-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Sat Feb 4 18:44:54 2017 New Revision: 294113 URL: http://llvm.org/viewvc/llvm-project?rev=294113&view=rev Log: Remove LIBLLDB_LOG_VERBOSE category Summary: Per discussion in D28616, having two ways two request logging (log enable lldb XXX verbose && log enable -v lldb XXX) i

[Lldb-commits] [lldb] r294114 - Clean up PlatformLinux code

2017-02-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Sat Feb 4 19:04:10 2017 New Revision: 294114 URL: http://llvm.org/viewvc/llvm-project?rev=294114&view=rev Log: Clean up PlatformLinux code don't create a platform.linux setting category, as it contains no actual settings, and I don't forsee adding any soon. Also remove some

[Lldb-commits] [lldb] r294211 - Fix missing include in NativeProcessLinux

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 12:36:58 2017 New Revision: 294211 URL: http://llvm.org/viewvc/llvm-project?rev=294211&view=rev Log: Fix missing include in NativeProcessLinux Modified: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp Modified: lldb/trunk/source/Plugins/Process/

[Lldb-commits] [lldb] r294215 - Really fix build on non-windows platforms :)

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 12:56:34 2017 New Revision: 294215 URL: http://llvm.org/viewvc/llvm-project?rev=294215&view=rev Log: Really fix build on non-windows platforms :) Modified: lldb/trunk/source/Host/common/Host.cpp Modified: lldb/trunk/source/Host/common/Host.cpp URL: http://llv

[Lldb-commits] [lldb] r294219 - Remove the verbose category in the dwarf channel

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 13:19:30 2017 New Revision: 294219 URL: http://llvm.org/viewvc/llvm-project?rev=294219&view=rev Log: Remove the verbose category in the dwarf channel Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp lldb/trunk/source/Plugins/SymbolF

[Lldb-commits] [lldb] r294222 - Fix darwin build (error.PutToLog fallout)

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 13:31:02 2017 New Revision: 294222 URL: http://llvm.org/viewvc/llvm-project?rev=294222&view=rev Log: Fix darwin build (error.PutToLog fallout) Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL: http://llvm.org

[Lldb-commits] [lldb] r294223 - Remove the verbose category in the posix channel

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 13:31:05 2017 New Revision: 294223 URL: http://llvm.org/viewvc/llvm-project?rev=294223&view=rev Log: Remove the verbose category in the posix channel replace by LLDB_LOGV Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp lldb/trunk/sour

[Lldb-commits] [lldb] r294224 - Remove the verbose category in the gdb-remote channel

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 13:31:09 2017 New Revision: 294224 URL: http://llvm.org/viewvc/llvm-project?rev=294224&view=rev Log: Remove the verbose category in the gdb-remote channel replace by LLDB_LOGV Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

[Lldb-commits] [lldb] r294221 - Fix darwin build (llvm::once_flag fallout)

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 13:30:59 2017 New Revision: 294221 URL: http://llvm.org/viewvc/llvm-project?rev=294221&view=rev Log: Fix darwin build (llvm::once_flag fallout) Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp lldb/trunk/tools/debugserver/sourc

[Lldb-commits] [lldb] r294243 - Switch PlatformLinux to LLDB_LOG

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 15:30:44 2017 New Revision: 294243 URL: http://llvm.org/viewvc/llvm-project?rev=294243&view=rev Log: Switch PlatformLinux to LLDB_LOG Modified: lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp Modified: lldb/trunk/source/Plugins/Platform/Linux/Platfo

[Lldb-commits] [lldb] r294244 - Remove verbose category in the kdp channel

2017-02-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 6 15:46:22 2017 New Revision: 294244 URL: http://llvm.org/viewvc/llvm-project?rev=294244&view=rev Log: Remove verbose category in the kdp channel Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/trunk/source/Plugins/Process/

[Lldb-commits] [lldb] r294549 - [cmake] add missing dependency lldbCommands->lldbBase

2017-02-08 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 8 19:17:34 2017 New Revision: 294549 URL: http://llvm.org/viewvc/llvm-project?rev=294549&view=rev Log: [cmake] add missing dependency lldbCommands->lldbBase CommandObjectVersion.cpp calls lldb_private::GetVersion (present in lldbBase). This should fix the unittest l

[Lldb-commits] [lldb] r294736 - Convert Log class to llvm streams

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 05:49:21 2017 New Revision: 294736 URL: http://llvm.org/viewvc/llvm-project?rev=294736&view=rev Log: Convert Log class to llvm streams Summary: This converts LLDB's logging to use llvm streams instead of lldb_private::Stream and friends. The changes are mostly stra

[Lldb-commits] [lldb] r294739 - Switch TestPacketSpeedJSON to use the llvm chrono formatter

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 05:49:40 2017 New Revision: 294739 URL: http://llvm.org/viewvc/llvm-project?rev=294739&view=rev Log: Switch TestPacketSpeedJSON to use the llvm chrono formatter Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/tr

[Lldb-commits] [lldb] r294737 - Improve asserts in TestWatchpointIgnoreCount

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 05:49:25 2017 New Revision: 294737 URL: http://llvm.org/viewvc/llvm-project?rev=294737&view=rev Log: Improve asserts in TestWatchpointIgnoreCount This test is flaky on the windows->android bot. Change assertTrue to assertEqual in the hope better error messages will

[Lldb-commits] [lldb] r294738 - Add a format_provider for the Timeout class

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 05:49:33 2017 New Revision: 294738 URL: http://llvm.org/viewvc/llvm-project?rev=294738&view=rev Log: Add a format_provider for the Timeout class and use it in the appropriate log statements. Formatting of chrono types in log messages was very clunky. This should m

[Lldb-commits] [lldb] r294741 - UriParser cleanup

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 06:21:22 2017 New Revision: 294741 URL: http://llvm.org/viewvc/llvm-project?rev=294741&view=rev Log: UriParser cleanup - move the header file to the include folder - enclose the class in the proper namespace Added: lldb/trunk/include/lldb/Utility/UriParser.h

[Lldb-commits] [lldb] r294743 - Fix darwin and windows builds broken by r294736

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 06:32:43 2017 New Revision: 294743 URL: http://llvm.org/viewvc/llvm-project?rev=294743&view=rev Log: Fix darwin and windows builds broken by r294736 Update the platform-specific log classes to match the new interface. Modified: lldb/trunk/source/Plugins/Proces

[Lldb-commits] [lldb] r294744 - Really fix windows build

2017-02-10 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 10 07:04:32 2017 New Revision: 294744 URL: http://llvm.org/viewvc/llvm-project?rev=294744&view=rev Log: Really fix windows build this time I have actually tried that it compiles on windows. Modified: lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows

[Lldb-commits] [lldb] r294939 - Clean up debug logging

2017-02-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 13 05:03:17 2017 New Revision: 294939 URL: http://llvm.org/viewvc/llvm-project?rev=294939&view=rev Log: Clean up debug logging Summary: We've had two ways to print a "debug" log message. - Log::GetDebug() was testing a Stream flag which was never set. - Log::Debug() w

[Lldb-commits] [lldb] r294940 - Remove some dead code from ProcessPOSIXLog

2017-02-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 13 05:03:24 2017 New Revision: 294940 URL: http://llvm.org/viewvc/llvm-project?rev=294940&view=rev Log: Remove some dead code from ProcessPOSIXLog Modified: lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIXLog.cpp lldb/trunk/source/Plugins/Process/POSIX/Pro

[Lldb-commits] [lldb] r294944 - Try to fix windows build (broken by r294939)

2017-02-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 13 05:56:19 2017 New Revision: 294944 URL: http://llvm.org/viewvc/llvm-project?rev=294944&view=rev Log: Try to fix windows build (broken by r294939) log->Debug is gone, switch to using log->Verbose Modified: lldb/trunk/source/Plugins/Process/Windows/Common/Debugg

[Lldb-commits] [lldb] r295047 - XFAIL TestNameLookup for GCC

2017-02-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 14 06:06:54 2017 New Revision: 295047 URL: http://llvm.org/viewvc/llvm-project?rev=295047&view=rev Log: XFAIL TestNameLookup for GCC I think I have a fix for this, but it needs review. This should keep the bots happy until then. Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r295171 - Fix unittests after r295088

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 06:27:19 2017 New Revision: 295171 URL: http://llvm.org/viewvc/llvm-project?rev=295171&view=rev Log: Fix unittests after r295088 This resurrects TestModule.so which got lost during the move and is needed for the ModuleCache test. Added: lldb/trunk/unittests/Ta

[Lldb-commits] [lldb] r295170 - Fix TestNameLookup for GCC

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 06:27:16 2017 New Revision: 295170 URL: http://llvm.org/viewvc/llvm-project?rev=295170&view=rev Log: Fix TestNameLookup for GCC Summary: GCC emits also symbols for the __PRETTY_FUNCTION__ virtual variable, which we accidentaly pick up when looking for functions for

[Lldb-commits] [lldb] r295189 - Fix debug build of unit tests

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 10:11:51 2017 New Revision: 295189 URL: http://llvm.org/viewvc/llvm-project?rev=295189&view=rev Log: Fix debug build of unit tests Summary: It turns out listing each library twice is not enough to resolve all references in a debug build on linux - a number of execu

[Lldb-commits] [lldb] r295190 - Refactor log channel registration mechanism

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 10:11:59 2017 New Revision: 295190 URL: http://llvm.org/viewvc/llvm-project?rev=295190&view=rev Log: Refactor log channel registration mechanism Summary: We currently have two log channel registration mechanisms. One uses a set of function pointers and the other on

[Lldb-commits] [lldb] r295201 - Revert "Refactor log channel registration mechanism"

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 11:13:19 2017 New Revision: 295201 URL: http://llvm.org/viewvc/llvm-project?rev=295201&view=rev Log: Revert "Refactor log channel registration mechanism" The change breaks on Windows and NetBSD bots. Revert while I investigate. Modified: lldb/trunk/include/lld

[Lldb-commits] [lldb] r295211 - Skip TestStepOverBreakpoint on windows

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 12:04:50 2017 New Revision: 295211 URL: http://llvm.org/viewvc/llvm-project?rev=295211&view=rev Log: Skip TestStepOverBreakpoint on windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoi

[Lldb-commits] [lldb] r295328 - Fix build due to clang r295311

2017-02-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 16 09:32:19 2017 New Revision: 295328 URL: http://llvm.org/viewvc/llvm-project?rev=295328&view=rev Log: Fix build due to clang r295311 BuiltinType::Kind::OCLNDRange was removed. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/S

[Lldb-commits] [lldb] r295345 - NPL: Fix single step workaround

2017-02-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 16 12:12:04 2017 New Revision: 295345 URL: http://llvm.org/viewvc/llvm-project?rev=295345&view=rev Log: NPL: Fix single step workaround While refactoring the code in r293046 I made a very basic error - relying on destructor side-effects of a copyable object. Fix that

[Lldb-commits] [lldb] r295436 - Fix breakage caused by r295368

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 04:19:46 2017 New Revision: 295436 URL: http://llvm.org/viewvc/llvm-project?rev=295436&view=rev Log: Fix breakage caused by r295368 Also move the ErrorTest into the Utility package, to follow the class it is testing. Added: lldb/trunk/unittests/Utility/ErrorTe

Re: [Lldb-commits] [lldb] r295369 - Fix build

2017-02-17 Thread Pavel Labath via lldb-commits
Hey Zach, after you think you've fixed the build, could you check back on the buildbot to make sure that it actually fixes things? In this case you would've seen that after the build is fixed, the next thing it runs into is about a dozen test failures. In fact, this breakage was something that wo

[Lldb-commits] [lldb] r295440 - NPL: Fix one more bug in the single step workaround

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 05:48:34 2017 New Revision: 295440 URL: http://llvm.org/viewvc/llvm-project?rev=295440&view=rev Log: NPL: Fix one more bug in the single step workaround In the case we are stepping over the thread creation instruction, we will end up calling Thread::SingleStep back

[Lldb-commits] [lldb] r295443 - Fix VASprintfTest on darwin

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 07:27:50 2017 New Revision: 295443 URL: http://llvm.org/viewvc/llvm-project?rev=295443&view=rev Log: Fix VASprintfTest on darwin The way of injecting an error into the printf call was not working on darwin - the C library still happily format the character. It only

[Lldb-commits] [lldb] r295442 - Reapply "Refactor log channel registration mechanism"

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 07:27:42 2017 New Revision: 295442 URL: http://llvm.org/viewvc/llvm-project?rev=295442&view=rev Log: Reapply "Refactor log channel registration mechanism" Changes wrt. previous version: - add #include : fix build on windows - add extra {} around the string literals

[Lldb-commits] [lldb] r295445 - Fix compiler warnings for missing switch cases in lldb.

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 07:39:50 2017 New Revision: 295445 URL: http://llvm.org/viewvc/llvm-project?rev=295445&view=rev Log: Fix compiler warnings for missing switch cases in lldb. Summary: There have been a few new values added to a few LLVM enums this change makes sure that LLDB code ha

[Lldb-commits] [lldb] r295450 - Switch ProcessKDPLog to the new channel registration mechanism

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 09:08:08 2017 New Revision: 295450 URL: http://llvm.org/viewvc/llvm-project?rev=295450&view=rev Log: Switch ProcessKDPLog to the new channel registration mechanism Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp lldb/trunk/source/Pl

[Lldb-commits] [lldb] r295455 - Switch GDBRemoteLog to the new registration mechanism

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 10:09:06 2017 New Revision: 295455 URL: http://llvm.org/viewvc/llvm-project?rev=295455&view=rev Log: Switch GDBRemoteLog to the new registration mechanism Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r295457 - NPL: Fix an incorrect logging formatv call

2017-02-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 17 10:09:10 2017 New Revision: 295457 URL: http://llvm.org/viewvc/llvm-project?rev=295457&view=rev Log: NPL: Fix an incorrect logging formatv call Modified: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp Modified: lldb/trunk/source/Plugins/Process

[Lldb-commits] [lldb] r295651 - Fix a couple of corner cases in NameMatches

2017-02-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 20 05:35:33 2017 New Revision: 295651 URL: http://llvm.org/viewvc/llvm-project?rev=295651&view=rev Log: Fix a couple of corner cases in NameMatches Summary: I originally set out to move the NameMatches closer to the relevant function and add some unit tests. However,

[Lldb-commits] [lldb] r295712 - Log: Fix race in accessing the stream variable

2017-02-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 21 03:58:23 2017 New Revision: 295712 URL: http://llvm.org/viewvc/llvm-project?rev=295712&view=rev Log: Log: Fix race in accessing the stream variable Summary: The code was attempting to copy the shared pointer member in order to guarantee atomicity, but this is not e

[Lldb-commits] [lldb] r295822 - Replace WINLOG_*** macros with LLDB_LOG

2017-02-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 22 04:38:02 2017 New Revision: 295822 URL: http://llvm.org/viewvc/llvm-project?rev=295822&view=rev Log: Replace WINLOG_*** macros with LLDB_LOG Summary: The main difference here is that in the WINLOG macros you can specify log categories per call, whereas here you hav

[Lldb-commits] [lldb] r295821 - Add format_provider for the MemoryRegionInfo::OptionalBool enum

2017-02-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 22 04:37:57 2017 New Revision: 295821 URL: http://llvm.org/viewvc/llvm-project?rev=295821&view=rev Log: Add format_provider for the MemoryRegionInfo::OptionalBool enum Added: lldb/trunk/unittests/Target/MemoryRegionInfoTest.cpp Modified: lldb/trunk/include/lld

[Lldb-commits] [lldb] r295823 - Switch "lldb" log channel to the new registration mechanism

2017-02-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 22 05:51:12 2017 New Revision: 295823 URL: http://llvm.org/viewvc/llvm-project?rev=295823&view=rev Log: Switch "lldb" log channel to the new registration mechanism Modified: lldb/trunk/include/lldb/Core/Log.h lldb/trunk/include/lldb/Core/Logging.h lldb/tru

[Lldb-commits] [lldb] r295950 - Reformat inferior's main.cpp in lldb-server test

2017-02-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 23 03:46:33 2017 New Revision: 295950 URL: http://llvm.org/viewvc/llvm-project?rev=295950&view=rev Log: Reformat inferior's main.cpp in lldb-server test Summary: main.cpp is complete mess of tabs and spaces. This change brings it to compliance with LLVM coding style.

[Lldb-commits] [lldb] r295952 - Finish the reformatting of the lldb-server test executables

2017-02-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 23 04:00:33 2017 New Revision: 295952 URL: http://llvm.org/viewvc/llvm-project?rev=295952&view=rev Log: Finish the reformatting of the lldb-server test executables This also reformats the executables in subfolders of lldb-server tests. Modified: lldb/trunk/packa

[Lldb-commits] [lldb] r295954 - Switch "posix" to the new log channel registration mechanism

2017-02-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 23 04:33:16 2017 New Revision: 295954 URL: http://llvm.org/viewvc/llvm-project?rev=295954&view=rev Log: Switch "posix" to the new log channel registration mechanism Summary: This also removes magic rename code, which caused the channel to be called "linux" when built

[Lldb-commits] [lldb] r295968 - Switch "windows" log channel to the new registration mechanism

2017-02-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 23 07:10:38 2017 New Revision: 295968 URL: http://llvm.org/viewvc/llvm-project?rev=295968&view=rev Log: Switch "windows" log channel to the new registration mechanism Modified: lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindowsLog.cpp lldb/trunk/s

[Lldb-commits] [lldb] r296101 - Implement QPassSignals GDB package in lldb-server

2017-02-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 24 03:29:14 2017 New Revision: 296101 URL: http://llvm.org/viewvc/llvm-project?rev=296101&view=rev Log: Implement QPassSignals GDB package in lldb-server Summary: QPassSignals package allows lldb client to tell lldb-server to ignore certain types of signals and re-in

[Lldb-commits] [lldb] r296107 - Attempt to fix windows unit tests

2017-02-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 24 05:17:40 2017 New Revision: 296107 URL: http://llvm.org/viewvc/llvm-project?rev=296107&view=rev Log: Attempt to fix windows unit tests In LLVM r296049, IPDBSession::getGlobalScope lost its constness. Adjust the unittest to account for that. Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-27 Thread Pavel Labath via lldb-commits
I was thinking of a simple test like "call get on an existing file and make sure it returns something reasonable" and "call get on a non-existing file and make sure it returns null". This is a very thin wrapper over over the llvm code, so I don't insist on it though... On 24 February 2017 at 15:18

[Lldb-commits] [lldb] r296328 - Switch SBBreakpoint to storing a weak_ptr of the internal breakpoint object

2017-02-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 27 05:05:34 2017 New Revision: 296328 URL: http://llvm.org/viewvc/llvm-project?rev=296328&view=rev Log: Switch SBBreakpoint to storing a weak_ptr of the internal breakpoint object Summary: There is nothing we can do with the breakpoint once the associated target becom

[Lldb-commits] [lldb] r296329 - Log: Fix a regression in handling log options

2017-02-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 27 05:05:39 2017 New Revision: 296329 URL: http://llvm.org/viewvc/llvm-project?rev=296329&view=rev Log: Log: Fix a regression in handling log options The channel refactor introduced a regression where we were not honoring the log options passed when enabling the chann

[Lldb-commits] [lldb] r296334 - Fix MinidumpParserTest on 32-bit arches

2017-02-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 27 06:21:20 2017 New Revision: 296334 URL: http://llvm.org/viewvc/llvm-project?rev=296334&view=rev Log: Fix MinidumpParserTest on 32-bit arches load_size should be 64-bit unconditionally to match the underlying API. This makes sure the MAX value correctly signals to a

[Lldb-commits] [lldb] r296333 - Remove the callback-based log channel registration mechanism

2017-02-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 27 06:21:16 2017 New Revision: 296333 URL: http://llvm.org/viewvc/llvm-project?rev=296333&view=rev Log: Remove the callback-based log channel registration mechanism All the existing channels have beens switched to the new mechanism and this code is now unused. Modifi

[Lldb-commits] [lldb] r296335 - Merge Linux and FreeBSD arm register contexts

2017-02-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Feb 27 07:00:50 2017 New Revision: 296335 URL: http://llvm.org/viewvc/llvm-project?rev=296335&view=rev Log: Merge Linux and FreeBSD arm register contexts Summary: These two register contexts were identical, so this shouldn't cause any regressions, but I'd appreciate it if

Re: [Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-28 Thread Pavel Labath via lldb-commits
> > big the file is, and maybe a few other things. >> > > >> > > After this change we have DataBufferLLVM and DataBufferHeap. But it >> > > turns out an LLVM MemoryBuffer can also be backed by the heap, which now >> > > makes DataBufferHeap

[Lldb-commits] [lldb] r296470 - Switch SBWatchpoint to use a weak_ptr to the underlying object

2017-02-28 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 28 06:32:45 2017 New Revision: 296470 URL: http://llvm.org/viewvc/llvm-project?rev=296470&view=rev Log: Switch SBWatchpoint to use a weak_ptr to the underlying object Modified: lldb/trunk/include/lldb/API/SBWatchpoint.h lldb/trunk/packages/Python/lldbsuite/te

[Lldb-commits] [lldb] r296593 - test: pass correct objcopy and ar paths to the test runner

2017-03-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 1 04:08:44 2017 New Revision: 296593 URL: http://llvm.org/viewvc/llvm-project?rev=296593&view=rev Log: test: pass correct objcopy and ar paths to the test runner Summary: The test runner has code to autodetect this, but it's not very smart -- in particular, it fails

[Lldb-commits] [lldb] r296595 - Fix gcc compilation of LogTest.cpp

2017-03-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 1 04:08:51 2017 New Revision: 296595 URL: http://llvm.org/viewvc/llvm-project?rev=296595&view=rev Log: Fix gcc compilation of LogTest.cpp Modified: lldb/trunk/unittests/Core/LogTest.cpp Modified: lldb/trunk/unittests/Core/LogTest.cpp URL: http://llvm.org/viewvc

[Lldb-commits] [lldb] r296592 - Modernize Enable/DisableLogChannel interface a bit

2017-03-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 1 04:08:40 2017 New Revision: 296592 URL: http://llvm.org/viewvc/llvm-project?rev=296592&view=rev Log: Modernize Enable/DisableLogChannel interface a bit Summary: Use StringRef and ArrayRef where possible. This adds an accessor to the Args class to get a view of the

[Lldb-commits] [lldb] r296594 - Switch SBBreakpointLocation to use a weak_ptr

2017-03-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 1 04:08:48 2017 New Revision: 296594 URL: http://llvm.org/viewvc/llvm-project?rev=296594&view=rev Log: Switch SBBreakpointLocation to use a weak_ptr Modified: lldb/trunk/include/lldb/API/SBBreakpointLocation.h lldb/trunk/packages/Python/lldbsuite/test/python

[Lldb-commits] [lldb] r296611 - Mark TestYMMRegister as no_debug_info_test

2017-03-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 1 05:18:59 2017 New Revision: 296611 URL: http://llvm.org/viewvc/llvm-project?rev=296611&view=rev Log: Mark TestYMMRegister as no_debug_info_test We don't need to run this test multiple times to check whether we can read a register. Modified: lldb/trunk/package

[Lldb-commits] [lldb] r296738 - Fix MSVC build

2017-03-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Mar 2 04:35:53 2017 New Revision: 296738 URL: http://llvm.org/viewvc/llvm-project?rev=296738&view=rev Log: Fix MSVC build MSVC (at least the version I am using) does not want to implicitly capture a const bool variable. Move it into the lambda, as it is not used outside

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

2017-03-02 Thread Pavel Labath via lldb-commits
On 2 March 2017 at 00:05, Zachary Turner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > -DumpValueObjectOptions::DeclPrintingHelper helper = > -[&valobj_sp, qualify_cxx_base_classes]( > -ConstString type, ConstString var, > -const DumpValueObjectOption

[Lldb-commits] [lldb] r296741 - Fix flakyness in TestGdbRemoteHostInfo

2017-03-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Mar 2 05:36:14 2017 New Revision: 296741 URL: http://llvm.org/viewvc/llvm-project?rev=296741&view=rev Log: Fix flakyness in TestGdbRemoteHostInfo this test was using the VPATH hack to avoid having a copy of the inferior source code. This makes the test fail if in happens

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

2017-03-02 Thread Pavel Labath via lldb-commits
FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DLLDB_DISABLE_CURSES -DLLDB_DISABLE_LIBEDIT -DLLDB_PYTHON_HOME=\"C:/Users/lldb_build/ll/prebuilts/python-2015/x86\" -DLLDB_USE_BUILTIN_DEMANGLER -DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONST

[Lldb-commits] [lldb] r296868 - Made GetClangTargetCPU() const.

2017-03-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 3 07:35:49 2017 New Revision: 296868 URL: http://llvm.org/viewvc/llvm-project?rev=296868&view=rev Log: Made GetClangTargetCPU() const. Summary: It does not change members or call non-const members. HostInfo::GetArchitecture() returns a const object ref (maybe others?

[Lldb-commits] [lldb] r296869 - testsuite/android: build test executables with the android ndk directly

2017-03-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 3 07:49:34 2017 New Revision: 296869 URL: http://llvm.org/viewvc/llvm-project?rev=296869&view=rev Log: testsuite/android: build test executables with the android ndk directly Summary: This teaches the test makefiles about the Android NDK, so we are able to run the te

[Lldb-commits] [lldb] r296870 - test: shorten test trace file names

2017-03-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 3 07:49:38 2017 New Revision: 296870 URL: http://llvm.org/viewvc/llvm-project?rev=296870&view=rev Log: test: shorten test trace file names Make sure we don't generate extremely long file names for test trace log file, as this can cause path-too-long errors. As the co

[Lldb-commits] [lldb] r296876 - Android.rules: fix building on windows

2017-03-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 3 10:29:56 2017 New Revision: 296876 URL: http://llvm.org/viewvc/llvm-project?rev=296876&view=rev Log: Android.rules: fix building on windows $(realpath), which I guess is a make builtin, gives strange results on Windows. $(shell realpath) invokes the gnuwin external

[Lldb-commits] [lldb] r296885 - Android.rules: fix building on mac

2017-03-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 3 11:03:46 2017 New Revision: 296885 URL: http://llvm.org/viewvc/llvm-project?rev=296885&view=rev Log: Android.rules: fix building on mac realpath is not available as an executable on mac. I give up, I am just going to leave the path with ..'s in it. Modified: l

[Lldb-commits] [lldb] r297013 - Fix Log unit tests

2017-03-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 6 09:17:36 2017 New Revision: 297013 URL: http://llvm.org/viewvc/llvm-project?rev=297013&view=rev Log: Fix Log unit tests the llvm function for getting the thread name dropped the _np suffix during review. Zachary's commit did not reflect that. Modified: lldb/tr

[Lldb-commits] [lldb] r297053 - Update log_options unit test

2017-03-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 6 13:10:19 2017 New Revision: 297053 URL: http://llvm.org/viewvc/llvm-project?rev=297053&view=rev Log: Update log_options unit test it was accessing the details of the Log class directly. Let it go through the channel class instead. This also discovered a bug when w

[Lldb-commits] [lldb] r297139 - Revert "Use LLVM for all stat-related functionality."

2017-03-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Mar 7 07:19:15 2017 New Revision: 297139 URL: http://llvm.org/viewvc/llvm-project?rev=297139&view=rev Log: Revert "Use LLVM for all stat-related functionality." this reverts r297116 because it breaks the unittests and TestCompDirSymlink. The ModuleCache unit test is triv

Re: [Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

2017-03-07 Thread Pavel Labath via lldb-commits
Yea, that would do the trick. On 7 March 2017 at 14:47, Zachary Turner wrote: > I think i can address this by adding a bool to llvm::sys::fs::status which > indicates whether to follow symlinks > > On Tue, Mar 7, 2017 at 5:41 AM Pavel Labath via Phabricator > wrote: >> >> labath added a comment.

[Lldb-commits] [lldb] r297145 - Android.rules: add support for clang compiler

2017-03-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Mar 7 08:57:37 2017 New Revision: 297145 URL: http://llvm.org/viewvc/llvm-project?rev=297145&view=rev Log: Android.rules: add support for clang compiler Summary: building executables with the NDK clang requires -target and -gcc-toolchain arguments. Reviewers: eugene, da

Re: [Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

2017-03-08 Thread Pavel Labath via lldb-commits
I've tried it out not and it works -- I think it's good to go then. The unit tests, was that a debug build by any chance? I think we are missing some dependency there which shows up only on debug builds, but I haven't dug into that yet. On 7 March 2017 at 22:28, Zachary Turner wrote: > I can run

[Lldb-commits] [lldb] r297279 - Android.rules: fix computation of gcc toolchain directory on arm

2017-03-08 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 8 08:57:15 2017 New Revision: 297279 URL: http://llvm.org/viewvc/llvm-project?rev=297279&view=rev Log: Android.rules: fix computation of gcc toolchain directory on arm The toolchain directory for arm android targets was computed incorrectly. The architecture part sho

[Lldb-commits] [lldb] r297369 - cmake: Increase LINK_INTERFACE_MULTIPLICITY of lldbCore

2017-03-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Mar 9 04:16:15 2017 New Revision: 297369 URL: http://llvm.org/viewvc/llvm-project?rev=297369&view=rev Log: cmake: Increase LINK_INTERFACE_MULTIPLICITY of lldbCore This is necessary to get debug builds of unit tests working on linux. I think we are at a point where remov

[Lldb-commits] [lldb] r297368 - Fix remaining threading issues in Log.h

2017-03-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Mar 9 04:16:07 2017 New Revision: 297368 URL: http://llvm.org/viewvc/llvm-project?rev=297368&view=rev Log: Fix remaining threading issues in Log.h Summary: This fixes two threading issues in the logging code. The access to the mask and options flags had data races when w

Re: [Lldb-commits] [PATCH] D30807: Use LLVM's directory enumeration code

2017-03-10 Thread Pavel Labath via lldb-commits
I can see both of them making sense, but I would actually prefer the new behavior you inadvertently introduced. I've looked at the callers and it seems no user sets find_directories to false, so I guess it's fine to change the behavior, if we want to. On 10 March 2017 at 14:08, Zachary Turner wro

[Lldb-commits] [lldb] r297609 - Fix Linux build for the FileSpec changes

2017-03-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 13 04:46:15 2017 New Revision: 297609 URL: http://llvm.org/viewvc/llvm-project?rev=297609&view=rev Log: Fix Linux build for the FileSpec changes Propagate changes that were made during review, and fix a couple of warnings while I'm in there. Modified: lldb/trunk/

[Lldb-commits] [lldb] r297612 - Fix android build

2017-03-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 13 05:59:23 2017 New Revision: 297612 URL: http://llvm.org/viewvc/llvm-project?rev=297612&view=rev Log: Fix android build getpwent is not available on android until API level 21, and even then it is only available when doing a non-static link. Since android's concept

[Lldb-commits] [lldb] r297615 - Fix windows build broken by r297612

2017-03-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 13 06:23:59 2017 New Revision: 297615 URL: http://llvm.org/viewvc/llvm-project?rev=297615&view=rev Log: Fix windows build broken by r297612 I have got my boolean logic incorrect. Sorry about the spam. Modified: lldb/trunk/source/Host/common/FileSpec.cpp Modified

[Lldb-commits] [lldb] r297616 - Android.rules: Add libc++ support

2017-03-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 13 07:07:48 2017 New Revision: 297616 URL: http://llvm.org/viewvc/llvm-project?rev=297616&view=rev Log: Android.rules: Add libc++ support Summary: This adds support for building libc++ tests when targetting android. The tests are still not passing due to several other

Re: [Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

2017-03-13 Thread Pavel Labath via lldb-commits
On 13 March 2017 at 12:35, Zachary Turner wrote: > Can we just copy the non portable system call to this location and inline it > here with appropriate glibc check so that we can still delete all that other > obsolete code? > That makes sense. I think that code belongs in NativeThreadLinux anyway

[Lldb-commits] [lldb] r297743 - Fix flakyness in TestCompletion

2017-03-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Mar 14 09:58:31 2017 New Revision: 297743 URL: http://llvm.org/viewvc/llvm-project?rev=297743&view=rev Log: Fix flakyness in TestCompletion One of the file name templates was occasionally generating the name "fooa***", which conflicted with the one of the tests expectatio

[Lldb-commits] [lldb] r297811 - dotest.py: remove the ability to specify different architectures/compilers in a single invocation

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 03:51:59 2017 New Revision: 297811 URL: http://llvm.org/viewvc/llvm-project?rev=297811&view=rev Log: dotest.py: remove the ability to specify different architectures/compilers in a single invocation Summary: This has been broken at least since the new test result

[Lldb-commits] [lldb] r297812 - Remove lldb streams from the Log class completely

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 04:06:58 2017 New Revision: 297812 URL: http://llvm.org/viewvc/llvm-project?rev=297812&view=rev Log: Remove lldb streams from the Log class completely Summary: previously we switched to llvm streams for log output, this completes the switch for the error streams.

[Lldb-commits] [lldb] r297817 - BreakpointResolverFileLine: Restrict move-to-nearest-code from moving across function boundaries

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 04:53:10 2017 New Revision: 297817 URL: http://llvm.org/viewvc/llvm-project?rev=297817&view=rev Log: BreakpointResolverFileLine: Restrict move-to-nearest-code from moving across function boundaries Summary: This fixes the case where a user tries to set a breakpoin

[Lldb-commits] [lldb] r297819 - Fix windows&darwin builds broken by r297812

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 05:02:20 2017 New Revision: 297819 URL: http://llvm.org/viewvc/llvm-project?rev=297819&view=rev Log: Fix windows&darwin builds broken by r297812 Modified: lldb/trunk/include/lldb/Utility/Log.h lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cp

[Lldb-commits] [lldb] r297818 - Delete empty file ProcessLauncherLinux.h

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 05:02:16 2017 New Revision: 297818 URL: http://llvm.org/viewvc/llvm-project?rev=297818&view=rev Log: Delete empty file ProcessLauncherLinux.h Removed: lldb/trunk/include/lldb/Host/linux/ProcessLauncherLinux.h Removed: lldb/trunk/include/lldb/Host/linux/Process

[Lldb-commits] [lldb] r297830 - Fix TestMoveNearest breakage on darwin

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 07:32:18 2017 New Revision: 297830 URL: http://llvm.org/viewvc/llvm-project?rev=297830&view=rev Log: Fix TestMoveNearest breakage on darwin It seems that on darwin we are not able to resolve breakpoints in the test shared library until the process has started. That

Re: [Lldb-commits] [lldb] r297830 - Fix TestMoveNearest breakage on darwin

2017-03-15 Thread Pavel Labath via lldb-commits
Hi Jim, I am not sure if behavior like this should be considered a bug, but I wanted to make sure you don't miss this. cheers, pl On 15 March 2017 at 12:32, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Wed Mar 15 07:32:18 2017 > New Revision: 297830 > >

[Lldb-commits] [lldb] r297834 - Fix TestMoveNearest for remote targets

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 08:32:17 2017 New Revision: 297834 URL: http://llvm.org/viewvc/llvm-project?rev=297834&view=rev Log: Fix TestMoveNearest for remote targets Launching a process with shared libraries on remote targets requires a special dance, which I forgot to do in r297830. Modif

[Lldb-commits] [lldb] r297843 - Remove some ProcFileReader occurences

2017-03-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 15 10:08:49 2017 New Revision: 297843 URL: http://llvm.org/viewvc/llvm-project?rev=297843&view=rev Log: Remove some ProcFileReader occurences Summary: ProcFileReader is the cause of the dependency from Host to ProcessLinux module. Since it's interface is also obsolete

<    7   8   9   10   11   12   13   14   15   16   >