Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. Jason, in MIPS watch registers, last 3 bits of watchpoint addresses are masked by IRW(instruction, read, write types) flags, so machine gives exception for any address having other bits same to the actual watch address execept last 3 bits. Comment at line number 7

[Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-09-30 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, jingham. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. For archs like MIPS, where watchpoints are triggered before as

[Lldb-commits] [PATCH] D13335: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

2015-10-01 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: jaydeep. mohit.bhakkad added a subscriber: lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. There is no hard constraint on MIPS hardware watches, so skipping this test. Repository: rL LLVM http://r

Re: [Lldb-commits] [PATCH] D13335: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

2015-10-05 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249299: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13335?vs=36212&id=36498#toc Repository: rL LLVM htt

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-10-05 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249377: [LLDB][MIPS] Fix hit_count for mips watchpoints (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13241?vs=35958&id=36583#toc Repository: rL LLVM http://reviews.

[Lldb-commits] [PATCH] D13493: [LLDB][MIPS] microMIPS load/store instruction emulation for hardware watchpoints

2015-10-07 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D13493 Files: source

Re: [Lldb-commits] [PATCH] D13493: [LLDB][MIPS] microMIPS load/store instruction emulation for hardware watchpoints

2015-10-07 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249651: [LLDB][MIPS] microMIPS load/store instruction emulation for hardware watchpoints (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13493?vs=36704&id=36824#toc Repos

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-10-08 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 36837. mohit.bhakkad added a comment. Changing as suggested Repository: rL LLVM http://reviews.llvm.org/D13202 Files: functionalities/watchpoint/watchpoint_on_vectors/Makefile functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVa

[Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-08 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, jingham. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. On MIPS architecture, it is possible to use same hardware regi

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249837: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13548?vs=36838&id=36951#toc Reposito

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-09 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. In http://reviews.llvm.org/D13548#262873, @clayborg wrote: > Add space in between if and opening ( and this is good to go. Thanks, addressed it while commiting. Repository: rL LLVM http://reviews.llvm.org/D13548

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-10-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249838: [LLDB] Fix display of value of a vector variables in watchpoint operations (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13202?vs=36837&id=36952#toc Repository:

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-10-09 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. In http://reviews.llvm.org/D13202#263841, @zturner wrote: > Strange, it was fine in the review, but wrong in the commit. Yea, that > needs to be fixed. Yes it looks strange, I directly applied the patch from review, and it looks like new files are added directl

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-10-09 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. @loladiro @zturner Thanks for pointing this out, fixed it in http://reviews.llvm.org/rL249897 Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-10-11 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a subscriber: clayborg. mohit.bhakkad added a comment. In http://reviews.llvm.org/D13296#260030, @clayborg wrote: > I will defer to Jim Ingham on this one. @jingham could you please review this. Repository: rL LLVM http://reviews.llvm.org/D13296 _

[Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

2015-10-12 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Herald added a subscriber: emaste. Looking at the keymap generated by

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

2015-10-15 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 37469. mohit.bhakkad added a comment. Herald added a subscriber: dsanders. Changes in this revision: - Added alias as new argument for AddSignal. - removed shortname as hardcoded argument, as for alias we would need another shortname. Now generating sh

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

2015-10-18 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added inline comments. Comment at: include/lldb/Target/UnixSignals.h:101-102 @@ -100,1 +100,4 @@ +ConstString +GetShortName(ConstString name) const; + clayborg wrote: > Why are we doing this by name? shouldn't we do this with the signal num

[Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

2015-10-19 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, zturner. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Some machines of an arch may not have all the regs listed for

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

2015-10-20 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250801: [LLDB] Insert names with same signo as alias instead of a new entry (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13646?vs=37469&id=37828#toc Repository: rL L

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

2015-10-20 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. In http://reviews.llvm.org/D13646#267953, @labath wrote: > This looks much better, I just have a couple of small remarks. @labath addressed these while committing. Repository: rL LLVM http://reviews.llvm.org/D13646 _

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

2015-10-20 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 37843. mohit.bhakkad added a comment. This patch makes server send an End of register(E45) response if a register present in reginfo is not available on actual machine. Repository: rL LLVM http://reviews.llvm.org/D13859 Files: source/Plugins/Pr

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-10-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. In http://reviews.llvm.org/D13296#265608, @jingham wrote: > This change alters the timing for the handling of ignore counts for > watchpoints. The original implementation (and the way ignore counts work for > breakpoints) is that the breakpoint's ignore count get

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

2015-10-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 38785. mohit.bhakkad added a comment. Changes in this revision: - Fixed GetUserRegisterCount () to get count registers which are actually present. This will make llgs send E45 when reg_index is of some unavailable reg. Repository: rL LLVM http://

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-10-30 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad requested a review of this revision. mohit.bhakkad added a comment. > Note, if you end up going with the current patch, isn't quite right, however. > You need to move the check for the watchpoint ignore count up before > printing out the old & new values. An ignored watchpoint

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-10-30 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. I forgot about note part, is it okay to add a TODO before ignore count condition in source/Target/StopInfo.cpp: TODO: This condition should be checked in synchronous part of watchpoint code (Watchpoint::ShouldStop), so that we avoid pulling an event even if watch

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-10-30 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 38799. mohit.bhakkad added a comment. Changes in this revision: - changed no-source to no-debuginfo and made it default - now no-source means display assembly if source file is missing, even if debug-info is present. Repository: rL LLVM http://rev

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-11-01 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. Is it okay to commit now? Repository: rL LLVM http://reviews.llvm.org/D13296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-11-03 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251905: [LLDB][Watchpoint] Change ignore_count condition location to fix watchpoint… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13296?vs=36119&id=39035#toc Repositor

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

2015-11-03 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251906: [LLDB][MIPS] Fix GetUserRegisterInfoCount to count no of regs which are… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13859?vs=38785&id=39037#toc Repository:

[Lldb-commits] [PATCH] D14860: [LLDB][MIPS] Getting 0 index for h/w watchpoint is not necessarily an error

2015-11-19 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: bhushan, jaydeep. mohit.bhakkad added subscribers: lldb-commits, sagar, nitesh.jain. mohit.bhakkad set the repository for this revision to rL LLVM. Index for H/W watchpoint regsisters starts from 0, so considering 0 as failure is

Re: [Lldb-commits] [PATCH] D14860: [LLDB][MIPS] Getting 0 index for h/w watchpoint is not necessarily an error

2015-11-23 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253864: [LLDB][MIPS] Getting 0 index for H/W watchpoint is not necessarily an error (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D14860?vs=40744&id=40913#toc Repository

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-11-23 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. @jingham, @jasonmolenda, is it okay to commit it? Repository: rL LLVM http://reviews.llvm.org/D12877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D14920: [LLDB][MIPS] Provide actual number of watchpoints supported

2015-11-24 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 41014. Repository: rL LLVM http://reviews.llvm.org/D14920 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h Index: source/Plugins/Process/Linux/NativeRegist

[Lldb-commits] [PATCH] D14944: [LLDB][MIPS] Marking some expected failures

2015-11-24 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, zturner. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. Mos

[Lldb-commits] [PATCH] D15106: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-12-01 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, nitesh.jain, sagar, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. rL249837 doesn't solves all the issues with MIPS false positives, some

Re: [Lldb-commits] [PATCH] D15106: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-12-02 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254522: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D15106?vs=41486&id=41644#toc Reposito

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-12-02 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254588: [LLDB] Switch to assembly view if source is moved (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12877?vs=38799&id=41714#toc Repository: rL LLVM http://review

Re: [Lldb-commits] [PATCH] D14944: [LLDB][MIPS] Marking some expected failures

2015-12-03 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 41843. mohit.bhakkad added a comment. Addressed comments Repository: rL LLVM http://reviews.llvm.org/D14944 Files: packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py packages/Python/lldbsuite/te

Re: [Lldb-commits] [PATCH] D14944: [LLDB][MIPS] Marking some expected failures

2015-12-06 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254892: [LLDB][MIPS] Marking some expected failures (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D14944?vs=41843&id=42027#toc Repository: rL LLVM http://reviews.llvm

[Lldb-commits] [PATCH] D15488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

2015-12-14 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: jaydeep. mohit.bhakkad added a subscriber: lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D15488 Files: packages/Python/lldbsuite/test/functionaliti

Re: [Lldb-commits] [PATCH] D15488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

2015-12-14 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D15488?vs=42693&id=42695#toc Repository

[Lldb-commits] [PATCH] D15738: [LLDB] Fix Read/Write memory to be compatible with both endians

2015-12-22 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. While copying a byte, copy a whole byte chunk instead of each bit, to

Re: [Lldb-commits] [PATCH] D15738: [LLDB] Fix Read/Write memory to be compatible with both endians

2015-12-23 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 43520. mohit.bhakkad added a comment. Addressed comment. Repository: rL LLVM http://reviews.llvm.org/D15738 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp ===

Re: [Lldb-commits] [PATCH] D15738: [LLDB] Fix Read/Write memory to be compatible with both endians

2015-12-23 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256331: [LLDB] Fix Read/Write memory to be compatible with both endians (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D15738?vs=43520&id=43522#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16060: [LLDB][MIPS] Fix ReadRegisterValue for registers with constant 32 bit size regardless of ABI

2016-01-11 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257447: [LLDB][MIPS] Fix ReadRegisterValue for registers with constant 32 bit size… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D16060?vs=44504&id=44603#toc Repository

Re: [Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

2016-01-23 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258621: [LLDB] Consider only valid symbols while resolving by address (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D16397?vs=45670&id=45789#toc Repository: rL LLVM h

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260362: [LLDB][MIPS] Generalise MIPS arch names (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D16840?vs=46919&id=47423#toc Repository: rL LLVM http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

2016-03-07 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D17597?vs=49021&id=49936#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-22 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264030: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D18082?vs=50569&id=51260#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [PATCH] D12427: [LLDB][MIPS] Aligning code with rL245831

2015-08-28 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: jaydeep. mohit.bhakkad added a subscriber: lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Resolving build failure due to some changes in rL245831 Repository: rL LLVM http://reviews.llvm.org/D1242

Re: [Lldb-commits] [PATCH] D10761: [LLDB][MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-28 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad abandoned this revision. mohit.bhakkad added a comment. Resolved by http://reviews.llvm.org/rL244864 Repository: rL LLVM http://reviews.llvm.org/D10761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D12427: [LLDB][MIPS] Aligning code with rL245831

2015-08-28 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246293: [LLDB][MIPS] Aligning code with rL245831 (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12427?vs=33399&id=33415#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [PATCH] D12670: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints

2015-09-07 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Emulate MIPS32/64 load and store instructions for HW watchpoints. Rep

Re: [Lldb-commits] [PATCH] D12670: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints

2015-09-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247129: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12670?vs=34132&id=34308#toc Repository

Re: [Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

2015-09-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247134: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12671?vs=34146&id=34314#toc Repository:

[Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-09-14 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12877 Files: source

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

2015-09-22 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. Hi Jason, thanks for your suggestions. Yes, this approach looks good and one time warning should be helpful from users view, I will implement it get back with a patch soon. Repository: rL LLVM http://reviews.llvm.org/D12877 _

[Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-09-27 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, granata.enrico. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Consider a vector variable 'v8i16 s0' Right now if we

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-09-28 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad updated this revision to Diff 35879. mohit.bhakkad added a comment. Adding a simple test to check displayed value of vector Repository: rL LLVM http://reviews.llvm.org/D13202 Files: source/Breakpoint/Watchpoint.cpp test/functionalities/watchpoint/watchpoint_on_vectors/Makef

[Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

2015-09-29 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Revise hit counts when hit a false positive Repository: rL LLVM ht