@@ -1084,3 +1084,43 @@ bool
lldb_private::formatters::LibcxxWStringViewSummaryProvider(
return ::LibcxxWStringSummaryProvider(valobj, stream, summary_options,
dataobj, size);
}
+
+bool lldb_private::formatters::LibcxxChronoMonthSummary
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/76983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const
Module::LookupInfo &lookup_info,
Module::LookupInfo no_tp_lookup_info(lookup_info);
no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params));
- m_index->GetFunctions(no_tp_lookup_i
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/77596
This seems to have always been a redundant do-while since its introduction in
`2e93a2ad2148d19337bf5f9885e46e3c00e8ab82`.
>From 5c439cb2bb04ce19c198d8a7120dc369d567f210 Mon Sep 17 00:00:00 2001
From: Michael
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/77596
>From 5c439cb2bb04ce19c198d8a7120dc369d567f210 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jan 2024 12:30:53 +
Subject: [PATCH 1/2] [lldb][ClangASTImporter][NFC] Remove redundant do-while
lo
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/77596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Merged the PR since we do want this fix ASAP. Will add the tests as a follow-up
https://github.com/llvm/llvm-project/pull/72233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: Michael Buch
Date: 2023-07-26T18:26:08+01:00
New Revision: b0b2b6bab4d25122b2259dfac500fd83d60fa154
URL:
https://github.com/llvm/llvm-project/commit/b0b2b6bab4d25122b2259dfac500fd83d60fa154
DIFF:
https://github.com/llvm/llvm-project/commit/b0b2b6bab4d25122b2259dfac500fd83d60fa154.diff
Author: Michael Buch
Date: 2023-08-01T23:43:24+02:00
New Revision: 5ce7831b402334a13b00c1441655a51fbec7456a
URL:
https://github.com/llvm/llvm-project/commit/5ce7831b402334a13b00c1441655a51fbec7456a
DIFF:
https://github.com/llvm/llvm-project/commit/5ce7831b402334a13b00c1441655a51fbec7456a.diff
Author: Michael Buch
Date: 2023-08-10T19:48:44+01:00
New Revision: 487ab39a5082098f92e886de606505f25031a22a
URL:
https://github.com/llvm/llvm-project/commit/487ab39a5082098f92e886de606505f25031a22a
DIFF:
https://github.com/llvm/llvm-project/commit/487ab39a5082098f92e886de606505f25031a22a.diff
Author: Michael Buch
Date: 2023-08-15T23:09:59+01:00
New Revision: 92d7254a989d106ba63e64d315dbb9397c275671
URL:
https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671
DIFF:
https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671.diff
Author: Michael Buch
Date: 2023-08-17T17:54:51+01:00
New Revision: 9c3f1f42cbed0fa6184cd2047b34ab5090503e9e
URL:
https://github.com/llvm/llvm-project/commit/9c3f1f42cbed0fa6184cd2047b34ab5090503e9e
DIFF:
https://github.com/llvm/llvm-project/commit/9c3f1f42cbed0fa6184cd2047b34ab5090503e9e.diff
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
}
+
+TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) {
+ const char *yamldata = R"(
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data:ELFDATA2LSB
+ T
@@ -462,3 +462,96 @@ TEST_F(DWARFASTParserClangTests,
TestDefaultTemplateParamParsing) {
}
}
}
+
+TEST_F(DWARFASTParserClangTests, EnsureNestedTypesOfTypeAreParsed) {
+ const char *yamldata = R"(
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data:ELFDATA2LSB
+ T
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/66879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> I didn't see much explanation as to why this is needed in the bug report.
The motivating example is something like:
```
struct Info {
enum Mask : uintptr_t {
Enum
};
}
```
`expr Info::Mask::Enum`.
> Is there a reason we need to complete nested types within a type?
Michael137 wrote:
> > > I didn't see much explanation as to why this is needed in the bug report.
> >
> >
> > The motivating example is something like:
> > ```
> > struct Info {
> > enum Mask : uintptr_t {
> > Enum
> > };
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's
Michael137 wrote:
Thanks, the API test looks good
Apologies for the delay, didn't have a chance to follow-up on Greg's concern
yet. But will hopefully get a chance in the next few days
https://github.com/llvm/llvm-project/pull/66879
___
lldb-commits
Michael137 wrote:
Change itself is fine. But could you please add a test in
`lldb/test/API/commands/expression/completion/TestExprCompletion.py` or
`lldb/test/API/functionalities/completion/TestCompletion.py`?
https://github.com/llvm/llvm-project/pull/83234
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83291
This patch moves the logic for copying the layout info of a `RecordDecl`s
origin into a target AST.
A follow-up patch re-uses the logic from within the `ClangASTImporter`, so the
natural choice was to move i
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83295
Layout information for a record gets stored in the `ClangASTImporter`
associated with the `DWARFASTParserClang` that originally parsed the record.
LLDB sometimes moves clang types from one AST to another (in
Michael137 wrote:
relies on https://github.com/llvm/llvm-project/pull/83291
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
lgtm thanks!
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/3] [LLDB] Fix crash when using tab completion on class
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/2] [lldb][NFC] Move helpers to import record layout into
Clan
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/3] [lldb][NFC] Move helpers to import record layout into
Clan
@@ -517,6 +520,207 @@ bool ClangASTImporter::CompleteType(const CompilerType
&compiler_type) {
return false;
}
+template
Michael137 wrote:
done
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits m
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/4] [lldb][NFC] Move helpers to import record layout into
Clan
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 9a6ed480fd407f9a9f12d6faccffbad952de0855 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 9a6ed480fd407f9a9f12d6faccffbad952de0855 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 7b3d74a917446ad03e605f57fcf9158eee1d21c5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83582
Adds a test-case for debugging a program with a
pch chain, that is, the main executable depends
on a pch that itself included another pch.
Currently clang doesn't emit the sekeleton CUs
required for LLDB to tr
@@ -0,0 +1,10 @@
+include Makefile.rules
+
+OBJECTS += main.o
+
+$(EXE): $(BUILDDIR)/main.o
+
+$(BUILDDIR)/main.o: main.cpp
+ $(CC) -cc1 -emit-pch -x c++-header -fmodule-format=obj -fmodules -O0
-dwarf-ext-refs -debug-info-kind=standalone $(SRCDIR)/base-pch.h -o
base-pch.h
@@ -0,0 +1,73 @@
+"""
+Tests that we correctly track AST layout info
+(specifically alignment) when moving AST nodes
+between several ClangASTImporter instances
+(in this case, from a pch chain to executable
+to expression AST).
+"""
+
+import lldb
+import os
+from lldbsuite.test.
https://github.com/Michael137 approved this pull request.
Using `FeaturesAsWritten` makes sense here, thanks! We really should change
this logic to derive all the compiler options using the driver, but that's a
bigger change for the future
https://github.com/llvm/llvm-project/pull/82364
__
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,7 +12,7 @@
target var a
# CHECK-LABEL: target var a
# FIXME: This should also produce some kind of an error.
-# CHECK: (A) a = {}
+# CHECK: (A) a =
Michael137 wrote:
nice!
https://github.com/llvm/llvm-project/pull/84265
___
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
big fan, LGTM
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/84890
None
>From ecb8e2744628207dd0ec72272428e3f57e8d68bb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 12 Mar 2024 10:04:12 +
Subject: [PATCH] [lldb][test] TestExprCompletion.py: add tests for complet
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/84890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/84890
>From ecb8e2744628207dd0ec72272428e3f57e8d68bb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 12 Mar 2024 10:04:12 +
Subject: [PATCH 1/2] [lldb][test] TestExprCompletion.py: add tests for
completi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/84890
>From ecb8e2744628207dd0ec72272428e3f57e8d68bb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 12 Mar 2024 10:04:12 +
Subject: [PATCH 1/3] [lldb][test] TestExprCompletion.py: add tests for
completi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/84890
>From ecb8e2744628207dd0ec72272428e3f57e8d68bb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 12 Mar 2024 10:04:12 +
Subject: [PATCH 1/4] [lldb][test] TestExprCompletion.py: add tests for
completi
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
@@ -0,0 +1,9 @@
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out
+# RUN: %lldb -b -s %s %t.out | FileCheck %s
+run
+# CHECK: thread #{{.*}}stop reason = Runtime Error: Function is not implemented
Michael137 wrote:
How about `Runtime trap: ...`?
ht
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/80368
>From 4ffcb261af05b2a68781cf353d8e45bf921f8cb7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 25 Jan 2024 11:05:02 +
Subject: [PATCH 1/6] [lldb] Add frame recognizer for __builtin_verbose_trap
Thi
@@ -0,0 +1,39 @@
+#ifndef LLDB_TARGET_VERBOSETRAPFRAMERECOGNIZER_H
Michael137 wrote:
done
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/84890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/85544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,166 @@
+//===--
LibCxxSliceArray.cpp---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 approved this pull request.
LGTM thanks!
https://github.com/llvm/llvm-project/pull/85544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/85763
This caused following warnings in an LLDB build:
```
[237/1072] Building CXX object tools/l...lusLanguage.dir/LibCxxSliceArray.cpp.o
/Volumes/Data/llvm-project/lldb/source/Plugins/Language/CPlusPlus/LibCxxSlice
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/85763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -664,6 +685,17 @@ CompilerType CompilerType::GetPointerType() const {
return CompilerType();
}
+CompilerType
+CompilerType::AddPtrAuthModifier(unsigned key, bool isAddressDiscriminated,
Michael137 wrote:
Can we add an API test that tests this API? E.g.,
@@ -664,6 +685,17 @@ CompilerType CompilerType::GetPointerType() const {
return CompilerType();
}
+CompilerType
+CompilerType::AddPtrAuthModifier(unsigned key, bool isAddressDiscriminated,
Michael137 wrote:
Also, whose this user of this API? Presumably ther
@@ -676,6 +677,62 @@ DWARFASTParserClang::ParseTypeModifier(const SymbolContext
&sc,
case DW_TAG_volatile_type:
encoding_data_type = Type::eEncodingIsVolatileUID;
break;
+ case DW_TAG_LLVM_ptrauth_type: {
+DWARFDIE ptr_die = die.GetReferencedDIE(DW_AT_type);
---
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/86159
This patch sets the necessary `ASTContext` flag
to ensure that the various ASTs (i.e., symbolfile-backed ASTs, scratch AST and
the expression AST) in LLDB are dumped using syntax highlighting (i.e.,
whenever
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> What happens if you have colors disabled in your terminal? Does this do
> nothing? Or does it start inserting ANSI escape codes in plain text?
Yea good question, was about to try this out. It does whatever clang's
`ast-dump` would do if colors aren't turned on
https://gith
Michael137 wrote:
> > > What happens if you have colors disabled in your terminal? Does this do
> > > nothing? Or does it start inserting ANSI escape codes in plain text?
> >
> >
> > Yea good question, was about to try this out. It does whatever clang's
> > `ast-dump` would do if colors aren'
Michael137 wrote:
Thanks for the patch, sounds like it should fix
https://github.com/llvm/llvm-project/issues/86184
https://github.com/llvm/llvm-project/pull/87177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/87177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1233,7 +1233,7 @@ void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery
&query,
std::lock_guard guard(GetModuleMutex());
ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
oso_dwarf->FindTypes(query, results);
-return !results.Done(query); // Keep it
@@ -1391,7 +1391,7 @@ void SymbolFileDWARFDebugMap::ParseDeclsForContext(
lldb_private::CompilerDeclContext decl_ctx) {
ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
oso_dwarf->ParseDeclsForContext(decl_ctx);
-return true; // Keep iterating
+retu
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/87177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4562,6 +4591,19 @@
TypeSystemClang::AddConstModifier(lldb::opaque_compiler_type_t type) {
return CompilerType();
}
+CompilerType
+TypeSystemClang::AddPtrAuthModifier(lldb::opaque_compiler_type_t type,
+uint32_t payload) {
+ if (type)
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/84387
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -579,6 +613,7 @@ DWARFASTParserClang::ParseTypeModifier(const SymbolContext
&sc,
LanguageType cu_language = SymbolFileDWARF::GetLanguage(*die.GetCU());
Type::ResolveState resolve_state = Type::ResolveState::Unresolved;
Type::EncodingDataType encoding_data_type = Type:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/87344
This patch introduces a new `IterationMarker` enum (happy to take alternative
name suggestions), which callbacks, like the one in
`SymbolFileDWARFDebugMap::ForEachSymbolFile` can return in order to indicate
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1339,6 +1339,13 @@ enum AddressMaskRange {
eAddressMaskRangeAll = eAddressMaskRangeAny,
};
+/// Useful for callbacks whose return type indicates
+/// whether to continue iteration or short-circuit.
+enum class IterationMarker {
Michael137 wrote:
Maybe `
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/87344
>From 9ebae9e48ae327ab16e1e7480a3e51b945b990c7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Apr 2024 13:50:09 +0100
Subject: [PATCH 1/2] [lldb][SymbolFileDWARFDebugMap] Introduce enum to
indicate
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/87344
>From 9ebae9e48ae327ab16e1e7480a3e51b945b990c7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Apr 2024 13:50:09 +0100
Subject: [PATCH 1/4] [lldb][SymbolFileDWARFDebugMap] Introduce enum to
indicate
@@ -553,9 +553,9 @@ bool ClangUserExpression::PrepareForParsing(
}
bool ClangUserExpression::TryParse(
-DiagnosticManager &diagnostic_manager, ExecutionContextScope *exe_scope,
-ExecutionContext &exe_ctx, lldb_private::ExecutionPolicy execution_policy,
-bool keep_r
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -669,15 +670,8 @@ bool ClangUserExpression::Parse(DiagnosticManager
&diagnostic_manager,
// Parse the expression
//
- Process *process = exe_ctx.GetProcessPtr();
- ExecutionContextScope *exe_scope = process;
-
- if (!exe_scope)
-exe_scope = exe_ctx.GetTargetPtr(
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/87767
This patch attempts to decouple C++ expression evaluation from Objective-C
support. We've previously enabled it by default (if a runtime existed), but
that meant we're opting into extra work we only need to d
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/87767
>From f27a547ab85463f182ab63949bb6f11140a2f33f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 5 Apr 2024 11:51:47 +0100
Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Don't by default enable
Objec
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/87767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/87807
Depends on https://github.com/llvm/llvm-project/pull/87767
>From a0dfe20ca4d6c544d00ca4b3791fc3dff70b465e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 5 Apr 2024 12:10:09 +0100
Subject: [PATCH] [lld
@@ -669,15 +670,8 @@ bool ClangUserExpression::Parse(DiagnosticManager
&diagnostic_manager,
// Parse the expression
//
- Process *process = exe_ctx.GetProcessPtr();
- ExecutionContextScope *exe_scope = process;
-
- if (!exe_scope)
-exe_scope = exe_ctx.GetTargetPtr(
Michael137 wrote:
> @Michael137 I'm a little late to the party but I just noticed that
> `ChildCacheState` is the only `enum class` in `lldb-enumerations.h`. Is that
> intentional? Is there a reason this cannot be a old-school enum like
> everything else in that file? I don't feel super strong
@@ -669,15 +670,8 @@ bool ClangUserExpression::Parse(DiagnosticManager
&diagnostic_manager,
// Parse the expression
//
- Process *process = exe_ctx.GetProcessPtr();
- ExecutionContextScope *exe_scope = process;
-
- if (!exe_scope)
-exe_scope = exe_ctx.GetTargetPtr(
Michael137 wrote:
> > No particular reason apart from it being scoped, which I thought we might
> > prefer for new enums. But there's no reason it couldn't be an old-school
> > enum
>
> If that's the case I think consistency is more important. Mind putting up a
> PR?
Yup will do sometime thi
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/87657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/87767
>From f27a547ab85463f182ab63949bb6f11140a2f33f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 5 Apr 2024 11:51:47 +0100
Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Don't by default enable
Objec
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/87767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
701 - 800 of 2354 matches
Mail list logo
