@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat());
- dump_options.SetHideRootName(suppress_result);
+ dump_opt
Michael137 wrote:
> LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
> running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6
> "test".
>
> Full details are available at:
> https://lab.llvm.org/buildbot/#/builders/59/builds/8268
>
> Here is the relev
Author: Michael Buch
Date: 2024-11-18T16:15:06Z
New Revision: ceeb08b9e0a51a4d2e0804baeb579fe8a6485885
URL:
https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885
DIFF:
https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885.diff
LOG:
Michael137 wrote:
Revert in
https://github.com/llvm/llvm-project/commit/ceeb08b9e0a51a4d2e0804baeb579fe8a6485885
for now to unblock the bot
https://github.com/llvm/llvm-project/pull/113787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/115571
The `relative_list_list_entry_t` offset field in the Objective-C runtime is of
type `int64_t`. There are cases where these offsets are negative values. For
negative offsets, LLDB would currently incorrectly
@@ -394,7 +394,7 @@ bool ClassDescriptorV2::relative_list_entry_t::Read(Process
*process,
lldb::offset_t cursor = 0;
uint64_t raw_entry = extractor.GetU64_unchecked(&cursor);
m_image_index = raw_entry & 0x;
- m_list_offset = (int64_t)(raw_entry >> 16);
+ m_list_off
https://github.com/Michael137 commented:
Very interesting find, I *think* this makes sense since the `FindTypes` query
expects to find template parameters if we're looking up templates. And given
this API is used specifically to perform these kinds of queries, this LGTM. But
please confirm if
@@ -0,0 +1,61 @@
+"""Test that forward declaration of a c++ template gets resolved correctly."""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+
+
+class ForwardDeclarationTestCase(TestBas
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> I think the problem here is of a more fundamental nature. `FindTypes` finds
> **types**. `bar` is _not_ a type. `bar` is. So, while a type query for
> `bar` will find the definition DIE with `DW_AT_name="bar"`, that DIE will
> actually be defining the type `bar`. So when th
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -151,10 +151,23 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
result.SetStatus(eReturnStatusSuccessFinishResult);
};
- // First, try `expr` as the name of a frame variable.
- if (frame) {
-auto valobj_sp = frame->FindVariable(ConstString(expr));
-
@@ -154,5 +163,25 @@ def test_preserves_persistent_variables(self):
def test_missing_type(self):
"""The expected output of po opaque is its address (no error)"""
self.build()
-lldbutil.run_to_source_breakpoint(self, "break here",
lldb.SBFileSpec("ma
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Makes sense to me!
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Looks like this broke the macOS CI:
```
/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/unittests/debugserver/RNBSocketTest.cpp:123:33:
error: no matching member function for call to 'Accept'
Status err = server_socket->Accept(connected_socket);
https://github.com/Michael137 commented:
This function is definitely due for a cleanup. Do you have a reduced test-case
for this by any chance? One way I see the vector would get cleared is if the
recursive call ended up failing in `GetIndexForRecordBase`. This does seem like
a plausible crash
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -353,6 +353,10 @@ class ModuleList {
lldb::ModuleSP FindFirstModule(const ModuleSpec &module_spec) const;
+ const Symbol *
Michael137 wrote:
Can we add a doxygen comment?
https://github.com/llvm/llvm-project/pull/11
___
@@ -524,6 +524,19 @@ void ModuleList::FindGlobalVariables(const
RegularExpression ®ex,
module_sp->FindGlobalVariables(regex, max_matches, variable_list);
}
+const Symbol *
+ModuleList::FindFirstSymbolWithNameAndType(ConstString name,
+
https://github.com/Michael137 commented:
Do you have a link to a PR that exercises this new API?
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
Michael137 wrote:
Is changing `struct symtab_command` to have the right-sized fields a no-go?
https://github.com/llvm/llvm-project/pull/117832
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat());
- dump_options.SetHideRootName(suppress_result);
+ dump_opt
Michael137 wrote:
> Fixed in
> [284d4e0](https://github.com/llvm/llvm-project/commit/284d4e0a7a789848b7af7f85158ccf522d70c6f0).
> FWIW, I did not get any emails for that breakage.
Thanks! Yea IIRC email notifications for green dragon are disabled at the
moment (@JDevlieghere @adrian-prantl an
Michael137 wrote:
Apologies for the late ping but looks like this is breaking macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/16280/execution/node/97/log/?consoleFull
```
==
FAIL: test_shadowed_stat
@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
ConstString name = query.GetTypeBasename();
std::vector query_context =
query.GetContextRef();
- if (query_context.size() <= 1)
+ if (query_context.size() <= 1 && !query.GetExactMatch())
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName(
llvm::StringRef field_name = field->getName();
if (field_name.empty()) {
CompilerType field_type = GetType(field->getType());
+std::vector save_indices = c
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-12-03T11:04:04Z
New Revision: 9a4c5a59d4ec0c582f56b221a64889c077f68376
URL:
https://github.com/llvm/llvm-project/commit/9a4c5a59d4ec0c582f56b221a64889c077f68376
DIFF:
https://github.com/llvm/llvm-project/commit/9a4c5a59d4ec0c582f56b221a64889c077f68376.diff
LOG:
https://github.com/Michael137 approved this pull request.
LGTM, thanks for fixing!
https://github.com/llvm/llvm-project/pull/118465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
ConstString name = query.GetTypeBasename();
std::vector query_context =
query.GetContextRef();
- if (query_context.size() <= 1)
+ if (query_context.size() <= 1 && !query.GetExactMatch())
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,19 @@
+struct A {
+ struct {
+int x = 1;
+ };
+ int y = 2;
Michael137 wrote:
Is `y` necessary for the reproducer?
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-co
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,19 @@
+struct A {
+ struct {
+int x = 1;
+ };
+ int y = 2;
+} a;
+
+struct B {
+ // Anonymous struct inherits another struct.
+ struct : public A {
+int z = 3;
+ };
+ int w = 4;
Michael137 wrote:
Are `w` and `a` necessary for the reprodu
https://github.com/Michael137 approved this pull request.
LGTM, happy to postpone clean up this function in a separate PR.
Left some comments on the test
https://github.com/llvm/llvm-project/pull/117808
___
lldb-commits mailing list
lldb-commits@lists
Michael137 wrote:
> So, is this patch worth pursuing or is it too much code for a too specific
> use case?
Sorry I was out for a few weeks when you pinged. I'll have another pass/think
about it early next week (if nobody else gets to it before me).
https://github.com/llvm/llvm-project/pull/11
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/121033
This was never set to anything other than `true`.
>From e635c466deb3ed6423582049b5352a687ca017cb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 24 Dec 2024 06:57:46 +
Subject: [PATCH] [lldb][DWAR
Michael137 wrote:
> @Michael137 Do you know if there is any way I could manually trigger the
> lldb-aarch64-ubuntu and the MacOS CI before merging this, to get CI feedback
> before merging this?
>
> Also, from what I can tell, all test failures in Buildkite seem to be due to
> Bolt and unrela
Michael137 wrote:
Feels a bit silly that we ran all LLVM/Clang/etc. tests just because you
amended the LLVM release notes
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
Michael137 wrote:
> > There's currently no way to trigger the macOS CI unfortunately.
>
> Is a manual trigger possible for the `lldb-aarch64-ubuntu` build? Or is it
> same as for the macOS CI?
Not sure tbh. You can re-run failed runs, but not sure if you can trigger
specific test-suites to ru
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125203
I tried using `CompleteEnumType` to replace some duplicated code in
`DWARFASTParserClang::ParseEnum` but tests started failing.
`CompleteEnumType` parse/attach the child enumerators using the signedness it
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125203
>From 620f30f73930a1a8b2edb298f67d555ff3b93e2c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 31 Jan 2025 11:18:28 +
Subject: [PATCH 1/3] [lldb][TypeSystemClang] Fix enum signedness in
CompleteEn
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8541,12 +8541,10 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
clang::EnumConstantDecl *TypeSystemClang::AddEnumerationValueToEnumerationType(
const CompilerType &enum_type, const Declaration &decl, const char *name,
-int64_t e
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125244
The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of the
enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an `APSInt`
from it.
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-01-31T12:38:07Z
New Revision: 8bd728180cadbab9fe11cd853670e488827ee302
URL:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302
DIFF:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302.diff
LOG:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126053
Setting a breakpoint on ` + ` used to work until
`2c76e88e9eb284d17cf409851fb01f1d583bb22a`, where this regex was reworked. Now
we only accept `+ `.
This patch fixes the regression by adding yet another `[[
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/126053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Btw, there are now two tests in the LLDB test-suite called
`TestSBCommandReturnObject.py`:
```
./lldb/test/API/api/command-return-object/TestSBCommandReturnObject.py
./lldb/test/API/python_api/commandreturnobject/TestSBCommandReturnObject.py
```
which `lldb-dotest` complains ab
@@ -2367,11 +2370,27 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
Michael137 wrote:
> @Michael137 Changed the first argument of `computeEnumBits` to an `ArrayRef`
> to avoid the template and so it can be still seamlessly used from Sema. On
> LLDB side, I had to create a `SmallVector` and put enum constants there at
> the point of their creation (`AddEnumerat
Michael137 wrote:
Actually, @mizvekov, can we make
`ClassTemplatePartialSpecializationDecl(ASTContext&)` default initialize the
`StrictPackMatch` member to false? In that case users of `CreateDeserialized`
wouldn't need to worry about it being potentially uninitialized? Otherwise
we'll have t
Michael137 wrote:
> > Actually, @mizvekov, can we make the
> > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > &C, Kind DK)` constructor default initialize the `StrictPackMatch` member
> > to false? In that case users of `CreateDeserialized` wouldn't need to wo
Author: Michael Buch
Date: 2025-02-06T19:12:26Z
New Revision: c4d75b1e9b9c22577032ba68b7560481027b4b8a
URL:
https://github.com/llvm/llvm-project/commit/c4d75b1e9b9c22577032ba68b7560481027b4b8a
DIFF:
https://github.com/llvm/llvm-project/commit/c4d75b1e9b9c22577032ba68b7560481027b4b8a.diff
LOG:
@@ -3205,6 +3199,8 @@ void DWARFASTParserClang::ParseChildParameters(
break;
}
}
+
+ assert(function_param_names.size() == function_param_names.size());
Michael137 wrote:
hah good catch! yea that's meant to say:
```
assert(function_param_types.siz
Michael137 wrote:
> > > > Actually, @mizvekov, can we make the
> > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch`
> > > > member to false? In that case users of `CreateDeserialized` wou
@@ -280,7 +280,8 @@ std::optional
CxxModuleHandler::tryInstantiateStdTemplate(Decl *d) {
new_class_template->getDeclContext(),
new_class_template->getTemplatedDecl()->getLocation(),
new_class_template->getLocation(), new_class_template, imported_args,
-
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-02-07T09:30:27Z
New Revision: 7aeae7379d430404499f2929ffeea9416575a091
URL:
https://github.com/llvm/llvm-project/commit/7aeae7379d430404499f2929ffeea9416575a091
DIFF:
https://github.com/llvm/llvm-project/commit/7aeae7379d430404499f2929ffeea9416575a091.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126221
This patch consumes the `DW_AT_APPLE_enum_kind` attribute added in
https://github.com/llvm/llvm-project/pull/124752 and turns it into a Clang
attribute in the AST. This will currently be used by the Swift la
Michael137 wrote:
Put up https://github.com/llvm/llvm-project/pull/126215
Should address the failure @hokein observed
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126215
This addresses the MSAN failure reported
in https://github.com/llvm/llvm-project/pull/125791#issuecomment-2639183154:
```
==5633==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 in
clang::ASTNodeI
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126053
>From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 6 Feb 2025 11:44:50 +
Subject: [PATCH 1/2] [lldb][Breakpoint] Allow whitespace in breakpoint address
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126053
>From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 6 Feb 2025 11:44:50 +
Subject: [PATCH 1/3] [lldb][Breakpoint] Allow whitespace in breakpoint address
@@ -0,0 +1,3 @@
+# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out
+# RUN: %lldb -b -o 'breakpoint set -a "main +26"' %t.out | FileCheck %s
--check-prefix CHECK
Michael137 wrote:
Done, will put them all in one lldb invocation
https://github.com/llvm/llv
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126053
>From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 6 Feb 2025 11:44:50 +
Subject: [PATCH 1/4] [lldb][Breakpoint] Allow whitespace in breakpoint address
Michael137 wrote:
We now have three APIs to query template parameters:
`GetTemplateParameterType`/`GetTemplateParameterKind`/`GetTemplateParameterValue`.
Perhaps we could just represent a template parameter as an `SBValue` instead?
And return that via a `SBType::GetTemplateParameter`. Then the
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
Michael137 wrote:
These were only necessary to get access to `SBTarget::GetSP`
https://github.com/llvm/llv
@@ -446,6 +446,7 @@ class LLDB_API SBValue {
friend class SBModule;
friend class SBTarget;
friend class SBThread;
+ friend class SBType;
Michael137 wrote:
This was necessary to get access to the SBValue constructor
https://github.com/llvm/llvm-project/
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126901
This patch adds a new API to `SBType` to retrieve the value of a template
parameter given an index. We re-use the
`TypeSystemClang::GetIntegralTemplateArgument` for this and thus currently only
supports inte
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/2] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/5] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/126902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/3] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
Michael137 wrote:
> > Perhaps we could just represent a template parameter as an SBValue instead?
>
> I'm not sure I understand. Do you mean, even for type template template
> parameters? How would that work? By creating an empty value of the given
> type? And how would we pass the "kind" of t
@@ -687,6 +687,39 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+lldb::SBValue SBType::GetTemplateArgumentValue(lldb::SBTarget target,
+ uint32_t idx) {
+ LLDB
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
Michael137 wrote:
Ah fair enough, reverted that for now
https://github.com/llvm/llvm-project/pull/126901
_
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/3] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
Author: Michael Buch
Date: 2025-01-30T15:09:53Z
New Revision: 38cb69373eef033c219efc7aaa11b84d9b307e69
URL:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69
DIFF:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125053
>From 310d7d6362a2f36503a9d8f94713fdb16c3bf65c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 30 Jan 2025 12:04:59 +
Subject: [PATCH 1/3] [lldb][test] Add test for detecting CV-quals of explicit
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125053
>From 310d7d6362a2f36503a9d8f94713fdb16c3bf65c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 30 Jan 2025 12:04:59 +
Subject: [PATCH 1/2] [lldb][test] Add test for detecting CV-quals of explicit
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125053
This is XFAILed for now until we find a good way to locate the
DW_AT_object_pointer of function declarations (a possible solution being
https://github.com/llvm/llvm-project/pull/124790).
Made it a shell tes
@@ -0,0 +1,22 @@
+// XFAIL: *
+
+// Tests that we correctly deduce the CV-quals and storage
+// class of explicit object member functions.
+//
+// RUN: %clangxx_host %s -g -std=c++23 -c -o %t
+// RUN: %lldb %t -b -o "type lookup Foo" 2>&1 | FileCheck %s
+//
+// CHECK: (lldb)
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125203
>From 620f30f73930a1a8b2edb298f67d555ff3b93e2c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 31 Jan 2025 11:18:28 +
Subject: [PATCH 1/4] [lldb][TypeSystemClang] Fix enum signedness in
CompleteEn
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
I do th
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
@@ -0,0 +1,37 @@
+"""
+Test LLDB type promotion of unscoped enums.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestCPPEnumPromotion(TestBase):
+@skipIf(debug_info=no_match([
1501 - 1600 of 2354 matches
Mail list logo
