Michael137 wrote:

> > Actually, @mizvekov, can we make the 
> > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> >  &C, Kind DK)` constructor default initialize the `StrictPackMatch` member 
> > to false? In that case users of `CreateDeserialized` wouldn't need to worry 
> > about it being potentially uninitialized? Otherwise we'll have to expose a 
> > setter and call it from LLDB
> 
> On the ASTReader, we don't need a setter because it's friends with the class.
> 
> I'd worry a little bit about leaving it always set to a fixed value, this 
> could be a hard to track bug in the future for the lldb folks, even if it's 
> probably not observable right now.

Yea that's fair. Would you prefer us adding a setter for it then? And set it to 
a fixed value from LLDB (until we have a better way to deal with it)?

https://github.com/llvm/llvm-project/pull/125791
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to