https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH] [lldb][DWARFASTParserClang] Fetch constant value from
variable
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Fetch constant value from
varia
Michael137 wrote:
@clayborg what are your thoughts on this? This could be a way to continue
supporting static inline members in the expression evaluator without having the
constant on the declaration DIE.
https://github.com/llvm/llvm-project/pull/71004
_
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/3] [lldb][DWARFASTParserClang] Fetch constant value from
varia
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/4] [lldb][DWARFASTParserClang] Fetch constant value from
varia
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/5] [lldb][DWARFASTParserClang] Fetch constant value from
varia
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/6] [lldb][DWARFASTParserClang] Fetch constant value from
varia
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/7] [lldb][DWARFASTParserClang] Fetch constant value from
varia
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70639
>From 81bd54091451eb2021007bc10b8a7c6965178800 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 27 Oct 2023 16:19:47 +0100
Subject: [PATCH 1/8] [clang][DebugInfo] Emit global variable definitions for
st
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70639
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/70641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71372
This fails on the matrix build bot for Clang versions < 9.0
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/7309/execution/node/102/log/?consoleFull
```
FAIL: LLDB :: test_vtable (TestVTableV
Michael137 wrote:
Looks like this caused a build test failure on linux for
`lang/cpp/symbols/TestSymbols.test_dwo`:
```
make
VPATH=/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/lang/cpp/symbols
-C
/home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/lang/cpp
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71378
This reverts commit 934c573b7d24327fafea916a1d0e9a9fc88f87ab.
We had to revert dependencies of this patch due to test failures on Linux:
```
4909814c08fdf4ec8bd9dad4f157d03de7c3c800
ef3febadf606c2fc4f1ad8d85a7
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-06T10:55:27Z
New Revision: 947a32aed8eba20022a2bf4b1678937310de019f
URL:
https://github.com/llvm/llvm-project/commit/947a32aed8eba20022a2bf4b1678937310de019f
DIFF:
https://github.com/llvm/llvm-project/commit/947a32aed8eba20022a2bf4b1678937310de019f.diff
LOG:
Author: Michael Buch
Date: 2023-11-06T10:56:49Z
New Revision: 5f86b49146902a37ea93470b5992206b20665128
URL:
https://github.com/llvm/llvm-project/commit/5f86b49146902a37ea93470b5992206b20665128
DIFF:
https://github.com/llvm/llvm-project/commit/5f86b49146902a37ea93470b5992206b20665128.diff
LOG:
Author: Michael Buch
Date: 2023-11-06T10:58:02Z
New Revision: 333124cfd6dfa413294e80f9be75460b9a9314f9
URL:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9
DIFF:
https://github.com/llvm/llvm-project/commit/333124cfd6dfa413294e80f9be75460b9a9314f9.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71372
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-07T04:53:54Z
New Revision: 7c3707aea8a6f1fc245ad2862982b8a51b6c0fea
URL:
https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea
DIFF:
https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea.diff
LOG:
Author: Michael Buch
Date: 2023-11-07T04:54:01Z
New Revision: 470de2bbec7f5fdd199775aa99c68ac76f4d5c74
URL:
https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74
DIFF:
https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74.diff
LOG:
Author: Michael Buch
Date: 2023-11-07T04:54:04Z
New Revision: 15fc809404d4715822e5349b76dcca50eb100eec
URL:
https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec
DIFF:
https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec.diff
LOG:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71486
This is a newly added test which XPASSes on Linux
>From acf1ba6c54bc897cf572a01bb0caeeff207f76dc Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 7 Nov 2023 05:10:44 +
Subject: [PATCH] [lldb][test]
Author: Michael Buch
Date: 2023-11-07T05:18:23Z
New Revision: d08d9cf55629a300a54ab1660912b044145540f1
URL:
https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1
DIFF:
https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -771,6 +771,10 @@ TypeSystemClang
*TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
return clang_ast;
}
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+ return Name.starts_with("_vptr$");
Michael137 wrote:
On GCC I s
@@ -3059,9 +3059,8 @@ void DWARFASTParserClang::ParseSingleMember(
// This needs to be done after updating FieldInfo which keeps track of where
// field start/end so we don't later try to fill the space of this
// artificial member with (unnamed bitfield) padding.
- // F
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71559
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> This causes Clang to assert:
>
> ```
> llvm/lib/IR/Metadata.cpp:689:
> void llvm::MDNode::resolve(): Assertion `isUniqued() && "Expected this
> to be uniqued"' failed.
> ```
>
> See https://bugs.chromium.org/p/chromium/issues/detail?id=1500262#c1 for a
> reprod
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71780
This patch relands https://github.com/llvm/llvm-project/pull/70639
It was reverted because under certain conditions we triggered an assertion
in `DIBuilder`. Specifically, in the original patch we called
`Emi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/2] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71800
This patch relands https://github.com/llvm/llvm-project/pull/71004 which was
reverted because the clang change it depends on was reverted.
In addition to the original patch, this PR includes a change to
`Sym
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71800
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -771,6 +771,10 @@ TypeSystemClang
*TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
return clang_ast;
}
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+ return Name.starts_with("_vptr$");
Michael137 wrote:
`TypeSyste
@@ -771,6 +771,10 @@ TypeSystemClang
*TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
return clang_ast;
}
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+ return Name.starts_with("_vptr$");
Michael137 wrote:
Are you st
@@ -0,0 +1,17 @@
+# UNSUPPORTED: system-darwin, system-windows
Michael137 wrote:
Why unsupported on Darwin? Pretty sure it should just work
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
@@ -0,0 +1,17 @@
+# UNSUPPORTED: system-darwin, system-windows
Michael137 wrote:
I think we can just remove these and if the test does end up failing we'll just
add the requirements back after the fact.
https://github.com/llvm/llvm-project/pull/70779
__
@@ -0,0 +1,17 @@
+# UNSUPPORTED: system-darwin, system-windows
Michael137 wrote:
Oh you're using gcc for this. Nvm
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
https://github.com/Michael137 approved this pull request.
LGTM
Are you still going to make the change to `CommandObjectFrame` such that `frame
var` doesn't hide the artificial fields?
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits m
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/3] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/4] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71800
>From d3e0391685605491383114f82d906c811f899b5d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 6 Nov 2023 11:34:09 +
Subject: [PATCH 1/2] Reland "[lldb][DWARFASTParserClang] Fetch constant value
fr
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
+ // of byt
@@ -2210,9 +2216,16 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
!layout_info.vbase_offsets.empty()) {
if (type)
layout_info.bit_size = type->GetByteSize(nullptr).value_or(0) * 8;
-if (layout_info.bit_size == 0)
- layout_info.bi
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
+ // of byt
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71921
This patch removes the Objective-C accessibility workaround added in
https://github.com/llvm/llvm-project/commit/5a477cfd90a8a12510518973fa450ae67372f199
(rdar://8492646). This allows us to make the local `Me
Michael137 wrote:
> Is there a way to run the tests under `lldb/test/API/` directory? `ninja
> check-lldb` doesn't seem to run these tests on my linux machine.
>
> ```
> ./bin/llvm-lit -sv
> /lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/
>
>
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
Michael
@@ -5596,6 +5587,42 @@ void CGDebugInfo::EmitGlobalVariable(const ValueDecl
*VD, const APValue &Init) {
TemplateParameters, Align));
}
+void CGDebugInfo::EmitGlobalVariable(const VarDecl *VD) {
+ assert(VD->hasInit());
+ assert(CGM.getCodeGenOpts().hasReducedDebugInfo
@@ -5800,6 +5827,18 @@ void CGDebugInfo::setDwoId(uint64_t Signature) {
}
void CGDebugInfo::finalize() {
+ for (auto const *VD : StaticDataMemberDefinitionsToEmit) {
+assert(VD->isStaticDataMember());
+
+if (DeclCache.contains(VD))
+ continue;
+
+if (!VD->has
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/4] Reland "[clang][DebugInfo] Emit global variable
definitions
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/5] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/6] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71800
>From 21567b31b5f11c7ed17fc49139e58cef570c4dac Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 6 Nov 2023 11:34:09 +
Subject: [PATCH 1/2] Reland "[lldb][DWARFASTParserClang] Fetch constant value
fr
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71800
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-13T06:14:23Z
New Revision: 9d587480dce30ff2c00dfba3dfdb2812d68ea9e9
URL:
https://github.com/llvm/llvm-project/commit/9d587480dce30ff2c00dfba3dfdb2812d68ea9e9
DIFF:
https://github.com/llvm/llvm-project/commit/9d587480dce30ff2c00dfba3dfdb2812d68ea9e9.diff
LOG:
Author: Michael Buch
Date: 2023-11-13T06:16:32Z
New Revision: c501bf4334d6cbe3fc3160ea6b9e91459e66cbe1
URL:
https://github.com/llvm/llvm-project/commit/c501bf4334d6cbe3fc3160ea6b9e91459e66cbe1
DIFF:
https://github.com/llvm/llvm-project/commit/c501bf4334d6cbe3fc3160ea6b9e91459e66cbe1.diff
LOG:
Author: Michael Buch
Date: 2023-11-13T06:38:57Z
New Revision: f86770aa073ac9c17d9ccb6409254e879dca2de6
URL:
https://github.com/llvm/llvm-project/commit/f86770aa073ac9c17d9ccb6409254e879dca2de6
DIFF:
https://github.com/llvm/llvm-project/commit/f86770aa073ac9c17d9ccb6409254e879dca2de6.diff
LOG:
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72109
This patch extracts the logic to create a static variable member decl into a
helper. We will use this in an upcoming patch which will need to call exactly
the same logic from a separate part of the DWARF pars
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/72109
>From 3513963ac45aff2296f687e6c7b315e0f25b8586 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 7 Nov 2023 10:57:08 +
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang][NFC] Extract static data
member
https://github.com/Michael137 approved this pull request.
LGTM (once bots are happy)
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72236
The accepted DWARFv5 issue 161118.1: "DW_TAG for C++ static data members"
specifies that static data member declaration be described by DW_TAG_variable.
Make sure we recognize such members.
>From de2be505917
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-14T10:31:07Z
New Revision: 27c5a9bbb01a464bb85624db2d0808f30de7c996
URL:
https://github.com/llvm/llvm-project/commit/27c5a9bbb01a464bb85624db2d0808f30de7c996
DIFF:
https://github.com/llvm/llvm-project/commit/27c5a9bbb01a464bb85624db2d0808f30de7c996.diff
LOG:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/72236
>From de2be505917256a03718a10928547730d03bc8bc Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 Nov 2023 08:13:08 +
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] DWARFv5: support
DW_TAG_variab
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> We're seeing crashes after this. Here is a reproducer:
> https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1
>
> Please consider reverting if it can't be fixed quickly (I had a look, but it
> seems there are some dependent changes on top).
Thanks for reporting
Michael137 wrote:
> > We're seeing crashes after this. Here is a reproducer:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1
> > Please consider reverting if it can't be fixed quickly (I had a look, but
> > it seems there are some dependent changes on top).
>
> Thanks for
Michael137 wrote:
Ok with ASAN I could trigger this quite consistently. Turns out we can't
iterate over the `StaticDataMemberDefinitionsToEmit` using a `for each` because
during `EmitGlobalVariable` we can end up adding more things to the vector,
invalidating the iterators. Will push a fix for
Michael137 wrote:
@zmodem Fix pushed in `14a84510f5d07b05b348188c7dfbe54076fa1485`. Your
reproducer works fine for me now. Let me know if you're still seeing issues.
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-co
Michael137 wrote:
> Hi @Michael137, we are seeing a failure in one of our internal tests that I
> bisected back to this change. Consider the following code:
>
> ```c++
> struct X
> {
> static const int constant = 1;
> int x;
>
> X() { x = constant; }
> };
> const int X::constant;
>
Michael137 wrote:
> The member is const with an initializer in-class. How is the constant value
> not available for the definition?
Right, it is available, we just don't attach it if we have a location for it.
Don't see why we couldn't put it on the definition if we have the constant on
hand
Michael137 wrote:
> So I guess what you are saying in this case is that it is expected and the
> value is at the location indicated by the DW_AT_location value? As long as
> the value is still available I suppose that is fine then and the test just
> needs updating.
Yup that's exactly right.
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72495
None
>From cf66beffe36e53fed5740775fa50b767a62f2c50 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 16 Nov 2023 08:46:37 +
Subject: [PATCH] [lldb][DWARFASTParserClang][NFC] Clarify comment around
@@ -2965,6 +2965,7 @@ void DWARFASTParserClang::ParseSingleMember(
// data members is DW_AT_declaration, so we check it instead.
// FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we
// can consistently detect them on both GCC and Clang without belo
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72495
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> Hi, we're seeing some breakages, similar to the above in our debugger tests
> with this patch.
>
> A failing bot can be found here:
> https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-debug/b8764552260903625809/overview
>
> You can find a f
Michael137 wrote:
> Fantastic!
@ilovepi To clarify the upcoming change, we are planning to attach the
`DW_AT_const_value` to the definition, not the declaration like we used to. In
case that's what your unit-test is expecting
https://github.com/llvm/llvm-project/pull/71780
___
Author: Michael Buch
Date: 2022-08-25T08:49:13+01:00
New Revision: 9427487fdbb24df148caba7f9b2f87146e5b40ec
URL:
https://github.com/llvm/llvm-project/commit/9427487fdbb24df148caba7f9b2f87146e5b40ec
DIFF:
https://github.com/llvm/llvm-project/commit/9427487fdbb24df148caba7f9b2f87146e5b40ec.diff
Author: Michael Buch
Date: 2022-08-26T10:06:38+01:00
New Revision: 2b95b50dd69b03be793357cbadae70d413b375a5
URL:
https://github.com/llvm/llvm-project/commit/2b95b50dd69b03be793357cbadae70d413b375a5
DIFF:
https://github.com/llvm/llvm-project/commit/2b95b50dd69b03be793357cbadae70d413b375a5.diff
Author: Michael Buch
Date: 2022-08-26T10:28:28+01:00
New Revision: 5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1
URL:
https://github.com/llvm/llvm-project/commit/5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1
DIFF:
https://github.com/llvm/llvm-project/commit/5955edf8a453b4b8ff7d5dfff2db3adc27a36bc1.diff
Author: Michael Buch
Date: 2022-09-14T14:45:35-04:00
New Revision: 3b44c9af8efd95aba7b4f351e5175ebf02e7b396
URL:
https://github.com/llvm/llvm-project/commit/3b44c9af8efd95aba7b4f351e5175ebf02e7b396
DIFF:
https://github.com/llvm/llvm-project/commit/3b44c9af8efd95aba7b4f351e5175ebf02e7b396.diff
1101 - 1200 of 2354 matches
Mail list logo
